[jira] [Commented] (HBASE-6537) Balancer compete with disable table will lead to cluster inconsistent
[ https://issues.apache.org/jira/browse/HBASE-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13445536#comment-13445536 ] Lars Hofhansl commented on HBASE-6537: -- HadoopQA can only run against trunk. So if you want a HadoopQA run you need a trunk patch. But since this issue does not occur in trunk (as you say) we only really need the 0.94 patch. Balancer compete with disable table will lead to cluster inconsistent -- Key: HBASE-6537 URL: https://issues.apache.org/jira/browse/HBASE-6537 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.94.0 Reporter: Zhou wenjian Assignee: Zhou wenjian Fix For: 0.94.2 Attachments: HBASE-6537-trunk.patch, HBASE-6537-trunk-v2.patch Appear in 94. trunk is ok for the issue Balancer will collect the regionplans to move(unassign and then assign). before unassign, disable table appears, after close the region in rs, master will delete the znode, romove region from RIT, and then clean the region from the online regions. During romoving region from RIT and cleaning out the region from the online regions. balancer begins to unassign, it will get a NotServingRegionException and if the table is disabling, it will deal with the state in master and delete the znode . However the table is disabled now, so the RIT and znode will remain. TimeoutMonitor draws a blank on it. It will hold back enabling the table or balancer unless restart -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6537) Balancer compete with disable table will lead to cluster inconsistent
[ https://issues.apache.org/jira/browse/HBASE-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13445538#comment-13445538 ] Lars Hofhansl commented on HBASE-6537: -- I'm happy to make a 0.94 patch. But just to be doubly sure, we only want this in 0.94, right? Balancer compete with disable table will lead to cluster inconsistent -- Key: HBASE-6537 URL: https://issues.apache.org/jira/browse/HBASE-6537 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.94.0 Reporter: Zhou wenjian Assignee: Zhou wenjian Fix For: 0.94.2 Attachments: HBASE-6537-trunk.patch, HBASE-6537-trunk-v2.patch Appear in 94. trunk is ok for the issue Balancer will collect the regionplans to move(unassign and then assign). before unassign, disable table appears, after close the region in rs, master will delete the znode, romove region from RIT, and then clean the region from the online regions. During romoving region from RIT and cleaning out the region from the online regions. balancer begins to unassign, it will get a NotServingRegionException and if the table is disabling, it will deal with the state in master and delete the znode . However the table is disabled now, so the RIT and znode will remain. TimeoutMonitor draws a blank on it. It will hold back enabling the table or balancer unless restart -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6537) Balancer compete with disable table will lead to cluster inconsistent
[ https://issues.apache.org/jira/browse/HBASE-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13445545#comment-13445545 ] Lars Hofhansl commented on HBASE-6537: -- Hmm... There was no RegionStates in 0.94. (added in the ginormous HBASE-6272 patch) Balancer compete with disable table will lead to cluster inconsistent -- Key: HBASE-6537 URL: https://issues.apache.org/jira/browse/HBASE-6537 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.94.0 Reporter: Zhou wenjian Assignee: Zhou wenjian Fix For: 0.94.2 Attachments: HBASE-6537-trunk.patch, HBASE-6537-trunk-v2.patch Appear in 94. trunk is ok for the issue Balancer will collect the regionplans to move(unassign and then assign). before unassign, disable table appears, after close the region in rs, master will delete the znode, romove region from RIT, and then clean the region from the online regions. During romoving region from RIT and cleaning out the region from the online regions. balancer begins to unassign, it will get a NotServingRegionException and if the table is disabling, it will deal with the state in master and delete the znode . However the table is disabled now, so the RIT and znode will remain. TimeoutMonitor draws a blank on it. It will hold back enabling the table or balancer unless restart -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6537) Balancer compete with disable table will lead to cluster inconsistent
[ https://issues.apache.org/jira/browse/HBASE-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13445591#comment-13445591 ] zhou wenjian commented on HBASE-6537: - @Lars,thanks for reply. update patch for 94 Balancer compete with disable table will lead to cluster inconsistent -- Key: HBASE-6537 URL: https://issues.apache.org/jira/browse/HBASE-6537 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.94.0 Reporter: Zhou wenjian Assignee: Zhou wenjian Fix For: 0.94.2 Attachments: HBASE-6537-94-v2.patch, HBASE-6537-trunk.patch, HBASE-6537-trunk-v2.patch Appear in 94. trunk is ok for the issue Balancer will collect the regionplans to move(unassign and then assign). before unassign, disable table appears, after close the region in rs, master will delete the znode, romove region from RIT, and then clean the region from the online regions. During romoving region from RIT and cleaning out the region from the online regions. balancer begins to unassign, it will get a NotServingRegionException and if the table is disabling, it will deal with the state in master and delete the znode . However the table is disabled now, so the RIT and znode will remain. TimeoutMonitor draws a blank on it. It will hold back enabling the table or balancer unless restart -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6537) Balancer compete with disable table will lead to cluster inconsistent
[ https://issues.apache.org/jira/browse/HBASE-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13445592#comment-13445592 ] Hadoop QA commented on HBASE-6537: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12543222/HBASE-6537-94-v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2746//console This message is automatically generated. Balancer compete with disable table will lead to cluster inconsistent -- Key: HBASE-6537 URL: https://issues.apache.org/jira/browse/HBASE-6537 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.94.0 Reporter: Zhou wenjian Assignee: Zhou wenjian Fix For: 0.94.2 Attachments: HBASE-6537-94-v2.patch, HBASE-6537-trunk.patch, HBASE-6537-trunk-v2.patch Appear in 94. trunk is ok for the issue Balancer will collect the regionplans to move(unassign and then assign). before unassign, disable table appears, after close the region in rs, master will delete the znode, romove region from RIT, and then clean the region from the online regions. During romoving region from RIT and cleaning out the region from the online regions. balancer begins to unassign, it will get a NotServingRegionException and if the table is disabling, it will deal with the state in master and delete the znode . However the table is disabled now, so the RIT and znode will remain. TimeoutMonitor draws a blank on it. It will hold back enabling the table or balancer unless restart -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6537) Balancer compete with disable table will lead to cluster inconsistent
[ https://issues.apache.org/jira/browse/HBASE-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442254#comment-13442254 ] Zhou wenjian commented on HBASE-6537: - @Lars rajeshbabu. i found it unavailable to run hudson, i do not know why, so i just delete the 94 attach. I'll resubmit it if nesscery Balancer compete with disable table will lead to cluster inconsistent -- Key: HBASE-6537 URL: https://issues.apache.org/jira/browse/HBASE-6537 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.94.0 Reporter: Zhou wenjian Assignee: Zhou wenjian Fix For: 0.94.2 Attachments: HBASE-6537-trunk.patch, HBASE-6537-trunk-v2.patch Appear in 94. trunk is ok for the issue Balancer will collect the regionplans to move(unassign and then assign). before unassign, disable table appears, after close the region in rs, master will delete the znode, romove region from RIT, and then clean the region from the online regions. During romoving region from RIT and cleaning out the region from the online regions. balancer begins to unassign, it will get a NotServingRegionException and if the table is disabling, it will deal with the state in master and delete the znode . However the table is disabled now, so the RIT and znode will remain. TimeoutMonitor draws a blank on it. It will hold back enabling the table or balancer unless restart -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6537) Balancer compete with disable table will lead to cluster inconsistent
[ https://issues.apache.org/jira/browse/HBASE-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13437639#comment-13437639 ] Hadoop QA commented on HBASE-6537: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12540261/HBASE-6537-94-v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2624//console This message is automatically generated. Balancer compete with disable table will lead to cluster inconsistent -- Key: HBASE-6537 URL: https://issues.apache.org/jira/browse/HBASE-6537 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.94.0 Reporter: Zhou wenjian Fix For: 0.94.2 Attachments: HBASE-6537-94.patch, HBASE-6537-94-v2.patch, HBASE-6537-trunk.patch Appear in 94. trunk is ok for the issue Balancer will collect the regionplans to move(unassign and then assign). before unassign, disable table appears, after close the region in rs, master will delete the znode, romove region from RIT, and then clean the region from the online regions. During romoving region from RIT and cleaning out the region from the online regions. balancer begins to unassign, it will get a NotServingRegionException and if the table is disabling, it will deal with the state in master and delete the znode . However the table is disabled now, so the RIT and znode will remain. TimeoutMonitor draws a blank on it. It will hold back enabling the table or balancer unless restart -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6537) Balancer compete with disable table will lead to cluster inconsistent
[ https://issues.apache.org/jira/browse/HBASE-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13435765#comment-13435765 ] ramkrishna.s.vasudevan commented on HBASE-6537: --- @Zhou I think only the check for Disabling should be enough right? do you think change in regionOffline is needed? Thanks Zhou. Balancer compete with disable table will lead to cluster inconsistent -- Key: HBASE-6537 URL: https://issues.apache.org/jira/browse/HBASE-6537 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.94.0 Reporter: Zhou wenjian Fix For: 0.94.2 Attachments: HBASE-6537-94.patch, HBASE-6537-94-v2.patch, HBASE-6537-trunk.patch Appear in 94. trunk is ok for the issue Balancer will collect the regionplans to move(unassign and then assign). before unassign, disable table appears, after close the region in rs, master will delete the znode, romove region from RIT, and then clean the region from the online regions. During romoving region from RIT and cleaning out the region from the online regions. balancer begins to unassign, it will get a NotServingRegionException and if the table is disabling, it will deal with the state in master and delete the znode . However the table is disabled now, so the RIT and znode will remain. TimeoutMonitor draws a blank on it. It will hold back enabling the table or balancer unless restart -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6537) Balancer compete with disable table will lead to cluster inconsistent
[ https://issues.apache.org/jira/browse/HBASE-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13435771#comment-13435771 ] Zhou wenjian commented on HBASE-6537: - @ramkrishna.s.vasudevan We can shutdown the window between RIT and regions with the change, lots of problems may be caused by it. Since truck has made the function synchronized, the change in regionOffline does no harm. Balancer compete with disable table will lead to cluster inconsistent -- Key: HBASE-6537 URL: https://issues.apache.org/jira/browse/HBASE-6537 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.94.0 Reporter: Zhou wenjian Fix For: 0.94.2 Attachments: HBASE-6537-94.patch, HBASE-6537-94-v2.patch, HBASE-6537-trunk.patch Appear in 94. trunk is ok for the issue Balancer will collect the regionplans to move(unassign and then assign). before unassign, disable table appears, after close the region in rs, master will delete the znode, romove region from RIT, and then clean the region from the online regions. During romoving region from RIT and cleaning out the region from the online regions. balancer begins to unassign, it will get a NotServingRegionException and if the table is disabling, it will deal with the state in master and delete the znode . However the table is disabled now, so the RIT and znode will remain. TimeoutMonitor draws a blank on it. It will hold back enabling the table or balancer unless restart -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6537) Balancer compete with disable table will lead to cluster inconsistent
[ https://issues.apache.org/jira/browse/HBASE-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13432921#comment-13432921 ] Zhou wenjian commented on HBASE-6537: - @Ted we have no trunk hudson, just 94 in local Balancer compete with disable table will lead to cluster inconsistent -- Key: HBASE-6537 URL: https://issues.apache.org/jira/browse/HBASE-6537 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.94.0 Reporter: Zhou wenjian Fix For: 0.94.2 Attachments: HBASE-6537-94.patch, HBASE-6537-94-v2.patch, HBASE-6537-trunk.patch Appear in 94. trunk is ok for the issue Balancer will collect the regionplans to move(unassign and then assign). before unassign, disable table appears, after close the region in rs, master will delete the znode, romove region from RIT, and then clean the region from the online regions. During romoving region from RIT and cleaning out the region from the online regions. balancer begins to unassign, it will get a NotServingRegionException and if the table is disabling, it will deal with the state in master and delete the znode . However the table is disabled now, so the RIT and znode will remain. TimeoutMonitor draws a blank on it. It will hold back enabling the table or balancer unless restart -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6537) Balancer compete with disable table will lead to cluster inconsistent
[ https://issues.apache.org/jira/browse/HBASE-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13432589#comment-13432589 ] Zhihong Ted Yu commented on HBASE-6537: --- @Wenjian: Can you run trunk patch through test suite and post back the results ? See INFRA-5131 for progress on solving JIRA malfunction. Balancer compete with disable table will lead to cluster inconsistent -- Key: HBASE-6537 URL: https://issues.apache.org/jira/browse/HBASE-6537 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.94.0 Reporter: Zhou wenjian Fix For: 0.94.2 Attachments: HBASE-6537-94-v2.patch, HBASE-6537-94.patch, HBASE-6537-trunk.patch Appear in 94. trunk is ok for the issue Balancer will collect the regionplans to move(unassign and then assign). before unassign, disable table appears, after close the region in rs, master will delete the znode, romove region from RIT, and then clean the region from the online regions. During romoving region from RIT and cleaning out the region from the online regions. balancer begins to unassign, it will get a NotServingRegionException and if the table is disabling, it will deal with the state in master and delete the znode . However the table is disabled now, so the RIT and znode will remain. TimeoutMonitor draws a blank on it. It will hold back enabling the table or balancer unless restart -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6537) Balancer compete with disable table will lead to cluster inconsistent
[ https://issues.apache.org/jira/browse/HBASE-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13431847#comment-13431847 ] rajeshbabu commented on HBASE-6537: --- @Zhou wenjian clearing from online regions before removing from RIT may not solve the problem completely. Its better to check whether table is in disabling and disabled also in case of NotServingRegionException. May be this is applicable for trunk also because there also we are checking table is in disabling only. Please correct me if i am wrong. Balancer compete with disable table will lead to cluster inconsistent -- Key: HBASE-6537 URL: https://issues.apache.org/jira/browse/HBASE-6537 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.94.0 Reporter: Zhou wenjian Fix For: 0.94.1 Attachments: HBASE-6537-94.patch Appear in 94. trunk is ok for the issue Balancer will collect the regionplans to move(unassign and then assign). before unassign, disable table appears, after close the region in rs, master will delete the znode, romove region from RIT, and then clean the region from the online regions. During romoving region from RIT and cleaning out the region from the online regions. balancer begins to unassign, it will get a NotServingRegionException and if the table is disabling, it will deal with the state in master and delete the znode . However the table is disabled now, so the RIT and znode will remain. TimeoutMonitor draws a blank on it. It will hold back enabling the table or balancer unless restart -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6537) Balancer compete with disable table will lead to cluster inconsistent
[ https://issues.apache.org/jira/browse/HBASE-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13432485#comment-13432485 ] Zhou wenjian commented on HBASE-6537: - @rajeshbabu thanks for your reply. agree with you, checking whether table is in disabling and disabled also in case of NotServingRegionException will prevent from the issue too. There is no problem in trunk because of it handling well in such scenario, but since we will check table state both disabling and disabled, patch for trunk is also applicable Balancer compete with disable table will lead to cluster inconsistent -- Key: HBASE-6537 URL: https://issues.apache.org/jira/browse/HBASE-6537 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.94.0 Reporter: Zhou wenjian Fix For: 0.94.2 Attachments: HBASE-6537-94.patch Appear in 94. trunk is ok for the issue Balancer will collect the regionplans to move(unassign and then assign). before unassign, disable table appears, after close the region in rs, master will delete the znode, romove region from RIT, and then clean the region from the online regions. During romoving region from RIT and cleaning out the region from the online regions. balancer begins to unassign, it will get a NotServingRegionException and if the table is disabling, it will deal with the state in master and delete the znode . However the table is disabled now, so the RIT and znode will remain. TimeoutMonitor draws a blank on it. It will hold back enabling the table or balancer unless restart -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
