[jira] [Commented] (HBASE-6820) [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()
[ https://issues.apache.org/jira/browse/HBASE-6820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867475#comment-13867475 ] Hudson commented on HBASE-6820: --- SUCCESS: Integrated in HBase-0.94 #1258 (See [https://builds.apache.org/job/HBase-0.94/1258/]) HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (chendihao) (larsh: rev 1557009) * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java > [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon > shutdown() > -- > > Key: HBASE-6820 > URL: https://issues.apache.org/jira/browse/HBASE-6820 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3, 0.95.2 >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Labels: windows > Fix For: 0.95.0 > > Attachments: hbase-6820_v1-0.94.patch, hbase-6820_v1-trunk.patch > > > MiniZookeeperCluster.shutdown() shuts down the ZookeeperServer and > NIOServerCnxnFactory. However, MiniZookeeperCluster uses a deprecated > ZookeeperServer constructor, which in turn constructs its own FileTxnSnapLog, > and ZKDatabase. Since ZookeeperServer.shutdown() does not close() the > ZKDatabase, we have to explicitly close it in MiniZookeeperCluster.shutdown(). > Tests effected by this are > {code} > TestSplitLogManager > TestSplitLogWorker > TestOfflineMetaRebuildBase > TestOfflineMetaRebuildHole > TestOfflineMetaRebuildOverlap > {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-6820) [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()
[ https://issues.apache.org/jira/browse/HBASE-6820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867470#comment-13867470 ] Hudson commented on HBASE-6820: --- FAILURE: Integrated in HBase-0.94-JDK7 #25 (See [https://builds.apache.org/job/HBase-0.94-JDK7/25/]) HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (chendihao) (larsh: rev 1557009) * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java > [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon > shutdown() > -- > > Key: HBASE-6820 > URL: https://issues.apache.org/jira/browse/HBASE-6820 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3, 0.95.2 >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Labels: windows > Fix For: 0.95.0 > > Attachments: hbase-6820_v1-0.94.patch, hbase-6820_v1-trunk.patch > > > MiniZookeeperCluster.shutdown() shuts down the ZookeeperServer and > NIOServerCnxnFactory. However, MiniZookeeperCluster uses a deprecated > ZookeeperServer constructor, which in turn constructs its own FileTxnSnapLog, > and ZKDatabase. Since ZookeeperServer.shutdown() does not close() the > ZKDatabase, we have to explicitly close it in MiniZookeeperCluster.shutdown(). > Tests effected by this are > {code} > TestSplitLogManager > TestSplitLogWorker > TestOfflineMetaRebuildBase > TestOfflineMetaRebuildHole > TestOfflineMetaRebuildOverlap > {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-6820) [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()
[ https://issues.apache.org/jira/browse/HBASE-6820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867456#comment-13867456 ] Hudson commented on HBASE-6820: --- SUCCESS: Integrated in HBase-0.94-security #386 (See [https://builds.apache.org/job/HBase-0.94-security/386/]) HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (chendihao) (larsh: rev 1557009) * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java > [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon > shutdown() > -- > > Key: HBASE-6820 > URL: https://issues.apache.org/jira/browse/HBASE-6820 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3, 0.95.2 >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Labels: windows > Fix For: 0.95.0 > > Attachments: hbase-6820_v1-0.94.patch, hbase-6820_v1-trunk.patch > > > MiniZookeeperCluster.shutdown() shuts down the ZookeeperServer and > NIOServerCnxnFactory. However, MiniZookeeperCluster uses a deprecated > ZookeeperServer constructor, which in turn constructs its own FileTxnSnapLog, > and ZKDatabase. Since ZookeeperServer.shutdown() does not close() the > ZKDatabase, we have to explicitly close it in MiniZookeeperCluster.shutdown(). > Tests effected by this are > {code} > TestSplitLogManager > TestSplitLogWorker > TestOfflineMetaRebuildBase > TestOfflineMetaRebuildHole > TestOfflineMetaRebuildOverlap > {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-6820) [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()
[ https://issues.apache.org/jira/browse/HBASE-6820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13861317#comment-13861317 ] chendihao commented on HBASE-6820: -- [~enis] [~stack] I'm working with MiniZooKeeperCluster and glad to see the patch. But I don't think it's done completely. KillCurrentActiveZooKeeperServer() and killOneBackupZooKeeperServer() will shutdown the ZooKeeperServer and need to close ZKDatabase as well. I open a new jira https://issues.apache.org/jira/browse/HBASE-10274 and it would be nice to fix it. > [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon > shutdown() > -- > > Key: HBASE-6820 > URL: https://issues.apache.org/jira/browse/HBASE-6820 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3, 0.95.2 >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Labels: windows > Fix For: 0.95.0 > > Attachments: hbase-6820_v1-0.94.patch, hbase-6820_v1-trunk.patch > > > MiniZookeeperCluster.shutdown() shuts down the ZookeeperServer and > NIOServerCnxnFactory. However, MiniZookeeperCluster uses a deprecated > ZookeeperServer constructor, which in turn constructs its own FileTxnSnapLog, > and ZKDatabase. Since ZookeeperServer.shutdown() does not close() the > ZKDatabase, we have to explicitly close it in MiniZookeeperCluster.shutdown(). > Tests effected by this are > {code} > TestSplitLogManager > TestSplitLogWorker > TestOfflineMetaRebuildBase > TestOfflineMetaRebuildHole > TestOfflineMetaRebuildOverlap > {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-6820) [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()
[ https://issues.apache.org/jira/browse/HBASE-6820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493621#comment-13493621 ] Hudson commented on HBASE-6820: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #253 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/253/]) HBASE-6820. [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (Revision 1407287) Result = FAILURE enis : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java > [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon > shutdown() > -- > > Key: HBASE-6820 > URL: https://issues.apache.org/jira/browse/HBASE-6820 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3, 0.96.0 >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Labels: windows > Fix For: 0.96.0 > > Attachments: hbase-6820_v1-0.94.patch, hbase-6820_v1-trunk.patch > > > MiniZookeeperCluster.shutdown() shuts down the ZookeeperServer and > NIOServerCnxnFactory. However, MiniZookeeperCluster uses a deprecated > ZookeeperServer constructor, which in turn constructs its own FileTxnSnapLog, > and ZKDatabase. Since ZookeeperServer.shutdown() does not close() the > ZKDatabase, we have to explicitly close it in MiniZookeeperCluster.shutdown(). > Tests effected by this are > {code} > TestSplitLogManager > TestSplitLogWorker > TestOfflineMetaRebuildBase > TestOfflineMetaRebuildHole > TestOfflineMetaRebuildOverlap > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6820) [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()
[ https://issues.apache.org/jira/browse/HBASE-6820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493604#comment-13493604 ] Hudson commented on HBASE-6820: --- Integrated in HBase-TRUNK #3522 (See [https://builds.apache.org/job/HBase-TRUNK/3522/]) HBASE-6820. [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (Revision 1407287) Result = FAILURE enis : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java > [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon > shutdown() > -- > > Key: HBASE-6820 > URL: https://issues.apache.org/jira/browse/HBASE-6820 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3, 0.96.0 >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Labels: windows > Fix For: 0.96.0 > > Attachments: hbase-6820_v1-0.94.patch, hbase-6820_v1-trunk.patch > > > MiniZookeeperCluster.shutdown() shuts down the ZookeeperServer and > NIOServerCnxnFactory. However, MiniZookeeperCluster uses a deprecated > ZookeeperServer constructor, which in turn constructs its own FileTxnSnapLog, > and ZKDatabase. Since ZookeeperServer.shutdown() does not close() the > ZKDatabase, we have to explicitly close it in MiniZookeeperCluster.shutdown(). > Tests effected by this are > {code} > TestSplitLogManager > TestSplitLogWorker > TestOfflineMetaRebuildBase > TestOfflineMetaRebuildHole > TestOfflineMetaRebuildOverlap > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6820) [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()
[ https://issues.apache.org/jira/browse/HBASE-6820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465221#comment-13465221 ] stack commented on HBASE-6820: -- agree > [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon > shutdown() > -- > > Key: HBASE-6820 > URL: https://issues.apache.org/jira/browse/HBASE-6820 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3, 0.96.0 >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Labels: windows > Attachments: hbase-6820_v1-0.94.patch, hbase-6820_v1-trunk.patch > > > MiniZookeeperCluster.shutdown() shuts down the ZookeeperServer and > NIOServerCnxnFactory. However, MiniZookeeperCluster uses a deprecated > ZookeeperServer constructor, which in turn constructs its own FileTxnSnapLog, > and ZKDatabase. Since ZookeeperServer.shutdown() does not close() the > ZKDatabase, we have to explicitly close it in MiniZookeeperCluster.shutdown(). > Tests effected by this are > {code} > TestSplitLogManager > TestSplitLogWorker > TestOfflineMetaRebuildBase > TestOfflineMetaRebuildHole > TestOfflineMetaRebuildOverlap > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6820) [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()
[ https://issues.apache.org/jira/browse/HBASE-6820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465214#comment-13465214 ] Enis Soztutar commented on HBASE-6820: -- {code} java.lang.OutOfMemoryError: unable to create new native thread {code} Test failure seems unrelated. > [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon > shutdown() > -- > > Key: HBASE-6820 > URL: https://issues.apache.org/jira/browse/HBASE-6820 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3, 0.96.0 >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Labels: windows > Attachments: hbase-6820_v1-0.94.patch, hbase-6820_v1-trunk.patch > > > MiniZookeeperCluster.shutdown() shuts down the ZookeeperServer and > NIOServerCnxnFactory. However, MiniZookeeperCluster uses a deprecated > ZookeeperServer constructor, which in turn constructs its own FileTxnSnapLog, > and ZKDatabase. Since ZookeeperServer.shutdown() does not close() the > ZKDatabase, we have to explicitly close it in MiniZookeeperCluster.shutdown(). > Tests effected by this are > {code} > TestSplitLogManager > TestSplitLogWorker > TestOfflineMetaRebuildBase > TestOfflineMetaRebuildHole > TestOfflineMetaRebuildOverlap > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6820) [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()
[ https://issues.apache.org/jira/browse/HBASE-6820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465030#comment-13465030 ] Hadoop QA commented on HBASE-6820: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12546135/hbase-6820_v1-trunk.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. -1 javadoc. The javadoc tool appears to have generated 140 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2945//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2945//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2945//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2945//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2945//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2945//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2945//console This message is automatically generated. > [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon > shutdown() > -- > > Key: HBASE-6820 > URL: https://issues.apache.org/jira/browse/HBASE-6820 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3, 0.96.0 >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Labels: windows > Attachments: hbase-6820_v1-0.94.patch, hbase-6820_v1-trunk.patch > > > MiniZookeeperCluster.shutdown() shuts down the ZookeeperServer and > NIOServerCnxnFactory. However, MiniZookeeperCluster uses a deprecated > ZookeeperServer constructor, which in turn constructs its own FileTxnSnapLog, > and ZKDatabase. Since ZookeeperServer.shutdown() does not close() the > ZKDatabase, we have to explicitly close it in MiniZookeeperCluster.shutdown(). > Tests effected by this are > {code} > TestSplitLogManager > TestSplitLogWorker > TestOfflineMetaRebuildBase > TestOfflineMetaRebuildHole > TestOfflineMetaRebuildOverlap > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira