[jira] [Commented] (HBASE-6955) Block read time should be in ms, not in ns
[ https://issues.apache.org/jira/browse/HBASE-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14269005#comment-14269005 ] Cosmin Lehene commented on HBASE-6955: -- [~mikhail], [~apurtell] is this still valid? > Block read time should be in ms, not in ns > -- > > Key: HBASE-6955 > URL: https://issues.apache.org/jira/browse/HBASE-6955 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Priority: Minor > Labels: delete > Attachments: D5901.1.patch, D5901.2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-6955) Block read time should be in ms, not in ns
[ https://issues.apache.org/jira/browse/HBASE-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482786#comment-13482786 ] Mikhail Bautin commented on HBASE-6955: --- [~xieliang007]: yes, it would be great to port this to trunk. > Block read time should be in ms, not in ns > -- > > Key: HBASE-6955 > URL: https://issues.apache.org/jira/browse/HBASE-6955 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Priority: Minor > Attachments: D5901.1.patch, D5901.2.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6955) Block read time should be in ms, not in ns
[ https://issues.apache.org/jira/browse/HBASE-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482083#comment-13482083 ] liang xie commented on HBASE-6955: -- do we need to port this to trunk as well ? Revision: 1397821 in fb-89 branch has done this job > Block read time should be in ms, not in ns > -- > > Key: HBASE-6955 > URL: https://issues.apache.org/jira/browse/HBASE-6955 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Priority: Minor > Attachments: D5901.1.patch, D5901.2.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6955) Block read time should be in ms, not in ns
[ https://issues.apache.org/jira/browse/HBASE-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475598#comment-13475598 ] Phabricator commented on HBASE-6955: mbautin has closed the revision "[jira] [HBASE-6955] [89-fb] Block read time should be in ms, not in ns". CHANGED PRIOR TO COMMIT https://reviews.facebook.net/D5901?vs=19917&id=19947#differential-review-toc REVISION DETAIL https://reviews.facebook.net/D5901 COMMIT https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1397821 To: Kannan, JIRA, mbautin > Block read time should be in ms, not in ns > -- > > Key: HBASE-6955 > URL: https://issues.apache.org/jira/browse/HBASE-6955 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Priority: Minor > Attachments: D5901.1.patch, D5901.2.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6955) Block read time should be in ms, not in ns
[ https://issues.apache.org/jira/browse/HBASE-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475319#comment-13475319 ] Phabricator commented on HBASE-6955: Kannan has accepted the revision "[jira] [HBASE-6955] [89-fb] Block read time should be in ms, not in ns". lgtm! REVISION DETAIL https://reviews.facebook.net/D5901 BRANCH fix_fs_read_time_v5 To: Kannan, JIRA, mbautin > Block read time should be in ms, not in ns > -- > > Key: HBASE-6955 > URL: https://issues.apache.org/jira/browse/HBASE-6955 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Priority: Minor > Attachments: D5901.1.patch, D5901.2.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6955) Block read time should be in ms, not in ns
[ https://issues.apache.org/jira/browse/HBASE-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469979#comment-13469979 ] Phabricator commented on HBASE-6955: Kannan has commented on the revision "[jira] [HBASE-6955] [89-fb] Block read time should be in ms, not in ns". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java:312 In RegionServerMetrics.java, can we also export the "pread" metrics much like we do for the non-pread case: int ops = HFile.getReadOps(); if (ops != 0) this.fsReadLatency.inc(ops, HFile.getReadTimeMs()); REVISION DETAIL https://reviews.facebook.net/D5901 To: Kannan, JIRA, mbautin > Block read time should be in ms, not in ns > -- > > Key: HBASE-6955 > URL: https://issues.apache.org/jira/browse/HBASE-6955 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Priority: Minor > Attachments: D5901.1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
