[jira] [Commented] (HBASE-7373) table should not be required in AccessControlService
[ https://issues.apache.org/jira/browse/HBASE-7373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13537274#comment-13537274 ] Hudson commented on HBASE-7373: --- Integrated in HBase-TRUNK #3643 (See [https://builds.apache.org/job/HBase-TRUNK/3643/]) HBASE-7373 table should not be required in AccessControlService (Revision 1424604) Result = FAILURE jxiang : Files : * /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AccessControlProtos.java * /hbase/trunk/hbase-protocol/src/main/protobuf/AccessControl.proto * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/TableAuthManager.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java table should not be required in AccessControlService Key: HBASE-7373 URL: https://issues.apache.org/jira/browse/HBASE-7373 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0 Attachments: trunk-7373.patch We should fix the proto file, add unit test for this case, and verify it works from hbase shell with table to be nil. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7373) table should not be required in AccessControlService
[ https://issues.apache.org/jira/browse/HBASE-7373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13537507#comment-13537507 ] Hudson commented on HBASE-7373: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #306 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/306/]) HBASE-7373 table should not be required in AccessControlService (Revision 1424604) Result = FAILURE jxiang : Files : * /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AccessControlProtos.java * /hbase/trunk/hbase-protocol/src/main/protobuf/AccessControl.proto * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/TableAuthManager.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java table should not be required in AccessControlService Key: HBASE-7373 URL: https://issues.apache.org/jira/browse/HBASE-7373 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0 Attachments: trunk-7373.patch We should fix the proto file, add unit test for this case, and verify it works from hbase shell with table to be nil. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7373) table should not be required in AccessControlService
[ https://issues.apache.org/jira/browse/HBASE-7373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13536429#comment-13536429 ] Jimmy Xiang commented on HBASE-7373: Patch is posted on RB too: https://reviews.apache.org/r/8687/ table should not be required in AccessControlService Key: HBASE-7373 URL: https://issues.apache.org/jira/browse/HBASE-7373 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Attachments: trunk-7373.patch We should fix the proto file, add unit test for this case, and verify it works from hbase shell with table to be nil. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7373) table should not be required in AccessControlService
[
https://issues.apache.org/jira/browse/HBASE-7373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13536510#comment-13536510
]
Hadoop QA commented on HBASE-7373:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12561784/trunk-7373.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 28 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster
{color:red}-1 core zombie tests{color}. There are zombie tests. See build
logs for details.
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3619//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3619//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3619//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3619//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3619//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3619//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3619//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3619//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3619//console
This message is automatically generated.
table should not be required in AccessControlService
Key: HBASE-7373
URL: https://issues.apache.org/jira/browse/HBASE-7373
Project: HBase
Issue Type: Bug
Reporter: Jimmy Xiang
Assignee: Jimmy Xiang
Priority: Minor
Attachments: trunk-7373.patch
We should fix the proto file, add unit test for this case, and verify it
works from hbase shell with table to be nil.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7373) table should not be required in AccessControlService
[
https://issues.apache.org/jira/browse/HBASE-7373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13534513#comment-13534513
]
Gary Helmling commented on HBASE-7373:
--
This relates to UserPermissionRequest, right?
{noformat}
message UserPermissionsRequest {
required bytes table = 1;
}
{noformat}
This is the only place I see table as required. Agree that it shouldn't be.
table should not be required in AccessControlService
Key: HBASE-7373
URL: https://issues.apache.org/jira/browse/HBASE-7373
Project: HBase
Issue Type: Bug
Reporter: Jimmy Xiang
Priority: Minor
We should fix the proto file, add unit test for this case, and verify it
works from hbase shell with table to be nil.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7373) table should not be required in AccessControlService
[ https://issues.apache.org/jira/browse/HBASE-7373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13534608#comment-13534608 ] Jimmy Xiang commented on HBASE-7373: Yes, that's the place. table should not be required in AccessControlService Key: HBASE-7373 URL: https://issues.apache.org/jira/browse/HBASE-7373 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Priority: Minor We should fix the proto file, add unit test for this case, and verify it works from hbase shell with table to be nil. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
