[jira] [Commented] (HBASE-7400) ExportSnapshot mapper closes the FileSystem

2012-12-29 Thread Jonathan Hsieh (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540940#comment-13540940
 ] 

Jonathan Hsieh commented on HBASE-7400:
---

thanks ted, matteo. committing to the offline and online snapshots branches.

> ExportSnapshot mapper closes the FileSystem
> ---
>
> Key: HBASE-7400
> URL: https://issues.apache.org/jira/browse/HBASE-7400
> Project: HBase
>  Issue Type: Sub-task
>  Components: Client, master, regionserver, snapshots, Zookeeper
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Blocker
> Fix For: hbase-6055, 0.96.0
>
> Attachments: HBASE-7400-v0.patch, HBASE-7400-v1.patch, 
> HBASE-7400-v2.patch
>
>
> The ExportSnapshotMapper closes the FileSystem on cleanup,
> and in case of shared instead, since there's no ref count, the job fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7400) ExportSnapshot mapper closes the FileSystem

2012-12-29 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540894#comment-13540894
 ] 

Hadoop QA commented on HBASE-7400:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12562670/HBASE-7400-v2.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3756//console

This message is automatically generated.

> ExportSnapshot mapper closes the FileSystem
> ---
>
> Key: HBASE-7400
> URL: https://issues.apache.org/jira/browse/HBASE-7400
> Project: HBase
>  Issue Type: Sub-task
>  Components: Client, master, regionserver, snapshots, Zookeeper
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Blocker
> Fix For: hbase-6055, 0.96.0
>
> Attachments: HBASE-7400-v0.patch, HBASE-7400-v1.patch, 
> HBASE-7400-v2.patch
>
>
> The ExportSnapshotMapper closes the FileSystem on cleanup,
> and in case of shared instead, since there's no ref count, the job fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7400) ExportSnapshot mapper closes the FileSystem

2012-12-27 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540039#comment-13540039
 ] 

Ted Yu commented on HBASE-7400:
---

Thanks for the quick response.
+1 on second patch.

> ExportSnapshot mapper closes the FileSystem
> ---
>
> Key: HBASE-7400
> URL: https://issues.apache.org/jira/browse/HBASE-7400
> Project: HBase
>  Issue Type: Sub-task
>  Components: Client, master, regionserver, snapshots, Zookeeper
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Blocker
> Fix For: hbase-6055, 0.96.0
>
> Attachments: HBASE-7400-v0.patch, HBASE-7400-v1.patch
>
>
> The ExportSnapshotMapper closes the FileSystem on cleanup,
> and in case of shared instead, since there's no ref count, the job fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7400) ExportSnapshot mapper closes the FileSystem

2012-12-27 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539979#comment-13539979
 ] 

Ted Yu commented on HBASE-7400:
---

I see.
What do you think about my other comment w.r.t. 'new Configuration()' ?

Thanks

> ExportSnapshot mapper closes the FileSystem
> ---
>
> Key: HBASE-7400
> URL: https://issues.apache.org/jira/browse/HBASE-7400
> Project: HBase
>  Issue Type: Sub-task
>  Components: Client, master, regionserver, snapshots, Zookeeper
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Blocker
> Fix For: hbase-6055, 0.96.0
>
> Attachments: HBASE-7400-v0.patch
>
>
> The ExportSnapshotMapper closes the FileSystem on cleanup,
> and in case of shared instead, since there's no ref count, the job fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7400) ExportSnapshot mapper closes the FileSystem

2012-12-27 Thread Matteo Bertozzi (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539963#comment-13539963
 ] 

Matteo Bertozzi commented on HBASE-7400:


changes between hadoop 1 and 2.
and since in the test, the mappers seems running in the same jvm
fs.close() called by the mapper interferes with the one used by the main().

> ExportSnapshot mapper closes the FileSystem
> ---
>
> Key: HBASE-7400
> URL: https://issues.apache.org/jira/browse/HBASE-7400
> Project: HBase
>  Issue Type: Sub-task
>  Components: Client, master, regionserver, snapshots, Zookeeper
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Blocker
> Fix For: hbase-6055, 0.96.0
>
> Attachments: HBASE-7400-v0.patch
>
>
> The ExportSnapshotMapper closes the FileSystem on cleanup,
> and in case of shared instead, since there's no ref count, the job fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7400) ExportSnapshot mapper closes the FileSystem

2012-12-21 Thread Jonathan Hsieh (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538454#comment-13538454
 ] 

Jonathan Hsieh commented on HBASE-7400:
---

bq. Can you explain how shared mapper comes about ?

I believe this is a hadoop 1 vs hadoop 2 unit test problem.

> ExportSnapshot mapper closes the FileSystem
> ---
>
> Key: HBASE-7400
> URL: https://issues.apache.org/jira/browse/HBASE-7400
> Project: HBase
>  Issue Type: Sub-task
>  Components: Client, master, regionserver, snapshots, Zookeeper
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Blocker
> Fix For: hbase-6055, 0.96.0
>
> Attachments: HBASE-7400-v0.patch
>
>
> The ExportSnapshotMapper closes the FileSystem on cleanup,
> and in case of shared instead, since there's no ref count, the job fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7400) ExportSnapshot mapper closes the FileSystem

2012-12-19 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536763#comment-13536763
 ] 

Ted Yu commented on HBASE-7400:
---

Looking at ExportSnapshot.java:
{code}
FileSystem outputFs = FileSystem.get(outputRoot.toUri(), new 
Configuration());
{code}
Can we use getConf() in place of 'new Configuration()' ?

bq. in case of shared instead
Can you explain how shared mapper comes about ?

Thanks

> ExportSnapshot mapper closes the FileSystem
> ---
>
> Key: HBASE-7400
> URL: https://issues.apache.org/jira/browse/HBASE-7400
> Project: HBase
>  Issue Type: Sub-task
>  Components: Client, master, regionserver, snapshots, Zookeeper
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Blocker
> Fix For: hbase-6055, 0.96.0
>
> Attachments: HBASE-7400-v0.patch
>
>
> The ExportSnapshotMapper closes the FileSystem on cleanup,
> and in case of shared instead, since there's no ref count, the job fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7400) ExportSnapshot mapper closes the FileSystem

2012-12-19 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536725#comment-13536725
 ] 

Hadoop QA commented on HBASE-7400:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12561836/HBASE-7400-v0.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3630//console

This message is automatically generated.

> ExportSnapshot mapper closes the FileSystem
> ---
>
> Key: HBASE-7400
> URL: https://issues.apache.org/jira/browse/HBASE-7400
> Project: HBase
>  Issue Type: Sub-task
>  Components: Client, master, regionserver, snapshots, Zookeeper
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Blocker
> Fix For: hbase-6055, 0.96.0
>
> Attachments: HBASE-7400-v0.patch
>
>
> The ExportSnapshotMapper closes the FileSystem on cleanup,
> and in case of shared instead, since there's no ref count, the job fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira