[jira] [Commented] (HBASE-7508) Fix simple findbugs
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546757#comment-13546757 ] Hudson commented on HBASE-7508: --- Integrated in HBase-TRUNK #3709 (See [https://builds.apache.org/job/HBase-TRUNK/3709/]) HBASE-7508 Fix simple findbugs (Revision 1430169) Result = FAILURE nkeywal : Files : * /hbase/trunk/dev-support/findbugs-exclude.xml * /hbase/trunk/dev-support/test-patch.properties * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/JVM.java * /hbase/trunk/hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/ZooKeeperScanPolicyObserver.java * /hbase/trunk/hbase-examples/src/main/java/org/apache/hadoop/hbase/thrift/DemoClient.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HealthCheckChore.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ServerName.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/OperationWithAttributes.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Scan.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HLogInputFormat.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/SplitRegionHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyPrefixRegionSplitPolicy.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/Permission.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/EmptyWatcher.java * /hbase/trunk/pom.xml Fix simple findbugs --- Key: HBASE-7508 URL: https://issues.apache.org/jira/browse/HBASE-7508 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Trivial Fix For: 0.96.0 Attachments: 7508.v1.patch, 7508.v2.patch, 7508.v2.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7508) Fix simple findbugs
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546811#comment-13546811 ] Hudson commented on HBASE-7508: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #335 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/335/]) HBASE-7508 Fix simple findbugs (Revision 1430169) Result = FAILURE nkeywal : Files : * /hbase/trunk/dev-support/findbugs-exclude.xml * /hbase/trunk/dev-support/test-patch.properties * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/JVM.java * /hbase/trunk/hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/ZooKeeperScanPolicyObserver.java * /hbase/trunk/hbase-examples/src/main/java/org/apache/hadoop/hbase/thrift/DemoClient.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HealthCheckChore.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ServerName.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/OperationWithAttributes.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Scan.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HLogInputFormat.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/SplitRegionHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyPrefixRegionSplitPolicy.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/Permission.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/EmptyWatcher.java * /hbase/trunk/pom.xml Fix simple findbugs --- Key: HBASE-7508 URL: https://issues.apache.org/jira/browse/HBASE-7508 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Trivial Fix For: 0.96.0 Attachments: 7508.v1.patch, 7508.v2.patch, 7508.v2.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7508) Fix simple findbugs
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546121#comment-13546121 ] Jonathan Hsieh commented on HBASE-7508: --- Squish these into a single line? {code} ArrayListColumnDescriptor columns = new ArrayListColumnDescriptor(); -ColumnDescriptor col = null; +ColumnDescriptor col; col = new ColumnDescriptor(); col.name = ByteBuffer.wrap(bytes(entry:)); col.maxVersions = 10; @@ -227,7 +227,7 @@ public class DemoClient { client.mutateRow(ByteBuffer.wrap(t), ByteBuffer.wrap(row), mutations, dummyAttributes); printRow(client.getRow(ByteBuffer.wrap(t), ByteBuffer.wrap(row), dummyAttributes)); -Mutation m = null; +Mutation m; mutations = new ArrayListMutation(); m = new Mutation(); m.column = ByteBuffer.wrap(bytes(entry:foo)); @@ -272,7 +272,7 @@ public class DemoClient { {code} Findbugs is lgpl. http://findbugs.sourceforge.net/manual/license.htmlThis adds a code dependency Can we do this via the excludes file instead? {code} */ + @edu.umd.cs.findbugs.annotations.SuppressWarnings(value=MS_SHOULD_BE_FINAL) {code} Fix simple findbugs --- Key: HBASE-7508 URL: https://issues.apache.org/jira/browse/HBASE-7508 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Trivial Fix For: 0.96.0 Attachments: 7508.v1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7508) Fix simple findbugs
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546135#comment-13546135 ] stack commented on HBASE-7508: -- +1 Why does it want you not to assign null to local variables? Fix simple findbugs --- Key: HBASE-7508 URL: https://issues.apache.org/jira/browse/HBASE-7508 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Trivial Fix For: 0.96.0 Attachments: 7508.v1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7508) Fix simple findbugs
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546175#comment-13546175 ] nkeywal commented on HBASE-7508: bq. Why does it want you not to assign null to local variables? Because IntelliJ complains when there are unused assignment ;-). I think it's right, and it allows to see clearly when you're forgetting something. bq. Findbugs is lgpl. http://findbugs.sourceforge.net/manual/license.html This adds a code dependency Can we do this via the excludes file instead? It's less efficient... What do you think of copy-pasting this as a workaround? https://github.com/stephenc/findbugs-annotations Fix simple findbugs --- Key: HBASE-7508 URL: https://issues.apache.org/jira/browse/HBASE-7508 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Trivial Fix For: 0.96.0 Attachments: 7508.v1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7508) Fix simple findbugs
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546194#comment-13546194 ] Jonathan Hsieh commented on HBASE-7508: --- I dislike this lawyerly stuff but it is important that we do this correctly. Avoiding it or just using known ok ways (we've been using excludes files here) seems the safest way. Is there a precedent elsewhere with LGPL+Apache compatibility? Should we ping apache legal? Here's the rules I found with a little bit of search. http://www.apache.org/licenses/GPL-compatibility.html There were a few other suggesting they are compatible but these were from non-authoritative sources. Technically, I'd be satisfied if we used the workaround. (the description of that project is quite humorous!). This should just be a pom inclusion right? It seems like it would eliminate the possibility of including the lgpl jars from our tarballs. Fix simple findbugs --- Key: HBASE-7508 URL: https://issues.apache.org/jira/browse/HBASE-7508 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Trivial Fix For: 0.96.0 Attachments: 7508.v1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7508) Fix simple findbugs
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546224#comment-13546224 ] Hadoop QA commented on HBASE-7508: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563604/7508.v1.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.TestZooKeeper {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3908//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3908//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3908//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3908//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3908//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3908//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3908//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3908//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3908//console This message is automatically generated. Fix simple findbugs --- Key: HBASE-7508 URL: https://issues.apache.org/jira/browse/HBASE-7508 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Trivial Fix For: 0.96.0 Attachments: 7508.v1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7508) Fix simple findbugs
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546227#comment-13546227 ] nkeywal commented on HBASE-7508: @[~jmhsieh] It seems it's available on a public repo (http://mvnrepository.com/artifact/com.github.stephenc.findbugs/findbugs-annotations/) so it seems yep we could have it. Let me try. Fix simple findbugs --- Key: HBASE-7508 URL: https://issues.apache.org/jira/browse/HBASE-7508 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Trivial Fix For: 0.96.0 Attachments: 7508.v1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7508) Fix simple findbugs
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546234#comment-13546234 ] stack commented on HBASE-7508: -- We can't ship LGPL. IMO, it should be fine having us depend on an LGPL at compile time as long as the dependency was pulled by maven at compile time. Fix simple findbugs --- Key: HBASE-7508 URL: https://issues.apache.org/jira/browse/HBASE-7508 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Trivial Fix For: 0.96.0 Attachments: 7508.v1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7508) Fix simple findbugs
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546239#comment-13546239 ] nkeywal commented on HBASE-7508: It's suppose to be RetentionPolicy.CLASS. I.e. not needed at runtime. I checked, it's the case. But in the library, I found one annotation (that we don't use) with runtime annotation. The apache library I mentioned above works. I got the same number of issues. It's available in one of the repo we already have. Maybe the simplest option is to link with this one? Fix simple findbugs --- Key: HBASE-7508 URL: https://issues.apache.org/jira/browse/HBASE-7508 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Trivial Fix For: 0.96.0 Attachments: 7508.v1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7508) Fix simple findbugs
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546252#comment-13546252 ] Jonathan Hsieh commented on HBASE-7508: --- I'm fine with the non-lgpl library, or with excludes file approaches. Your choice, and simple is good. If you choose the library, we need to document this -- if someone sees this again it would be good to have a comment about this in our pom, on maybe in the docs (in a grep'able way?) Fix simple findbugs --- Key: HBASE-7508 URL: https://issues.apache.org/jira/browse/HBASE-7508 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Trivial Fix For: 0.96.0 Attachments: 7508.v1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7508) Fix simple findbugs
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546261#comment-13546261 ] Hadoop QA commented on HBASE-7508: -- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563604/7508.v1.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3910//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3910//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3910//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3910//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3910//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3910//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3910//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3910//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3910//console This message is automatically generated. Fix simple findbugs --- Key: HBASE-7508 URL: https://issues.apache.org/jira/browse/HBASE-7508 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Trivial Fix For: 0.96.0 Attachments: 7508.v1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7508) Fix simple findbugs
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546268#comment-13546268 ] nkeywal commented on HBASE-7508: Let's go for the library way then. And ok for the doc work as well. If nobody objects, I will commit this patch soon, as this touches multiple files. I will do the doc this week. Fix simple findbugs --- Key: HBASE-7508 URL: https://issues.apache.org/jira/browse/HBASE-7508 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Trivial Fix For: 0.96.0 Attachments: 7508.v1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7508) Fix simple findbugs
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546272#comment-13546272 ] Jonathan Hsieh commented on HBASE-7508: --- +1 Fix simple findbugs --- Key: HBASE-7508 URL: https://issues.apache.org/jira/browse/HBASE-7508 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Trivial Fix For: 0.96.0 Attachments: 7508.v1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7508) Fix simple findbugs
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546274#comment-13546274 ] stack commented on HBASE-7508: -- +1 You will open another issue to do the doc/lib? Fix simple findbugs --- Key: HBASE-7508 URL: https://issues.apache.org/jira/browse/HBASE-7508 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Trivial Fix For: 0.96.0 Attachments: 7508.v1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7508) Fix simple findbugs
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546277#comment-13546277 ] nkeywal commented on HBASE-7508: Done. Thanks for the review! Fix simple findbugs --- Key: HBASE-7508 URL: https://issues.apache.org/jira/browse/HBASE-7508 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Trivial Fix For: 0.96.0 Attachments: 7508.v1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira