[jira] [Commented] (HBASE-7553) TestServerCustomProtocol depends on the test methods execution order
[ https://issues.apache.org/jira/browse/HBASE-7553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552660#comment-13552660 ] nkeywal commented on HBASE-7553: trivial, worked locally 10 times, I will commit it is precommit is ok and there is no objection. TestServerCustomProtocol depends on the test methods execution order Key: HBASE-7553 URL: https://issues.apache.org/jira/browse/HBASE-7553 Project: HBase Issue Type: Bug Components: test Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Minor Fix For: 0.96.0 Attachments: 7553.v1.patch This breaks with JUnit 4.11 and could break the test JDK 1.7 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7553) TestServerCustomProtocol depends on the test methods execution order
[
https://issues.apache.org/jira/browse/HBASE-7553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552760#comment-13552760
]
Hadoop QA commented on HBASE-7553:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12564705/7553.v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4000//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4000//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4000//console
This message is automatically generated.
TestServerCustomProtocol depends on the test methods execution order
Key: HBASE-7553
URL: https://issues.apache.org/jira/browse/HBASE-7553
Project: HBase
Issue Type: Bug
Components: test
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
Fix For: 0.96.0
Attachments: 7553.v1.patch
This breaks with JUnit 4.11 and could break the test JDK 1.7
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7553) TestServerCustomProtocol depends on the test methods execution order
[ https://issues.apache.org/jira/browse/HBASE-7553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552904#comment-13552904 ] stack commented on HBASE-7553: -- +1 I'd say just go ahead and commit test changes w/o waiting on +1s. Its easy to see if you have messed up (smile). TestServerCustomProtocol depends on the test methods execution order Key: HBASE-7553 URL: https://issues.apache.org/jira/browse/HBASE-7553 Project: HBase Issue Type: Bug Components: test Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Minor Fix For: 0.96.0 Attachments: 7553.v1.patch This breaks with JUnit 4.11 and could break the test JDK 1.7 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7553) TestServerCustomProtocol depends on the test methods execution order
[ https://issues.apache.org/jira/browse/HBASE-7553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552938#comment-13552938 ] nkeywal commented on HBASE-7553: Ok. Committed. Thanks for the review! TestServerCustomProtocol depends on the test methods execution order Key: HBASE-7553 URL: https://issues.apache.org/jira/browse/HBASE-7553 Project: HBase Issue Type: Bug Components: test Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Minor Fix For: 0.96.0 Attachments: 7553.v1.patch This breaks with JUnit 4.11 and could break the test JDK 1.7 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7553) TestServerCustomProtocol depends on the test methods execution order
[ https://issues.apache.org/jira/browse/HBASE-7553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553088#comment-13553088 ] Hudson commented on HBASE-7553: --- Integrated in HBase-TRUNK #3742 (See [https://builds.apache.org/job/HBase-TRUNK/3742/]) HBASE-7553 TestServerCustomProtocol depends on the test methods execution order (Revision 1433014) Result = FAILURE nkeywal : Files : * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java TestServerCustomProtocol depends on the test methods execution order Key: HBASE-7553 URL: https://issues.apache.org/jira/browse/HBASE-7553 Project: HBase Issue Type: Bug Components: test Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Minor Fix For: 0.96.0 Attachments: 7553.v1.patch This breaks with JUnit 4.11 and could break the test JDK 1.7 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7553) TestServerCustomProtocol depends on the test methods execution order
[ https://issues.apache.org/jira/browse/HBASE-7553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553253#comment-13553253 ] Andrew Purtell commented on HBASE-7553: --- +1 on CTR for test only fixes. Does that need discussion? TestServerCustomProtocol depends on the test methods execution order Key: HBASE-7553 URL: https://issues.apache.org/jira/browse/HBASE-7553 Project: HBase Issue Type: Bug Components: test Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Minor Fix For: 0.96.0 Attachments: 7553.v1.patch This breaks with JUnit 4.11 and could break the test JDK 1.7 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7553) TestServerCustomProtocol depends on the test methods execution order
[ https://issues.apache.org/jira/browse/HBASE-7553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553319#comment-13553319 ] Hudson commented on HBASE-7553: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #347 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/347/]) HBASE-7553 TestServerCustomProtocol depends on the test methods execution order (Revision 1433014) Result = FAILURE nkeywal : Files : * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java TestServerCustomProtocol depends on the test methods execution order Key: HBASE-7553 URL: https://issues.apache.org/jira/browse/HBASE-7553 Project: HBase Issue Type: Bug Components: test Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Minor Fix For: 0.96.0 Attachments: 7553.v1.patch This breaks with JUnit 4.11 and could break the test JDK 1.7 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7553) TestServerCustomProtocol depends on the test methods execution order
[ https://issues.apache.org/jira/browse/HBASE-7553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553435#comment-13553435 ] Andrew Purtell commented on HBASE-7553: --- bq. I withdraw the suggestion then Fair enough. Wasn't my intent to go all process on you, just to say I wouldn't mind commits like on this jira without review. Like you say, Jenkins is the reviewer that matters when dealing with test failures. TestServerCustomProtocol depends on the test methods execution order Key: HBASE-7553 URL: https://issues.apache.org/jira/browse/HBASE-7553 Project: HBase Issue Type: Bug Components: test Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Minor Fix For: 0.96.0 Attachments: 7553.v1.patch This breaks with JUnit 4.11 and could break the test JDK 1.7 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
