[jira] [Commented] (HBASE-8138) Using [packed=true] for repeated field of primitive numeric types (types which use the varint, 32-bit, or 64-bit wire types)
[
https://issues.apache.org/jira/browse/HBASE-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606746#comment-13606746
]
Jeffrey Zhong commented on HBASE-8138:
--
[~saint@gmail.com] There is another optimization about avoiding copy bytes
I think we already have something in plan.
Using [packed=true] for repeated field of primitive numeric types (types
which use the varint, 32-bit, or 64-bit wire types)
Key: HBASE-8138
URL: https://issues.apache.org/jira/browse/HBASE-8138
Project: HBase
Issue Type: Bug
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
Priority: Trivial
Fix For: 0.98.0
Attachments: hbase-8138.patch
It's recommended to do the following for numeric primitive types
{quote}
For historical reasons, repeated fields of basic numeric types aren't encoded
as efficiently as they could be. New code should use the special option
[packed=true] to get a more efficient encoding
{quote}
See details at https://developers.google.com/protocol-buffers/docs/proto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8138) Using [packed=true] for repeated field of primitive numeric types (types which use the varint, 32-bit, or 64-bit wire types)
[
https://issues.apache.org/jira/browse/HBASE-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606766#comment-13606766
]
stack commented on HBASE-8138:
--
[~jeffreyz] Tell me what the option is so I am clear (saving byte copies around
pb is always nice)
Using [packed=true] for repeated field of primitive numeric types (types
which use the varint, 32-bit, or 64-bit wire types)
Key: HBASE-8138
URL: https://issues.apache.org/jira/browse/HBASE-8138
Project: HBase
Issue Type: Bug
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
Priority: Trivial
Fix For: 0.98.0
Attachments: hbase-8138.patch
It's recommended to do the following for numeric primitive types
{quote}
For historical reasons, repeated fields of basic numeric types aren't encoded
as efficiently as they could be. New code should use the special option
[packed=true] to get a more efficient encoding
{quote}
See details at https://developers.google.com/protocol-buffers/docs/proto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8138) Using [packed=true] for repeated field of primitive numeric types (types which use the varint, 32-bit, or 64-bit wire types)
[
https://issues.apache.org/jira/browse/HBASE-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606777#comment-13606777
]
Jeffrey Zhong commented on HBASE-8138:
--
[~saint@gmail.com] Oh, the avoid buffer copying enhancement is tracked here
https://issues.apache.org/jira/browse/hbase-5945.
Using [packed=true] for repeated field of primitive numeric types (types
which use the varint, 32-bit, or 64-bit wire types)
Key: HBASE-8138
URL: https://issues.apache.org/jira/browse/HBASE-8138
Project: HBase
Issue Type: Bug
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
Priority: Trivial
Fix For: 0.95.0, 0.98.0
Attachments: hbase-8138.patch
It's recommended to do the following for numeric primitive types
{quote}
For historical reasons, repeated fields of basic numeric types aren't encoded
as efficiently as they could be. New code should use the special option
[packed=true] to get a more efficient encoding
{quote}
See details at https://developers.google.com/protocol-buffers/docs/proto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8138) Using [packed=true] for repeated field of primitive numeric types (types which use the varint, 32-bit, or 64-bit wire types)
[
https://issues.apache.org/jira/browse/HBASE-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606786#comment-13606786
]
stack commented on HBASE-8138:
--
[~jeffreyz] oh, that. Yes. Thanks.
Using [packed=true] for repeated field of primitive numeric types (types
which use the varint, 32-bit, or 64-bit wire types)
Key: HBASE-8138
URL: https://issues.apache.org/jira/browse/HBASE-8138
Project: HBase
Issue Type: Bug
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
Priority: Trivial
Fix For: 0.95.0, 0.98.0
Attachments: hbase-8138.patch
It's recommended to do the following for numeric primitive types
{quote}
For historical reasons, repeated fields of basic numeric types aren't encoded
as efficiently as they could be. New code should use the special option
[packed=true] to get a more efficient encoding
{quote}
See details at https://developers.google.com/protocol-buffers/docs/proto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8138) Using [packed=true] for repeated field of primitive numeric types (types which use the varint, 32-bit, or 64-bit wire types)
[
https://issues.apache.org/jira/browse/HBASE-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606989#comment-13606989
]
Hudson commented on HBASE-8138:
---
Integrated in HBase-TRUNK #3974 (See
[https://builds.apache.org/job/HBase-TRUNK/3974/])
HBASE-8138 Using [packed=true] for repeated field of primitive numeric
types (types which use the varint, 32-bit, or 64-bit wire types) (Revision
1458504)
Result = FAILURE
stack :
Files :
*
/hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FilterProtos.java
* /hbase/trunk/hbase-protocol/src/main/protobuf/Filter.proto
Using [packed=true] for repeated field of primitive numeric types (types
which use the varint, 32-bit, or 64-bit wire types)
Key: HBASE-8138
URL: https://issues.apache.org/jira/browse/HBASE-8138
Project: HBase
Issue Type: Bug
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
Priority: Trivial
Fix For: 0.95.0, 0.98.0
Attachments: hbase-8138.patch
It's recommended to do the following for numeric primitive types
{quote}
For historical reasons, repeated fields of basic numeric types aren't encoded
as efficiently as they could be. New code should use the special option
[packed=true] to get a more efficient encoding
{quote}
See details at https://developers.google.com/protocol-buffers/docs/proto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8138) Using [packed=true] for repeated field of primitive numeric types (types which use the varint, 32-bit, or 64-bit wire types)
[
https://issues.apache.org/jira/browse/HBASE-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607089#comment-13607089
]
Hudson commented on HBASE-8138:
---
Integrated in hbase-0.95 #88 (See
[https://builds.apache.org/job/hbase-0.95/88/])
HBASE-8138 Using [packed=true] for repeated field of primitive numeric
types (types which use the varint, 32-bit, or 64-bit wire types) (Revision
1458505)
Result = FAILURE
stack :
Files :
*
/hbase/branches/0.95/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FilterProtos.java
* /hbase/branches/0.95/hbase-protocol/src/main/protobuf/Filter.proto
Using [packed=true] for repeated field of primitive numeric types (types
which use the varint, 32-bit, or 64-bit wire types)
Key: HBASE-8138
URL: https://issues.apache.org/jira/browse/HBASE-8138
Project: HBase
Issue Type: Bug
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
Priority: Trivial
Fix For: 0.95.0, 0.98.0
Attachments: hbase-8138.patch
It's recommended to do the following for numeric primitive types
{quote}
For historical reasons, repeated fields of basic numeric types aren't encoded
as efficiently as they could be. New code should use the special option
[packed=true] to get a more efficient encoding
{quote}
See details at https://developers.google.com/protocol-buffers/docs/proto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8138) Using [packed=true] for repeated field of primitive numeric types (types which use the varint, 32-bit, or 64-bit wire types)
[
https://issues.apache.org/jira/browse/HBASE-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607221#comment-13607221
]
Hudson commented on HBASE-8138:
---
Integrated in hbase-0.95-on-hadoop2 #34 (See
[https://builds.apache.org/job/hbase-0.95-on-hadoop2/34/])
HBASE-8138 Using [packed=true] for repeated field of primitive numeric
types (types which use the varint, 32-bit, or 64-bit wire types) (Revision
1458505)
Result = FAILURE
stack :
Files :
*
/hbase/branches/0.95/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FilterProtos.java
* /hbase/branches/0.95/hbase-protocol/src/main/protobuf/Filter.proto
Using [packed=true] for repeated field of primitive numeric types (types
which use the varint, 32-bit, or 64-bit wire types)
Key: HBASE-8138
URL: https://issues.apache.org/jira/browse/HBASE-8138
Project: HBase
Issue Type: Bug
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
Priority: Trivial
Fix For: 0.95.0, 0.98.0
Attachments: hbase-8138.patch
It's recommended to do the following for numeric primitive types
{quote}
For historical reasons, repeated fields of basic numeric types aren't encoded
as efficiently as they could be. New code should use the special option
[packed=true] to get a more efficient encoding
{quote}
See details at https://developers.google.com/protocol-buffers/docs/proto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8138) Using [packed=true] for repeated field of primitive numeric types (types which use the varint, 32-bit, or 64-bit wire types)
[
https://issues.apache.org/jira/browse/HBASE-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607229#comment-13607229
]
Hudson commented on HBASE-8138:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #455 (See
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/455/])
HBASE-8138 Using [packed=true] for repeated field of primitive numeric
types (types which use the varint, 32-bit, or 64-bit wire types) (Revision
1458504)
Result = FAILURE
stack :
Files :
*
/hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FilterProtos.java
* /hbase/trunk/hbase-protocol/src/main/protobuf/Filter.proto
Using [packed=true] for repeated field of primitive numeric types (types
which use the varint, 32-bit, or 64-bit wire types)
Key: HBASE-8138
URL: https://issues.apache.org/jira/browse/HBASE-8138
Project: HBase
Issue Type: Bug
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
Priority: Trivial
Fix For: 0.95.0, 0.98.0
Attachments: hbase-8138.patch
It's recommended to do the following for numeric primitive types
{quote}
For historical reasons, repeated fields of basic numeric types aren't encoded
as efficiently as they could be. New code should use the special option
[packed=true] to get a more efficient encoding
{quote}
See details at https://developers.google.com/protocol-buffers/docs/proto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8138) Using [packed=true] for repeated field of primitive numeric types (types which use the varint, 32-bit, or 64-bit wire types)
[
https://issues.apache.org/jira/browse/HBASE-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13605909#comment-13605909
]
Hadoop QA commented on HBASE-8138:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12574187/hbase-8138.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4879//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4879//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4879//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4879//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4879//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4879//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4879//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4879//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4879//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4879//console
This message is automatically generated.
Using [packed=true] for repeated field of primitive numeric types (types
which use the varint, 32-bit, or 64-bit wire types)
Key: HBASE-8138
URL: https://issues.apache.org/jira/browse/HBASE-8138
Project: HBase
Issue Type: Bug
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
Priority: Trivial
Fix For: 0.98.0
Attachments: hbase-8138.patch
It's recommended to do the following for numeric primitive types
{quote}
For historical reasons, repeated fields of basic numeric types aren't encoded
as efficiently as they could be. New code should use the special option
[packed=true] to get a more efficient encoding
{quote}
See details at https://developers.google.com/protocol-buffers/docs/proto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8138) Using [packed=true] for repeated field of primitive numeric types (types which use the varint, 32-bit, or 64-bit wire types)
[
https://issues.apache.org/jira/browse/HBASE-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606051#comment-13606051
]
Anoop Sam John commented on HBASE-8138:
---
Just gone through all the protos that we have. Only in this place there is a
repeated numeric type field.
+1 on patch
Using [packed=true] for repeated field of primitive numeric types (types
which use the varint, 32-bit, or 64-bit wire types)
Key: HBASE-8138
URL: https://issues.apache.org/jira/browse/HBASE-8138
Project: HBase
Issue Type: Bug
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
Priority: Trivial
Fix For: 0.98.0
Attachments: hbase-8138.patch
It's recommended to do the following for numeric primitive types
{quote}
For historical reasons, repeated fields of basic numeric types aren't encoded
as efficiently as they could be. New code should use the special option
[packed=true] to get a more efficient encoding
{quote}
See details at https://developers.google.com/protocol-buffers/docs/proto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8138) Using [packed=true] for repeated field of primitive numeric types (types which use the varint, 32-bit, or 64-bit wire types)
[
https://issues.apache.org/jira/browse/HBASE-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606060#comment-13606060
]
stack commented on HBASE-8138:
--
+1
Any other optimizations you see [~jeffreyz]? Thanks.
Using [packed=true] for repeated field of primitive numeric types (types
which use the varint, 32-bit, or 64-bit wire types)
Key: HBASE-8138
URL: https://issues.apache.org/jira/browse/HBASE-8138
Project: HBase
Issue Type: Bug
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
Priority: Trivial
Fix For: 0.98.0
Attachments: hbase-8138.patch
It's recommended to do the following for numeric primitive types
{quote}
For historical reasons, repeated fields of basic numeric types aren't encoded
as efficiently as they could be. New code should use the special option
[packed=true] to get a more efficient encoding
{quote}
See details at https://developers.google.com/protocol-buffers/docs/proto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
