[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[ https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637369#comment-13637369 ] Hudson commented on HBASE-8317: --- Integrated in HBase-TRUNK #4072 (See [https://builds.apache.org/job/HBase-TRUNK/4072/]) HBASE-8317 Seek returns wrong result with PREFIX_TREE Encoding (Revision 1470123) Result = FAILURE zjushch : Files : * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeArraySearcher.java * /hbase/trunk/hbase-prefix-tree/src/test/java/org/apache/hadoop/hbase/codec/prefixtree/row/TestPrefixTreeSearcher.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestPrefixTreeEncoding.java > Seek returns wrong result with PREFIX_TREE Encoding > --- > > Key: HBASE-8317 > URL: https://issues.apache.org/jira/browse/HBASE-8317 > Project: HBase > Issue Type: Bug >Affects Versions: 0.95.0 >Reporter: chunhui shen >Assignee: chunhui shen > Fix For: 0.98.0, 0.95.1 > > Attachments: HBASE-8317-v1.patch, hbase-trunk-8317.patch, > hbase-trunk-8317v3.patch > > > TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce > the bug. > An example of the bug case: > Suppose the following rows: > 1.row3/c1:q1/ > 2.row3/c1:q2/ > 3.row3/c1:q3/ > 4.row4/c1:q1/ > 5.row4/c1:q2/ > After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but > actual is row3/c1:q1/. > I just fix this bug case in the patch, > Maybe we can do more for other potential problems if anyone is familiar with > the code of PREFIX_TREE -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[ https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637360#comment-13637360 ] Hudson commented on HBASE-8317: --- Integrated in hbase-0.95 #155 (See [https://builds.apache.org/job/hbase-0.95/155/]) HBASE-8317 Seek returns wrong result with PREFIX_TREE Encoding (Revision 1470124) Result = FAILURE zjushch : Files : * /hbase/branches/0.95/hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeArraySearcher.java * /hbase/branches/0.95/hbase-prefix-tree/src/test/java/org/apache/hadoop/hbase/codec/prefixtree/row/TestPrefixTreeSearcher.java * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestPrefixTreeEncoding.java > Seek returns wrong result with PREFIX_TREE Encoding > --- > > Key: HBASE-8317 > URL: https://issues.apache.org/jira/browse/HBASE-8317 > Project: HBase > Issue Type: Bug >Affects Versions: 0.95.0 >Reporter: chunhui shen >Assignee: chunhui shen > Fix For: 0.98.0, 0.95.1 > > Attachments: HBASE-8317-v1.patch, hbase-trunk-8317.patch, > hbase-trunk-8317v3.patch > > > TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce > the bug. > An example of the bug case: > Suppose the following rows: > 1.row3/c1:q1/ > 2.row3/c1:q2/ > 3.row3/c1:q3/ > 4.row4/c1:q1/ > 5.row4/c1:q2/ > After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but > actual is row3/c1:q1/. > I just fix this bug case in the patch, > Maybe we can do more for other potential problems if anyone is familiar with > the code of PREFIX_TREE -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[ https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637225#comment-13637225 ] Hudson commented on HBASE-8317: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #505 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/505/]) HBASE-8317 Seek returns wrong result with PREFIX_TREE Encoding (Revision 1470123) Result = FAILURE zjushch : Files : * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeArraySearcher.java * /hbase/trunk/hbase-prefix-tree/src/test/java/org/apache/hadoop/hbase/codec/prefixtree/row/TestPrefixTreeSearcher.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestPrefixTreeEncoding.java > Seek returns wrong result with PREFIX_TREE Encoding > --- > > Key: HBASE-8317 > URL: https://issues.apache.org/jira/browse/HBASE-8317 > Project: HBase > Issue Type: Bug >Affects Versions: 0.95.0 >Reporter: chunhui shen >Assignee: chunhui shen > Fix For: 0.98.0, 0.95.1 > > Attachments: HBASE-8317-v1.patch, hbase-trunk-8317.patch, > hbase-trunk-8317v3.patch > > > TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce > the bug. > An example of the bug case: > Suppose the following rows: > 1.row3/c1:q1/ > 2.row3/c1:q2/ > 3.row3/c1:q3/ > 4.row4/c1:q1/ > 5.row4/c1:q2/ > After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but > actual is row3/c1:q1/. > I just fix this bug case in the patch, > Maybe we can do more for other potential problems if anyone is familiar with > the code of PREFIX_TREE -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[ https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637197#comment-13637197 ] Hudson commented on HBASE-8317: --- Integrated in hbase-0.95-on-hadoop2 #75 (See [https://builds.apache.org/job/hbase-0.95-on-hadoop2/75/]) HBASE-8317 Seek returns wrong result with PREFIX_TREE Encoding (Revision 1470124) Result = FAILURE zjushch : Files : * /hbase/branches/0.95/hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeArraySearcher.java * /hbase/branches/0.95/hbase-prefix-tree/src/test/java/org/apache/hadoop/hbase/codec/prefixtree/row/TestPrefixTreeSearcher.java * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestPrefixTreeEncoding.java > Seek returns wrong result with PREFIX_TREE Encoding > --- > > Key: HBASE-8317 > URL: https://issues.apache.org/jira/browse/HBASE-8317 > Project: HBase > Issue Type: Bug >Affects Versions: 0.95.0 >Reporter: chunhui shen >Assignee: chunhui shen > Fix For: 0.98.0, 0.95.1 > > Attachments: HBASE-8317-v1.patch, hbase-trunk-8317.patch, > hbase-trunk-8317v3.patch > > > TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce > the bug. > An example of the bug case: > Suppose the following rows: > 1.row3/c1:q1/ > 2.row3/c1:q2/ > 3.row3/c1:q3/ > 4.row4/c1:q1/ > 5.row4/c1:q2/ > After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but > actual is row3/c1:q1/. > I just fix this bug case in the patch, > Maybe we can do more for other potential problems if anyone is familiar with > the code of PREFIX_TREE -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[ https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637158#comment-13637158 ] chunhui shen commented on HBASE-8317: - Committed to trunk and 0.95. Thanks for the review, matt, ted, ram. > Seek returns wrong result with PREFIX_TREE Encoding > --- > > Key: HBASE-8317 > URL: https://issues.apache.org/jira/browse/HBASE-8317 > Project: HBase > Issue Type: Bug >Affects Versions: 0.95.0 >Reporter: chunhui shen >Assignee: chunhui shen > Attachments: HBASE-8317-v1.patch, hbase-trunk-8317.patch, > hbase-trunk-8317v3.patch > > > TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce > the bug. > An example of the bug case: > Suppose the following rows: > 1.row3/c1:q1/ > 2.row3/c1:q2/ > 3.row3/c1:q3/ > 4.row4/c1:q1/ > 5.row4/c1:q2/ > After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but > actual is row3/c1:q1/. > I just fix this bug case in the patch, > Maybe we can do more for other potential problems if anyone is familiar with > the code of PREFIX_TREE -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[ https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13636296#comment-13636296 ] chunhui shen commented on HBASE-8317: - I will commit patch v3 if no objection > Seek returns wrong result with PREFIX_TREE Encoding > --- > > Key: HBASE-8317 > URL: https://issues.apache.org/jira/browse/HBASE-8317 > Project: HBase > Issue Type: Bug >Affects Versions: 0.95.0 >Reporter: chunhui shen >Assignee: chunhui shen > Attachments: HBASE-8317-v1.patch, hbase-trunk-8317.patch, > hbase-trunk-8317v3.patch > > > TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce > the bug. > An example of the bug case: > Suppose the following rows: > 1.row3/c1:q1/ > 2.row3/c1:q2/ > 3.row3/c1:q3/ > 4.row4/c1:q1/ > 5.row4/c1:q2/ > After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but > actual is row3/c1:q1/. > I just fix this bug case in the patch, > Maybe we can do more for other potential problems if anyone is familiar with > the code of PREFIX_TREE -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[ https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13635375#comment-13635375 ] ramkrishna.s.vasudevan commented on HBASE-8317: --- I think this can be committed. > Seek returns wrong result with PREFIX_TREE Encoding > --- > > Key: HBASE-8317 > URL: https://issues.apache.org/jira/browse/HBASE-8317 > Project: HBase > Issue Type: Bug >Affects Versions: 0.95.0 >Reporter: chunhui shen >Assignee: chunhui shen > Attachments: HBASE-8317-v1.patch, hbase-trunk-8317.patch, > hbase-trunk-8317v3.patch > > > TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce > the bug. > An example of the bug case: > Suppose the following rows: > 1.row3/c1:q1/ > 2.row3/c1:q2/ > 3.row3/c1:q3/ > 4.row4/c1:q1/ > 5.row4/c1:q2/ > After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but > actual is row3/c1:q1/. > I just fix this bug case in the patch, > Maybe we can do more for other potential problems if anyone is familiar with > the code of PREFIX_TREE -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[ https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630864#comment-13630864 ] Ted Yu commented on HBASE-8317: --- As long as there is a way to find cause of test failure, I am fine. > Seek returns wrong result with PREFIX_TREE Encoding > --- > > Key: HBASE-8317 > URL: https://issues.apache.org/jira/browse/HBASE-8317 > Project: HBase > Issue Type: Bug >Affects Versions: 0.95.0 >Reporter: chunhui shen >Assignee: chunhui shen > Attachments: HBASE-8317-v1.patch, hbase-trunk-8317.patch, > hbase-trunk-8317v3.patch > > > TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce > the bug. > An example of the bug case: > Suppose the following rows: > 1.row3/c1:q1/ > 2.row3/c1:q2/ > 3.row3/c1:q3/ > 4.row4/c1:q1/ > 5.row4/c1:q2/ > After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but > actual is row3/c1:q1/. > I just fix this bug case in the patch, > Maybe we can do more for other potential problems if anyone is familiar with > the code of PREFIX_TREE -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[ https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629849#comment-13629849 ] chunhui shen commented on HBASE-8317: - bq.Please also log the seed so that we can reproduce issue if this test ever fails. If the test fails, we will dump all the test KeyValues by TestPrefixTreeEncoding#dumpInputKVSet() > Seek returns wrong result with PREFIX_TREE Encoding > --- > > Key: HBASE-8317 > URL: https://issues.apache.org/jira/browse/HBASE-8317 > Project: HBase > Issue Type: Bug >Affects Versions: 0.95.0 >Reporter: chunhui shen >Assignee: chunhui shen > Attachments: HBASE-8317-v1.patch, hbase-trunk-8317.patch, > hbase-trunk-8317v3.patch > > > TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce > the bug. > An example of the bug case: > Suppose the following rows: > 1.row3/c1:q1/ > 2.row3/c1:q2/ > 3.row3/c1:q3/ > 4.row4/c1:q1/ > 5.row4/c1:q2/ > After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but > actual is row3/c1:q1/. > I just fix this bug case in the patch, > Maybe we can do more for other potential problems if anyone is familiar with > the code of PREFIX_TREE -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[
https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629844#comment-13629844
]
Ted Yu commented on HBASE-8317:
---
The new test is a small test. I think we can keep it.
{code}
+Random random = new Random();
{code}
Can a seed be used above ? Please also log the seed so that we can reproduce
issue if this test ever fails.
> Seek returns wrong result with PREFIX_TREE Encoding
> ---
>
> Key: HBASE-8317
> URL: https://issues.apache.org/jira/browse/HBASE-8317
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.95.0
>Reporter: chunhui shen
>Assignee: chunhui shen
> Attachments: HBASE-8317-v1.patch, hbase-trunk-8317.patch,
> hbase-trunk-8317v3.patch
>
>
> TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce
> the bug.
> An example of the bug case:
> Suppose the following rows:
> 1.row3/c1:q1/
> 2.row3/c1:q2/
> 3.row3/c1:q3/
> 4.row4/c1:q1/
> 5.row4/c1:q2/
> After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but
> actual is row3/c1:q1/.
> I just fix this bug case in the patch,
> Maybe we can do more for other potential problems if anyone is familiar with
> the code of PREFIX_TREE
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[ https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629833#comment-13629833 ] Matt Corgan commented on HBASE-8317: Should be ok to commit both tests. I think it's important to have the fine-grained tests in the prefix-tree module to prove its correctness with the simplest test possible, but those tests only verify the prefix-tree code. Tests in hbase-server can cover all encoding types. The downside to building up redundant tests in hbase-server is that we will always be afraid to remove them or modify them, creating a maintenance struggle. We should keep it I think, but be conscious of the fact that too course-grained of a test suite may slow us down later. > Seek returns wrong result with PREFIX_TREE Encoding > --- > > Key: HBASE-8317 > URL: https://issues.apache.org/jira/browse/HBASE-8317 > Project: HBase > Issue Type: Bug >Affects Versions: 0.95.0 >Reporter: chunhui shen >Assignee: chunhui shen > Attachments: HBASE-8317-v1.patch, hbase-trunk-8317.patch, > hbase-trunk-8317v3.patch > > > TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce > the bug. > An example of the bug case: > Suppose the following rows: > 1.row3/c1:q1/ > 2.row3/c1:q2/ > 3.row3/c1:q3/ > 4.row4/c1:q1/ > 5.row4/c1:q2/ > After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but > actual is row3/c1:q1/. > I just fix this bug case in the patch, > Maybe we can do more for other potential problems if anyone is familiar with > the code of PREFIX_TREE -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[
https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629765#comment-13629765
]
Hadoop QA commented on HBASE-8317:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12578343/hbase-trunk-8317v3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.security.access.TestAccessController
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5280//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5280//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5280//console
This message is automatically generated.
> Seek returns wrong result with PREFIX_TREE Encoding
> ---
>
> Key: HBASE-8317
> URL: https://issues.apache.org/jira/browse/HBASE-8317
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.95.0
>Reporter: chunhui shen
>Assignee: chunhui shen
> Attachments: HBASE-8317-v1.patch, hbase-trunk-8317.patch,
> hbase-trunk-8317v3.patch
>
>
> TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce
> the bug.
> An example of the bug case:
> Suppose the following rows:
> 1.row3/c1:q1/
> 2.row3/c1:q2/
> 3.row3/c1:q3/
> 4.row4/c1:q1/
> 5.row4/c1:q2/
> After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but
> actual is row3/c1:q1/.
> I just fix this bug case in the patch,
> Maybe we can do more for other potential problems if anyone is familiar with
> the code of PREFIX_TREE
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[ https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629201#comment-13629201 ] Ted Yu commented on HBASE-8317: --- So the new test in patch v1 is covered by the extended test in patch v2 ? > Seek returns wrong result with PREFIX_TREE Encoding > --- > > Key: HBASE-8317 > URL: https://issues.apache.org/jira/browse/HBASE-8317 > Project: HBase > Issue Type: Bug >Affects Versions: 0.95.0 >Reporter: chunhui shen >Assignee: chunhui shen > Attachments: HBASE-8317-v1.patch, hbase-trunk-8317.patch > > > TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce > the bug. > An example of the bug case: > Suppose the following rows: > 1.row3/c1:q1/ > 2.row3/c1:q2/ > 3.row3/c1:q3/ > 4.row4/c1:q1/ > 5.row4/c1:q2/ > After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but > actual is row3/c1:q1/. > I just fix this bug case in the patch, > Maybe we can do more for other potential problems if anyone is familiar with > the code of PREFIX_TREE -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[
https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628798#comment-13628798
]
Hadoop QA commented on HBASE-8317:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12578176/HBASE-8317-v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5262//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5262//console
This message is automatically generated.
> Seek returns wrong result with PREFIX_TREE Encoding
> ---
>
> Key: HBASE-8317
> URL: https://issues.apache.org/jira/browse/HBASE-8317
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.95.0
>Reporter: chunhui shen
>Assignee: chunhui shen
> Attachments: HBASE-8317-v1.patch, hbase-trunk-8317.patch
>
>
> TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce
> the bug.
> An example of the bug case:
> Suppose the following rows:
> 1.row3/c1:q1/
> 2.row3/c1:q2/
> 3.row3/c1:q3/
> 4.row4/c1:q1/
> 5.row4/c1:q2/
> After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but
> actual is row3/c1:q1/.
> I just fix this bug case in the patch,
> Maybe we can do more for other potential problems if anyone is familiar with
> the code of PREFIX_TREE
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[ https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628773#comment-13628773 ] chunhui shen commented on HBASE-8317: - [~mcorgan] Thanks for confirming it. Run HadoopQA first... > Seek returns wrong result with PREFIX_TREE Encoding > --- > > Key: HBASE-8317 > URL: https://issues.apache.org/jira/browse/HBASE-8317 > Project: HBase > Issue Type: Bug >Affects Versions: 0.95.0 >Reporter: chunhui shen >Assignee: chunhui shen > Attachments: HBASE-8317-v1.patch, hbase-trunk-8317.patch > > > TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce > the bug. > An example of the bug case: > Suppose the following rows: > 1.row3/c1:q1/ > 2.row3/c1:q2/ > 3.row3/c1:q3/ > 4.row4/c1:q1/ > 5.row4/c1:q2/ > After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but > actual is row3/c1:q1/. > I just fix this bug case in the patch, > Maybe we can do more for other potential problems if anyone is familiar with > the code of PREFIX_TREE -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[ https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628750#comment-13628750 ] Matt Corgan commented on HBASE-8317: [~zjushch] thanks again for debugging - I hope it didn't take you all day. Your fix looks good. It was due to missing test coverage that I is added in attached patch v1. I was previously testing only the PrefixTreeArraySearcher.positionAtOrBefore method, but not positionAtOrAfter, which would have revealed the bug. I modified TestPrefixTreeSearcher.testRandomSeekMisses() to test both methods. There is a simplified test data set in TestRowDataNub.java (was already there) that passes/fails with/without your fix. > Seek returns wrong result with PREFIX_TREE Encoding > --- > > Key: HBASE-8317 > URL: https://issues.apache.org/jira/browse/HBASE-8317 > Project: HBase > Issue Type: Bug >Affects Versions: 0.95.0 >Reporter: chunhui shen >Assignee: chunhui shen > Attachments: HBASE-8317-v1.patch, hbase-trunk-8317.patch > > > TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce > the bug. > An example of the bug case: > Suppose the following rows: > 1.row3/c1:q1/ > 2.row3/c1:q2/ > 3.row3/c1:q3/ > 4.row4/c1:q1/ > 5.row4/c1:q2/ > After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but > actual is row3/c1:q1/. > I just fix this bug case in the patch, > Maybe we can do more for other potential problems if anyone is familiar with > the code of PREFIX_TREE -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[
https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628574#comment-13628574
]
chunhui shen commented on HBASE-8317:
-
bq.batch0_row2* it is behaving bit different for others bit different.
[~ram_krish]
The generated test data is not completely consecutive (in order to reproduce
the bug),
{code}
+ private static ByteBuffer generateFixedTestData(
+for (int i = 0; i < NUM_ROWS_PER_BATCH; ++i) {
+ if (i / 10 % 2 == 1) continue;
{code}
Hope it's your doubt point
> Seek returns wrong result with PREFIX_TREE Encoding
> ---
>
> Key: HBASE-8317
> URL: https://issues.apache.org/jira/browse/HBASE-8317
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.95.0
>Reporter: chunhui shen
>Assignee: chunhui shen
> Attachments: hbase-trunk-8317.patch
>
>
> TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce
> the bug.
> An example of the bug case:
> Suppose the following rows:
> 1.row3/c1:q1/
> 2.row3/c1:q2/
> 3.row3/c1:q3/
> 4.row4/c1:q1/
> 5.row4/c1:q2/
> After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but
> actual is row3/c1:q1/.
> I just fix this bug case in the patch,
> Maybe we can do more for other potential problems if anyone is familiar with
> the code of PREFIX_TREE
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[ https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628044#comment-13628044 ] Matt Corgan commented on HBASE-8317: Thanks for testing out the PREFIX_TREE guys. I will try to look into this one tonight. Let me know if you find anything else before then. > Seek returns wrong result with PREFIX_TREE Encoding > --- > > Key: HBASE-8317 > URL: https://issues.apache.org/jira/browse/HBASE-8317 > Project: HBase > Issue Type: Bug >Affects Versions: 0.95.0 >Reporter: chunhui shen >Assignee: chunhui shen > Attachments: hbase-trunk-8317.patch > > > TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce > the bug. > An example of the bug case: > Suppose the following rows: > 1.row3/c1:q1/ > 2.row3/c1:q2/ > 3.row3/c1:q3/ > 4.row4/c1:q1/ > 5.row4/c1:q2/ > After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but > actual is row3/c1:q1/. > I just fix this bug case in the patch, > Maybe we can do more for other potential problems if anyone is familiar with > the code of PREFIX_TREE -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
[
https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627684#comment-13627684
]
ramkrishna.s.vasudevan commented on HBASE-8317:
---
@Chunhui
I am not aware of this Prefix. But one thing i noticed is that,
for batch0_row2* it is behaving bit different for others bit different.
Even after this patch if you see the matching entries it goes like this,
{code}
batch0_row0/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row0/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row1/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row1/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row3/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row3/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row4/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row4/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row5/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row5/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row6/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row6/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row7/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row7/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row8/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row8/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row9/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row9/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row2/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row20/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
#batch0_row20/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
batch0_row21/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
#batch0_row21/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
batch0_row22/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
#batch0_row22/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
batch0_row23/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
#batch0_row23/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
batch0_row24/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
#batch0_row24/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
batch0_row25/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
#batch0_row25/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
batch0_row26/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
#batch0_row26/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
batch0_row27/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
#batch0_row27/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
batch0_row28/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
#batch0_row28/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
batch0_row29/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
#batch0_row29/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=27/mvcc=0
batch0_row4/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row4/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row4/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
#batch0_row4/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc=0
batch0_row4/EncodingTestCF:col0/LATEST_TIMESTAMP/Put/vlen=26/mvcc
