[jira] [Commented] (HBASE-8332) Add truncate as HMaster method
[ https://issues.apache.org/jira/browse/HBASE-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993154#comment-13993154 ] Matteo Bertozzi commented on HBASE-8332: yeah, nothing new. just nit and line length fixes. > Add truncate as HMaster method > -- > > Key: HBASE-8332 > URL: https://issues.apache.org/jira/browse/HBASE-8332 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Fix For: 0.99.0 > > Attachments: HBASE-8332-v0.patch, HBASE-8332-v2.patch, > HBASE-8332-v3.patch, HBASE-8332-v4.patch, HBASE-8332.draft.patch > > > Currently truncate and truncate_preserve are only shell functions, and > implemented as deleteTable() + createTable(). > Using ACLs the user running truncate, must have rights to create a table and > only "global granted" users can create tables. > Add truncate() and truncatePreserve() to HBaseAdmin/HMaster with its own ACL > check. > https://reviews.apache.org/r/15835/ -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-8332) Add truncate as HMaster method
[ https://issues.apache.org/jira/browse/HBASE-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993150#comment-13993150 ] Jonathan Hsieh commented on HBASE-8332: --- I reviewed on review board. The last versions are just fixing the nits and the line length stuff right? if so +1. > Add truncate as HMaster method > -- > > Key: HBASE-8332 > URL: https://issues.apache.org/jira/browse/HBASE-8332 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Fix For: 0.99.0 > > Attachments: HBASE-8332-v0.patch, HBASE-8332-v2.patch, > HBASE-8332-v3.patch, HBASE-8332-v4.patch, HBASE-8332.draft.patch > > > Currently truncate and truncate_preserve are only shell functions, and > implemented as deleteTable() + createTable(). > Using ACLs the user running truncate, must have rights to create a table and > only "global granted" users can create tables. > Add truncate() and truncatePreserve() to HBaseAdmin/HMaster with its own ACL > check. > https://reviews.apache.org/r/15835/ -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-8332) Add truncate as HMaster method
[ https://issues.apache.org/jira/browse/HBASE-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993419#comment-13993419 ] Hudson commented on HBASE-8332: --- FAILURE: Integrated in HBase-TRUNK #5131 (See [https://builds.apache.org/job/HBase-TRUNK/5131/]) HBASE-8332 Add truncate as HMaster method (mbertozzi: rev 1593439) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/TruncateTableAction.java * /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java * /hbase/trunk/hbase-protocol/src/main/protobuf/Master.proto * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/CreateTableHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/TruncateTableHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/ModifyRegionUtils.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java * /hbase/trunk/hbase-shell/src/main/ruby/hbase/admin.rb > Add truncate as HMaster method > -- > > Key: HBASE-8332 > URL: https://issues.apache.org/jira/browse/HBASE-8332 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Fix For: 0.99.0 > > Attachments: HBASE-8332-v0.patch, HBASE-8332-v2.patch, > HBASE-8332-v3.patch, HBASE-8332-v4.patch, HBASE-8332.draft.patch > > > Currently truncate and truncate_preserve are only shell functions, and > implemented as deleteTable() + createTable(). > Using ACLs the user running truncate, must have rights to create a table and > only "global granted" users can create tables. > Add truncate() and truncatePreserve() to HBaseAdmin/HMaster with its own ACL > check. > https://reviews.apache.org/r/15835/ -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-8332) Add truncate as HMaster method
[
https://issues.apache.org/jira/browse/HBASE-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897809#comment-13897809
]
Hadoop QA commented on HBASE-8332:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12628184/HBASE-8332-v3.patch
against trunk revision .
ATTACHMENT ID: 12628184
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 14 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+private TruncateTableRequest(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+private TruncateTableResponse(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+private EnableTableRequest(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+private EnableTableResponse(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+private DisableTableRequest(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+private DisableTableResponse(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+private ModifyTableRequest(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+.preTruncateTable(ObserverContext.createAndPrepare(CP_ENV, null),
TEST_TABLE.getTableName());
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8661//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8661//console
This message is automatically generated.
> Add truncate as HMaster method
> --
>
> Key: HBASE-8332
> URL: https://issues.apache.org/jira/browse/HBASE-8332
> Project: HBase
> Issue Type: Improvement
> Components: master
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Minor
> Attachments: HBASE-8332-v0.patch, HBASE-8332-v2.patch,
> HBASE-8332-v3.patch, HBASE-8332.draft.patch
>
>
> Currently truncate and truncate_preserve are only shell functions, and
> implemented as deleteTable() + createTable().
> Using ACLs the user running truncate, must have rights to create a table and
> only "global granted" users can create tables.
> Add truncate() and truncatePreserve() to HBaseAdmin/HMaster with its own ACL
> check.
> https://revi
[jira] [Commented] (HBASE-8332) Add truncate as HMaster method
[
https://issues.apache.org/jira/browse/HBASE-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897799#comment-13897799
]
Hadoop QA commented on HBASE-8332:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12628180/HBASE-8332-v3.patch
against trunk revision .
ATTACHMENT ID: 12628180
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 14 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+private TruncateTableRequest(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+private TruncateTableResponse(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+private EnableTableRequest(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+private EnableTableResponse(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+private DisableTableRequest(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+private DisableTableResponse(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+private ModifyTableRequest(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+.preTruncateTable(ObserverContext.createAndPrepare(CP_ENV, null),
TEST_TABLE.getTableName());
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8660//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8660//console
This message is automatically generated.
> Add truncate as HMaster method
> --
>
> Key: HBASE-8332
> URL: https://issues.apache.org/jira/browse/HBASE-8332
> Project: HBase
> Issue Type: Improvement
> Components: master
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Minor
> Attachments: HBASE-8332-v0.patch, HBASE-8332-v2.patch,
> HBASE-8332-v3.patch, HBASE-8332.draft.patch
>
>
> Currently truncate and truncate_preserve are only shell functions, and
> implemented as deleteTable() + createTable().
> Using ACLs the user running truncate, must have rights to create a table and
> only "global granted" users can create tables.
> Add truncate() and truncatePreserve() to HBaseAdmin/HMaster with its own ACL
> check.
> https:/
[jira] [Commented] (HBASE-8332) Add truncate as HMaster method
[
https://issues.apache.org/jira/browse/HBASE-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897161#comment-13897161
]
Hadoop QA commented on HBASE-8332:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12628055/HBASE-8332-v2.patch
against trunk revision .
ATTACHMENT ID: 12628055
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 11 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+private TruncateTableRequest(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+private TruncateTableResponse(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+private EnableTableRequest(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+private EnableTableResponse(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+private DisableTableRequest(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+private DisableTableResponse(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+private ModifyTableRequest(boolean noInit) { this.unknownFields =
com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
+ private void testTruncateTable(final TableName tableName, boolean
preserveSplits) throws IOException {
+ raise(ArgumentError, "BloomFilter type #{bloomtype} is not
supported. Use one of " +
org.apache.hadoop.hbase.regionserver.StoreFile::BloomType.constants.join(" "))
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestMasterObserver
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8652//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8652//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8652//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8652//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8652//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8652//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8652//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8652//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8652//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8652//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8652//console
This message is automatically generated.
> Add truncate as HMaster method
> --
>
> Key: HBASE-8332
> URL: https://issues.apache.org/jira/browse/HBASE-8332
> Project: HBase
> Issue Type: Improvement
> Components: master
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Minor
> Attachments: HBASE-8332-v0.patch, HBASE-8332-v2.patch,
> HBASE-8332.draft.patch
>
>
> Currently truncate and truncate_preserve are only shell functions, and
> implemented as deleteTable() + createTa
[jira] [Commented] (HBASE-8332) Add truncate as HMaster method
[ https://issues.apache.org/jira/browse/HBASE-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13831648#comment-13831648 ] Matteo Bertozzi commented on HBASE-8332: posted the patch on review board https://reviews.apache.org/r/15835/ > Add truncate as HMaster method > -- > > Key: HBASE-8332 > URL: https://issues.apache.org/jira/browse/HBASE-8332 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Attachments: HBASE-8332-v0.patch, HBASE-8332.draft.patch > > > Currently truncate and truncate_preserve are only shell functions, and > implemented as deleteTable() + createTable(). > Using ACLs the user running truncate, must have rights to create a table and > only "global granted" users can create tables. > Add truncate() and truncatePreserve() to HBaseAdmin/HMaster with its own ACL > check. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-8332) Add truncate as HMaster method
[
https://issues.apache.org/jira/browse/HBASE-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828208#comment-13828208
]
Jonathan Hsieh commented on HBASE-8332:
---
Since this is a new method on a public api, can we just choose a single method
instead of all the different flavors?
I prefer this one:
{code}
+ */
+ public void truncateTable(final TableName tableName) throws IOException {
+truncateTable(tableName, false);
+ }
{code}
...
Before I review more can you post to review board?
> Add truncate as HMaster method
> --
>
> Key: HBASE-8332
> URL: https://issues.apache.org/jira/browse/HBASE-8332
> Project: HBase
> Issue Type: Improvement
> Components: master
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Minor
> Attachments: HBASE-8332-v0.patch, HBASE-8332.draft.patch
>
>
> Currently truncate and truncate_preserve are only shell functions, and
> implemented as deleteTable() + createTable().
> Using ACLs the user running truncate, must have rights to create a table and
> only "global granted" users can create tables.
> Add truncate() and truncatePreserve() to HBaseAdmin/HMaster with its own ACL
> check.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-8332) Add truncate as HMaster method
[
https://issues.apache.org/jira/browse/HBASE-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824387#comment-13824387
]
Hadoop QA commented on HBASE-8332:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12614177/HBASE-8332-v0.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
10 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestMasterObserver
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7893//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7893//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7893//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7893//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7893//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7893//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7893//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7893//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7893//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7893//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7893//console
This message is automatically generated.
> Add truncate as HMaster method
> --
>
> Key: HBASE-8332
> URL: https://issues.apache.org/jira/browse/HBASE-8332
> Project: HBase
> Issue Type: Improvement
> Components: master
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Minor
> Attachments: HBASE-8332-v0.patch, HBASE-8332.draft.patch
>
>
> Currently truncate and truncate_preserve are only shell functions, and
> implemented as deleteTable() + createTable().
> Using ACLs the user running truncate, must have rights to create a table and
> only "global granted" users can create tables.
> Add truncate() and truncatePreserve() to HBaseAdmin/HMaster with its own ACL
> check.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-8332) Add truncate as HMaster method
[ https://issues.apache.org/jira/browse/HBASE-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13731835#comment-13731835 ] Liu Shaohui commented on HBASE-8332: [~mbertozzi] Some tips about the patch a, I think a sync truncate method in HbaseAdmin is better than a async one. b, TruncateTableHandler can reuse the CreateTableHandler code in recreateTable c. Truncate shoud keep acl info too. > Add truncate as HMaster method > -- > > Key: HBASE-8332 > URL: https://issues.apache.org/jira/browse/HBASE-8332 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Attachments: HBASE-8332.draft.patch > > > Currently truncate and truncate_preserve are only shell functions, and > implemented as deleteTable() + createTable(). > Using ACLs the user running truncate, must have rights to create a table and > only "global granted" users can create tables. > Add truncate() and truncatePreserve() to HBaseAdmin/HMaster with its own ACL > check. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8332) Add truncate as HMaster method
[ https://issues.apache.org/jira/browse/HBASE-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630097#comment-13630097 ] Jonathan Hsieh commented on HBASE-8332: --- We should also make sure we take the table lock to prevent races with enable/disable/alter while the truncate is happening. > Add truncate as HMaster method > -- > > Key: HBASE-8332 > URL: https://issues.apache.org/jira/browse/HBASE-8332 > Project: HBase > Issue Type: Improvement > Components: master >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Fix For: 0.95.1 > > > Currently truncate and truncate_preserve are only shell functions, and > implemented as deleteTable() + createTable(). > Using ACLs the user running truncate, must have rights to create a table and > only "global granted" users can create tables. > Add truncate() and truncatePreserve() to HBaseAdmin/HMaster with its own ACL > check. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
