[jira] [Commented] (HBASE-8532) Bootstrap based webui compatibility for IE.
[ https://issues.apache.org/jira/browse/HBASE-8532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655792#comment-13655792 ] Julian Zhou commented on HBASE-8532: Hi, [~jmspaggi], thanks if having a try on the patch on the trunk for IE 7. Feel that documenting the browsers supported should make sense for release. Bootstrap based webui compatibility for IE. --- Key: HBASE-8532 URL: https://issues.apache.org/jira/browse/HBASE-8532 Project: HBase Issue Type: Bug Components: UI Affects Versions: 0.98.0, 0.95.2 Reporter: Julian Zhou Assignee: Julian Zhou Priority: Minor Fix For: 0.98.0 Attachments: hbase-8532_v0.patch, webui-IE-error.png HBASE-7425 brings bootstrap based webui to hbase. While trying on trunk version, Firefox works well, but IE 8/9 layout and style look strange due to compatibility issue. Add !DOCTYPE html ... at the beginning of all jamon html/jsp templates to fix it. Seems HBase-2110 had a work to comment out the DOCTYPE for all .jsp to make the browser run the pages in Quirks mode (http://en.wikipedia.org/wiki/Quirks_mode) due to jetty issue at that time? To support the compatibility of webui across browsers (IE/Firefox/Chrome, etc.), there are some guidelines for choosing rendering the page under standard mode or quirk mode: http://en.wikipedia.org/wiki/Quirks_mode http://hsivonen.iki.fi/doctype/ According to document, !DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.1//EN http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd; has the most extensive compatibility even for HTML 5. According to my test, add this could make webui works in IE (standard mode), while Firefox could not work well with styles. Looks like if in Firefox, we still need the quirk mode (no DOCTYPE declaration). So just adding conditional DOCTYPE declaration for IE, !--[if IE] !DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.1//EN http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd; ![endif]-- this could make webui works for both IE and Firefox, also for Chrome and other browsers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8532) Bootstrap based webui compatibility for IE.
[ https://issues.apache.org/jira/browse/HBASE-8532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655535#comment-13655535 ] Julian Zhou commented on HBASE-8532: Hi Jean-Marc, Yes, the issue is for IE, so added conditional DOCTYPE for IE. I only got IE 8/9, could not find IE version older than 7 (including 7) :-(. Maybe that's the case for most of PC users. Other browser works fine including Firefox 20.0.1, Chrome 26.0.1410.64 (other browsers with Webkit engine should be ok as well), Opera 12.15, Safari 5.1.9. Bootstrap based webui compatibility for IE. --- Key: HBASE-8532 URL: https://issues.apache.org/jira/browse/HBASE-8532 Project: HBase Issue Type: Bug Components: UI Affects Versions: 0.98.0, 0.95.2 Reporter: Julian Zhou Assignee: Julian Zhou Priority: Minor Fix For: 0.98.0 Attachments: hbase-8532_v0.patch, webui-IE-error.png HBASE-7425 brings bootstrap based webui to hbase. While trying on trunk version, Firefox works well, but IE 8/9 layout and style look strange due to compatibility issue. Add !DOCTYPE html ... at the beginning of all jamon html/jsp templates to fix it. Seems HBase-2110 had a work to comment out the DOCTYPE for all .jsp to make the browser run the pages in Quirks mode (http://en.wikipedia.org/wiki/Quirks_mode) due to jetty issue at that time? To support the compatibility of webui across browsers (IE/Firefox/Chrome, etc.), there are some guidelines for choosing rendering the page under standard mode or quirk mode: http://en.wikipedia.org/wiki/Quirks_mode http://hsivonen.iki.fi/doctype/ According to document, !DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.1//EN http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd; has the most extensive compatibility even for HTML 5. According to my test, add this could make webui works in IE (standard mode), while Firefox could not work well with styles. Looks like if in Firefox, we still need the quirk mode (no DOCTYPE declaration). So just adding conditional DOCTYPE declaration for IE, !--[if IE] !DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.1//EN http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd; ![endif]-- this could make webui works for both IE and Firefox, also for Chrome and other browsers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8532) Bootstrap based webui compatibility for IE.
[ https://issues.apache.org/jira/browse/HBASE-8532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1363#comment-1363 ] Jean-Marc Spaggiari commented on HBASE-8532: I have access to a IE7 if we want. But the real question should be do we want to support IE7? I mean, it's a pretty old version of IE, should we have an official list of supporter browsers for the WEBUIs? Bootstrap based webui compatibility for IE. --- Key: HBASE-8532 URL: https://issues.apache.org/jira/browse/HBASE-8532 Project: HBase Issue Type: Bug Components: UI Affects Versions: 0.98.0, 0.95.2 Reporter: Julian Zhou Assignee: Julian Zhou Priority: Minor Fix For: 0.98.0 Attachments: hbase-8532_v0.patch, webui-IE-error.png HBASE-7425 brings bootstrap based webui to hbase. While trying on trunk version, Firefox works well, but IE 8/9 layout and style look strange due to compatibility issue. Add !DOCTYPE html ... at the beginning of all jamon html/jsp templates to fix it. Seems HBase-2110 had a work to comment out the DOCTYPE for all .jsp to make the browser run the pages in Quirks mode (http://en.wikipedia.org/wiki/Quirks_mode) due to jetty issue at that time? To support the compatibility of webui across browsers (IE/Firefox/Chrome, etc.), there are some guidelines for choosing rendering the page under standard mode or quirk mode: http://en.wikipedia.org/wiki/Quirks_mode http://hsivonen.iki.fi/doctype/ According to document, !DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.1//EN http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd; has the most extensive compatibility even for HTML 5. According to my test, add this could make webui works in IE (standard mode), while Firefox could not work well with styles. Looks like if in Firefox, we still need the quirk mode (no DOCTYPE declaration). So just adding conditional DOCTYPE declaration for IE, !--[if IE] !DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.1//EN http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd; ![endif]-- this could make webui works for both IE and Firefox, also for Chrome and other browsers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8532) Bootstrap based webui compatibility for IE.
[
https://issues.apache.org/jira/browse/HBASE-8532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655562#comment-13655562
]
Hadoop QA commented on HBASE-8532:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12582835/hbase-8532_v0.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.security.access.TestAccessController
org.apache.hadoop.hbase.client.TestHCM
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5646//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5646//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5646//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5646//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5646//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5646//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5646//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5646//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5646//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5646//console
This message is automatically generated.
Bootstrap based webui compatibility for IE.
---
Key: HBASE-8532
URL: https://issues.apache.org/jira/browse/HBASE-8532
Project: HBase
Issue Type: Bug
Components: UI
Affects Versions: 0.98.0, 0.95.2
Reporter: Julian Zhou
Assignee: Julian Zhou
Priority: Minor
Fix For: 0.98.0
Attachments: hbase-8532_v0.patch, webui-IE-error.png
HBASE-7425 brings bootstrap based webui to hbase. While trying on trunk
version, Firefox works well, but IE 8/9 layout and style look strange due to
compatibility issue. Add !DOCTYPE html ... at the beginning of all jamon
html/jsp templates to fix it.
Seems HBase-2110 had a work to comment out the DOCTYPE for all .jsp to make
the browser run the pages in Quirks mode
(http://en.wikipedia.org/wiki/Quirks_mode) due to jetty issue at that time?
To support the compatibility of webui across browsers (IE/Firefox/Chrome,
etc.), there are some guidelines for choosing rendering the page under
standard mode or quirk mode:
http://en.wikipedia.org/wiki/Quirks_mode
http://hsivonen.iki.fi/doctype/
According to document, !DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.1//EN
http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd; has the most extensive
compatibility even for HTML 5. According to my test, add this could make
webui works in IE (standard mode), while Firefox could not work well with
styles. Looks like if in Firefox, we still need the quirk mode (no DOCTYPE
declaration).
So just adding conditional DOCTYPE declaration for IE,
!--[if IE]
!DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.1//EN
