[jira] [Commented] (HBASE-8631) Meta Region First Recovery

2013-05-31 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13671293#comment-13671293
 ] 

Hudson commented on HBASE-8631:
---

Integrated in hbase-0.95-on-hadoop2 #118 (See 
[https://builds.apache.org/job/hbase-0.95-on-hadoop2/118/])
HBASE-8631 Meta Region First Recovery (Revision 1487940)

 Result = FAILURE
stack : 
Files : 
* 
/hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
* 
/hbase/branches/0.95/hbase-it/src/test/java/org/apache/hadoop/hbase/IngestIntegrationTestBase.java
* 
/hbase/branches/0.95/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestDataIngestWithChaosMonkey.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtil.java
* 
/hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java


 Meta Region First Recovery
 --

 Key: HBASE-8631
 URL: https://issues.apache.org/jira/browse/HBASE-8631
 Project: HBase
  Issue Type: Bug
  Components: MTTR
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Fix For: 0.98.0, 0.95.1

 Attachments: hbase-8631.patch, hbase-8631-v2.patch, 
 hbase-8631-v3.patch, hbase-8631-v4.patch


 We have a separate wal for meta region. While log splitting logic haven't 
 taken the advantage of this and splitlogworker still picks a wal file 
 randomly. Imaging if we have multiple region servers including meta RS fails 
 about the same time while meta wal is recovered last, all failed regions have 
 to wait meta recovered and then can be online again. 
 The open JIRA is to let splitlogworker to pick a meta wal file firstly and 
 then others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-8631) Meta Region First Recovery

2013-05-31 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13671338#comment-13671338
 ] 

Hudson commented on HBASE-8631:
---

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #549 (See 
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/549/])
HBASE-8631 Meta Region First Recovery (Revision 1487939)

 Result = FAILURE
stack : 
Files : 
* 
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
* 
/hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IngestIntegrationTestBase.java
* 
/hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestDataIngestWithChaosMonkey.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtil.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java


 Meta Region First Recovery
 --

 Key: HBASE-8631
 URL: https://issues.apache.org/jira/browse/HBASE-8631
 Project: HBase
  Issue Type: Bug
  Components: MTTR
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Fix For: 0.98.0, 0.95.1

 Attachments: hbase-8631.patch, hbase-8631-v2.patch, 
 hbase-8631-v3.patch, hbase-8631-v4.patch


 We have a separate wal for meta region. While log splitting logic haven't 
 taken the advantage of this and splitlogworker still picks a wal file 
 randomly. Imaging if we have multiple region servers including meta RS fails 
 about the same time while meta wal is recovered last, all failed regions have 
 to wait meta recovered and then can be online again. 
 The open JIRA is to let splitlogworker to pick a meta wal file firstly and 
 then others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-8631) Meta Region First Recovery

2013-05-30 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670126#comment-13670126
 ] 

Hadoop QA commented on HBASE-8631:
--

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12585366/hbase-8631-v4.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 9 new 
or modified tests.

{color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5877//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5877//console

This message is automatically generated.

 Meta Region First Recovery
 --

 Key: HBASE-8631
 URL: https://issues.apache.org/jira/browse/HBASE-8631
 Project: HBase
  Issue Type: Bug
  Components: MTTR
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Attachments: hbase-8631.patch, hbase-8631-v2.patch, 
 hbase-8631-v3.patch, hbase-8631-v4.patch


 We have a separate wal for meta region. While log splitting logic haven't 
 taken the advantage of this and splitlogworker still picks a wal file 
 randomly. Imaging if we have multiple region servers including meta RS fails 
 about the same time while meta wal is recovered last, all failed regions have 
 to wait meta recovered and then can be online again. 
 The open JIRA is to let splitlogworker to pick a meta wal file firstly and 
 then others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-8631) Meta Region First Recovery

2013-05-30 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670162#comment-13670162
 ] 

Hadoop QA commented on HBASE-8631:
--

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12585374/hbase-8631-v4.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 9 new 
or modified tests.

{color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5878//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5878//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5878//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5878//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5878//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5878//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5878//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5878//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5878//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5878//console

This message is automatically generated.

 Meta Region First Recovery
 --

 Key: HBASE-8631
 URL: https://issues.apache.org/jira/browse/HBASE-8631
 Project: HBase
  Issue Type: Bug
  Components: MTTR
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Attachments: hbase-8631.patch, hbase-8631-v2.patch, 
 hbase-8631-v3.patch, hbase-8631-v4.patch


 We have a separate wal for meta region. While log splitting logic haven't 
 taken the advantage of this and splitlogworker still picks a wal file 
 randomly. Imaging if we have multiple region servers including meta RS fails 
 about the same time while meta wal is recovered last, all failed regions have 
 to wait meta recovered and then can be online again. 
 The open JIRA is to let splitlogworker to pick a meta wal file firstly and 
 then others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-8631) Meta Region First Recovery

2013-05-30 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670178#comment-13670178
 ] 

Ted Yu commented on HBASE-8631:
---

+1

 Meta Region First Recovery
 --

 Key: HBASE-8631
 URL: https://issues.apache.org/jira/browse/HBASE-8631
 Project: HBase
  Issue Type: Bug
  Components: MTTR
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Attachments: hbase-8631.patch, hbase-8631-v2.patch, 
 hbase-8631-v3.patch, hbase-8631-v4.patch


 We have a separate wal for meta region. While log splitting logic haven't 
 taken the advantage of this and splitlogworker still picks a wal file 
 randomly. Imaging if we have multiple region servers including meta RS fails 
 about the same time while meta wal is recovered last, all failed regions have 
 to wait meta recovered and then can be online again. 
 The open JIRA is to let splitlogworker to pick a meta wal file firstly and 
 then others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-8631) Meta Region First Recovery

2013-05-30 Thread Jeffrey Zhong (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670485#comment-13670485
 ] 

Jeffrey Zhong commented on HBASE-8631:
--

[~saint@gmail.com] Could this patch be check in 0.95 which fixes the issues 
found in my integration tests of hbase-7006? Thanks.

 Meta Region First Recovery
 --

 Key: HBASE-8631
 URL: https://issues.apache.org/jira/browse/HBASE-8631
 Project: HBase
  Issue Type: Bug
  Components: MTTR
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Attachments: hbase-8631.patch, hbase-8631-v2.patch, 
 hbase-8631-v3.patch, hbase-8631-v4.patch


 We have a separate wal for meta region. While log splitting logic haven't 
 taken the advantage of this and splitlogworker still picks a wal file 
 randomly. Imaging if we have multiple region servers including meta RS fails 
 about the same time while meta wal is recovered last, all failed regions have 
 to wait meta recovered and then can be online again. 
 The open JIRA is to let splitlogworker to pick a meta wal file firstly and 
 then others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-8631) Meta Region First Recovery

2013-05-30 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670905#comment-13670905
 ] 

Hudson commented on HBASE-8631:
---

Integrated in HBase-TRUNK #4151 (See 
[https://builds.apache.org/job/HBase-TRUNK/4151/])
HBASE-8631 Meta Region First Recovery (Revision 1487939)

 Result = FAILURE
stack : 
Files : 
* 
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
* 
/hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IngestIntegrationTestBase.java
* 
/hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestDataIngestWithChaosMonkey.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtil.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java


 Meta Region First Recovery
 --

 Key: HBASE-8631
 URL: https://issues.apache.org/jira/browse/HBASE-8631
 Project: HBase
  Issue Type: Bug
  Components: MTTR
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Fix For: 0.98.0, 0.95.1

 Attachments: hbase-8631.patch, hbase-8631-v2.patch, 
 hbase-8631-v3.patch, hbase-8631-v4.patch


 We have a separate wal for meta region. While log splitting logic haven't 
 taken the advantage of this and splitlogworker still picks a wal file 
 randomly. Imaging if we have multiple region servers including meta RS fails 
 about the same time while meta wal is recovered last, all failed regions have 
 to wait meta recovered and then can be online again. 
 The open JIRA is to let splitlogworker to pick a meta wal file firstly and 
 then others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-8631) Meta Region First Recovery

2013-05-30 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13671038#comment-13671038
 ] 

Hudson commented on HBASE-8631:
---

Integrated in hbase-0.95 #222 (See 
[https://builds.apache.org/job/hbase-0.95/222/])
HBASE-8631 Meta Region First Recovery (Revision 1487940)

 Result = SUCCESS
stack : 
Files : 
* 
/hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
* 
/hbase/branches/0.95/hbase-it/src/test/java/org/apache/hadoop/hbase/IngestIntegrationTestBase.java
* 
/hbase/branches/0.95/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestDataIngestWithChaosMonkey.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtil.java
* 
/hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java


 Meta Region First Recovery
 --

 Key: HBASE-8631
 URL: https://issues.apache.org/jira/browse/HBASE-8631
 Project: HBase
  Issue Type: Bug
  Components: MTTR
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Fix For: 0.98.0, 0.95.1

 Attachments: hbase-8631.patch, hbase-8631-v2.patch, 
 hbase-8631-v3.patch, hbase-8631-v4.patch


 We have a separate wal for meta region. While log splitting logic haven't 
 taken the advantage of this and splitlogworker still picks a wal file 
 randomly. Imaging if we have multiple region servers including meta RS fails 
 about the same time while meta wal is recovered last, all failed regions have 
 to wait meta recovered and then can be online again. 
 The open JIRA is to let splitlogworker to pick a meta wal file firstly and 
 then others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-8631) Meta Region First Recovery

2013-05-29 Thread Jeffrey Zhong (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669526#comment-13669526
 ] 

Jeffrey Zhong commented on HBASE-8631:
--

Could someone else please review the path? The patch solves the issue that 
recovery sometimes may get stuck because meta isn't available from integration 
tests on distributedLogReplay. Thanks.

 Meta Region First Recovery
 --

 Key: HBASE-8631
 URL: https://issues.apache.org/jira/browse/HBASE-8631
 Project: HBase
  Issue Type: Bug
  Components: MTTR
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Attachments: hbase-8631.patch, hbase-8631-v2.patch


 We have a separate wal for meta region. While log splitting logic haven't 
 taken the advantage of this and splitlogworker still picks a wal file 
 randomly. Imaging if we have multiple region servers including meta RS fails 
 about the same time while meta wal is recovered last, all failed regions have 
 to wait meta recovered and then can be online again. 
 The open JIRA is to let splitlogworker to pick a meta wal file firstly and 
 then others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-8631) Meta Region First Recovery

2013-05-29 Thread Devaraj Das (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669784#comment-13669784
 ] 

Devaraj Das commented on HBASE-8631:


Some comments:
1. Are the timeout related changes in HLogSplitter relevant to this issue?
2. _if (filter != null  filter == MasterFileSystem.META_FILTER _ - No need 
for a null check?
3. removeRecoveringRegionsFromZK now has a new argument called carryingMeta. 
The name of the argument should be changed to better reflect the usage.
4. See if you can add unit tests for the issues.

 Meta Region First Recovery
 --

 Key: HBASE-8631
 URL: https://issues.apache.org/jira/browse/HBASE-8631
 Project: HBase
  Issue Type: Bug
  Components: MTTR
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Attachments: hbase-8631.patch, hbase-8631-v2.patch


 We have a separate wal for meta region. While log splitting logic haven't 
 taken the advantage of this and splitlogworker still picks a wal file 
 randomly. Imaging if we have multiple region servers including meta RS fails 
 about the same time while meta wal is recovered last, all failed regions have 
 to wait meta recovered and then can be online again. 
 The open JIRA is to let splitlogworker to pick a meta wal file firstly and 
 then others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-8631) Meta Region First Recovery

2013-05-29 Thread Devaraj Das (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669978#comment-13669978
 ] 

Devaraj Das commented on HBASE-8631:


+1 ... Please commit this to 0.95.x branch as well.

 Meta Region First Recovery
 --

 Key: HBASE-8631
 URL: https://issues.apache.org/jira/browse/HBASE-8631
 Project: HBase
  Issue Type: Bug
  Components: MTTR
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Attachments: hbase-8631.patch, hbase-8631-v2.patch, 
 hbase-8631-v3.patch


 We have a separate wal for meta region. While log splitting logic haven't 
 taken the advantage of this and splitlogworker still picks a wal file 
 randomly. Imaging if we have multiple region servers including meta RS fails 
 about the same time while meta wal is recovered last, all failed regions have 
 to wait meta recovered and then can be online again. 
 The open JIRA is to let splitlogworker to pick a meta wal file firstly and 
 then others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-8631) Meta Region First Recovery

2013-05-29 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669984#comment-13669984
 ] 

Hadoop QA commented on HBASE-8631:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12585346/hbase-8631-v3.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 9 new 
or modified tests.

{color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   
org.apache.hadoop.hbase.master.TestDistributedLogSplitting

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5873//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5873//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5873//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5873//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5873//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5873//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5873//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5873//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5873//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5873//console

This message is automatically generated.

 Meta Region First Recovery
 --

 Key: HBASE-8631
 URL: https://issues.apache.org/jira/browse/HBASE-8631
 Project: HBase
  Issue Type: Bug
  Components: MTTR
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Attachments: hbase-8631.patch, hbase-8631-v2.patch, 
 hbase-8631-v3.patch


 We have a separate wal for meta region. While log splitting logic haven't 
 taken the advantage of this and splitlogworker still picks a wal file 
 randomly. Imaging if we have multiple region servers including meta RS fails 
 about the same time while meta wal is recovered last, all failed regions have 
 to wait meta recovered and then can be online again. 
 The open JIRA is to let splitlogworker to pick a meta wal file firstly and 
 then others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-8631) Meta Region First Recovery

2013-05-28 Thread Himanshu Vashishtha (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13668548#comment-13668548
 ] 

Himanshu Vashishtha commented on HBASE-8631:


I think it is handled in the MetaServerShutdownHandler's process()?

 Meta Region First Recovery
 --

 Key: HBASE-8631
 URL: https://issues.apache.org/jira/browse/HBASE-8631
 Project: HBase
  Issue Type: Bug
  Components: MTTR
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong

 We have a separate wal for meta region. While log splitting logic haven't 
 taken the advantage of this and splitlogworker still picks a wal file 
 randomly. Imaging if we have multiple region servers including meta RS fails 
 about the same time while meta wal is recovered last, all failed regions have 
 to wait meta recovered and then can be online again. 
 The open JIRA is to let splitlogworker to pick a meta wal file firstly and 
 then others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-8631) Meta Region First Recovery

2013-05-28 Thread Jeffrey Zhong (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13668558#comment-13668558
 ] 

Jeffrey Zhong commented on HBASE-8631:
--

{quote}
I think it is handled in the MetaServerShutdownHandler's process()?
{quote}
MetaSSH can deal with one RS failure which put meta wal firstly. While even in 
that case, if we already have bunch of wals files in log splitting process, it 
still has issue.

 Meta Region First Recovery
 --

 Key: HBASE-8631
 URL: https://issues.apache.org/jira/browse/HBASE-8631
 Project: HBase
  Issue Type: Bug
  Components: MTTR
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong

 We have a separate wal for meta region. While log splitting logic haven't 
 taken the advantage of this and splitlogworker still picks a wal file 
 randomly. Imaging if we have multiple region servers including meta RS fails 
 about the same time while meta wal is recovered last, all failed regions have 
 to wait meta recovered and then can be online again. 
 The open JIRA is to let splitlogworker to pick a meta wal file firstly and 
 then others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-8631) Meta Region First Recovery

2013-05-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13668636#comment-13668636
 ] 

Hadoop QA commented on HBASE-8631:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12585062/hbase-8631.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 6 new 
or modified tests.

{color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   
org.apache.hadoop.hbase.security.access.TestAccessController

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5852//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5852//console

This message is automatically generated.

 Meta Region First Recovery
 --

 Key: HBASE-8631
 URL: https://issues.apache.org/jira/browse/HBASE-8631
 Project: HBase
  Issue Type: Bug
  Components: MTTR
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Attachments: hbase-8631.patch


 We have a separate wal for meta region. While log splitting logic haven't 
 taken the advantage of this and splitlogworker still picks a wal file 
 randomly. Imaging if we have multiple region servers including meta RS fails 
 about the same time while meta wal is recovered last, all failed regions have 
 to wait meta recovered and then can be online again. 
 The open JIRA is to let splitlogworker to pick a meta wal file firstly and 
 then others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-8631) Meta Region First Recovery

2013-05-28 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13668649#comment-13668649
 ] 

Ted Yu commented on HBASE-8631:
---

{code}
+  // we split meta regions and user regions separately therefore logfiles 
are either all for
{code}
'meta regions' - 'meta region'
{code}
+if (carryingMeta  
!region.equalsIgnoreCase(metaEncodeRegionName)) {
+  // skip non-meta regions because we recover meta regions and 
user regions in
+  // two separate calls.
+  continue;
+} else if (!carryingMeta  
region.equalsIgnoreCase(metaEncodeRegionName)) {
{code}
The conditions for above two checks can be unified, right ?
{code}
carryingMeta != region.equalsIgnoreCase(metaEncodeRegionName)
{code}
{code}
-SetServerName previouslyFailedDeletoins = null;
+ListPairSetServerName, Boolean previouslyFailedDeletoins = null;
{code}
typo: Deletoin
{code}
+// set a smaller retries to fast fail otherwise splitlogworker 
could be blocked for
+// quite a while inside HConnection layer. The worker won't 
available for other
+// tasks even after current task is preempted after a split task 
times out.
{code}
Should the new conf be created inside LogReplayOutputSink ctor ?

 Meta Region First Recovery
 --

 Key: HBASE-8631
 URL: https://issues.apache.org/jira/browse/HBASE-8631
 Project: HBase
  Issue Type: Bug
  Components: MTTR
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Attachments: hbase-8631.patch


 We have a separate wal for meta region. While log splitting logic haven't 
 taken the advantage of this and splitlogworker still picks a wal file 
 randomly. Imaging if we have multiple region servers including meta RS fails 
 about the same time while meta wal is recovered last, all failed regions have 
 to wait meta recovered and then can be online again. 
 The open JIRA is to let splitlogworker to pick a meta wal file firstly and 
 then others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-8631) Meta Region First Recovery

2013-05-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13668861#comment-13668861
 ] 

Hadoop QA commented on HBASE-8631:
--

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12585116/hbase-8631-v2.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 6 new 
or modified tests.

{color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5856//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5856//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5856//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5856//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5856//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5856//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5856//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5856//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5856//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5856//console

This message is automatically generated.

 Meta Region First Recovery
 --

 Key: HBASE-8631
 URL: https://issues.apache.org/jira/browse/HBASE-8631
 Project: HBase
  Issue Type: Bug
  Components: MTTR
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Attachments: hbase-8631.patch, hbase-8631-v2.patch


 We have a separate wal for meta region. While log splitting logic haven't 
 taken the advantage of this and splitlogworker still picks a wal file 
 randomly. Imaging if we have multiple region servers including meta RS fails 
 about the same time while meta wal is recovered last, all failed regions have 
 to wait meta recovered and then can be online again. 
 The open JIRA is to let splitlogworker to pick a meta wal file firstly and 
 then others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-8631) Meta Region First Recovery

2013-05-28 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1366#comment-1366
 ] 

Ted Yu commented on HBASE-8631:
---

+1

 Meta Region First Recovery
 --

 Key: HBASE-8631
 URL: https://issues.apache.org/jira/browse/HBASE-8631
 Project: HBase
  Issue Type: Bug
  Components: MTTR
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Attachments: hbase-8631.patch, hbase-8631-v2.patch


 We have a separate wal for meta region. While log splitting logic haven't 
 taken the advantage of this and splitlogworker still picks a wal file 
 randomly. Imaging if we have multiple region servers including meta RS fails 
 about the same time while meta wal is recovered last, all failed regions have 
 to wait meta recovered and then can be online again. 
 The open JIRA is to let splitlogworker to pick a meta wal file firstly and 
 then others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira