[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13713191#comment-13713191 ] Hudson commented on HBASE-8928: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #623 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/623/]) HBASE-8928: Make ChaosMonkey & LoadTest tools extensible (Gautam Soni) (jyates: rev 1504609) * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/util/ChaosMonkey.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: gautam > Fix For: 0.98.0, 0.95.2, 0.94.10 > > Attachments: HBASE-8928-0.94.patch, HBASE-8928-trunk.patch > > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13713169#comment-13713169 ] Hudson commented on HBASE-8928: --- FAILURE: Integrated in hbase-0.95-on-hadoop2 #185 (See [https://builds.apache.org/job/hbase-0.95-on-hadoop2/185/]) HBASE-8928: Make ChaosMonkey & LoadTest tools extensible (Gautam Soni) (jyates: rev 1504614) * /hbase/branches/0.95/hbase-it/src/test/java/org/apache/hadoop/hbase/util/ChaosMonkey.java * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: gautam > Fix For: 0.98.0, 0.95.2, 0.94.10 > > Attachments: HBASE-8928-0.94.patch, HBASE-8928-trunk.patch > > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13713127#comment-13713127 ] Hudson commented on HBASE-8928: --- FAILURE: Integrated in HBase-TRUNK #4270 (See [https://builds.apache.org/job/HBase-TRUNK/4270/]) HBASE-8928: Make ChaosMonkey & LoadTest tools extensible (Gautam Soni) (jyates: rev 1504609) * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/util/ChaosMonkey.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: gautam > Fix For: 0.98.0, 0.95.2, 0.94.10 > > Attachments: HBASE-8928-0.94.patch, HBASE-8928-trunk.patch > > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13713062#comment-13713062 ] Hudson commented on HBASE-8928: --- SUCCESS: Integrated in hbase-0.95 #339 (See [https://builds.apache.org/job/hbase-0.95/339/]) HBASE-8928: Make ChaosMonkey & LoadTest tools extensible (Gautam Soni) (jyates: rev 1504614) * /hbase/branches/0.95/hbase-it/src/test/java/org/apache/hadoop/hbase/util/ChaosMonkey.java * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: gautam > Fix For: 0.98.0, 0.95.2, 0.94.10 > > Attachments: HBASE-8928-0.94.patch, HBASE-8928-trunk.patch > > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712749#comment-13712749 ] Hudson commented on HBASE-8928: --- SUCCESS: Integrated in HBase-0.94 #1063 (See [https://builds.apache.org/job/HBase-0.94/1063/]) HBASE-8928: Make ChaosMonkey & LoadTest tools extensible (Gautam Soni) (jyates: rev 1504602) * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/ChaosMonkey.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: gautam > Fix For: 0.98.0, 0.95.2, 0.94.10 > > Attachments: HBASE-8928-0.94.patch, HBASE-8928-trunk.patch > > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712747#comment-13712747 ] Hudson commented on HBASE-8928: --- SUCCESS: Integrated in HBase-0.94-security #218 (See [https://builds.apache.org/job/HBase-0.94-security/218/]) HBASE-8928: Make ChaosMonkey & LoadTest tools extensible (Gautam Soni) (jyates: rev 1504602) * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/ChaosMonkey.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: gautam > Fix For: 0.98.0, 0.95.2, 0.94.10 > > Attachments: HBASE-8928-0.94.patch, HBASE-8928-trunk.patch > > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712652#comment-13712652 ] Jesse Yates commented on HBASE-8928: Doing it now, ironhand :) > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: gautam > Fix For: 0.98.0, 0.95.2, 0.94.10 > > Attachments: HBASE-8928-0.94.patch, HBASE-8928-trunk.patch > > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712633#comment-13712633 ] Lars Hofhansl commented on HBASE-8928: -- You going to commit [~jesse_yates]? > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: gautam > Fix For: 0.98.0, 0.95.2, 0.94.10 > > Attachments: HBASE-8928-0.94.patch, HBASE-8928-trunk.patch > > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13711959#comment-13711959 ] Lars Hofhansl commented on HBASE-8928: -- +1 > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: gautam > Fix For: 0.98.0, 0.95.2, 0.94.10 > > Attachments: HBASE-8928-0.94.patch, HBASE-8928-trunk.patch > > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13711572#comment-13711572 ] Enis Soztutar commented on HBASE-8928: -- +1. > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: gautam > Attachments: HBASE-8928-0.94.patch, HBASE-8928-trunk.patch > > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13711562#comment-13711562 ] Jesse Yates commented on HBASE-8928: Cool, I'll look to commit then tomorrow morning. > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: gautam > Attachments: HBASE-8928-0.94.patch, HBASE-8928-trunk.patch > > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13711234#comment-13711234 ] Elliott Clark commented on HBASE-8928: -- +1 > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: Enis Soztutar > Attachments: HBASE-8928-0.94.patch, HBASE-8928-trunk.patch > > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13711222#comment-13711222 ] Jesse Yates commented on HBASE-8928: +1 LGTM. Any more comments [~eclark] or [~enis]? > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: Enis Soztutar > Attachments: HBASE-8928-0.94.patch, HBASE-8928-trunk.patch > > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13709954#comment-13709954 ] Jesse Yates commented on HBASE-8928: Does the trunk patch apply for 0.95 as well? otherwise, LGTM > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: Enis Soztutar > Attachments: HBASE-8928-0.94.patch, HBASE-8928-trunk.patch > > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[
https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13709923#comment-13709923
]
Jesse Yates commented on HBASE-8928:
Looks like the visibility stuff for ChaosMonkey already exist in tip of 0.94,
except for:
{code}
/**
* A context for a Policy
*/
- private static class PolicyContext extends ActionContext {
-PolicyContext(IntegrationTestingUtility util) {
+ public static class PolicyContext extends ActionContext {
+public PolicyContext(IntegrationTestingUtility util) {
super(util);
}
}
@@ -440,7 +441,8 @@ public class ChaosMonkey extends AbstractHBaseTool
implements Stoppable {
* A policy to introduce chaos to the cluster
*/
public static abstract class Policy extends StoppableImplementation
implements Runnable {
-PolicyContext context;
+protected PolicyContext context;
+
public void init(PolicyContext context) throws Exception {
this.context = context;
}
{code}
Which is out of date for the current state of 0.94; want to take another look?
LoadTest visibilities looks good to me for 0.94.
> Make ChaosMonkey & LoadTest tools extensible, to allow addition of more
> actions and policies.
> -
>
> Key: HBASE-8928
> URL: https://issues.apache.org/jira/browse/HBASE-8928
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 0.95.2
>Reporter: gautam
>Assignee: Enis Soztutar
> Attachments: HBASE-8928-0.94.patch, HBASE-8928-trunk.patch
>
>
> Let me split this requirement into 2 parts:
> i) ChaosMonkey
> I was trying to add more tests around new actions and policies by leveraging
> the existing classes nested inside ChaosMonkey.
> But it turned out that some of the classes cannot be used outside, unless we
> make those visible to the world.
> Here is an example:
> I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method
> has package-wide visibility.
> There are other places as well which makes it impossible for anyone to extend
> on top of this hierarchy.
> ii) LoadTestTool
> I wanted to extend this tool to define failure/pass criteria based on % of
> read/write failed, rather than comparing against absolute 0.
> For that this beautiful class should mark some of its properties usable by
> its child, by marking those protected.
> I wanted to get unblocked here first.
> Once this gets fixed, I think I can take up a JIRA item to refactor these
> tools, if required.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708314#comment-13708314 ] gautam commented on HBASE-8928: --- Here is the pull request. Again to avoid any confusion here: https://github.com/apache/hbase/pull/5 is over "trunk" branch https://github.com/apache/hbase/pull/4 is over "0.94" branch Elliott, I think you merged the "0.94" branch changes over trunk, hence it didnt work. > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: Enis Soztutar > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706543#comment-13706543 ] gautam commented on HBASE-8928: --- I picked up the latest 94.0 branch. May I know which one do I pick up for the latest changes? > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: Enis Soztutar > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706063#comment-13706063 ] Elliott Clark commented on HBASE-8928: -- Some of the ChaosMonkey.Action stuff might have been fixed since you last looked at it. I committed code just a little while ago that opened up some of the visibilities. > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: Enis Soztutar > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705654#comment-13705654 ] gautam commented on HBASE-8928: --- I have added a pull request for this change here: https://github.com/apache/hbase/pull/4 > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: Enis Soztutar > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705626#comment-13705626 ] gautam commented on HBASE-8928: --- Again I wont change LoadTest tool per se, I will add another tool, you can say LoadTestWithTolerance extending this tool. The only change I will be doing is to make the properties protected to be usable by my tool. > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: Enis Soztutar > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705623#comment-13705623 ] gautam commented on HBASE-8928: --- Yes, for CM I will post the changes for review. For Policies I was trying to add Periodic Sequential policy, which at the moment I cant see. For LoadTestTool, I wanted to relax the verification criteria as I have observed that even if 1 write has failed out of say 1 million write operations, the test fails. I wanted to move it to percentile for the new actions where I will be using this framework. > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: Enis Soztutar > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools, if required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8928) Make ChaosMonkey & LoadTest tools extensible, to allow addition of more actions and policies.
[ https://issues.apache.org/jira/browse/HBASE-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705609#comment-13705609 ] Enis Soztutar commented on HBASE-8928: -- For CM action and policy classes, I think we can make them public. What kind of policies are you trying to add. For LoadTestTool, I think we would still require non of the operations to fail. Why would you want to relax the verification? > Make ChaosMonkey & LoadTest tools extensible, to allow addition of more > actions and policies. > - > > Key: HBASE-8928 > URL: https://issues.apache.org/jira/browse/HBASE-8928 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 0.95.2 >Reporter: gautam >Assignee: Enis Soztutar > > Let me split this requirement into 2 parts: > i) ChaosMonkey > I was trying to add more tests around new actions and policies by leveraging > the existing classes nested inside ChaosMonkey. > But it turned out that some of the classes cannot be used outside, unless we > make those visible to the world. > Here is an example: > I cannot extend ChaosMonkey.Action, as the init(ActionContext context) method > has package-wide visibility. > There are other places as well which makes it impossible for anyone to extend > on top of this hierarchy. > ii) LoadTestTool > I wanted to extend this tool to define failure/pass criteria based on % of > read/write failed, rather than comparing against absolute 0. > For that this beautiful class should mark some of its properties usable by > its child, by marking those protected. > I wanted to get unblocked here first. > Once this gets fixed, I think I can take up a JIRA item to refactor these > tools. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
