[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824962#comment-13824962
]
Nick Dimiduk commented on HBASE-9165:
-
Yeah, it's fine. Wish there was a way to include the check, but without an
integration test I don't think we can.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.94.01.patch, HBASE-9165-0.96.00.patch,
> HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824959#comment-13824959
]
Lars Hofhansl commented on HBASE-9165:
--
NP :)
Are you OK with my "fix"? Just removed the test for HBase in tmpjars.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.94.01.patch, HBASE-9165-0.96.00.patch,
> HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824952#comment-13824952
]
Nick Dimiduk commented on HBASE-9165:
-
This test is on 0.96 and trunk, but as an integration test. Sorry for the
mistake.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.94.01.patch, HBASE-9165-0.96.00.patch,
> HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824780#comment-13824780
]
Hudson commented on HBASE-9165:
---
SUCCESS: Integrated in HBase-0.94 #1204 (See
[https://builds.apache.org/job/HBase-0.94/1204/])
HBASE-9165 Addendum, fix TestTableMapreduce (larsh: rev 1542642)
*
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.94.01.patch, HBASE-9165-0.96.00.patch,
> HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824775#comment-13824775
]
Hudson commented on HBASE-9165:
---
SUCCESS: Integrated in HBase-0.94-security #338 (See
[https://builds.apache.org/job/HBase-0.94-security/338/])
HBASE-9165 Addendum, fix TestTableMapreduce (larsh: rev 1542642)
*
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.94.01.patch, HBASE-9165-0.96.00.patch,
> HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824730#comment-13824730
]
Lars Hofhansl commented on HBASE-9165:
--
0.96 and trunk do not have this change TestTableMapreduce. Should be good now.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.94.01.patch, HBASE-9165-0.96.00.patch,
> HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824729#comment-13824729
]
Lars Hofhansl commented on HBASE-9165:
--
Fixed in 0.94 for now, but removing the newly added test for "hbase" in the
dependency jars.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.94.01.patch, HBASE-9165-0.96.00.patch,
> HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824728#comment-13824728
]
Lars Hofhansl commented on HBASE-9165:
--
This only passes on my local box, because the directory I have my build in is
called hbase-0.94 (on jenkins it is HBase-0.94). So even on my box it only
passes by pure accident.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.94.01.patch, HBASE-9165-0.96.00.patch,
> HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824727#comment-13824727
]
Lars Hofhansl commented on HBASE-9165:
--
The reason is probably this from the logs:
{code}
2013-11-16 17:57:00,896 DEBUG [pool-1-thread-1]
mapreduce.TableMapReduceUtil(665): For class
org.apache.hadoop.hbase.util.Bytes, using jar
/x1/jenkins/jenkins-slave/workspace/HBase-0.94/trunk/target/test-dir/hadoop-1223249546787952422.jar
{code}
This does not happen on my local box.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.94.01.patch, HBASE-9165-0.96.00.patch,
> HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824649#comment-13824649
]
Lars Hofhansl commented on HBASE-9165:
--
{code{
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:92)
at org.junit.Assert.assertTrue(Assert.java:43)
at org.junit.Assert.assertTrue(Assert.java:54)
at
org.apache.hadoop.hbase.mapreduce.TestTableMapReduce.testAddDependencyJars(TestTableMapReduce.java:272)
{code}
Can you take a look [~ndimiduk]?
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.94.01.patch, HBASE-9165-0.96.00.patch,
> HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824608#comment-13824608
]
Hudson commented on HBASE-9165:
---
FAILURE: Integrated in hbase-0.96-hadoop2 #120 (See
[https://builds.apache.org/job/hbase-0.96-hadoop2/120/])
HBASE-9165 [mapreduce] Modularize building dependency jars
- Separate adding HBase and dependencies from adding other job
dependencies, and expose it as a separate method that other
projects can use (for PIG-3285).
- Explicitly add hbase-server to the list of dependencies we ship
with the job, for users who extend the classes we provide (see
HBASE-9112).
- Add integration test for addDependencyJars.
- Code reuse for TestTableMapReduce.
Note this patch differs from the one applied to TRUNK/0.98 in that it omits
changes to TestTableMapReduceUtil which have not yet been backported from
HBASE-8534. This can be addressed when that patch is backported (HBASE-9484).
(ndimiduk: rev 1542342)
*
/hbase/branches/0.96/hbase-it/src/test/java/org/apache/hadoop/hbase/mapreduce/IntegrationTestTableMapReduceUtil.java
*
/hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java
*
/hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/IdentityTableMapper.java
*
/hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
*
/hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/mapred/TestTableMapReduce.java
*
/hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java
*
/hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduceBase.java
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.94.01.patch, HBASE-9165-0.96.00.patch,
> HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824587#comment-13824587
]
Hudson commented on HBASE-9165:
---
SUCCESS: Integrated in HBase-0.94-security #337 (See
[https://builds.apache.org/job/HBase-0.94-security/337/])
HBASE-9165 [mapreduce] Modularize building dependency jars
Separate adding HBase and dependencies from adding other job dependencies, and
expose it as a separate method that other projects can use (for PIG-3285,
HIVE-2055). (ndimiduk: rev 1542414)
*
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java
*
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
*
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.94.01.patch, HBASE-9165-0.96.00.patch,
> HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824559#comment-13824559
]
Hudson commented on HBASE-9165:
---
FAILURE: Integrated in HBase-0.94 #1203 (See
[https://builds.apache.org/job/HBase-0.94/1203/])
HBASE-9165 [mapreduce] Modularize building dependency jars
Separate adding HBase and dependencies from adding other job dependencies, and
expose it as a separate method that other projects can use (for PIG-3285,
HIVE-2055). (ndimiduk: rev 1542414)
*
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java
*
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
*
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.94.01.patch, HBASE-9165-0.96.00.patch,
> HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824516#comment-13824516
]
Hudson commented on HBASE-9165:
---
FAILURE: Integrated in hbase-0.96 #190 (See
[https://builds.apache.org/job/hbase-0.96/190/])
HBASE-9165 [mapreduce] Modularize building dependency jars
- Separate adding HBase and dependencies from adding other job
dependencies, and expose it as a separate method that other
projects can use (for PIG-3285).
- Explicitly add hbase-server to the list of dependencies we ship
with the job, for users who extend the classes we provide (see
HBASE-9112).
- Add integration test for addDependencyJars.
- Code reuse for TestTableMapReduce.
Note this patch differs from the one applied to TRUNK/0.98 in that it omits
changes to TestTableMapReduceUtil which have not yet been backported from
HBASE-8534. This can be addressed when that patch is backported (HBASE-9484).
(ndimiduk: rev 1542342)
*
/hbase/branches/0.96/hbase-it/src/test/java/org/apache/hadoop/hbase/mapreduce/IntegrationTestTableMapReduceUtil.java
*
/hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java
*
/hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/IdentityTableMapper.java
*
/hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
*
/hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/mapred/TestTableMapReduce.java
*
/hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java
*
/hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduceBase.java
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.94.01.patch, HBASE-9165-0.96.00.patch,
> HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824381#comment-13824381
]
Hudson commented on HBASE-9165:
---
SUCCESS: Integrated in HBase-TRUNK #4681 (See
[https://builds.apache.org/job/HBase-TRUNK/4681/])
HBASE-9165 [mapreduce] Modularize building dependency jars
- Separate adding HBase and dependencies from adding other job
dependencies, and expose it as a separate method that other
projects can use (for PIG-3285).
- Explicitly add hbase-server to the list of dependencies we ship
with the job, for users who extend the classes we provide (see
HBASE-9112).
- Add integration test for addDependencyJars.
- Code reuse for TestTableMapReduce. (ndimiduk: rev 1542341)
*
/hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/mapreduce/IntegrationTestTableMapReduceUtil.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/IdentityTableMapper.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapred/TestTableMapReduce.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduceBase.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduceUtil.java
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.94.01.patch, HBASE-9165-0.96.00.patch,
> HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824115#comment-13824115
]
Lars Hofhansl commented on HBASE-9165:
--
+1 :)
Thanks Nick.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.94.01.patch, HBASE-9165-0.96.00.patch,
> HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824091#comment-13824091
]
Hadoop QA commented on HBASE-9165:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12614123/HBASE-9165-0.94.01.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7888//console
This message is automatically generated.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.94.01.patch, HBASE-9165-0.96.00.patch,
> HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824074#comment-13824074
]
Hudson commented on HBASE-9165:
---
SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #838 (See
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/838/])
HBASE-9165 [mapreduce] Modularize building dependency jars
- Separate adding HBase and dependencies from adding other job
dependencies, and expose it as a separate method that other
projects can use (for PIG-3285).
- Explicitly add hbase-server to the list of dependencies we ship
with the job, for users who extend the classes we provide (see
HBASE-9112).
- Add integration test for addDependencyJars.
- Code reuse for TestTableMapReduce. (ndimiduk: rev 1542341)
*
/hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/mapreduce/IntegrationTestTableMapReduceUtil.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/IdentityTableMapper.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapred/TestTableMapReduce.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduceBase.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduceUtil.java
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.96.00.patch, HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824033#comment-13824033
]
Lars Hofhansl commented on HBASE-9165:
--
If they are in the same jar, let's just add them both. Seems safer and it also
calls out the actual dependencies.
+1 otherwise.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.96.00.patch, HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824002#comment-13824002
]
Nick Dimiduk commented on HBASE-9165:
-
I stood up a pseudo-distributed hadoop on my laptop, built the tarball from
0.94.14-SNAPSHOT, and launched PerformanceEvaluation sequentialWrite 2. In the
job launch logs I see
{noformat}
13/11/15 11:36:46 DEBUG mapreduce.TableMapReduceUtil: For class
com.google.common.collect.ImmutableSet, using jar
/private/tmp/hbase-0.94.14-SNAPSHOT/lib/guava-11.0.2.jar
{noformat}
The submitted job.xml file contains the following value for "tmpjars":
{noformat}
file:/private/tmp/hbase-0.94.14-SNAPSHOT/hbase-0.94.14-SNAPSHOT.jar,file:/private/tmp/hbase-0.94.14-SNAPSHOT/lib/protobuf-java-2.4.0a.jar,file:/private/tmp/hbase-0.94.14-SNAPSHOT/lib/zookeeper-3.4.5.jar,file:/private/tmp/hbase-0.94.14-SNAPSHOT/lib/guava-11.0.2.jar,file:/private/tmp/hbase-0.94.14-SNAPSHOT/lib/hadoop-core-1.0.4.jar,file:/private/tmp/hbase-0.94.14-SNAPSHOT/hbase-0.94.14-SNAPSHOT-tests.jar
{noformat}
I think we're good :)
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.96.00.patch, HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823983#comment-13823983
]
Nick Dimiduk commented on HBASE-9165:
-
Yes. This change is an effective noop; the same jar contains both classes. It's
value is to bring the implementations across branches back into sync.
{noformat}
soleil:hbase-94 ndimiduk$ grep \ pom.xml
11.0.2
soleil:hbase-94 ndimiduk$ jar tf
~/.m2/repository/com/google/guava/guava/11.0.2/guava-11.0.2.jar | grep
base\.Function\.class
com/google/common/base/Function.class
soleil:hbase-94 ndimiduk$ jar tf
~/.m2/repository/com/google/guava/guava/11.0.2/guava-11.0.2.jar | grep
collect\.ImmutableSet\.class
com/google/common/collect/ImmutableSet.class
{noformat}
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.96.00.patch, HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823904#comment-13823904
]
Lars Hofhansl commented on HBASE-9165:
--
+1
You sure we won't need com.google.common.base.Function.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.96.00.patch, HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823857#comment-13823857
]
Hadoop QA commented on HBASE-9165:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12614091/HBASE-9165-0.96.00.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 15 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7883//console
This message is automatically generated.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.96.00.patch, HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823850#comment-13823850
]
Nick Dimiduk commented on HBASE-9165:
-
[~lhofhansl] are you okay with the 0.94 backport?
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165-0.96.00.patch, HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823235#comment-13823235
]
Hadoop QA commented on HBASE-9165:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12613983/HBASE-9165.02.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 19 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7871//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7871//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7871//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7871//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7871//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7871//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7871//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7871//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7871//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7871//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7871//console
This message is automatically generated.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch, HBASE-9165.02.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823132#comment-13823132
]
Hadoop QA commented on HBASE-9165:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12613968/HBASE-9165-0.94.00.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7869//console
This message is automatically generated.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823125#comment-13823125
]
Nick Dimiduk commented on HBASE-9165:
-
Yikes, I didn't realize the list of classes are different between the two. This
is a bug, right? Mapred is just a pass-through to the mapreduce implementations.
Zookeeper and protobuf jars are drawn by the same class in both cases. The same
Guava jar is brought in by Function.class and ImmutableSet.class respectively.
Not including the hbase.jar is a bug as reported by HBASE-9112, and fixed
inadvertently by HBASE-8146.
So yes, this is correct. Thanks for double-checking.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823113#comment-13823113
]
Lars Hofhansl commented on HBASE-9165:
--
So with mapred we are removing:
- org.apache.zookeeper.ZooKeeper.class,
- com.google.common.base.Function.class,
- com.google.protobuf.Message.class,
And adding:
+ org.apache.zookeeper.ZooKeeper.class,
+ com.google.protobuf.Message.class,
+ com.google.common.collect.ImmutableSet.class,
+ org.apache.hadoop.hbase.util.Bytes.class
Is that correct?
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823108#comment-13823108
]
Hadoop QA commented on HBASE-9165:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12613968/HBASE-9165-0.94.00.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7867//console
This message is automatically generated.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> HBASE-9165-0.94.00.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822994#comment-13822994
]
Nick Dimiduk commented on HBASE-9165:
-
[~lhofhansl] do you want at least a partial backport to 0.94? I think we can
leave out the test refactor if you'd prefer, keep only the new method. This
should be helpful for downstream projects (Pig, Hive). I'd like to include the
new method so I can also backport HBASE-8438.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822168#comment-13822168
]
stack commented on HBASE-9165:
--
Skimmed. lgtm
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821987#comment-13821987
]
Ted Yu commented on HBASE-9165:
---
{code}
+ // when making changes here, consider also mapreduce.TableMapReduceUtils
{code}
You meant TableMapReduceUtil, right ?
{code}
+ public static class ProcessContentsMapper extends MapReduceBase implements
{code}
The above class can be package-private, right ?
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820976#comment-13820976
]
Hadoop QA commented on HBASE-9165:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12613499/0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 19 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7831//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7831//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7831//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7831//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7831//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7831//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7831//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7831//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7831//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7831//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7831//console
This message is automatically generated.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.1
>
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch,
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755134#comment-13755134
]
Daniel Dai commented on HBASE-9165:
---
+1. Pig need this feature to ship HBase dependent jars correctly. Currently Pig
user have to register HBase dependent jars (such as protobuf.jar) to use
HBaseStorage.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9165) Improvements to addDependencyJars
[
https://issues.apache.org/jira/browse/HBASE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13734389#comment-13734389
]
Hadoop QA commented on HBASE-9165:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12596999/0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 19 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
20 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at org.apache.hadoop.hbase.client.TestAdmin.testTableExist(TestAdmin.java:835)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/6671//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6671//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6671//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6671//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6671//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6671//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6671//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6671//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6671//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6671//console
This message is automatically generated.
> Improvements to addDependencyJars
> -
>
> Key: HBASE-9165
> URL: https://issues.apache.org/jira/browse/HBASE-9165
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Affects Versions: 0.95.2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Attachments:
> 0001-HBASE-9165-mapreduce-Modularize-building-dependency-.patch
>
>
> The way we support adding HBase dependencies to a MapReduce job in
> {{TableMapReduceUtils#addDependencyJars(job)}} is a bit monolithic. Advanced
> users need a way to add HBase and its dependencies to their job without us
> snooping around for ouput formats and the like (see PIG-3285). We can also
> benefit from a little more code reuse between our {{mapred}} and
> {{mapreduce}} namespaces.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
