[jira] [Commented] (HBASE-9800) Impl CoprocessorRowcounter to run in command-line
[
https://issues.apache.org/jira/browse/HBASE-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13933418#comment-13933418
]
Hadoop QA commented on HBASE-9800:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12634418/HBASE-9800-0.94-v2.patch
against trunk revision .
ATTACHMENT ID: 12634418
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8967//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8967//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8967//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8967//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8967//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8967//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8967//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8967//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8967//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8967//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8967//console
This message is automatically generated.
> Impl CoprocessorRowcounter to run in command-line
> -
>
> Key: HBASE-9800
> URL: https://issues.apache.org/jira/browse/HBASE-9800
> Project: HBase
> Issue Type: New Feature
> Components: Coprocessors
>Affects Versions: 0.94.3
>Reporter: chendihao
>Assignee: chendihao
>Priority: Minor
> Attachments: HBASE-9800-0.94-v1.patch, HBASE-9800-0.94-v2.patch
>
>
> We want to count the rows of table daily but the default rowcounter using
> mapreduce is inefficient. Impl rowcounter using coprocessor makes it better.
> Furthermore, It must provide the mechanism to choose the way to output result.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-9800) Impl CoprocessorRowcounter to run in command-line
[ https://issues.apache.org/jira/browse/HBASE-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13933036#comment-13933036 ] chendihao commented on HBASE-9800: -- Thank [~yuzhih...@gmail.com] for reviewing. 1. I will update the license header. 2. LocalFileSink can be used when we set "coprocessor.rowcounter.sink" as "org.apache.hadoop.hbase.coprocessor.example.CoprocessorRowcounter$LocalFileSink" in the configuration file. 3. We periodically count the rows, so we need to indicate the date of the data. It's not so general but meets our requirements. 4. The patch for trunk will be uploaded later if we need it. > Impl CoprocessorRowcounter to run in command-line > - > > Key: HBASE-9800 > URL: https://issues.apache.org/jira/browse/HBASE-9800 > Project: HBase > Issue Type: New Feature > Components: Coprocessors >Affects Versions: 0.94.3 >Reporter: chendihao >Assignee: chendihao >Priority: Minor > Attachments: HBASE-9800-0.94-v1.patch > > > We want to count the rows of table daily but the default rowcounter using > mapreduce is inefficient. Impl rowcounter using coprocessor makes it better. > Furthermore, It must provide the mechanism to choose the way to output result. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-9800) Impl CoprocessorRowcounter to run in command-line
[
https://issues.apache.org/jira/browse/HBASE-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13932777#comment-13932777
]
Ted Yu commented on HBASE-9800:
---
Year is not needed in license header.
{code}
+ public static class LocalFileSink implements Sink{
{code}
Where is LocalFileSink used ?
{code}
+ Put put = new Put(Bytes.toBytes(tableName+"_"+date));
{code}
Why is date needed in row key ?
Can you attach patch for trunk ?
> Impl CoprocessorRowcounter to run in command-line
> -
>
> Key: HBASE-9800
> URL: https://issues.apache.org/jira/browse/HBASE-9800
> Project: HBase
> Issue Type: New Feature
> Components: Coprocessors
>Affects Versions: 0.94.3
>Reporter: chendihao
>Assignee: chendihao
>Priority: Minor
> Attachments: HBASE-9800-0.94-v1.patch
>
>
> We want to count the rows of table daily but the default rowcounter using
> mapreduce is inefficient. Impl rowcounter using coprocessor makes it better.
> Furthermore, It must provide the mechanism to choose the way to output result.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-9800) Impl CoprocessorRowcounter to run in command-line
[
https://issues.apache.org/jira/browse/HBASE-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931661#comment-13931661
]
Hadoop QA commented on HBASE-9800:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12609088/HBASE-9800-0.94-v1.patch
against trunk revision .
ATTACHMENT ID: 12609088
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+String sinkClassName = conf.get("coprocessor.rowcounter.sink",
"org.apache.hadoop.hbase.coprocessor.example.CoprocessorRowcounter$StdOutSink");
+bufferedWriter = new BufferedWriter(new OutputStreamWriter(new
FileOutputStream(("rowcounter_result";
+ put.add(Bytes.toBytes(columnFamily), Bytes.toBytes(columnQualifier),
Bytes.toBytes(String.valueOf(rowCount)));
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8957//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8957//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8957//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8957//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8957//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8957//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8957//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8957//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8957//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8957//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8957//console
This message is automatically generated.
> Impl CoprocessorRowcounter to run in command-line
> -
>
> Key: HBASE-9800
> URL: https://issues.apache.org/jira/browse/HBASE-9800
> Project: HBase
> Issue Type: New Feature
> Components: Coprocessors
>Affects Versions: 0.94.3
>Reporter: chendihao
>Assignee: chendihao
>Priority: Minor
> Attachments: HBASE-9800-0.94-v1.patch
>
>
> We want to count the rows of table daily but the default rowcounter using
> mapreduce is inefficient. Impl rowcounter using coprocessor makes it better.
> Furthermore, It must provide the mechanism to choose the way to output result.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-9800) Impl CoprocessorRowcounter to run in command-line
[ https://issues.apache.org/jira/browse/HBASE-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931576#comment-13931576 ] chendihao commented on HBASE-9800: -- [~te...@apache.org] [~stack] It's a nice feature for us to count the rows. But the issue has been opened for a long time, could you help to review the code or just close it? > Impl CoprocessorRowcounter to run in command-line > - > > Key: HBASE-9800 > URL: https://issues.apache.org/jira/browse/HBASE-9800 > Project: HBase > Issue Type: New Feature > Components: Coprocessors >Affects Versions: 0.94.3 >Reporter: chendihao >Assignee: chendihao >Priority: Minor > Attachments: HBASE-9800-0.94-v1.patch > > > We want to count the rows of table daily but the default rowcounter using > mapreduce is inefficient. Impl rowcounter using coprocessor makes it better. > Furthermore, It must provide the mechanism to choose the way to output result. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-9800) Impl CoprocessorRowcounter to run in command-line
[ https://issues.apache.org/jira/browse/HBASE-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821993#comment-13821993 ] Ted Yu commented on HBASE-9800: --- Sounds good. > Impl CoprocessorRowcounter to run in command-line > - > > Key: HBASE-9800 > URL: https://issues.apache.org/jira/browse/HBASE-9800 > Project: HBase > Issue Type: New Feature > Components: Coprocessors >Affects Versions: 0.94.3 >Reporter: chendihao >Priority: Minor > Attachments: HBASE-9800-0.94-v1.patch > > > We want to count the rows of table daily but the default rowcounter using > mapreduce is inefficient. Impl rowcounter using coprocessor makes it better. > Furthermore, It must provide the mechanism to choose the way to output result. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9800) Impl CoprocessorRowcounter to run in command-line
[ https://issues.apache.org/jira/browse/HBASE-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798833#comment-13798833 ] chendihao commented on HBASE-9800: -- I will put it in coprocessor/example package. Any suggestions? [~yuzhih...@gmail.com] > Impl CoprocessorRowcounter to run in command-line > - > > Key: HBASE-9800 > URL: https://issues.apache.org/jira/browse/HBASE-9800 > Project: HBase > Issue Type: New Feature > Components: Coprocessors >Affects Versions: 0.94.3 >Reporter: chendihao >Priority: Minor > Attachments: HBASE-9800-0.94-v1.patch > > > We want to count the rows of table daily but the default rowcounter using > mapreduce is inefficient. Impl rowcounter using coprocessor makes it better. > Furthermore, It must provide the mechanism to choose the way to output result. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9800) Impl CoprocessorRowcounter to run in command-line
[ https://issues.apache.org/jira/browse/HBASE-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798760#comment-13798760 ] chendihao commented on HBASE-9800: -- Yes, I know AggregationClient.rowCount(). We write a main function to call it from time to time. Because it's not quite real-time, we have a plan to count the rows daily at midnight. It might be helpful for us to know the rough statistics about tables while not affecting the online services. > Impl CoprocessorRowcounter to run in command-line > - > > Key: HBASE-9800 > URL: https://issues.apache.org/jira/browse/HBASE-9800 > Project: HBase > Issue Type: New Feature > Components: Coprocessors >Affects Versions: 0.94.3 >Reporter: chendihao >Priority: Minor > > We want to count the rows of table daily but the default rowcounter using > mapreduce is inefficient. Impl rowcounter using coprocessor makes it better. > Furthermore, It must provide the mechanism to choose the way to output result. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9800) Impl CoprocessorRowcounter to run in command-line
[ https://issues.apache.org/jira/browse/HBASE-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798744#comment-13798744 ] Ted Yu commented on HBASE-9800: --- What's the difference from AggregationClient / AggregateProtocol ? See AggregationClient#rowCount() > Impl CoprocessorRowcounter to run in command-line > - > > Key: HBASE-9800 > URL: https://issues.apache.org/jira/browse/HBASE-9800 > Project: HBase > Issue Type: New Feature > Components: Coprocessors >Affects Versions: 0.94.3 >Reporter: chendihao >Priority: Minor > > We want to count the rows of table daily but the default rowcounter using > mapreduce is inefficient. Impl rowcounter using coprocessor makes it better. > Furthermore, It must provide the mechanism to choose the way to output result. -- This message was sent by Atlassian JIRA (v6.1#6144)
