[jira] [Commented] (HBASE-9988) DOn't use HRI#getEncodedName in the client
[ https://issues.apache.org/jira/browse/HBASE-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827570#comment-13827570 ] Hudson commented on HBASE-9988: --- SUCCESS: Integrated in hbase-0.96-hadoop2 #125 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/125/]) HBASE-9988 DOn't use HRI#getEncodedName in the client (nkeywal: rev 1543428) * /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * /hbase/branches/0.96/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java > DOn't use HRI#getEncodedName in the client > -- > > Key: HBASE-9988 > URL: https://issues.apache.org/jira/browse/HBASE-9988 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1 > > Attachments: 9988.v1.patch, 9988.v2.patch > > > This functions does a lazy initialisation. It cost memory and it creates a > synchronisation point. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9988) DOn't use HRI#getEncodedName in the client
[ https://issues.apache.org/jira/browse/HBASE-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827022#comment-13827022 ] Hudson commented on HBASE-9988: --- SUCCESS: Integrated in HBase-TRUNK #4688 (See [https://builds.apache.org/job/HBase-TRUNK/4688/]) HBASE-9988 DOn't use HRI#getEncodedName in the client (nkeywal: rev 1543427) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * /hbase/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java > DOn't use HRI#getEncodedName in the client > -- > > Key: HBASE-9988 > URL: https://issues.apache.org/jira/browse/HBASE-9988 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1 > > Attachments: 9988.v1.patch, 9988.v2.patch > > > This functions does a lazy initialisation. It cost memory and it creates a > synchronisation point. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9988) DOn't use HRI#getEncodedName in the client
[ https://issues.apache.org/jira/browse/HBASE-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826986#comment-13826986 ] Hudson commented on HBASE-9988: --- SUCCESS: Integrated in hbase-0.96 #196 (See [https://builds.apache.org/job/hbase-0.96/196/]) HBASE-9988 DOn't use HRI#getEncodedName in the client (nkeywal: rev 1543428) * /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * /hbase/branches/0.96/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java > DOn't use HRI#getEncodedName in the client > -- > > Key: HBASE-9988 > URL: https://issues.apache.org/jira/browse/HBASE-9988 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1 > > Attachments: 9988.v1.patch, 9988.v2.patch > > > This functions does a lazy initialisation. It cost memory and it creates a > synchronisation point. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9988) DOn't use HRI#getEncodedName in the client
[ https://issues.apache.org/jira/browse/HBASE-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826843#comment-13826843 ] Hudson commented on HBASE-9988: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #844 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/844/]) HBASE-9988 DOn't use HRI#getEncodedName in the client (nkeywal: rev 1543427) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * /hbase/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java > DOn't use HRI#getEncodedName in the client > -- > > Key: HBASE-9988 > URL: https://issues.apache.org/jira/browse/HBASE-9988 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1 > > Attachments: 9988.v1.patch, 9988.v2.patch > > > This functions does a lazy initialisation. It cost memory and it creates a > synchronisation point. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9988) DOn't use HRI#getEncodedName in the client
[ https://issues.apache.org/jira/browse/HBASE-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825919#comment-13825919 ] Nick Dimiduk commented on HBASE-9988: - Thanks for clarifying. +1 > DOn't use HRI#getEncodedName in the client > -- > > Key: HBASE-9988 > URL: https://issues.apache.org/jira/browse/HBASE-9988 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1 > > Attachments: 9988.v1.patch, 9988.v2.patch > > > This functions does a lazy initialisation. It cost memory and it creates a > synchronisation point. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9988) DOn't use HRI#getEncodedName in the client
[ https://issues.apache.org/jira/browse/HBASE-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825880#comment-13825880 ] Nicolas Liochon commented on HBASE-9988: We were just putting the failure in an internal array, without publishing it anywhere. As well it was only if log.trace was on, so not really useful in practice. We now log the errors (at the info level) after a configurable number of retries. > DOn't use HRI#getEncodedName in the client > -- > > Key: HBASE-9988 > URL: https://issues.apache.org/jira/browse/HBASE-9988 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1 > > Attachments: 9988.v1.patch, 9988.v2.patch > > > This functions does a lazy initialisation. It cost memory and it creates a > synchronisation point. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9988) DOn't use HRI#getEncodedName in the client
[ https://issues.apache.org/jira/browse/HBASE-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825738#comment-13825738 ] Nick Dimiduk commented on HBASE-9988: - The change in retry logic -- you're no longer gathering the failures? That feature is being dropped? > DOn't use HRI#getEncodedName in the client > -- > > Key: HBASE-9988 > URL: https://issues.apache.org/jira/browse/HBASE-9988 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1 > > Attachments: 9988.v1.patch, 9988.v2.patch > > > This functions does a lazy initialisation. It cost memory and it creates a > synchronisation point. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9988) DOn't use HRI#getEncodedName in the client
[ https://issues.apache.org/jira/browse/HBASE-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825399#comment-13825399 ] Nicolas Liochon commented on HBASE-9988: The patch changed, so I don't mind another review if you have time, Nick :-). I've removed something used only in "trace" mode, and fixed the previous issue. > DOn't use HRI#getEncodedName in the client > -- > > Key: HBASE-9988 > URL: https://issues.apache.org/jira/browse/HBASE-9988 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1 > > Attachments: 9988.v1.patch, 9988.v2.patch > > > This functions does a lazy initialisation. It cost memory and it creates a > synchronisation point. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9988) DOn't use HRI#getEncodedName in the client
[
https://issues.apache.org/jira/browse/HBASE-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825266#comment-13825266
]
Hadoop QA commented on HBASE-9988:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12614360/9988.v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
10 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7911//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7911//console
This message is automatically generated.
> DOn't use HRI#getEncodedName in the client
> --
>
> Key: HBASE-9988
> URL: https://issues.apache.org/jira/browse/HBASE-9988
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 0.98.0, 0.96.0
>Reporter: Nicolas Liochon
>Assignee: Nicolas Liochon
> Fix For: 0.98.0, 0.96.1
>
> Attachments: 9988.v1.patch, 9988.v2.patch
>
>
> This functions does a lazy initialisation. It cost memory and it creates a
> synchronisation point.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9988) DOn't use HRI#getEncodedName in the client
[ https://issues.apache.org/jira/browse/HBASE-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825182#comment-13825182 ] Nicolas Liochon commented on HBASE-9988: bq. Is the test failure related? Yes, I need to fix it :-) > DOn't use HRI#getEncodedName in the client > -- > > Key: HBASE-9988 > URL: https://issues.apache.org/jira/browse/HBASE-9988 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1 > > Attachments: 9988.v1.patch > > > This functions does a lazy initialisation. It cost memory and it creates a > synchronisation point. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9988) DOn't use HRI#getEncodedName in the client
[ https://issues.apache.org/jira/browse/HBASE-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824968#comment-13824968 ] Nick Dimiduk commented on HBASE-9988: - +1 Is the test failure related? > DOn't use HRI#getEncodedName in the client > -- > > Key: HBASE-9988 > URL: https://issues.apache.org/jira/browse/HBASE-9988 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.98.0, 0.96.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1 > > Attachments: 9988.v1.patch > > > This functions does a lazy initialisation. It cost memory and it creates a > synchronisation point. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9988) DOn't use HRI#getEncodedName in the client
[
https://issues.apache.org/jira/browse/HBASE-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824837#comment-13824837
]
Hadoop QA commented on HBASE-9988:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12614283/9988.v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
10 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestAsyncProcess
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7904//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7904//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7904//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7904//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7904//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7904//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7904//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7904//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7904//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7904//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7904//console
This message is automatically generated.
> DOn't use HRI#getEncodedName in the client
> --
>
> Key: HBASE-9988
> URL: https://issues.apache.org/jira/browse/HBASE-9988
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 0.98.0, 0.96.0
>Reporter: Nicolas Liochon
>Assignee: Nicolas Liochon
> Fix For: 0.98.0, 0.96.1
>
> Attachments: 9988.v1.patch
>
>
> This functions does a lazy initialisation. It cost memory and it creates a
> synchronisation point.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
