[jira] [Updated] (HBASE-10889) test-patch.sh should exclude thrift generated code from long line detection

2014-04-01 Thread Ted Yu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-10889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-10889:
---

Priority: Minor  (was: Major)

 test-patch.sh should exclude thrift generated code from long line detection
 ---

 Key: HBASE-10889
 URL: https://issues.apache.org/jira/browse/HBASE-10889
 Project: HBase
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
 Attachments: 10889-v1.txt


 As can be seen from HBASE-10881 :
 {code}
 {color:red}-1 lineLengths{color}.  The patch introduces the following 
 lines longer than 100:
 +  private static final org.apache.thrift.protocol.TField 
 REVERSED_FIELD_DESC = new org.apache.thrift.protocol.TField(reversed, 
 org.apache.thrift.protocol.TType.BOOL, (short)11);
 {code}
 test-patch.sh should exclude thrift generated code from long line detection.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (HBASE-10889) test-patch.sh should exclude thrift generated code from long line detection

2014-04-01 Thread Ted Yu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-10889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-10889:
---

Status: Patch Available  (was: Open)

 test-patch.sh should exclude thrift generated code from long line detection
 ---

 Key: HBASE-10889
 URL: https://issues.apache.org/jira/browse/HBASE-10889
 Project: HBase
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
 Attachments: 10889-v1.txt


 As can be seen from HBASE-10881 :
 {code}
 {color:red}-1 lineLengths{color}.  The patch introduces the following 
 lines longer than 100:
 +  private static final org.apache.thrift.protocol.TField 
 REVERSED_FIELD_DESC = new org.apache.thrift.protocol.TField(reversed, 
 org.apache.thrift.protocol.TType.BOOL, (short)11);
 {code}
 test-patch.sh should exclude thrift generated code from long line detection.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (HBASE-10889) test-patch.sh should exclude thrift generated code from long line detection

2014-04-01 Thread Ted Yu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-10889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-10889:
---

Attachment: 10889-v1.txt

 test-patch.sh should exclude thrift generated code from long line detection
 ---

 Key: HBASE-10889
 URL: https://issues.apache.org/jira/browse/HBASE-10889
 Project: HBase
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
 Attachments: 10889-v1.txt


 As can be seen from HBASE-10881 :
 {code}
 {color:red}-1 lineLengths{color}.  The patch introduces the following 
 lines longer than 100:
 +  private static final org.apache.thrift.protocol.TField 
 REVERSED_FIELD_DESC = new org.apache.thrift.protocol.TField(reversed, 
 org.apache.thrift.protocol.TType.BOOL, (short)11);
 {code}
 test-patch.sh should exclude thrift generated code from long line detection.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (HBASE-10889) test-patch.sh should exclude thrift generated code from long line detection

2014-04-01 Thread Ted Yu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-10889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-10889:
---

   Resolution: Fixed
Fix Version/s: 0.99.0
 Hadoop Flags: Reviewed
   Status: Resolved  (was: Patch Available)

Thanks for the review.

 test-patch.sh should exclude thrift generated code from long line detection
 ---

 Key: HBASE-10889
 URL: https://issues.apache.org/jira/browse/HBASE-10889
 Project: HBase
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
 Fix For: 0.99.0

 Attachments: 10889-v1.txt


 As can be seen from HBASE-10881 :
 {code}
 {color:red}-1 lineLengths{color}.  The patch introduces the following 
 lines longer than 100:
 +  private static final org.apache.thrift.protocol.TField 
 REVERSED_FIELD_DESC = new org.apache.thrift.protocol.TField(reversed, 
 org.apache.thrift.protocol.TType.BOOL, (short)11);
 {code}
 test-patch.sh should exclude thrift generated code from long line detection.



--
This message was sent by Atlassian JIRA
(v6.2#6252)