[jira] [Updated] (HBASE-11232) Region fail to release the updatelock for illegal CF in multi row mutations
[
https://issues.apache.org/jira/browse/HBASE-11232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lars Hofhansl updated HBASE-11232:
--
Fix Version/s: 0.94.23
Region fail to release the updatelock for illegal CF in multi row mutations
---
Key: HBASE-11232
URL: https://issues.apache.org/jira/browse/HBASE-11232
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.94.19
Reporter: Liu Shaohui
Assignee: Liu Shaohui
Fix For: 0.94.23
Attachments: HBASE-11232-0.94.diff
The failback code in processRowsWithLocks did not check the column family. If
there is an illegal CF in the muation, it will throw NullPointException and
the update lock will not be released. So the region can not be flushed and
compacted.
HRegion #4946
{code}
if (!mutations.isEmpty() !walSyncSuccessful) {
LOG.warn(Wal sync failed. Roll back + mutations.size() +
memstore keyvalues for row(s): +
processor.getRowsToLock().iterator().next() + ...);
for (KeyValue kv : mutations) {
stores.get(kv.getFamily()).rollback(kv);
}
}
// 11. Roll mvcc forward
if (writeEntry != null) {
mvcc.completeMemstoreInsert(writeEntry);
writeEntry = null;
}
if (locked) {
this.updatesLock.readLock().unlock();
locked = false;
}
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11232) Region fail to release the updatelock for illegal CF in multi row mutations
[
https://issues.apache.org/jira/browse/HBASE-11232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Liu Shaohui updated HBASE-11232:
Attachment: HBASE-11232-0.94.diff
After the check of code, the trunk doesn't have this issue after the refactor
of coprocessor.
So only upload a 0.94 patch.
[~lhofhansl]
Region fail to release the updatelock for illegal CF in multi row mutations
---
Key: HBASE-11232
URL: https://issues.apache.org/jira/browse/HBASE-11232
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Liu Shaohui
Assignee: Liu Shaohui
Fix For: 0.99.0
Attachments: HBASE-11232-0.94.diff
The failback code in processRowsWithLocks did not check the column family. If
there is an illegal CF in the muation, it will throw NullPointException and
the update lock will not be released. So the region can not be flushed and
compacted.
HRegion #4946
{code}
if (!mutations.isEmpty() !walSyncSuccessful) {
LOG.warn(Wal sync failed. Roll back + mutations.size() +
memstore keyvalues for row(s): +
processor.getRowsToLock().iterator().next() + ...);
for (KeyValue kv : mutations) {
stores.get(kv.getFamily()).rollback(kv);
}
}
// 11. Roll mvcc forward
if (writeEntry != null) {
mvcc.completeMemstoreInsert(writeEntry);
writeEntry = null;
}
if (locked) {
this.updatesLock.readLock().unlock();
locked = false;
}
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11232) Region fail to release the updatelock for illegal CF in multi row mutations
[
https://issues.apache.org/jira/browse/HBASE-11232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Liang Xie updated HBASE-11232:
--
Fix Version/s: (was: 0.99.0)
Region fail to release the updatelock for illegal CF in multi row mutations
---
Key: HBASE-11232
URL: https://issues.apache.org/jira/browse/HBASE-11232
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Liu Shaohui
Assignee: Liu Shaohui
Attachments: HBASE-11232-0.94.diff
The failback code in processRowsWithLocks did not check the column family. If
there is an illegal CF in the muation, it will throw NullPointException and
the update lock will not be released. So the region can not be flushed and
compacted.
HRegion #4946
{code}
if (!mutations.isEmpty() !walSyncSuccessful) {
LOG.warn(Wal sync failed. Roll back + mutations.size() +
memstore keyvalues for row(s): +
processor.getRowsToLock().iterator().next() + ...);
for (KeyValue kv : mutations) {
stores.get(kv.getFamily()).rollback(kv);
}
}
// 11. Roll mvcc forward
if (writeEntry != null) {
mvcc.completeMemstoreInsert(writeEntry);
writeEntry = null;
}
if (locked) {
this.updatesLock.readLock().unlock();
locked = false;
}
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11232) Region fail to release the updatelock for illegal CF in multi row mutations
[
https://issues.apache.org/jira/browse/HBASE-11232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Liang Xie updated HBASE-11232:
--
Status: Patch Available (was: Open)
How about 0.96 and 0.98 branch ?
Region fail to release the updatelock for illegal CF in multi row mutations
---
Key: HBASE-11232
URL: https://issues.apache.org/jira/browse/HBASE-11232
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.94.19
Reporter: Liu Shaohui
Assignee: Liu Shaohui
Attachments: HBASE-11232-0.94.diff
The failback code in processRowsWithLocks did not check the column family. If
there is an illegal CF in the muation, it will throw NullPointException and
the update lock will not be released. So the region can not be flushed and
compacted.
HRegion #4946
{code}
if (!mutations.isEmpty() !walSyncSuccessful) {
LOG.warn(Wal sync failed. Roll back + mutations.size() +
memstore keyvalues for row(s): +
processor.getRowsToLock().iterator().next() + ...);
for (KeyValue kv : mutations) {
stores.get(kv.getFamily()).rollback(kv);
}
}
// 11. Roll mvcc forward
if (writeEntry != null) {
mvcc.completeMemstoreInsert(writeEntry);
writeEntry = null;
}
if (locked) {
this.updatesLock.readLock().unlock();
locked = false;
}
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11232) Region fail to release the updatelock for illegal CF in multi row mutations
[
https://issues.apache.org/jira/browse/HBASE-11232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Liang Xie updated HBASE-11232:
--
Affects Version/s: 0.94.19
Region fail to release the updatelock for illegal CF in multi row mutations
---
Key: HBASE-11232
URL: https://issues.apache.org/jira/browse/HBASE-11232
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.94.19
Reporter: Liu Shaohui
Assignee: Liu Shaohui
Attachments: HBASE-11232-0.94.diff
The failback code in processRowsWithLocks did not check the column family. If
there is an illegal CF in the muation, it will throw NullPointException and
the update lock will not be released. So the region can not be flushed and
compacted.
HRegion #4946
{code}
if (!mutations.isEmpty() !walSyncSuccessful) {
LOG.warn(Wal sync failed. Roll back + mutations.size() +
memstore keyvalues for row(s): +
processor.getRowsToLock().iterator().next() + ...);
for (KeyValue kv : mutations) {
stores.get(kv.getFamily()).rollback(kv);
}
}
// 11. Roll mvcc forward
if (writeEntry != null) {
mvcc.completeMemstoreInsert(writeEntry);
writeEntry = null;
}
if (locked) {
this.updatesLock.readLock().unlock();
locked = false;
}
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
