[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-13273: Resolution: Fixed Fix Version/s: (was: 0.98.13) 0.98.12 Release Note: The Result.EMPTY_RESULT object is now immutable. In previous releases, the object could be modified by a caller to no longer be empty. Code that relies on this behavior will now receive an UnsupportedOperationException. Status: Resolved (was: Patch Available) Pushed to 0.98+. Thanks Mikhail! Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 1.0.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Attachments: HBASE-13273-v5.patch, HBASE-13273-v5.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Status: Patch Available (was: Open) Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 0.98.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273-v5.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Status: Open (was: Patch Available) Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 0.98.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273-v5.patch, HBASE-13273-v5.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Status: Patch Available (was: Open) Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 0.98.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273-v5.patch, HBASE-13273-v5.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Attachment: HBASE-13273-v5.patch updating the same patch just to kick hadoop-qa bot Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 1.0.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273-v5.patch, HBASE-13273-v5.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Status: Open (was: Patch Available) Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 0.98.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273-v5.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Status: Open (was: Patch Available) Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 0.98.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273-v5.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Status: Patch Available (was: Open) Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 0.98.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273-v5.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Attachment: HBASE-13273.patch updated per [~larsgeorge] suggestion Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 1.0.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Status: Open (was: Patch Available) Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 0.98.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Status: Patch Available (was: Open) Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 0.98.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Status: Open (was: Patch Available) Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 0.98.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273-v5.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Attachment: HBASE-13273-v5.patch Thanks for review [~busbey] (and I indeed was habitually using just git diff HEAD~ patch file, my bad), here's updated patch. Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 1.0.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273-v5.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Status: Patch Available (was: Open) Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 0.98.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273-v5.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-13273: Fix Version/s: 0.98.12 1.1.0 1.0.1 2.0.0 Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 1.0.0 Reporter: stack Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Attachment: HBASE-13273.patch patch (testing on object identity in fact, as Result doesn't implement equals(), which is what we need in this case) Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 1.0.0 Reporter: stack Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Attachments: HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Status: Patch Available (was: Open) Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 0.98.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Attachments: HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Attachment: HBASE-13273.patch added trivial test case Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 1.0.0 Reporter: stack Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Attachments: HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-13273: --- Fix Version/s: (was: 0.98.12) 0.98.13 Ok, moved to .13 Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 1.0.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Status: Open (was: Patch Available) Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 0.98.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Status: Patch Available (was: Open) Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 0.98.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Attachment: HBASE-13273.patch Thanks for review [~busbey]! @Test wouldn't work, yeah, just checked.. Here's updated patch, how's that? Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 1.0.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Status: Open (was: Patch Available) Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 0.98.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Antonov updated HBASE-13273: Status: Patch Available (was: Open) Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 0.98.0 Reporter: stack Assignee: Mikhail Antonov Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13273.patch, HBASE-13273.patch, HBASE-13273.patch Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-13273: Affects Version/s: 0.98.0 1.0.0 Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 1.0.0 Reporter: stack Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13273) Make Result.EMPTY_RESULT read-only; currently it can be modified
[ https://issues.apache.org/jira/browse/HBASE-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-13273: Labels: beginner (was: ) Make Result.EMPTY_RESULT read-only; currently it can be modified Key: HBASE-13273 URL: https://issues.apache.org/jira/browse/HBASE-13273 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 1.0.0 Reporter: stack Labels: beginner Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Again from [~larsgeorge] Result result2 = Result.EMPTY_RESULT; System.out.println(result2); result2.copyFrom(result1); System.out.println(result2); What do you think happens when result1 has cells? Yep, you just modified the shared public EMPTY_RESULT to be not empty anymore. Fix. Result should be non-modifiable post-construction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
