[jira] [Updated] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
[
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Appy updated HBASE-14099:
-
Attachment: hfiles_and_testclass.zip
> StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
> and stop Row
> ---
>
> Key: HBASE-14099
> URL: https://issues.apache.org/jira/browse/HBASE-14099
> Project: HBase
> Issue Type: Improvement
> Components: Performance, Scanners
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-14099.patch, HBASE-14099_1.patch,
> HBASE-14099_2.patch, HBASE-14099_3.patch, HBASE-14099_4.patch,
> hfiles_and_testclass.zip, storefile.png
>
>
> During profiling saw that the code here in passesKeyRangeFilter in Storefile
> {code}
> KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
> .createFirstOnRow(scan.getStopRow()) :
> KeyValueUtil.createFirstOnRow(scan
> .getStartRow());
> KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
> .createLastOnRow(scan.getStartRow()) :
> KeyValueUtil.createLastOnRow(scan
> .getStopRow());
> {code}
> This row need not be copied now considering that we have
> CellComparator.compareRows(Cell, byte[]).
> We have already refactored the firstKeyKv and lastKeyKV as part of other
> JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
[
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-14099:
---
Status: Open (was: Patch Available)
StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
and stop Row
---
Key: HBASE-14099
URL: https://issues.apache.org/jira/browse/HBASE-14099
Project: HBase
Issue Type: Bug
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Priority: Minor
Fix For: 2.0.0
Attachments: HBASE-14099.patch, HBASE-14099_1.patch, storefile.png
During profiling saw that the code here in passesKeyRangeFilter in Storefile
{code}
KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createFirstOnRow(scan.getStopRow()) :
KeyValueUtil.createFirstOnRow(scan
.getStartRow());
KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createLastOnRow(scan.getStartRow()) :
KeyValueUtil.createLastOnRow(scan
.getStopRow());
{code}
This row need not be copied now considering that we have
CellComparator.compareRows(Cell, byte[]).
We have already refactored the firstKeyKv and lastKeyKV as part of other
JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
[
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-14099:
---
Status: Patch Available (was: Open)
StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
and stop Row
---
Key: HBASE-14099
URL: https://issues.apache.org/jira/browse/HBASE-14099
Project: HBase
Issue Type: Bug
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Priority: Minor
Fix For: 2.0.0
Attachments: HBASE-14099.patch, HBASE-14099_1.patch, storefile.png
During profiling saw that the code here in passesKeyRangeFilter in Storefile
{code}
KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createFirstOnRow(scan.getStopRow()) :
KeyValueUtil.createFirstOnRow(scan
.getStartRow());
KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createLastOnRow(scan.getStartRow()) :
KeyValueUtil.createLastOnRow(scan
.getStopRow());
{code}
This row need not be copied now considering that we have
CellComparator.compareRows(Cell, byte[]).
We have already refactored the firstKeyKv and lastKeyKV as part of other
JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
[
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anoop Sam John updated HBASE-14099:
---
Component/s: Scanners
Performance
StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
and stop Row
---
Key: HBASE-14099
URL: https://issues.apache.org/jira/browse/HBASE-14099
Project: HBase
Issue Type: Bug
Components: Performance, Scanners
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Priority: Minor
Fix For: 2.0.0
Attachments: HBASE-14099.patch, HBASE-14099_1.patch, storefile.png
During profiling saw that the code here in passesKeyRangeFilter in Storefile
{code}
KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createFirstOnRow(scan.getStopRow()) :
KeyValueUtil.createFirstOnRow(scan
.getStartRow());
KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createLastOnRow(scan.getStartRow()) :
KeyValueUtil.createLastOnRow(scan
.getStopRow());
{code}
This row need not be copied now considering that we have
CellComparator.compareRows(Cell, byte[]).
We have already refactored the firstKeyKv and lastKeyKV as part of other
JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
[
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anoop Sam John updated HBASE-14099:
---
Priority: Major (was: Minor)
StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
and stop Row
---
Key: HBASE-14099
URL: https://issues.apache.org/jira/browse/HBASE-14099
Project: HBase
Issue Type: Improvement
Components: Performance, Scanners
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 2.0.0
Attachments: HBASE-14099.patch, HBASE-14099_1.patch, storefile.png
During profiling saw that the code here in passesKeyRangeFilter in Storefile
{code}
KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createFirstOnRow(scan.getStopRow()) :
KeyValueUtil.createFirstOnRow(scan
.getStartRow());
KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createLastOnRow(scan.getStartRow()) :
KeyValueUtil.createLastOnRow(scan
.getStopRow());
{code}
This row need not be copied now considering that we have
CellComparator.compareRows(Cell, byte[]).
We have already refactored the firstKeyKv and lastKeyKV as part of other
JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
[
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-14099:
---
Attachment: storefile.png
HBASE-14099_1.patch
Just refactored it as suggested. Also the KVUtil.createLastOnRow was creating a
KV with LATEST_TIMESTAMP. It should be OLDEST_TIMESTAMP.
Also attaching a screen shot of a profiler that shows this KV creation that
happens by copying the byte[] before the patch. We reduce two object creations
including its copy.
Thanks for the review.
StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
and stop Row
---
Key: HBASE-14099
URL: https://issues.apache.org/jira/browse/HBASE-14099
Project: HBase
Issue Type: Bug
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Priority: Minor
Fix For: 2.0.0
Attachments: HBASE-14099.patch, HBASE-14099_1.patch, storefile.png
During profiling saw that the code here in passesKeyRangeFilter in Storefile
{code}
KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createFirstOnRow(scan.getStopRow()) :
KeyValueUtil.createFirstOnRow(scan
.getStartRow());
KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createLastOnRow(scan.getStartRow()) :
KeyValueUtil.createLastOnRow(scan
.getStopRow());
{code}
This row need not be copied now considering that we have
CellComparator.compareRows(Cell, byte[]).
We have already refactored the firstKeyKv and lastKeyKV as part of other
JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
[
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anoop Sam John updated HBASE-14099:
---
Issue Type: Improvement (was: Bug)
StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
and stop Row
---
Key: HBASE-14099
URL: https://issues.apache.org/jira/browse/HBASE-14099
Project: HBase
Issue Type: Improvement
Components: Performance, Scanners
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Priority: Minor
Fix For: 2.0.0
Attachments: HBASE-14099.patch, HBASE-14099_1.patch, storefile.png
During profiling saw that the code here in passesKeyRangeFilter in Storefile
{code}
KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createFirstOnRow(scan.getStopRow()) :
KeyValueUtil.createFirstOnRow(scan
.getStartRow());
KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createLastOnRow(scan.getStartRow()) :
KeyValueUtil.createLastOnRow(scan
.getStopRow());
{code}
This row need not be copied now considering that we have
CellComparator.compareRows(Cell, byte[]).
We have already refactored the firstKeyKv and lastKeyKV as part of other
JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
[
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-14099:
---
Attachment: HBASE-14099_2.patch
Updated patch that handles the createFirstOnRowDeleteFamily also. Now we create
a cell object without copying by using the FakeCell concept.
StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
and stop Row
---
Key: HBASE-14099
URL: https://issues.apache.org/jira/browse/HBASE-14099
Project: HBase
Issue Type: Improvement
Components: Performance, Scanners
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 2.0.0
Attachments: HBASE-14099.patch, HBASE-14099_1.patch,
HBASE-14099_2.patch, storefile.png
During profiling saw that the code here in passesKeyRangeFilter in Storefile
{code}
KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createFirstOnRow(scan.getStopRow()) :
KeyValueUtil.createFirstOnRow(scan
.getStartRow());
KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createLastOnRow(scan.getStartRow()) :
KeyValueUtil.createLastOnRow(scan
.getStopRow());
{code}
This row need not be copied now considering that we have
CellComparator.compareRows(Cell, byte[]).
We have already refactored the firstKeyKv and lastKeyKV as part of other
JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
[
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-14099:
---
Status: Patch Available (was: Open)
StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
and stop Row
---
Key: HBASE-14099
URL: https://issues.apache.org/jira/browse/HBASE-14099
Project: HBase
Issue Type: Improvement
Components: Performance, Scanners
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 2.0.0
Attachments: HBASE-14099.patch, HBASE-14099_1.patch,
HBASE-14099_2.patch, storefile.png
During profiling saw that the code here in passesKeyRangeFilter in Storefile
{code}
KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createFirstOnRow(scan.getStopRow()) :
KeyValueUtil.createFirstOnRow(scan
.getStartRow());
KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createLastOnRow(scan.getStartRow()) :
KeyValueUtil.createLastOnRow(scan
.getStopRow());
{code}
This row need not be copied now considering that we have
CellComparator.compareRows(Cell, byte[]).
We have already refactored the firstKeyKv and lastKeyKV as part of other
JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
[
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-14099:
---
Attachment: HBASE-14099_3.patch
Updated patch. Renamed to createFirstDeleteFamilyCellOnRow. Also removed
KVUtil.createFirstDeleteFamilyOnRow() as per suggestion by Anoop.
StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
and stop Row
---
Key: HBASE-14099
URL: https://issues.apache.org/jira/browse/HBASE-14099
Project: HBase
Issue Type: Improvement
Components: Performance, Scanners
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 2.0.0
Attachments: HBASE-14099.patch, HBASE-14099_1.patch,
HBASE-14099_2.patch, HBASE-14099_3.patch, storefile.png
During profiling saw that the code here in passesKeyRangeFilter in Storefile
{code}
KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createFirstOnRow(scan.getStopRow()) :
KeyValueUtil.createFirstOnRow(scan
.getStartRow());
KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createLastOnRow(scan.getStartRow()) :
KeyValueUtil.createLastOnRow(scan
.getStopRow());
{code}
This row need not be copied now considering that we have
CellComparator.compareRows(Cell, byte[]).
We have already refactored the firstKeyKv and lastKeyKV as part of other
JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
[
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-14099:
---
Status: Patch Available (was: Open)
StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
and stop Row
---
Key: HBASE-14099
URL: https://issues.apache.org/jira/browse/HBASE-14099
Project: HBase
Issue Type: Improvement
Components: Performance, Scanners
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 2.0.0
Attachments: HBASE-14099.patch, HBASE-14099_1.patch,
HBASE-14099_2.patch, HBASE-14099_3.patch, storefile.png
During profiling saw that the code here in passesKeyRangeFilter in Storefile
{code}
KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createFirstOnRow(scan.getStopRow()) :
KeyValueUtil.createFirstOnRow(scan
.getStartRow());
KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createLastOnRow(scan.getStartRow()) :
KeyValueUtil.createLastOnRow(scan
.getStopRow());
{code}
This row need not be copied now considering that we have
CellComparator.compareRows(Cell, byte[]).
We have already refactored the firstKeyKv and lastKeyKV as part of other
JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
[
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-14099:
---
Status: Open (was: Patch Available)
StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
and stop Row
---
Key: HBASE-14099
URL: https://issues.apache.org/jira/browse/HBASE-14099
Project: HBase
Issue Type: Improvement
Components: Performance, Scanners
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 2.0.0
Attachments: HBASE-14099.patch, HBASE-14099_1.patch, storefile.png
During profiling saw that the code here in passesKeyRangeFilter in Storefile
{code}
KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createFirstOnRow(scan.getStopRow()) :
KeyValueUtil.createFirstOnRow(scan
.getStartRow());
KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createLastOnRow(scan.getStartRow()) :
KeyValueUtil.createLastOnRow(scan
.getStopRow());
{code}
This row need not be copied now considering that we have
CellComparator.compareRows(Cell, byte[]).
We have already refactored the firstKeyKv and lastKeyKV as part of other
JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
[
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-14099:
---
Status: Open (was: Patch Available)
StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
and stop Row
---
Key: HBASE-14099
URL: https://issues.apache.org/jira/browse/HBASE-14099
Project: HBase
Issue Type: Improvement
Components: Performance, Scanners
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 2.0.0
Attachments: HBASE-14099.patch, HBASE-14099_1.patch,
HBASE-14099_2.patch, storefile.png
During profiling saw that the code here in passesKeyRangeFilter in Storefile
{code}
KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createFirstOnRow(scan.getStopRow()) :
KeyValueUtil.createFirstOnRow(scan
.getStartRow());
KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createLastOnRow(scan.getStartRow()) :
KeyValueUtil.createLastOnRow(scan
.getStopRow());
{code}
This row need not be copied now considering that we have
CellComparator.compareRows(Cell, byte[]).
We have already refactored the firstKeyKv and lastKeyKV as part of other
JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
[
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-14099:
---
Attachment: HBASE-14099_4.patch
bq.-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestFastFail
The failure is random I think. Corrected the javadoc too. Will commit this
patch now.
StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
and stop Row
---
Key: HBASE-14099
URL: https://issues.apache.org/jira/browse/HBASE-14099
Project: HBase
Issue Type: Improvement
Components: Performance, Scanners
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 2.0.0
Attachments: HBASE-14099.patch, HBASE-14099_1.patch,
HBASE-14099_2.patch, HBASE-14099_3.patch, HBASE-14099_4.patch, storefile.png
During profiling saw that the code here in passesKeyRangeFilter in Storefile
{code}
KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createFirstOnRow(scan.getStopRow()) :
KeyValueUtil.createFirstOnRow(scan
.getStartRow());
KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createLastOnRow(scan.getStartRow()) :
KeyValueUtil.createLastOnRow(scan
.getStopRow());
{code}
This row need not be copied now considering that we have
CellComparator.compareRows(Cell, byte[]).
We have already refactored the firstKeyKv and lastKeyKV as part of other
JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
[
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-14099:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
Pushed to master. Thanks for the reviews Anoop.
StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
and stop Row
---
Key: HBASE-14099
URL: https://issues.apache.org/jira/browse/HBASE-14099
Project: HBase
Issue Type: Improvement
Components: Performance, Scanners
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 2.0.0
Attachments: HBASE-14099.patch, HBASE-14099_1.patch,
HBASE-14099_2.patch, HBASE-14099_3.patch, HBASE-14099_4.patch, storefile.png
During profiling saw that the code here in passesKeyRangeFilter in Storefile
{code}
KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createFirstOnRow(scan.getStopRow()) :
KeyValueUtil.createFirstOnRow(scan
.getStartRow());
KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createLastOnRow(scan.getStartRow()) :
KeyValueUtil.createLastOnRow(scan
.getStopRow());
{code}
This row need not be copied now considering that we have
CellComparator.compareRows(Cell, byte[]).
We have already refactored the firstKeyKv and lastKeyKV as part of other
JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
[
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-14099:
---
Attachment: HBASE-14099.patch
Attaching for QA.
StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
and stop Row
---
Key: HBASE-14099
URL: https://issues.apache.org/jira/browse/HBASE-14099
Project: HBase
Issue Type: Bug
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Priority: Minor
Fix For: 2.0.0
Attachments: HBASE-14099.patch
During profiling saw that the code here in passesKeyRangeFilter in Storefile
{code}
KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createFirstOnRow(scan.getStopRow()) :
KeyValueUtil.createFirstOnRow(scan
.getStartRow());
KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createLastOnRow(scan.getStartRow()) :
KeyValueUtil.createLastOnRow(scan
.getStopRow());
{code}
This row need not be copied now considering that we have
CellComparator.compareRows(Cell, byte[]).
We have already refactored the firstKeyKv and lastKeyKV as part of other
JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
[
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-14099:
---
Status: Patch Available (was: Open)
StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
and stop Row
---
Key: HBASE-14099
URL: https://issues.apache.org/jira/browse/HBASE-14099
Project: HBase
Issue Type: Bug
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Priority: Minor
Fix For: 2.0.0
Attachments: HBASE-14099.patch
During profiling saw that the code here in passesKeyRangeFilter in Storefile
{code}
KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createFirstOnRow(scan.getStopRow()) :
KeyValueUtil.createFirstOnRow(scan
.getStartRow());
KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createLastOnRow(scan.getStartRow()) :
KeyValueUtil.createLastOnRow(scan
.getStopRow());
{code}
This row need not be copied now considering that we have
CellComparator.compareRows(Cell, byte[]).
We have already refactored the firstKeyKv and lastKeyKV as part of other
JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
[
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-14099:
---
Fix Version/s: 2.0.0
StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
and stop Row
---
Key: HBASE-14099
URL: https://issues.apache.org/jira/browse/HBASE-14099
Project: HBase
Issue Type: Bug
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Priority: Minor
Fix For: 2.0.0
During profiling saw that the code here in passesKeyRangeFilter in Storefile
{code}
KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createFirstOnRow(scan.getStopRow()) :
KeyValueUtil.createFirstOnRow(scan
.getStartRow());
KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
.createLastOnRow(scan.getStartRow()) :
KeyValueUtil.createLastOnRow(scan
.getStopRow());
{code}
This row need not be copied now considering that we have
CellComparator.compareRows(Cell, byte[]).
We have already refactored the firstKeyKv and lastKeyKV as part of other
JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
