[jira] [Updated] (HBASE-14382) Missing interface audience annotations

2015-09-08 Thread Nick Dimiduk (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-14382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk updated HBASE-14382:
-
Priority: Minor  (was: Blocker)

> Missing interface audience annotations
> --
>
> Key: HBASE-14382
> URL: https://issues.apache.org/jira/browse/HBASE-14382
> Project: HBase
>  Issue Type: Bug
>  Components: Client
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14382.00.patch
>
>
> Over on HBASE-12911, buildbot tells me I'm missing some interface audience 
> annotations. Indeed, from test log, my patch is not the only one missing 
> annotations.
> {noformat}
> 2015-09-08 12:05:31,071 DEBUG [main] hbase.ClassFinder(147): Looking in 
> /Users/ndimiduk/repos/hbase/hbase-client/target/classes/org/apache/hadoop/hbase;
>  isJar=false
> 2015-09-08 12:05:31,071 DEBUG [main] hbase.ClassFinder(147): Looking in 
> /Users/ndimiduk/repos/hbase/hbase-annotations/target/classes/org/apache/hadoop/hbase;
>  isJar=false
> 2015-09-08 12:05:31,071 DEBUG [main] hbase.ClassFinder(147): Looking in 
> /Users/ndimiduk/repos/hbase/hbase-common/target/classes/org/apache/hadoop/hbase;
>  isJar=false
> 2015-09-08 12:05:31,072 DEBUG [main] hbase.ClassFinder(147): Looking in 
> /Users/ndimiduk/repos/hbase/hbase-hadoop-compat/target/classes/org/apache/hadoop/hbase;
>  isJar=false
> 2015-09-08 12:05:31,072 DEBUG [main] hbase.ClassFinder(147): Looking in 
> /Users/ndimiduk/repos/hbase/hbase-hadoop2-compat/target/classes/org/apache/hadoop/hbase;
>  isJar=false
> 2015-09-08 12:05:31,072 DEBUG [main] hbase.ClassFinder(147): Looking in 
> /Users/ndimiduk/repos/hbase/hbase-protocol/target/classes/org/apache/hadoop/hbase;
>  isJar=false
> 2015-09-08 12:05:31,158 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(252): These are the classes that DO 
> NOT have @InterfaceAudience annotation:
> 2015-09-08 12:05:31,158 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.client.MetricsRegionClientWrapper
> 2015-09-08 12:05:31,158 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.client.MetricsConnectionWrapper
> 2015-09-08 12:05:31,160 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.client.MetricsConnectionSourceFactory
> 2015-09-08 12:05:31,160 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.client.MetricsConnectionHostSource
> 2015-09-08 12:05:31,160 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): class 
> org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSourceSourceImpl
> 2015-09-08 12:05:31,160 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSourceFactory
> 2015-09-08 12:05:31,160 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.thrift.MetricsThriftServerSource
> 2015-09-08 12:05:31,160 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.master.balancer.MetricsStochasticBalancerSource
> 2015-09-08 12:05:31,161 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.regionserver.wal.MetricsEditsReplaySource
> 2015-09-08 12:05:31,161 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.thrift.MetricsThriftServerSourceFactory
> 2015-09-08 12:05:31,161 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): class 
> org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSinkSourceImpl
> 2015-09-08 12:05:31,161 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.client.MetricsConnectionSource
> 2015-09-08 12:05:31,161 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.regionserver.MetricsRegionServerWrapper
> 2015-09-08 12:05:31,161 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.regionserver.MetricsRegionServerSource
> 2015-09-08 12:05:31,161 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): class 
> org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationGlobalSourceSource
> 2015-09-08 12:05:31,162 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): class 
> org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSourceFactoryImpl
> 2015-09-08 12:05:31,162 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.regionserver.MetricsRegionSource
> 2015-09-08 12:05:31,162 INFO  [main] 
>

[jira] [Updated] (HBASE-14382) Missing interface audience annotations

2015-09-08 Thread Nick Dimiduk (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-14382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk updated HBASE-14382:
-
Attachment: HBASE-14382.00.patch

Not quite, there's a bug there. I need the following patch above HBASE-12911 to 
get the test passing.

> Missing interface audience annotations
> --
>
> Key: HBASE-14382
> URL: https://issues.apache.org/jira/browse/HBASE-14382
> Project: HBase
>  Issue Type: Bug
>  Components: Client
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Blocker
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14382.00.patch
>
>
> Over on HBASE-12911, buildbot tells me I'm missing some interface audience 
> annotations. Indeed, from test log, my patch is not the only one missing 
> annotations.
> {noformat}
> 2015-09-08 12:05:31,071 DEBUG [main] hbase.ClassFinder(147): Looking in 
> /Users/ndimiduk/repos/hbase/hbase-client/target/classes/org/apache/hadoop/hbase;
>  isJar=false
> 2015-09-08 12:05:31,071 DEBUG [main] hbase.ClassFinder(147): Looking in 
> /Users/ndimiduk/repos/hbase/hbase-annotations/target/classes/org/apache/hadoop/hbase;
>  isJar=false
> 2015-09-08 12:05:31,071 DEBUG [main] hbase.ClassFinder(147): Looking in 
> /Users/ndimiduk/repos/hbase/hbase-common/target/classes/org/apache/hadoop/hbase;
>  isJar=false
> 2015-09-08 12:05:31,072 DEBUG [main] hbase.ClassFinder(147): Looking in 
> /Users/ndimiduk/repos/hbase/hbase-hadoop-compat/target/classes/org/apache/hadoop/hbase;
>  isJar=false
> 2015-09-08 12:05:31,072 DEBUG [main] hbase.ClassFinder(147): Looking in 
> /Users/ndimiduk/repos/hbase/hbase-hadoop2-compat/target/classes/org/apache/hadoop/hbase;
>  isJar=false
> 2015-09-08 12:05:31,072 DEBUG [main] hbase.ClassFinder(147): Looking in 
> /Users/ndimiduk/repos/hbase/hbase-protocol/target/classes/org/apache/hadoop/hbase;
>  isJar=false
> 2015-09-08 12:05:31,158 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(252): These are the classes that DO 
> NOT have @InterfaceAudience annotation:
> 2015-09-08 12:05:31,158 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.client.MetricsRegionClientWrapper
> 2015-09-08 12:05:31,158 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.client.MetricsConnectionWrapper
> 2015-09-08 12:05:31,160 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.client.MetricsConnectionSourceFactory
> 2015-09-08 12:05:31,160 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.client.MetricsConnectionHostSource
> 2015-09-08 12:05:31,160 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): class 
> org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSourceSourceImpl
> 2015-09-08 12:05:31,160 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSourceFactory
> 2015-09-08 12:05:31,160 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.thrift.MetricsThriftServerSource
> 2015-09-08 12:05:31,160 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.master.balancer.MetricsStochasticBalancerSource
> 2015-09-08 12:05:31,161 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.regionserver.wal.MetricsEditsReplaySource
> 2015-09-08 12:05:31,161 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.thrift.MetricsThriftServerSourceFactory
> 2015-09-08 12:05:31,161 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): class 
> org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSinkSourceImpl
> 2015-09-08 12:05:31,161 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.client.MetricsConnectionSource
> 2015-09-08 12:05:31,161 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.regionserver.MetricsRegionServerWrapper
> 2015-09-08 12:05:31,161 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
> org.apache.hadoop.hbase.regionserver.MetricsRegionServerSource
> 2015-09-08 12:05:31,161 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): class 
> org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationGlobalSourceSource
> 2015-09-08 12:05:31,162 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): class 
> org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSourceFactoryImpl
> 2015-09-08 12:05:31,162 INFO  [main] 
> hbase.TestInterfaceAudienceAnnotations(254): interface 
>