[jira] [Updated] (HBASE-14448) Refine RegionGroupingProvider Phase-2: remove provider nesting and formalize wal group name
[ https://issues.apache.org/jira/browse/HBASE-14448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-14448: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Thanks for the patch, Yu. > Refine RegionGroupingProvider Phase-2: remove provider nesting and formalize > wal group name > --- > > Key: HBASE-14448 > URL: https://issues.apache.org/jira/browse/HBASE-14448 > Project: HBase > Issue Type: Improvement >Reporter: Yu Li >Assignee: Yu Li > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14448.patch, HBASE-14448_v2.patch, > HBASE-14448_v3.patch > > > Now we are nesting DefaultWALProvider inside RegionGroupingProvider, which > makes the logic ambiguous since a "provider" itself should provide logs. > Suggest to directly instantiate FSHlog in RegionGroupingProvider. > W.r.t wal group name, now in RegionGroupingProvider it's using sth like > "\-null\-" which is quite long and unnecessary. > Suggest to directly use ".". > For more details, please refer to the initial patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14448) Refine RegionGroupingProvider Phase-2: remove provider nesting and formalize wal group name
[ https://issues.apache.org/jira/browse/HBASE-14448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated HBASE-14448: -- Attachment: HBASE-14448_v3.patch > Refine RegionGroupingProvider Phase-2: remove provider nesting and formalize > wal group name > --- > > Key: HBASE-14448 > URL: https://issues.apache.org/jira/browse/HBASE-14448 > Project: HBase > Issue Type: Improvement >Reporter: Yu Li >Assignee: Yu Li > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14448.patch, HBASE-14448_v2.patch, > HBASE-14448_v3.patch > > > Now we are nesting DefaultWALProvider inside RegionGroupingProvider, which > makes the logic ambiguous since a "provider" itself should provide logs. > Suggest to directly instantiate FSHlog in RegionGroupingProvider. > W.r.t wal group name, now in RegionGroupingProvider it's using sth like > "\-null\-" which is quite long and unnecessary. > Suggest to directly use ".". > For more details, please refer to the initial patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14448) Refine RegionGroupingProvider Phase-2: remove provider nesting and formalize wal group name
[ https://issues.apache.org/jira/browse/HBASE-14448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated HBASE-14448: -- Description: Now we are nesting DefaultWALProvider inside RegionGroupingProvider, which makes the logic ambiguous since a "provider" itself should provide logs. Suggest to directly instantiate FSHlog in RegionGroupingProvider. W.r.t wal group name, now in RegionGroupingProvider it's using sth like "\-null\-" which is quite long and unnecessary. Suggest to directly use ".". For more details, please refer to the initial patch. was: Now we are nesting DefaultWALProvider inside RegionGroupingProvider, which makes the logic ambiguous since a "provider" itself should provide logs. Suggest to directly instantiate FSHlog in RegionGroupingProvider. W.r.t wal group name, now in RegionGroupingProvider it's using sth like "-null-" which is quite long and unnecessary. Suggest to directly use ".". For more details, please refer to the initial patch. > Refine RegionGroupingProvider Phase-2: remove provider nesting and formalize > wal group name > --- > > Key: HBASE-14448 > URL: https://issues.apache.org/jira/browse/HBASE-14448 > Project: HBase > Issue Type: Improvement >Reporter: Yu Li >Assignee: Yu Li > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14448.patch, HBASE-14448_v2.patch > > > Now we are nesting DefaultWALProvider inside RegionGroupingProvider, which > makes the logic ambiguous since a "provider" itself should provide logs. > Suggest to directly instantiate FSHlog in RegionGroupingProvider. > W.r.t wal group name, now in RegionGroupingProvider it's using sth like > "\-null\-" which is quite long and unnecessary. > Suggest to directly use ".". > For more details, please refer to the initial patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14448) Refine RegionGroupingProvider Phase-2: remove provider nesting and formalize wal group name
[ https://issues.apache.org/jira/browse/HBASE-14448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated HBASE-14448: -- Attachment: HBASE-14448.patch > Refine RegionGroupingProvider Phase-2: remove provider nesting and formalize > wal group name > --- > > Key: HBASE-14448 > URL: https://issues.apache.org/jira/browse/HBASE-14448 > Project: HBase > Issue Type: Improvement >Reporter: Yu Li >Assignee: Yu Li > Attachments: HBASE-14448.patch > > > Now we are nesting DefaultWALProvider inside RegionGroupingProvider, which > makes the logic ambiguous since a "provider" itself should provide logs. > Suggest to directly instantiate FSHlog in RegionGroupingProvider. > W.r.t wal group name, now in RegionGroupingProvider it's using sth like > "-null-" which is quite long and unnecessary. Suggest > to directly use ".". > For more details, please refer to the initial patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14448) Refine RegionGroupingProvider Phase-2: remove provider nesting and formalize wal group name
[ https://issues.apache.org/jira/browse/HBASE-14448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated HBASE-14448: -- Attachment: HBASE-14448_v2.patch Upload patch in sync with rb > Refine RegionGroupingProvider Phase-2: remove provider nesting and formalize > wal group name > --- > > Key: HBASE-14448 > URL: https://issues.apache.org/jira/browse/HBASE-14448 > Project: HBase > Issue Type: Improvement >Reporter: Yu Li >Assignee: Yu Li > Attachments: HBASE-14448.patch, HBASE-14448_v2.patch > > > Now we are nesting DefaultWALProvider inside RegionGroupingProvider, which > makes the logic ambiguous since a "provider" itself should provide logs. > Suggest to directly instantiate FSHlog in RegionGroupingProvider. > W.r.t wal group name, now in RegionGroupingProvider it's using sth like > "-null-" which is quite long and unnecessary. Suggest > to directly use ".". > For more details, please refer to the initial patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
