[jira] [Updated] (HBASE-15080) Remove synchronized block from MasterServiceStubMaker#releaseZooKeeperWatcher()

2016-01-08 Thread Ted Yu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-15080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-15080:
---
  Resolution: Fixed
Hadoop Flags: Reviewed
  Status: Resolved  (was: Patch Available)

Thanks, Josh

> Remove synchronized block from 
> MasterServiceStubMaker#releaseZooKeeperWatcher()
> ---
>
> Key: HBASE-15080
> URL: https://issues.apache.org/jira/browse/HBASE-15080
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 0.98.17
>
> Attachments: 15080-0.98.txt
>
>
> This is a follow up to HBASE-11460
> [~elserj] found that in 0.98, the synchronized block below should have been 
> taken out (as was done for branch-1 +):
> {code}
>   synchronized (masterAndZKLock) {
> if (keepAliveZookeeperUserCount.decrementAndGet() <= 0 ){
> {code}
> keepAliveZookeeperUserCount is an AtomicInteger. There is no need for the 
> synchronized block.
> This issue is to remove the synchronized block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-15080) Remove synchronized block from MasterServiceStubMaker#releaseZooKeeperWatcher()

2016-01-07 Thread Ted Yu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-15080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-15080:
---
Summary: Remove synchronized block from 
MasterServiceStubMaker#releaseZooKeeperWatcher()  (was: Remove synchronized 
keyword from MasterServiceStubMaker#releaseZooKeeperWatcher())

> Remove synchronized block from 
> MasterServiceStubMaker#releaseZooKeeperWatcher()
> ---
>
> Key: HBASE-15080
> URL: https://issues.apache.org/jira/browse/HBASE-15080
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 0.98.17
>
> Attachments: 15080-0.98.txt
>
>
> This is a follow up to HBASE-11460
> [~elserj] found that in 0.98, the synchronized block below should have been 
> taken out (as was done for branch-1 +):
> {code}
>   synchronized (masterAndZKLock) {
> if (keepAliveZookeeperUserCount.decrementAndGet() <= 0 ){
> {code}
> keepAliveZookeeperUserCount is an AtomicInteger. There is no need for the 
> synchronized block.
> This issue is to remove the synchronized block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)