[jira] [Updated] (HBASE-15222) Use less contended classes for metrics
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-15222: Issue Type: Improvement (was: Bug) > Use less contended classes for metrics > -- > > Key: HBASE-15222 > URL: https://issues.apache.org/jira/browse/HBASE-15222 > Project: HBase > Issue Type: Improvement > Components: metrics >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-15222-ADD-0.patch, HBASE-15222-v1.patch, > HBASE-15222-v10.patch, HBASE-15222-v11.patch, HBASE-15222-v12.patch, > HBASE-15222-v13.patch, HBASE-15222-v2.patch, HBASE-15222-v3.patch, > HBASE-15222-v5.patch, HBASE-15222-v6.patch, HBASE-15222-v8.patch, > HBASE-15222-v9.patch, HBASE-15222.patch > > > Running the benchmarks now, but it looks like the results are pretty extreme. > The locking in our histograms is pretty extreme. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15222) Use less contended classes for metrics
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Attachment: HBASE-15222-ADD-0.patch > Use less contended classes for metrics > -- > > Key: HBASE-15222 > URL: https://issues.apache.org/jira/browse/HBASE-15222 > Project: HBase > Issue Type: Bug > Components: metrics >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-15222-ADD-0.patch, HBASE-15222-v1.patch, > HBASE-15222-v10.patch, HBASE-15222-v11.patch, HBASE-15222-v12.patch, > HBASE-15222-v13.patch, HBASE-15222-v2.patch, HBASE-15222-v3.patch, > HBASE-15222-v5.patch, HBASE-15222-v6.patch, HBASE-15222-v8.patch, > HBASE-15222-v9.patch, HBASE-15222.patch > > > Running the benchmarks now, but it looks like the results are pretty extreme. > The locking in our histograms is pretty extreme. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15222) Use less contended classes for metrics
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed to master and branch-1 Thanks > Use less contended classes for metrics > -- > > Key: HBASE-15222 > URL: https://issues.apache.org/jira/browse/HBASE-15222 > Project: HBase > Issue Type: Bug > Components: metrics >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-15222-v1.patch, HBASE-15222-v10.patch, > HBASE-15222-v11.patch, HBASE-15222-v12.patch, HBASE-15222-v13.patch, > HBASE-15222-v2.patch, HBASE-15222-v3.patch, HBASE-15222-v5.patch, > HBASE-15222-v6.patch, HBASE-15222-v8.patch, HBASE-15222-v9.patch, > HBASE-15222.patch > > > Running the benchmarks now, but it looks like the results are pretty extreme. > The locking in our histograms is pretty extreme. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15222) Use less contended classes for metrics
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Attachment: HBASE-15222-v13.patch Fixed checkstyle. The issue with installing is because yetus is not working well with our modules depending upon each other. > Use less contended classes for metrics > -- > > Key: HBASE-15222 > URL: https://issues.apache.org/jira/browse/HBASE-15222 > Project: HBase > Issue Type: Bug > Components: metrics >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-15222-v1.patch, HBASE-15222-v10.patch, > HBASE-15222-v11.patch, HBASE-15222-v12.patch, HBASE-15222-v13.patch, > HBASE-15222-v2.patch, HBASE-15222-v3.patch, HBASE-15222-v5.patch, > HBASE-15222-v6.patch, HBASE-15222-v8.patch, HBASE-15222-v9.patch, > HBASE-15222.patch > > > Running the benchmarks now, but it looks like the results are pretty extreme. > The locking in our histograms is pretty extreme. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15222) Use less contended classes for metrics
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Attachment: HBASE-15222-v12.patch Protect against divide by zero for mean. > Use less contended classes for metrics > -- > > Key: HBASE-15222 > URL: https://issues.apache.org/jira/browse/HBASE-15222 > Project: HBase > Issue Type: Bug > Components: metrics >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-15222-v1.patch, HBASE-15222-v10.patch, > HBASE-15222-v11.patch, HBASE-15222-v12.patch, HBASE-15222-v2.patch, > HBASE-15222-v3.patch, HBASE-15222-v5.patch, HBASE-15222-v6.patch, > HBASE-15222-v8.patch, HBASE-15222-v9.patch, HBASE-15222.patch > > > Running the benchmarks now, but it looks like the results are pretty extreme. > The locking in our histograms is pretty extreme. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15222) Use less contended classes for metrics
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Attachment: HBASE-15222-v11.patch I had left some debug numbers in when creating buckets. So there were only 4 bins. Fixed that. > Use less contended classes for metrics > -- > > Key: HBASE-15222 > URL: https://issues.apache.org/jira/browse/HBASE-15222 > Project: HBase > Issue Type: Bug > Components: metrics >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-15222-v1.patch, HBASE-15222-v10.patch, > HBASE-15222-v11.patch, HBASE-15222-v2.patch, HBASE-15222-v3.patch, > HBASE-15222-v5.patch, HBASE-15222-v6.patch, HBASE-15222-v8.patch, > HBASE-15222-v9.patch, HBASE-15222.patch > > > Running the benchmarks now, but it looks like the results are pretty extreme. > The locking in our histograms is pretty extreme. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15222) Use less contended classes for metrics
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Attachment: HBASE-15222-v10.patch Updated commit message to reflect the correct class used for histograms. > Use less contended classes for metrics > -- > > Key: HBASE-15222 > URL: https://issues.apache.org/jira/browse/HBASE-15222 > Project: HBase > Issue Type: Bug > Components: metrics >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-15222-v1.patch, HBASE-15222-v10.patch, > HBASE-15222-v2.patch, HBASE-15222-v3.patch, HBASE-15222-v5.patch, > HBASE-15222-v6.patch, HBASE-15222-v8.patch, HBASE-15222-v9.patch, > HBASE-15222.patch > > > Running the benchmarks now, but it looks like the results are pretty extreme. > The locking in our histograms is pretty extreme. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15222) Use less contended classes for metrics
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Attachment: HBASE-15222-v9.patch Not sure why the last patch didn't trigger HadoopQA > Use less contended classes for metrics > -- > > Key: HBASE-15222 > URL: https://issues.apache.org/jira/browse/HBASE-15222 > Project: HBase > Issue Type: Bug > Components: metrics >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-15222-v1.patch, HBASE-15222-v2.patch, > HBASE-15222-v3.patch, HBASE-15222-v5.patch, HBASE-15222-v6.patch, > HBASE-15222-v8.patch, HBASE-15222-v9.patch, HBASE-15222.patch > > > Running the benchmarks now, but it looks like the results are pretty extreme. > The locking in our histograms is pretty extreme. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15222) Use less contended classes for metrics
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliott Clark updated HBASE-15222:
--
Attachment: HBASE-15222-v8.patch
Use fast long histogram for both histogram and for timerange/sizerange
estimates.
Benchmarks:
{code}
Benchmark Mode Cnt ScoreError
Units
HistogramBenchmark.fastLong sample 3338218 401.795 ± 37.543
ns/op
HistogramBenchmark.testHDRAtomic sample 2952135 780.955 ± 27.390
ns/op
HistogramBenchmark.testHDRConcurrent sample 2875714 844.485 ± 43.087
ns/op
HistogramBenchmark.testMutableTimeHistogram sample 4192279 304.305 ± 20.453
ns/op
HistogramBenchmark.testYammersample 2747876 1508.518 ± 48.166
ns/op
{code}
> Use less contended classes for metrics
> --
>
> Key: HBASE-15222
> URL: https://issues.apache.org/jira/browse/HBASE-15222
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: Elliott Clark
>Assignee: Elliott Clark
>Priority: Critical
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-15222-v1.patch, HBASE-15222-v2.patch,
> HBASE-15222-v3.patch, HBASE-15222-v5.patch, HBASE-15222-v6.patch,
> HBASE-15222-v8.patch, HBASE-15222.patch
>
>
> Running the benchmarks now, but it looks like the results are pretty extreme.
> The locking in our histograms is pretty extreme.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-15222) Use less contended classes for metrics
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Attachment: HBASE-15222-v6.patch > Use less contended classes for metrics > -- > > Key: HBASE-15222 > URL: https://issues.apache.org/jira/browse/HBASE-15222 > Project: HBase > Issue Type: Bug > Components: metrics >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-15222-v1.patch, HBASE-15222-v2.patch, > HBASE-15222-v3.patch, HBASE-15222-v5.patch, HBASE-15222-v6.patch, > HBASE-15222.patch > > > Running the benchmarks now, but it looks like the results are pretty extreme. > The locking in our histograms is pretty extreme. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15222) Use less contended classes for metrics
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Attachment: HBASE-15222-v5.patch > Use less contended classes for metrics > -- > > Key: HBASE-15222 > URL: https://issues.apache.org/jira/browse/HBASE-15222 > Project: HBase > Issue Type: Bug > Components: metrics >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-15222-v1.patch, HBASE-15222-v2.patch, > HBASE-15222-v3.patch, HBASE-15222-v5.patch, HBASE-15222.patch > > > Running the benchmarks now, but it looks like the results are pretty extreme. > The locking in our histograms is pretty extreme. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-15222) Use less contended classes for metrics
[ https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-15222: -- Summary: Use less contended classes for metrics (was: Use HDR histograms rather than hadoop or yammer's) > Use less contended classes for metrics > -- > > Key: HBASE-15222 > URL: https://issues.apache.org/jira/browse/HBASE-15222 > Project: HBase > Issue Type: Bug > Components: metrics >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-15222-v1.patch, HBASE-15222-v2.patch, > HBASE-15222-v3.patch, HBASE-15222.patch > > > Running the benchmarks now, but it looks like the results are pretty extreme. > The locking in our histograms is pretty extreme. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
