[jira] [Updated] (HBASE-16692) Make ByteBufferUtils#equals safer and correct

[Ted Yu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-16692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-16692:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

Thanks for the patch, binlijin

Thanks for the reviews.

> Make ByteBufferUtils#equals safer and correct
> -
>
> Key: HBASE-16692
> URL: https://issues.apache.org/jira/browse/HBASE-16692
> Project: HBase
>  Issue Type: Improvement
>Reporter: binlijin
>Assignee: binlijin
> Fix For: 2.0.0
>
> Attachments: HBASE-16692-master.patch, HBASE-16692-master_v2.patch, 
> HBASE-16692-master_v3.patch, HBASE-16692-master_v4.patch, 
> HBASE-16692-master_v5.patch
>
>
> ByteBufferUtils.equals(HConstants.EMPTY_BYTE_BUFFER, 0, 0, 
> HConstants.EMPTY_BYTE_ARRAY, 0, 0) will throw 
> java.lang.ArrayIndexOutOfBoundsException: -1, i think it should return true.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-16692) Make ByteBufferUtils#equals safer and correct

[Ted Yu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-16692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-16692:
---
Summary: Make ByteBufferUtils#equals safer and correct  (was: Make 
ByteBufferUtils#equals more safe and correct)

> Make ByteBufferUtils#equals safer and correct
> -
>
> Key: HBASE-16692
> URL: https://issues.apache.org/jira/browse/HBASE-16692
> Project: HBase
>  Issue Type: Improvement
>Reporter: binlijin
>Assignee: binlijin
> Fix For: 2.0.0
>
> Attachments: HBASE-16692-master.patch, HBASE-16692-master_v2.patch, 
> HBASE-16692-master_v3.patch, HBASE-16692-master_v4.patch, 
> HBASE-16692-master_v5.patch
>
>
> ByteBufferUtils.equals(HConstants.EMPTY_BYTE_BUFFER, 0, 0, 
> HConstants.EMPTY_BYTE_ARRAY, 0, 0) will throw 
> java.lang.ArrayIndexOutOfBoundsException: -1, i think it should return true.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)