[jira] [Updated] (HBASE-17278) [C++] Cell Scanner Implementation to be used by ResultScanner
[ https://issues.apache.org/jira/browse/HBASE-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-17278: -- Attachment: hbase-17278_v5.patch [~sudeeps] can you please take a look at the v5 patch. It includes some of my review comments addressed (since you are busy with other things). Thanks. > [C++] Cell Scanner Implementation to be used by ResultScanner > - > > Key: HBASE-17278 > URL: https://issues.apache.org/jira/browse/HBASE-17278 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17278.HBASE-14850.v1.patch, > HBASE-17278.HBASE-14850.v2.patch, HBASE-17278.HBASE-14850.v3.patch, > HBASE-17278.HBASE-14850.v4.patch, hbase-17278_v5.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17278) [C++] Cell Scanner Implementation to be used by ResultScanner
[ https://issues.apache.org/jira/browse/HBASE-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17278: -- Attachment: HBASE-17278.HBASE-14850.v4.patch Re-submitting the patch after removing unnecessary source for CellScanner interface. Thanks > [C++] Cell Scanner Implementation to be used by ResultScanner > - > > Key: HBASE-17278 > URL: https://issues.apache.org/jira/browse/HBASE-17278 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17278.HBASE-14850.v1.patch, > HBASE-17278.HBASE-14850.v2.patch, HBASE-17278.HBASE-14850.v3.patch, > HBASE-17278.HBASE-14850.v4.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17278) [C++] Cell Scanner Implementation to be used by ResultScanner
[ https://issues.apache.org/jira/browse/HBASE-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17278: -- Attachment: (was: HBASE-17278.HBASE-14850.v4.patch) > [C++] Cell Scanner Implementation to be used by ResultScanner > - > > Key: HBASE-17278 > URL: https://issues.apache.org/jira/browse/HBASE-17278 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17278.HBASE-14850.v1.patch, > HBASE-17278.HBASE-14850.v2.patch, HBASE-17278.HBASE-14850.v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17278) [C++] Cell Scanner Implementation to be used by ResultScanner
[ https://issues.apache.org/jira/browse/HBASE-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17278: -- Attachment: HBASE-17278.HBASE-14850.v4.patch This patch addresses the points based on the last feedback. 1) Unnecessary methods removed from CellScanner. 2) Added Decoder() method to KeyValueCodec() which will enable decoding of cell block through base class methods of Advance() and Current() Thanks > [C++] Cell Scanner Implementation to be used by ResultScanner > - > > Key: HBASE-17278 > URL: https://issues.apache.org/jira/browse/HBASE-17278 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17278.HBASE-14850.v1.patch, > HBASE-17278.HBASE-14850.v2.patch, HBASE-17278.HBASE-14850.v3.patch, > HBASE-17278.HBASE-14850.v4.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17278) [C++] Cell Scanner Implementation to be used by ResultScanner
[ https://issues.apache.org/jira/browse/HBASE-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17278: -- Attachment: HBASE-17278.HBASE-14850.v3.patch Hi, I have addressed the below points as per the feedback which were missing in the last patch. # CellScanner is an Abstract class now. # KeyValueCodec class implements the methods defined in CellScanner # We are passing IOBUF instead of passing the extracted data from IOBUF # Added documentation Thanks. > [C++] Cell Scanner Implementation to be used by ResultScanner > - > > Key: HBASE-17278 > URL: https://issues.apache.org/jira/browse/HBASE-17278 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17278.HBASE-14850.v1.patch, > HBASE-17278.HBASE-14850.v2.patch, HBASE-17278.HBASE-14850.v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17278) [C++] Cell Scanner Implementation to be used by ResultScanner
[ https://issues.apache.org/jira/browse/HBASE-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17278: -- Status: Patch Available (was: In Progress) > [C++] Cell Scanner Implementation to be used by ResultScanner > - > > Key: HBASE-17278 > URL: https://issues.apache.org/jira/browse/HBASE-17278 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17278.HBASE-14850.v1.patch, > HBASE-17278.HBASE-14850.v2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17278) [C++] Cell Scanner Implementation to be used by ResultScanner
[ https://issues.apache.org/jira/browse/HBASE-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17278: -- Attachment: HBASE-17278.HBASE-14850.v2.patch In this patch we have the foll:- 1) Cell Scanner class which will iterate through sequence of cells obtained from cell_meta block 2) KeyValueCodec class where the actual logic of parsing is present Thanks. > [C++] Cell Scanner Implementation to be used by ResultScanner > - > > Key: HBASE-17278 > URL: https://issues.apache.org/jira/browse/HBASE-17278 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17278.HBASE-14850.v1.patch, > HBASE-17278.HBASE-14850.v2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17278) [C++] Cell Scanner Implementation to be used by ResultScanner
[ https://issues.apache.org/jira/browse/HBASE-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-17278: -- Summary: [C++] Cell Scanner Implementation to be used by ResultScanner (was: Cell Scanner Implementation to be used by ResultScanner) > [C++] Cell Scanner Implementation to be used by ResultScanner > - > > Key: HBASE-17278 > URL: https://issues.apache.org/jira/browse/HBASE-17278 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-17278.HBASE-14850.v1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
