[jira] [Updated] (HBASE-17644) Always create ByteBufferCells after copying to MSLAB
[ https://issues.apache.org/jira/browse/HBASE-17644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-17644: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed to master. Thanks all for reviews. > Always create ByteBufferCells after copying to MSLAB > > > Key: HBASE-17644 > URL: https://issues.apache.org/jira/browse/HBASE-17644 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-17644.patch, HBASE-17644_V2.patch, > HBASE-17644_V3.patch > > > We create a cell out of the Bytebuffer that is returned by MSLAB. This BB can > be offheap or onheap type. If MSLAB is full we return onheap byte buffer. So > the place where we create a cell by copying data to this buffer we either > create KeyValue or OffheapKV based on the buffer type. So what we saw in > tests is that since we have a combination of Cells the comparisons that > happens when adding to memstore happens millions of times and that has an > impact on the performance of write path. In read path this is not significant > enougth (though we have plans to just create one type of cells every where in > Server side). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17644) Always create ByteBufferCells after copying to MSLAB
[ https://issues.apache.org/jira/browse/HBASE-17644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-17644: --- Attachment: HBASE-17644_V3.patch > Always create ByteBufferCells after copying to MSLAB > > > Key: HBASE-17644 > URL: https://issues.apache.org/jira/browse/HBASE-17644 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-17644.patch, HBASE-17644_V2.patch, > HBASE-17644_V3.patch > > > We create a cell out of the Bytebuffer that is returned by MSLAB. This BB can > be offheap or onheap type. If MSLAB is full we return onheap byte buffer. So > the place where we create a cell by copying data to this buffer we either > create KeyValue or OffheapKV based on the buffer type. So what we saw in > tests is that since we have a combination of Cells the comparisons that > happens when adding to memstore happens millions of times and that has an > impact on the performance of write path. In read path this is not significant > enougth (though we have plans to just create one type of cells every where in > Server side). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17644) Always create ByteBufferCells after copying to MSLAB
[ https://issues.apache.org/jira/browse/HBASE-17644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-17644: --- Attachment: HBASE-17644_V2.patch Fixed test failure. Those because of typecasting into KVs. Renamed TestOffheapKeyValue also as per the class name change > Always create ByteBufferCells after copying to MSLAB > > > Key: HBASE-17644 > URL: https://issues.apache.org/jira/browse/HBASE-17644 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-17644.patch, HBASE-17644_V2.patch > > > We create a cell out of the Bytebuffer that is returned by MSLAB. This BB can > be offheap or onheap type. If MSLAB is full we return onheap byte buffer. So > the place where we create a cell by copying data to this buffer we either > create KeyValue or OffheapKV based on the buffer type. So what we saw in > tests is that since we have a combination of Cells the comparisons that > happens when adding to memstore happens millions of times and that has an > impact on the performance of write path. In read path this is not significant > enougth (though we have plans to just create one type of cells every where in > Server side). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17644) Always create ByteBufferCells after copying to MSLAB
[ https://issues.apache.org/jira/browse/HBASE-17644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-17644: --- Status: Patch Available (was: Open) > Always create ByteBufferCells after copying to MSLAB > > > Key: HBASE-17644 > URL: https://issues.apache.org/jira/browse/HBASE-17644 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-17644.patch > > > We create a cell out of the Bytebuffer that is returned by MSLAB. This BB can > be offheap or onheap type. If MSLAB is full we return onheap byte buffer. So > the place where we create a cell by copying data to this buffer we either > create KeyValue or OffheapKV based on the buffer type. So what we saw in > tests is that since we have a combination of Cells the comparisons that > happens when adding to memstore happens millions of times and that has an > impact on the performance of write path. In read path this is not significant > enougth (though we have plans to just create one type of cells every where in > Server side). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17644) Always create ByteBufferCells after copying to MSLAB
[ https://issues.apache.org/jira/browse/HBASE-17644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-17644: --- Attachment: HBASE-17644.patch Most of the patch size is by renaming of 2 classes > Always create ByteBufferCells after copying to MSLAB > > > Key: HBASE-17644 > URL: https://issues.apache.org/jira/browse/HBASE-17644 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-17644.patch > > > We create a cell out of the Bytebuffer that is returned by MSLAB. This BB can > be offheap or onheap type. If MSLAB is full we return onheap byte buffer. So > the place where we create a cell by copying data to this buffer we either > create KeyValue or OffheapKV based on the buffer type. So what we saw in > tests is that since we have a combination of Cells the comparisons that > happens when adding to memstore happens millions of times and that has an > impact on the performance of write path. In read path this is not significant > enougth (though we have plans to just create one type of cells every where in > Server side). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17644) Always create ByteBufferCells after copying to MSLAB
[ https://issues.apache.org/jira/browse/HBASE-17644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-17644: --- Summary: Always create ByteBufferCells after copying to MSLAB (was: Create ByteBuffered cells only while creating a cell from MSLAB) > Always create ByteBufferCells after copying to MSLAB > > > Key: HBASE-17644 > URL: https://issues.apache.org/jira/browse/HBASE-17644 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: Anoop Sam John > Fix For: 2.0.0 > > > We create a cell out of the Bytebuffer that is returned by MSLAB. This BB can > be offheap or onheap type. If MSLAB is full we return onheap byte buffer. So > the place where we create a cell by copying data to this buffer we either > create KeyValue or OffheapKV based on the buffer type. So what we saw in > tests is that since we have a combination of Cells the comparisons that > happens when adding to memstore happens millions of times and that has an > impact on the performance of write path. In read path this is not significant > enougth (though we have plans to just create one type of cells every where in > Server side). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
