[jira] [Updated] (HBASE-17779) disable_table_replication returns misleading message and does not turn off replication
[ https://issues.apache.org/jira/browse/HBASE-17779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-17779: Component/s: Replication > disable_table_replication returns misleading message and does not turn off > replication > -- > > Key: HBASE-17779 > URL: https://issues.apache.org/jira/browse/HBASE-17779 > Project: HBase > Issue Type: Bug > Components: Replication >Reporter: Ted Yu >Assignee: Janos Gub > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-17779-branch-1.patch, HBASE-17779.patch, > HBASE-17779-v2.patch > > > Currently HBaseAdmin#isTableRepEnabled() returns false if ANY of the columns > families is not replicated. > Because of this if you have a table where replication is partially enabled, > calling disable_table_replication will not have any effect, but will report > that replication for a given table is disabled. > Workaround is enabling table replication before disabling. > As a solution quoted from HBASE-17460: > Admin#disableTableReplication() returns nothing and isTableRepEnabled() > returns boolean. For master branch, we can let isTableRepEnabled() return > enum (partially disabled, disabled, etc) This way, > Admin#disableTableReplication() can return meaningful value to the user. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17779) disable_table_replication returns misleading message and does not turn off replication
[ https://issues.apache.org/jira/browse/HBASE-17779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-17779: -- Fix Version/s: (was: 2.0) 2.0.0 > disable_table_replication returns misleading message and does not turn off > replication > -- > > Key: HBASE-17779 > URL: https://issues.apache.org/jira/browse/HBASE-17779 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Janos Gub > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-17779-branch-1.patch, HBASE-17779.patch, > HBASE-17779-v2.patch > > > Currently HBaseAdmin#isTableRepEnabled() returns false if ANY of the columns > families is not replicated. > Because of this if you have a table where replication is partially enabled, > calling disable_table_replication will not have any effect, but will report > that replication for a given table is disabled. > Workaround is enabling table replication before disabling. > As a solution quoted from HBASE-17460: > Admin#disableTableReplication() returns nothing and isTableRepEnabled() > returns boolean. For master branch, we can let isTableRepEnabled() return > enum (partially disabled, disabled, etc) This way, > Admin#disableTableReplication() can return meaningful value to the user. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17779) disable_table_replication returns misleading message and does not turn off replication
[ https://issues.apache.org/jira/browse/HBASE-17779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-17779: --- Resolution: Fixed Fix Version/s: 2.0 1.4.0 Status: Resolved (was: Patch Available) Thanks for the patch, Janos. 1.3 is in quiet period, resolving for now. > disable_table_replication returns misleading message and does not turn off > replication > -- > > Key: HBASE-17779 > URL: https://issues.apache.org/jira/browse/HBASE-17779 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Janos Gub > Fix For: 1.4.0, 2.0 > > Attachments: HBASE-17779-branch-1.patch, HBASE-17779.patch, > HBASE-17779-v2.patch > > > Currently HBaseAdmin#isTableRepEnabled() returns false if ANY of the columns > families is not replicated. > Because of this if you have a table where replication is partially enabled, > calling disable_table_replication will not have any effect, but will report > that replication for a given table is disabled. > Workaround is enabling table replication before disabling. > As a solution quoted from HBASE-17460: > Admin#disableTableReplication() returns nothing and isTableRepEnabled() > returns boolean. For master branch, we can let isTableRepEnabled() return > enum (partially disabled, disabled, etc) This way, > Admin#disableTableReplication() can return meaningful value to the user. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17779) disable_table_replication returns misleading message and does not turn off replication
[ https://issues.apache.org/jira/browse/HBASE-17779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-17779: --- Labels: (was: incompatibleChange) Hadoop Flags: Reviewed > disable_table_replication returns misleading message and does not turn off > replication > -- > > Key: HBASE-17779 > URL: https://issues.apache.org/jira/browse/HBASE-17779 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Janos Gub > Attachments: HBASE-17779-branch-1.patch, HBASE-17779.patch, > HBASE-17779-v2.patch > > > Currently HBaseAdmin#isTableRepEnabled() returns false if ANY of the columns > families is not replicated. > Because of this if you have a table where replication is partially enabled, > calling disable_table_replication will not have any effect, but will report > that replication for a given table is disabled. > Workaround is enabling table replication before disabling. > As a solution quoted from HBASE-17460: > Admin#disableTableReplication() returns nothing and isTableRepEnabled() > returns boolean. For master branch, we can let isTableRepEnabled() return > enum (partially disabled, disabled, etc) This way, > Admin#disableTableReplication() can return meaningful value to the user. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17779) disable_table_replication returns misleading message and does not turn off replication
[ https://issues.apache.org/jira/browse/HBASE-17779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-17779: --- Summary: disable_table_replication returns misleading message and does not turn off replication (was: disable_table_replication returns misleading message and does not turn off repliaton) > disable_table_replication returns misleading message and does not turn off > replication > -- > > Key: HBASE-17779 > URL: https://issues.apache.org/jira/browse/HBASE-17779 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Janos Gub > Labels: incompatibleChange > Attachments: HBASE-17779-branch-1.patch, HBASE-17779.patch, > HBASE-17779-v2.patch > > > Currently HBaseAdmin#isTableRepEnabled() returns false if ANY of the columns > families is not replicated. > Because of this if you have a table where replication is partially enabled, > calling disable_table_replication will not have any effect, but will report > that replication for a given table is disabled. > Workaround is enabling table replication before disabling. > As a solution quoted from HBASE-17460: > Admin#disableTableReplication() returns nothing and isTableRepEnabled() > returns boolean. For master branch, we can let isTableRepEnabled() return > enum (partially disabled, disabled, etc) This way, > Admin#disableTableReplication() can return meaningful value to the user. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
