[jira] [Updated] (HBASE-18024) HRegion#initializeRegionInternals should not re-create .hregioninfo file when the region directory no longer exists
[
https://issues.apache.org/jira/browse/HBASE-18024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-18024:
---
Fix Version/s: (was: 1.5.0)
> HRegion#initializeRegionInternals should not re-create .hregioninfo file when
> the region directory no longer exists
> ---
>
> Key: HBASE-18024
> URL: https://issues.apache.org/jira/browse/HBASE-18024
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment, regionserver
>Affects Versions: 2.0.0, 1.4.0, 1.3.1, 1.2.5
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-18024.001.patch, HBASE-18024.002.patch,
> HBASE-18024.003.patch, HBASE-18024.004.patch
>
>
> When a RegionSever attempts to open a region, during initialization the RS
> tries to open the {{/data///.hregioninfo}}
> file, however if the {{.hregioninfofile}} doesn't exist, the RegionServer
> will create a new one on {{HRegionFileSystem#checkRegionInfoOnFilesystem}}. A
> side effect of that tools like hbck will incorrectly assume an inconsistency
> due the presence of this new {{.hregioninfofile}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18024) HRegion#initializeRegionInternals should not re-create .hregioninfo file when the region directory no longer exists
[
https://issues.apache.org/jira/browse/HBASE-18024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Esteban Gutierrez updated HBASE-18024:
--
Resolution: Fixed
Fix Version/s: 1.2.7
1.5.0
1.3.2
1.4.0
2.0.0
Status: Resolved (was: Patch Available)
> HRegion#initializeRegionInternals should not re-create .hregioninfo file when
> the region directory no longer exists
> ---
>
> Key: HBASE-18024
> URL: https://issues.apache.org/jira/browse/HBASE-18024
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment, regionserver
>Affects Versions: 2.0.0, 1.4.0, 1.3.1, 1.2.5
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18024.001.patch, HBASE-18024.002.patch,
> HBASE-18024.003.patch, HBASE-18024.004.patch
>
>
> When a RegionSever attempts to open a region, during initialization the RS
> tries to open the {{/data///.hregioninfo}}
> file, however if the {{.hregioninfofile}} doesn't exist, the RegionServer
> will create a new one on {{HRegionFileSystem#checkRegionInfoOnFilesystem}}. A
> side effect of that tools like hbck will incorrectly assume an inconsistency
> due the presence of this new {{.hregioninfofile}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18024) HRegion#initializeRegionInternals should not re-create .hregioninfo file when the region directory no longer exists
[
https://issues.apache.org/jira/browse/HBASE-18024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Esteban Gutierrez updated HBASE-18024:
--
Attachment: HBASE-18024.004.patch
Thanks for the quick review [~tedyu]. I don't think there is any reason to
print just the replica ID since to {{HRegionInfo.toString()}} already does that:
{code}
public String toString() {
return "{ENCODED => " + getEncodedName() + ", " +
HConstants.NAME + " => '" + Bytes.toStringBinary(this.regionName)
+ "', STARTKEY => '" +
Bytes.toStringBinary(this.startKey) + "', ENDKEY => '" +
Bytes.toStringBinary(this.endKey) + "'" +
(isOffline()? ", OFFLINE => true": "") +
(isSplit()? ", SPLIT => true": "") +
((replicaId > 0)? ", REPLICA_ID => " + replicaId : "") + "}";
}
{code}
New patch only adds some more logging in debug mode and typo in test.
> HRegion#initializeRegionInternals should not re-create .hregioninfo file when
> the region directory no longer exists
> ---
>
> Key: HBASE-18024
> URL: https://issues.apache.org/jira/browse/HBASE-18024
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment, regionserver
>Affects Versions: 2.0.0, 1.4.0, 1.3.1, 1.2.5
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Attachments: HBASE-18024.001.patch, HBASE-18024.002.patch,
> HBASE-18024.003.patch, HBASE-18024.004.patch
>
>
> When a RegionSever attempts to open a region, during initialization the RS
> tries to open the {{/data///.hregioninfo}}
> file, however if the {{.hregioninfofile}} doesn't exist, the RegionServer
> will create a new one on {{HRegionFileSystem#checkRegionInfoOnFilesystem}}. A
> side effect of that tools like hbck will incorrectly assume an inconsistency
> due the presence of this new {{.hregioninfofile}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18024) HRegion#initializeRegionInternals should not re-create .hregioninfo file when the region directory no longer exists
[
https://issues.apache.org/jira/browse/HBASE-18024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Esteban Gutierrez updated HBASE-18024:
--
Attachment: HBASE-18024.003.patch
New version only avoids creating a new {{.regioninfo}} if region is a replica.
> HRegion#initializeRegionInternals should not re-create .hregioninfo file when
> the region directory no longer exists
> ---
>
> Key: HBASE-18024
> URL: https://issues.apache.org/jira/browse/HBASE-18024
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment, regionserver
>Affects Versions: 2.0.0, 1.4.0, 1.3.1, 1.2.5
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Attachments: HBASE-18024.001.patch, HBASE-18024.002.patch,
> HBASE-18024.003.patch
>
>
> When a RegionSever attempts to open a region, during initialization the RS
> tries to open the {{/data///.hregioninfo}}
> file, however if the {{.hregioninfofile}} doesn't exist, the RegionServer
> will create a new one on {{HRegionFileSystem#checkRegionInfoOnFilesystem}}. A
> side effect of that tools like hbck will incorrectly assume an inconsistency
> due the presence of this new {{.hregioninfofile}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18024) HRegion#initializeRegionInternals should not re-create .hregioninfo file when the region directory no longer exists
[
https://issues.apache.org/jira/browse/HBASE-18024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Esteban Gutierrez updated HBASE-18024:
--
Attachment: HBASE-18024.002.patch
> HRegion#initializeRegionInternals should not re-create .hregioninfo file when
> the region directory no longer exists
> ---
>
> Key: HBASE-18024
> URL: https://issues.apache.org/jira/browse/HBASE-18024
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment, regionserver
>Affects Versions: 2.0.0, 1.4.0, 1.3.1, 1.2.5
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Attachments: HBASE-18024.001.patch, HBASE-18024.002.patch
>
>
> When a RegionSever attempts to open a region, during initialization the RS
> tries to open the {{/data///.hregioninfo}}
> file, however if the {{.hregioninfofile}} doesn't exist, the RegionServer
> will create a new one on {{HRegionFileSystem#checkRegionInfoOnFilesystem}}. A
> side effect of that tools like hbck will incorrectly assume an inconsistency
> due the presence of this new {{.hregioninfofile}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18024) HRegion#initializeRegionInternals should not re-create .hregioninfo file when the region directory no longer exists
[
https://issues.apache.org/jira/browse/HBASE-18024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Esteban Gutierrez updated HBASE-18024:
--
Attachment: HBASE-18024.001.patch
> HRegion#initializeRegionInternals should not re-create .hregioninfo file when
> the region directory no longer exists
> ---
>
> Key: HBASE-18024
> URL: https://issues.apache.org/jira/browse/HBASE-18024
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment, regionserver
>Affects Versions: 2.0.0, 1.4.0, 1.3.1, 1.2.5
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Attachments: HBASE-18024.001.patch
>
>
> When a RegionSever attempts to open a region, during initialization the RS
> tries to open the {{/data///.hregioninfo}}
> file, however if the {{.hregioninfofile}} doesn't exist, the RegionServer
> will create a new one on {{HRegionFileSystem#checkRegionInfoOnFilesystem}}. A
> side effect of that tools like hbck will incorrectly assume an inconsistency
> due the presence of this new {{.hregioninfofile}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18024) HRegion#initializeRegionInternals should not re-create .hregioninfo file when the region directory no longer exists
[
https://issues.apache.org/jira/browse/HBASE-18024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Esteban Gutierrez updated HBASE-18024:
--
Affects Version/s: 2.0.0
Status: Patch Available (was: In Progress)
> HRegion#initializeRegionInternals should not re-create .hregioninfo file when
> the region directory no longer exists
> ---
>
> Key: HBASE-18024
> URL: https://issues.apache.org/jira/browse/HBASE-18024
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment, regionserver
>Affects Versions: 1.2.5, 1.3.1, 2.0.0, 1.4.0
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Attachments: HBASE-18024.001.patch
>
>
> When a RegionSever attempts to open a region, during initialization the RS
> tries to open the {{/data///.hregioninfo}}
> file, however if the {{.hregioninfofile}} doesn't exist, the RegionServer
> will create a new one on {{HRegionFileSystem#checkRegionInfoOnFilesystem}}. A
> side effect of that tools like hbck will incorrectly assume an inconsistency
> due the presence of this new {{.hregioninfofile}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
