[jira] [Updated] (HBASE-18130) Refactor ReplicationSource
[ https://issues.apache.org/jira/browse/HBASE-18130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18130: --- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to master. Since HBASE-15995 not be merged to branch-1, so branch-1 has too much different with master branch. Will backport this to branch-1 after HBASE-15995. Thanks all for reviewing. > Refactor ReplicationSource > -- > > Key: HBASE-18130 > URL: https://issues.apache.org/jira/browse/HBASE-18130 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-18130.master.001.patch, > HBASE-18130.master.002.patch, HBASE-18130.master.003.patch, > HBASE-18130.master.004.patch, HBASE-18130.master.004.patch, > HBASE-18130.master.005.patch > > > One basic idea is move the code about recovered queue to a new subclass > RecoveredReplicationSource. Then ReplicationSource will don't need call > isQueueRecovered many times. This will make the code more clearly. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18130) Refactor ReplicationSource
[ https://issues.apache.org/jira/browse/HBASE-18130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18130: --- Attachment: HBASE-18130.master.005.patch > Refactor ReplicationSource > -- > > Key: HBASE-18130 > URL: https://issues.apache.org/jira/browse/HBASE-18130 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-18130.master.001.patch, > HBASE-18130.master.002.patch, HBASE-18130.master.003.patch, > HBASE-18130.master.004.patch, HBASE-18130.master.004.patch, > HBASE-18130.master.005.patch > > > One basic idea is move the code about recovered queue to a new subclass > RecoveredReplicationSource. Then ReplicationSource will don't need call > isQueueRecovered many times. This will make the code more clearly. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18130) Refactor ReplicationSource
[ https://issues.apache.org/jira/browse/HBASE-18130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18130: --- Attachment: HBASE-18130.master.004.patch > Refactor ReplicationSource > -- > > Key: HBASE-18130 > URL: https://issues.apache.org/jira/browse/HBASE-18130 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-18130.master.001.patch, > HBASE-18130.master.002.patch, HBASE-18130.master.003.patch, > HBASE-18130.master.004.patch, HBASE-18130.master.004.patch > > > One basic idea is move the code about recovered queue to a new subclass > RecoveredReplicationSource. Then ReplicationSource will don't need call > isQueueRecovered many times. This will make the code more clearly. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18130) Refactor ReplicationSource
[ https://issues.apache.org/jira/browse/HBASE-18130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18130: --- Attachment: HBASE-18130.master.004.patch Fix ut. > Refactor ReplicationSource > -- > > Key: HBASE-18130 > URL: https://issues.apache.org/jira/browse/HBASE-18130 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-18130.master.001.patch, > HBASE-18130.master.002.patch, HBASE-18130.master.003.patch, > HBASE-18130.master.004.patch > > > One basic idea is move the code about recovered queue to a new subclass > RecoveredReplicationSource. Then ReplicationSource will don't need call > isQueueRecovered many times. This will make the code more clearly. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18130) Refactor ReplicationSource
[ https://issues.apache.org/jira/browse/HBASE-18130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18130: --- Attachment: HBASE-18130.master.003.patch > Refactor ReplicationSource > -- > > Key: HBASE-18130 > URL: https://issues.apache.org/jira/browse/HBASE-18130 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-18130.master.001.patch, > HBASE-18130.master.002.patch, HBASE-18130.master.003.patch > > > One basic idea is move the code about recovered queue to a new subclass > RecoveredReplicationSource. Then ReplicationSource will don't need call > isQueueRecovered many times. This will make the code more clearly. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18130) Refactor ReplicationSource
[ https://issues.apache.org/jira/browse/HBASE-18130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18130: --- Attachment: HBASE-18130.master.002.patch > Refactor ReplicationSource > -- > > Key: HBASE-18130 > URL: https://issues.apache.org/jira/browse/HBASE-18130 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-18130.master.001.patch, > HBASE-18130.master.002.patch > > > One basic idea is move the code about recovered queue to a new subclass > RecoveredReplicationSource. Then ReplicationSource will don't need call > isQueueRecovered many times. This will make the code more clearly. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18130) Refactor ReplicationSource
[ https://issues.apache.org/jira/browse/HBASE-18130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18130: --- Status: Patch Available (was: Open) > Refactor ReplicationSource > -- > > Key: HBASE-18130 > URL: https://issues.apache.org/jira/browse/HBASE-18130 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-18130.master.001.patch > > > One basic idea is move the code about recovered queue to a new subclass > RecoveredReplicationSource. Then ReplicationSource will don't need call > isQueueRecovered many times. This will make the code more clearly. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18130) Refactor ReplicationSource
[ https://issues.apache.org/jira/browse/HBASE-18130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18130: --- Attachment: HBASE-18130.master.001.patch > Refactor ReplicationSource > -- > > Key: HBASE-18130 > URL: https://issues.apache.org/jira/browse/HBASE-18130 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-18130.master.001.patch > > > One basic idea is move the code about recovered queue to a new subclass > RecoveredReplicationSource. Then ReplicationSource will don't need call > isQueueRecovered many times. This will make the code more clearly. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
