[jira] [Updated] (HBASE-18170) Refactor ReplicationSourceWALReaderThread
[ https://issues.apache.org/jira/browse/HBASE-18170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18170: --- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to master and branch-2. Thanks [~tedyu] and [~stack] for reviewing. > Refactor ReplicationSourceWALReaderThread > - > > Key: HBASE-18170 > URL: https://issues.apache.org/jira/browse/HBASE-18170 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-18170.master.001.patch, > HBASE-18170.master.001.patch, HBASE-18170.master.002.patch, > HBASE-18170.master.002.patch, HBASE-18170.master.003.patch, > HBASE-18170.master.004.patch, HBASE-18170.master.005.patch > > > HBASE-18130 add some get* method to ReplicationSource. So > ReplicationSourceWALReaderThread doesn't need so many parameter to > initialize. And the WALEntryFilter only used by > ReplicationSourceWALReaderThread, so we don't need to new it for every > ReplicationSourceWALReaderThread. Meanwhile, we can separate a new > RecoveredReplicationSourceWALReaderThread for recovered replication source. > Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18170) Refactor ReplicationSourceWALReaderThread
[ https://issues.apache.org/jira/browse/HBASE-18170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18170: --- Attachment: HBASE-18170.master.005.patch > Refactor ReplicationSourceWALReaderThread > - > > Key: HBASE-18170 > URL: https://issues.apache.org/jira/browse/HBASE-18170 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-18170.master.001.patch, > HBASE-18170.master.001.patch, HBASE-18170.master.002.patch, > HBASE-18170.master.002.patch, HBASE-18170.master.003.patch, > HBASE-18170.master.004.patch, HBASE-18170.master.005.patch > > > HBASE-18130 add some get* method to ReplicationSource. So > ReplicationSourceWALReaderThread doesn't need so many parameter to > initialize. And the WALEntryFilter only used by > ReplicationSourceWALReaderThread, so we don't need to new it for every > ReplicationSourceWALReaderThread. Meanwhile, we can separate a new > RecoveredReplicationSourceWALReaderThread for recovered replication source. > Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18170) Refactor ReplicationSourceWALReaderThread
[ https://issues.apache.org/jira/browse/HBASE-18170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18170: --- Attachment: HBASE-18170.master.004.patch > Refactor ReplicationSourceWALReaderThread > - > > Key: HBASE-18170 > URL: https://issues.apache.org/jira/browse/HBASE-18170 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-18170.master.001.patch, > HBASE-18170.master.001.patch, HBASE-18170.master.002.patch, > HBASE-18170.master.002.patch, HBASE-18170.master.003.patch, > HBASE-18170.master.004.patch > > > HBASE-18130 add some get* method to ReplicationSource. So > ReplicationSourceWALReaderThread doesn't need so many parameter to > initialize. And the WALEntryFilter only used by > ReplicationSourceWALReaderThread, so we don't need to new it for every > ReplicationSourceWALReaderThread. Meanwhile, we can separate a new > RecoveredReplicationSourceWALReaderThread for recovered replication source. > Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18170) Refactor ReplicationSourceWALReaderThread
[ https://issues.apache.org/jira/browse/HBASE-18170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18170: --- Attachment: HBASE-18170.master.003.patch > Refactor ReplicationSourceWALReaderThread > - > > Key: HBASE-18170 > URL: https://issues.apache.org/jira/browse/HBASE-18170 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-18170.master.001.patch, > HBASE-18170.master.001.patch, HBASE-18170.master.002.patch, > HBASE-18170.master.002.patch, HBASE-18170.master.003.patch > > > HBASE-18130 add some get* method to ReplicationSource. So > ReplicationSourceWALReaderThread doesn't need so many parameter to > initialize. And the WALEntryFilter only used by > ReplicationSourceWALReaderThread, so we don't need to new it for every > ReplicationSourceWALReaderThread. Meanwhile, we can separate a new > RecoveredReplicationSourceWALReaderThread for recovered replication source. > Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18170) Refactor ReplicationSourceWALReaderThread
[ https://issues.apache.org/jira/browse/HBASE-18170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18170: --- Attachment: HBASE-18170.master.002.patch > Refactor ReplicationSourceWALReaderThread > - > > Key: HBASE-18170 > URL: https://issues.apache.org/jira/browse/HBASE-18170 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-18170.master.001.patch, > HBASE-18170.master.001.patch, HBASE-18170.master.002.patch, > HBASE-18170.master.002.patch > > > HBASE-18130 add some get* method to ReplicationSource. So > ReplicationSourceWALReaderThread doesn't need so many parameter to > initialize. And the WALEntryFilter only used by > ReplicationSourceWALReaderThread, so we don't need to new it for every > ReplicationSourceWALReaderThread. Meanwhile, we can separate a new > RecoveredReplicationSourceWALReaderThread for recovered replication source. > Thanks. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18170) Refactor ReplicationSourceWALReaderThread
[ https://issues.apache.org/jira/browse/HBASE-18170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18170: --- Attachment: HBASE-18170.master.002.patch > Refactor ReplicationSourceWALReaderThread > - > > Key: HBASE-18170 > URL: https://issues.apache.org/jira/browse/HBASE-18170 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-18170.master.001.patch, > HBASE-18170.master.001.patch, HBASE-18170.master.002.patch > > > HBASE-18130 add some get* method to ReplicationSource. So > ReplicationSourceWALReaderThread doesn't need so many parameter to > initialize. And the WALEntryFilter only used by > ReplicationSourceWALReaderThread, so we don't need to new it for every > ReplicationSourceWALReaderThread. Meanwhile, we can separate a new > RecoveredReplicationSourceWALReaderThread for recovered replication source. > Thanks. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18170) Refactor ReplicationSourceWALReaderThread
[ https://issues.apache.org/jira/browse/HBASE-18170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18170: --- Attachment: HBASE-18170.master.001.patch > Refactor ReplicationSourceWALReaderThread > - > > Key: HBASE-18170 > URL: https://issues.apache.org/jira/browse/HBASE-18170 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-18170.master.001.patch, > HBASE-18170.master.001.patch > > > HBASE-18130 add some get* method to ReplicationSource. So > ReplicationSourceWALReaderThread doesn't need so many parameter to > initialize. And the WALEntryFilter only used by > ReplicationSourceWALReaderThread, so we don't need to new it for every > ReplicationSourceWALReaderThread. Meanwhile, we can separate a new > RecoveredReplicationSourceWALReaderThread for recovered replication source. > Thanks. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18170) Refactor ReplicationSourceWALReaderThread
[ https://issues.apache.org/jira/browse/HBASE-18170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18170: --- Status: Patch Available (was: Open) > Refactor ReplicationSourceWALReaderThread > - > > Key: HBASE-18170 > URL: https://issues.apache.org/jira/browse/HBASE-18170 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-18170.master.001.patch > > > HBASE-18130 add some get* method to ReplicationSource. So > ReplicationSourceWALReaderThread doesn't need so many parameter to > initialize. And the WALEntryFilter only used by > ReplicationSourceWALReaderThread, so we don't need to new it for every > ReplicationSourceWALReaderThread. Meanwhile, we can separate a new > RecoveredReplicationSourceWALReaderThread for recovered replication source. > Thanks. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18170) Refactor ReplicationSourceWALReaderThread
[ https://issues.apache.org/jira/browse/HBASE-18170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18170: --- Attachment: HBASE-18170.master.001.patch > Refactor ReplicationSourceWALReaderThread > - > > Key: HBASE-18170 > URL: https://issues.apache.org/jira/browse/HBASE-18170 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-18170.master.001.patch > > > HBASE-18130 add some get* method to ReplicationSource. So > ReplicationSourceWALReaderThread doesn't need so many parameter to > initialize. And the WALEntryFilter only used by > ReplicationSourceWALReaderThread, so we don't need to new it for every > ReplicationSourceWALReaderThread. Meanwhile, we can separate a new > RecoveredReplicationSourceWALReaderThread for recovered replication source. > Thanks. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
