[jira] [Updated] (HBASE-19056) TestCompactionInDeadRegionServer is top of the flakies charts!
[ https://issues.apache.org/jira/browse/HBASE-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19056: --- Fix Version/s: 1.4.0 > TestCompactionInDeadRegionServer is top of the flakies charts! > --- > > Key: HBASE-19056 > URL: https://issues.apache.org/jira/browse/HBASE-19056 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: Ted Yu > Fix For: 3.0.0, 1.4.0, 2.0.0-beta-1 > > Attachments: 19056.branch-1.patch, 19056.v5.txt, 19056.v6.txt, > 19056.v7.txt > > > The test came in recently as part of HBASE-17712 "Remove/Simplify the logic > of RegionScannerImpl.handleFileNotFound" > [~Apache9] when you have a chance, help me out. I was going to just remove > the test since it made no sense to me but then I saw you wrote it (smile). > When the region.compact(true); is called on the end, what is supposed to be > going on? > When I trace, the compact is not done because the Region is not writeEnabled > (we check if Region is writeEnabled down in Store before we go ahead and > compact). So, I thought the problem was that the region reference was stale > because it came from the rsToSuspend which had just been killed. > After a while, I figured that you intend the region reference to be stale so > you can try an append AFTER the WAL has been taken over by WAL splitter. > But the writeEnabled flag is set so compactions don't run. I tried unsetting > this flag and closed flags and but compaction won't run. > Was this your intent sir? If so, I'll work w/ it np. Just looking for > clarity. Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19056) TestCompactionInDeadRegionServer is top of the flakies charts!
[ https://issues.apache.org/jira/browse/HBASE-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19056: --- Attachment: 19056.branch-1.patch > TestCompactionInDeadRegionServer is top of the flakies charts! > --- > > Key: HBASE-19056 > URL: https://issues.apache.org/jira/browse/HBASE-19056 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: Ted Yu > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: 19056.branch-1.patch, 19056.v5.txt, 19056.v6.txt, > 19056.v7.txt > > > The test came in recently as part of HBASE-17712 "Remove/Simplify the logic > of RegionScannerImpl.handleFileNotFound" > [~Apache9] when you have a chance, help me out. I was going to just remove > the test since it made no sense to me but then I saw you wrote it (smile). > When the region.compact(true); is called on the end, what is supposed to be > going on? > When I trace, the compact is not done because the Region is not writeEnabled > (we check if Region is writeEnabled down in Store before we go ahead and > compact). So, I thought the problem was that the region reference was stale > because it came from the rsToSuspend which had just been killed. > After a while, I figured that you intend the region reference to be stale so > you can try an append AFTER the WAL has been taken over by WAL splitter. > But the writeEnabled flag is set so compactions don't run. I tried unsetting > this flag and closed flags and but compaction won't run. > Was this your intent sir? If so, I'll work w/ it np. Just looking for > clarity. Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19056) TestCompactionInDeadRegionServer is top of the flakies charts!
[ https://issues.apache.org/jira/browse/HBASE-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19056: -- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.0.0-beta-1 3.0.0 Status: Resolved (was: Patch Available) Pushed to master and branch-2. Thanks [~tedyu] for contributing and thanks [~chia7712] for reviewing. Will open new issue for backporting to branch-1.x. > TestCompactionInDeadRegionServer is top of the flakies charts! > --- > > Key: HBASE-19056 > URL: https://issues.apache.org/jira/browse/HBASE-19056 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: Ted Yu > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: 19056.v5.txt, 19056.v6.txt, 19056.v7.txt > > > The test came in recently as part of HBASE-17712 "Remove/Simplify the logic > of RegionScannerImpl.handleFileNotFound" > [~Apache9] when you have a chance, help me out. I was going to just remove > the test since it made no sense to me but then I saw you wrote it (smile). > When the region.compact(true); is called on the end, what is supposed to be > going on? > When I trace, the compact is not done because the Region is not writeEnabled > (we check if Region is writeEnabled down in Store before we go ahead and > compact). So, I thought the problem was that the region reference was stale > because it came from the rsToSuspend which had just been killed. > After a while, I figured that you intend the region reference to be stale so > you can try an append AFTER the WAL has been taken over by WAL splitter. > But the writeEnabled flag is set so compactions don't run. I tried unsetting > this flag and closed flags and but compaction won't run. > Was this your intent sir? If so, I'll work w/ it np. Just looking for > clarity. Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19056) TestCompactionInDeadRegionServer is top of the flakies charts!
[ https://issues.apache.org/jira/browse/HBASE-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19056: --- Attachment: 19056.v7.txt Patch v7 changes region to be of Region type. However, a cast is needed for calling compact(true) because that method is not in Region interface. > TestCompactionInDeadRegionServer is top of the flakies charts! > --- > > Key: HBASE-19056 > URL: https://issues.apache.org/jira/browse/HBASE-19056 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: Ted Yu > Attachments: 19056.v5.txt, 19056.v6.txt, 19056.v7.txt > > > The test came in recently as part of HBASE-17712 "Remove/Simplify the logic > of RegionScannerImpl.handleFileNotFound" > [~Apache9] when you have a chance, help me out. I was going to just remove > the test since it made no sense to me but then I saw you wrote it (smile). > When the region.compact(true); is called on the end, what is supposed to be > going on? > When I trace, the compact is not done because the Region is not writeEnabled > (we check if Region is writeEnabled down in Store before we go ahead and > compact). So, I thought the problem was that the region reference was stale > because it came from the rsToSuspend which had just been killed. > After a while, I figured that you intend the region reference to be stale so > you can try an append AFTER the WAL has been taken over by WAL splitter. > But the writeEnabled flag is set so compactions don't run. I tried unsetting > this flag and closed flags and but compaction won't run. > Was this your intent sir? If so, I'll work w/ it np. Just looking for > clarity. Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19056) TestCompactionInDeadRegionServer is top of the flakies charts!
[ https://issues.apache.org/jira/browse/HBASE-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19056: --- Attachment: 19056.v6.txt Patch v6 keeps parameterization. > TestCompactionInDeadRegionServer is top of the flakies charts! > --- > > Key: HBASE-19056 > URL: https://issues.apache.org/jira/browse/HBASE-19056 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: Ted Yu > Attachments: 19056.v5.txt, 19056.v6.txt > > > The test came in recently as part of HBASE-17712 "Remove/Simplify the logic > of RegionScannerImpl.handleFileNotFound" > [~Apache9] when you have a chance, help me out. I was going to just remove > the test since it made no sense to me but then I saw you wrote it (smile). > When the region.compact(true); is called on the end, what is supposed to be > going on? > When I trace, the compact is not done because the Region is not writeEnabled > (we check if Region is writeEnabled down in Store before we go ahead and > compact). So, I thought the problem was that the region reference was stale > because it came from the rsToSuspend which had just been killed. > After a while, I figured that you intend the region reference to be stale so > you can try an append AFTER the WAL has been taken over by WAL splitter. > But the writeEnabled flag is set so compactions don't run. I tried unsetting > this flag and closed flags and but compaction won't run. > Was this your intent sir? If so, I'll work w/ it np. Just looking for > clarity. Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19056) TestCompactionInDeadRegionServer is top of the flakies charts!
[ https://issues.apache.org/jira/browse/HBASE-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19056: --- Assignee: Ted Yu Status: Patch Available (was: Open) > TestCompactionInDeadRegionServer is top of the flakies charts! > --- > > Key: HBASE-19056 > URL: https://issues.apache.org/jira/browse/HBASE-19056 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Assignee: Ted Yu > Attachments: 19056.v5.txt > > > The test came in recently as part of HBASE-17712 "Remove/Simplify the logic > of RegionScannerImpl.handleFileNotFound" > [~Apache9] when you have a chance, help me out. I was going to just remove > the test since it made no sense to me but then I saw you wrote it (smile). > When the region.compact(true); is called on the end, what is supposed to be > going on? > When I trace, the compact is not done because the Region is not writeEnabled > (we check if Region is writeEnabled down in Store before we go ahead and > compact). So, I thought the problem was that the region reference was stale > because it came from the rsToSuspend which had just been killed. > After a while, I figured that you intend the region reference to be stale so > you can try an append AFTER the WAL has been taken over by WAL splitter. > But the writeEnabled flag is set so compactions don't run. I tried unsetting > this flag and closed flags and but compaction won't run. > Was this your intent sir? If so, I'll work w/ it np. Just looking for > clarity. Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19056) TestCompactionInDeadRegionServer is top of the flakies charts!
[ https://issues.apache.org/jira/browse/HBASE-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19056: --- Attachment: 19056.v5.txt > TestCompactionInDeadRegionServer is top of the flakies charts! > --- > > Key: HBASE-19056 > URL: https://issues.apache.org/jira/browse/HBASE-19056 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack > Attachments: 19056.v5.txt > > > The test came in recently as part of HBASE-17712 "Remove/Simplify the logic > of RegionScannerImpl.handleFileNotFound" > [~Apache9] when you have a chance, help me out. I was going to just remove > the test since it made no sense to me but then I saw you wrote it (smile). > When the region.compact(true); is called on the end, what is supposed to be > going on? > When I trace, the compact is not done because the Region is not writeEnabled > (we check if Region is writeEnabled down in Store before we go ahead and > compact). So, I thought the problem was that the region reference was stale > because it came from the rsToSuspend which had just been killed. > After a while, I figured that you intend the region reference to be stale so > you can try an append AFTER the WAL has been taken over by WAL splitter. > But the writeEnabled flag is set so compactions don't run. I tried unsetting > this flag and closed flags and but compaction won't run. > Was this your intent sir? If so, I'll work w/ it np. Just looking for > clarity. Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
