[jira] [Updated] (HBASE-22100) False positive for error prone warnings in pre commit job

2019-03-27 Thread Duo Zhang (JIRA) 


 [ 
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-22100:
--
Release Note: Now we will sort the javac WARNING/ERROR before generating 
diff in pre-commit so we can get a stable output for the error prone. The 
downside is that we just sort the output lexicographically so the line number 
will also be sorted lexicographically, which is a bit strange to human.

> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Minor
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5
>
> Attachments: HBASE-22100-test.patch, HBASE-22100.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
>  [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
>  [UnusedVariable] The parameter 'error' is never read.
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-22100) False positive for error prone warnings in pre commit job

2019-03-27 Thread Duo Zhang (JIRA) 


 [ 
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-22100:
--
  Resolution: Fixed
Hadoop Flags: Reviewed
  Status: Resolved  (was: Patch Available)

Pushed to branch-2.0+.

> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Minor
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5
>
> Attachments: HBASE-22100-test.patch, HBASE-22100.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
>  [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
>  [UnusedVariable] The parameter 'error' is never read.
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-22100) False positive for error prone warnings in pre commit job

2019-03-27 Thread Duo Zhang (JIRA) 


 [ 
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-22100:
--
Fix Version/s: 2.1.5
   2.0.6
   2.3.0
   2.2.0

> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Minor
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5
>
> Attachments: HBASE-22100-test.patch, HBASE-22100.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
>  [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
>  [UnusedVariable] The parameter 'error' is never read.
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-22100) False positive for error prone warnings in pre commit job

2019-03-27 Thread Sean Busbey (JIRA) 


 [ 
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-22100:

Priority: Minor  (was: Major)

> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-22100-test.patch, HBASE-22100.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
>  [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
>  [UnusedVariable] The parameter 'error' is never read.
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-22100) False positive for error prone warnings in pre commit job

2019-03-27 Thread Duo Zhang (JIRA) 


 [ 
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-22100:
--
Attachment: HBASE-22100-test.patch

> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-22100-test.patch, HBASE-22100.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
>  [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
>  [UnusedVariable] The parameter 'error' is never read.
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-22100) False positive for error prone warnings in pre commit job

2019-03-27 Thread Duo Zhang (JIRA) 


 [ 
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-22100:
--
Attachment: HBASE-22100.patch

> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Reporter: Duo Zhang
>Priority: Major
> Attachments: HBASE-22100.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
>  [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
>  [UnusedVariable] The parameter 'error' is never read.
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (HBASE-22100) False positive for error prone warnings in pre commit job

2019-03-27 Thread Duo Zhang (JIRA) 


 [ 
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-22100:
--
 Assignee: Duo Zhang
Fix Version/s: 3.0.0
   Status: Patch Available  (was: Open)

> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-22100.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
>  [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
>  [UnusedVariable] The parameter 'error' is never read.
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
>  [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)