[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit Functionality within the HBase Shell
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Spiegelberg updated HBASE-4628: --- Comment: was deleted (was: nspiegelberg has accepted the revision HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell. lgtm! Thanks for the contribution REVISION DETAIL https://reviews.facebook.net/D417 ) Enhance Table Create Presplit Functionality within the HBase Shell -- Key: HBASE-4628 URL: https://issues.apache.org/jira/browse/HBASE-4628 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit Functionality within the HBase Shell
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Spiegelberg updated HBASE-4628: --- Comment: was deleted (was: cgist has commented on the revision HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell. This diff was only intended for 89-fb. There is a separate diff for apache trunk D429. REVISION DETAIL https://reviews.facebook.net/D417 ) Enhance Table Create Presplit Functionality within the HBase Shell -- Key: HBASE-4628 URL: https://issues.apache.org/jira/browse/HBASE-4628 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit Functionality within the HBase Shell
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Spiegelberg updated HBASE-4628: --- Comment: was deleted (was: cgist requested code review of HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell. Reviewers: nspiegelberg, JIRA [89-fb] HBase shell can pre-split a new table at creation THis change adds optional arguments to the HBase shell's create command to split a tabel into a specified number of regions using a specified splitting algorithm as defined by RegionSplitter. Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want. TEST PLAN Created tables with and without splits using the shell; also attempted to give incorrect arguments to shell create command. REVISION DETAIL https://reviews.facebook.net/D417 AFFECTED FILES src/main/ruby/hbase.rb src/main/ruby/hbase/admin.rb src/main/ruby/shell/commands/create.rb MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/837/ Tip: use the X-Herald-Rules header to filter Herald messages in your client. ) Enhance Table Create Presplit Functionality within the HBase Shell -- Key: HBASE-4628 URL: https://issues.apache.org/jira/browse/HBASE-4628 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit Functionality within the HBase Shell
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-4628: --- Attachment: HBASE-4628.D411.1.patch cgist requested code review of HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell. Reviewers: nspiegelberg, JIRA [89-fb] Ported RegionSplitter and TestRegionSplitter from trunk The RegionSplitter is useful for creating a table pre-split into many regions, including two different algorithms for splitting keys. This also includes the patch for HBASE-4627. Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want. TEST PLAN The TestRegionSplitter test suite. REVISION DETAIL https://reviews.facebook.net/D411 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/util/Bytes.java src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitter.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/831/ Tip: use the X-Herald-Rules header to filter Herald messages in your client. Enhance Table Create Presplit Functionality within the HBase Shell -- Key: HBASE-4628 URL: https://issues.apache.org/jira/browse/HBASE-4628 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Attachments: HBASE-4628.D411.1.patch Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit Functionality within the HBase Shell
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-4628: --- Attachment: HBASE-4628.D417.1.patch cgist requested code review of HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell. Reviewers: nspiegelberg, JIRA [89-fb] HBase shell can pre-split a new table at creation THis change adds optional arguments to the HBase shell's create command to split a tabel into a specified number of regions using a specified splitting algorithm as defined by RegionSplitter. Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want. TEST PLAN Created tables with and without splits using the shell; also attempted to give incorrect arguments to shell create command. REVISION DETAIL https://reviews.facebook.net/D417 AFFECTED FILES src/main/ruby/hbase.rb src/main/ruby/hbase/admin.rb src/main/ruby/shell/commands/create.rb MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/837/ Tip: use the X-Herald-Rules header to filter Herald messages in your client. Enhance Table Create Presplit Functionality within the HBase Shell -- Key: HBASE-4628 URL: https://issues.apache.org/jira/browse/HBASE-4628 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit Functionality within the HBase Shell
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Spiegelberg updated HBASE-4628: --- Comment: was deleted (was: cgist requested code review of HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell. Reviewers: nspiegelberg, JIRA [89-fb] Ported RegionSplitter and TestRegionSplitter from trunk The RegionSplitter is useful for creating a table pre-split into many regions, including two different algorithms for splitting keys. This also includes the patch for HBASE-4627. Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want. TEST PLAN The TestRegionSplitter test suite. REVISION DETAIL https://reviews.facebook.net/D411 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/util/Bytes.java src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitter.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/831/ Tip: use the X-Herald-Rules header to filter Herald messages in your client. ) Enhance Table Create Presplit Functionality within the HBase Shell -- Key: HBASE-4628 URL: https://issues.apache.org/jira/browse/HBASE-4628 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit Functionality within the HBase Shell
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Spiegelberg updated HBASE-4628: --- Comment: was deleted (was: nspiegelberg has commented on the revision HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell. Since this patch has been accepted into apache trunk, you don't need to make a patch for 89-fb. I'll automatically pull it in. We're just stalled on a previous commit. Go ahead and abandone this review. REVISION DETAIL https://reviews.facebook.net/D411 ) Enhance Table Create Presplit Functionality within the HBase Shell -- Key: HBASE-4628 URL: https://issues.apache.org/jira/browse/HBASE-4628 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit Functionality within the HBase Shell
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Spiegelberg updated HBASE-4628: --- Comment: was deleted (was: cgist has abandoned the revision HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell. REVISION DETAIL https://reviews.facebook.net/D411 ) Enhance Table Create Presplit Functionality within the HBase Shell -- Key: HBASE-4628 URL: https://issues.apache.org/jira/browse/HBASE-4628 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit Functionality within the HBase Shell
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-4628: --- Attachment: HBASE-4628.D429.1.patch cgist requested code review of HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell. Reviewers: nspiegelberg, JIRA HBase shell can algorithmically split a new table at creation This change adds optional arguments to the HBase shell's create command to split a table into a specified number of regions using a specified splitting algorithm as defined by RegionSplitter. Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want. TEST PLAN Created tables with and without splits using the shell; also attampted to give incorrect arguments to shell create command. REVISION DETAIL https://reviews.facebook.net/D429 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java src/main/ruby/hbase.rb src/main/ruby/hbase/admin.rb src/main/ruby/shell/commands/create.rb MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/855/ Tip: use the X-Herald-Rules header to filter Herald messages in your client. Enhance Table Create Presplit Functionality within the HBase Shell -- Key: HBASE-4628 URL: https://issues.apache.org/jira/browse/HBASE-4628 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D429.1.patch Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit Functionality within the HBase Shell
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-4628: --- Attachment: HBASE-4628.D417.2.patch cgist updated the revision HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell. Reviewers: nspiegelberg, JIRA Added a line which was missing from admin.rb due to an unrelated commit REVISION DETAIL https://reviews.facebook.net/D417 AFFECTED FILES src/main/ruby/hbase.rb src/main/ruby/hbase/admin.rb src/main/ruby/shell/commands/create.rb Enhance Table Create Presplit Functionality within the HBase Shell -- Key: HBASE-4628 URL: https://issues.apache.org/jira/browse/HBASE-4628 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
