[jira] [Updated] (HBASE-5281) Should a failure in creating an unassigned node abort the master?
[ https://issues.apache.org/jira/browse/HBASE-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Justice updated HBASE-5281: -- Attachment: Tester.java Code that splits table 100+ times after creation. Should a failure in creating an unassigned node abort the master? - Key: HBASE-5281 URL: https://issues.apache.org/jira/browse/HBASE-5281 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.5 Reporter: Harsh J Assignee: Harsh J Fix For: 0.92.1, 0.94.0 Attachments: HBASE-5281.patch, Tester.java In {{AssignmentManager}}'s {{CreateUnassignedAsyncCallback}}, we have the following condition: {code} if (rc != 0) { // Thisis resultcode. If non-zero, need to resubmit. LOG.warn(rc != 0 for + path + -- retryable connectionloss -- + FIX see http://wiki.apache.org/hadoop/ZooKeeper/FAQ#A2;); this.zkw.abort(Connectionloss writing unassigned at + path + , rc= + rc, null); return; } {code} While a similar structure inside {{ExistsUnassignedAsyncCallback}} (which the above is linked to), does not have such a force abort. Do we really require the abort statement here, or can we make do without? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5281) Should a failure in creating an unassigned node abort the master?
[ https://issues.apache.org/jira/browse/HBASE-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J updated HBASE-5281: --- Resolution: Not A Problem Status: Resolved (was: Patch Available) Thank you for the analysis, stack and Jimmy! Marking as closed for now. Should a failure in creating an unassigned node abort the master? - Key: HBASE-5281 URL: https://issues.apache.org/jira/browse/HBASE-5281 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.5 Reporter: Harsh J Assignee: Harsh J Fix For: 0.94.0, 0.92.1 Attachments: HBASE-5281.patch In {{AssignmentManager}}'s {{CreateUnassignedAsyncCallback}}, we have the following condition: {code} if (rc != 0) { // Thisis resultcode. If non-zero, need to resubmit. LOG.warn(rc != 0 for + path + -- retryable connectionloss -- + FIX see http://wiki.apache.org/hadoop/ZooKeeper/FAQ#A2;); this.zkw.abort(Connectionloss writing unassigned at + path + , rc= + rc, null); return; } {code} While a similar structure inside {{ExistsUnassignedAsyncCallback}} (which the above is linked to), does not have such a force abort. Do we really require the abort statement here, or can we make do without? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5281) Should a failure in creating an unassigned node abort the master?
[ https://issues.apache.org/jira/browse/HBASE-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J updated HBASE-5281: --- Attachment: HBASE-5281.patch Patch that removes the abort statement, like the other callback has. Should a failure in creating an unassigned node abort the master? - Key: HBASE-5281 URL: https://issues.apache.org/jira/browse/HBASE-5281 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.5 Reporter: Harsh J Fix For: 0.94.0, 0.92.1 Attachments: HBASE-5281.patch In {{AssignmentManager}}'s {{CreateUnassignedAsyncCallback}}, we have the following condition: {code} if (rc != 0) { // Thisis resultcode. If non-zero, need to resubmit. LOG.warn(rc != 0 for + path + -- retryable connectionloss -- + FIX see http://wiki.apache.org/hadoop/ZooKeeper/FAQ#A2;); this.zkw.abort(Connectionloss writing unassigned at + path + , rc= + rc, null); return; } {code} While a similar structure inside {{ExistsUnassignedAsyncCallback}} (which the above is linked to), does not have such a force abort. Do we really require the abort statement here, or can we make do without? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5281) Should a failure in creating an unassigned node abort the master?
[ https://issues.apache.org/jira/browse/HBASE-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J updated HBASE-5281: --- Status: Patch Available (was: Open) Patch should apply both to 0.92 and trunk branches. Should a failure in creating an unassigned node abort the master? - Key: HBASE-5281 URL: https://issues.apache.org/jira/browse/HBASE-5281 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.5 Reporter: Harsh J Fix For: 0.94.0, 0.92.1 Attachments: HBASE-5281.patch In {{AssignmentManager}}'s {{CreateUnassignedAsyncCallback}}, we have the following condition: {code} if (rc != 0) { // Thisis resultcode. If non-zero, need to resubmit. LOG.warn(rc != 0 for + path + -- retryable connectionloss -- + FIX see http://wiki.apache.org/hadoop/ZooKeeper/FAQ#A2;); this.zkw.abort(Connectionloss writing unassigned at + path + , rc= + rc, null); return; } {code} While a similar structure inside {{ExistsUnassignedAsyncCallback}} (which the above is linked to), does not have such a force abort. Do we really require the abort statement here, or can we make do without? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira