[jira] [Updated] (HBASE-5357) Use builder pattern in HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lars Francke updated HBASE-5357:
Fix Version/s: (was: 0.94.20)
0.96.0
Use builder pattern in HColumnDescriptor
Key: HBASE-5357
URL: https://issues.apache.org/jira/browse/HBASE-5357
Project: HBase
Issue Type: Improvement
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Fix For: 0.96.0
Attachments: ASF.LICENSE.NOT.GRANTED--D1851.1.patch,
ASF.LICENSE.NOT.GRANTED--D1851.2.patch,
ASF.LICENSE.NOT.GRANTED--D1851.3.patch,
ASF.LICENSE.NOT.GRANTED--D1851.4.patch,
ASF.LICENSE.NOT.GRANTED--D1929.1.patch,
ASF.LICENSE.NOT.GRANTED--D1929.2.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-21_19_13_35.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-23_12_42_49.patch,
Use-builder-pattern-for-HColumnDescriptor-20120223113155-e387d251.patch
We have five ways to create an HFile writer, two ways to create a StoreFile
writer, and the sets of parameters keep changing, creating a lot of
confusion, especially when porting patches across branches. The same thing is
happening to HColumnDescriptor. I think we should move to a builder pattern
solution, e.g.
{code:java}
HFileWriter w = HFile.getWriterBuilder(conf, some common args)
.setParameter1(value1)
.setParameter2(value2)
...
.build();
{code}
Each parameter setter being on its own line will make merges/cherry-pick work
properly, we will not have to even mention default parameters again, and we
can eliminate a dozen impossible-to-remember constructors.
This particular JIRA addresses the HColumnDescriptor refactoring. For
StoreFile/HFile refactoring see HBASE-5442.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-5357) Use builder pattern in HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lars Francke updated HBASE-5357:
Fix Version/s: 0.94.20
Use builder pattern in HColumnDescriptor
Key: HBASE-5357
URL: https://issues.apache.org/jira/browse/HBASE-5357
Project: HBase
Issue Type: Improvement
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Fix For: 0.94.20
Attachments: ASF.LICENSE.NOT.GRANTED--D1851.1.patch,
ASF.LICENSE.NOT.GRANTED--D1851.2.patch,
ASF.LICENSE.NOT.GRANTED--D1851.3.patch,
ASF.LICENSE.NOT.GRANTED--D1851.4.patch,
ASF.LICENSE.NOT.GRANTED--D1929.1.patch,
ASF.LICENSE.NOT.GRANTED--D1929.2.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-21_19_13_35.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-23_12_42_49.patch,
Use-builder-pattern-for-HColumnDescriptor-20120223113155-e387d251.patch
We have five ways to create an HFile writer, two ways to create a StoreFile
writer, and the sets of parameters keep changing, creating a lot of
confusion, especially when porting patches across branches. The same thing is
happening to HColumnDescriptor. I think we should move to a builder pattern
solution, e.g.
{code:java}
HFileWriter w = HFile.getWriterBuilder(conf, some common args)
.setParameter1(value1)
.setParameter2(value2)
...
.build();
{code}
Each parameter setter being on its own line will make merges/cherry-pick work
properly, we will not have to even mention default parameters again, and we
can eliminate a dozen impossible-to-remember constructors.
This particular JIRA addresses the HColumnDescriptor refactoring. For
StoreFile/HFile refactoring see HBASE-5442.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-5357) Use builder pattern in HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lars Francke updated HBASE-5357:
Fix Version/s: (was: 0.96.0)
Use builder pattern in HColumnDescriptor
Key: HBASE-5357
URL: https://issues.apache.org/jira/browse/HBASE-5357
Project: HBase
Issue Type: Improvement
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Attachments: ASF.LICENSE.NOT.GRANTED--D1851.1.patch,
ASF.LICENSE.NOT.GRANTED--D1851.2.patch,
ASF.LICENSE.NOT.GRANTED--D1851.3.patch,
ASF.LICENSE.NOT.GRANTED--D1851.4.patch,
ASF.LICENSE.NOT.GRANTED--D1929.1.patch,
ASF.LICENSE.NOT.GRANTED--D1929.2.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-21_19_13_35.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-23_12_42_49.patch,
Use-builder-pattern-for-HColumnDescriptor-20120223113155-e387d251.patch
We have five ways to create an HFile writer, two ways to create a StoreFile
writer, and the sets of parameters keep changing, creating a lot of
confusion, especially when porting patches across branches. The same thing is
happening to HColumnDescriptor. I think we should move to a builder pattern
solution, e.g.
{code:java}
HFileWriter w = HFile.getWriterBuilder(conf, some common args)
.setParameter1(value1)
.setParameter2(value2)
...
.build();
{code}
Each parameter setter being on its own line will make merges/cherry-pick work
properly, we will not have to even mention default parameters again, and we
can eliminate a dozen impossible-to-remember constructors.
This particular JIRA addresses the HColumnDescriptor refactoring. For
StoreFile/HFile refactoring see HBASE-5442.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-5357) Use builder pattern in HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HBASE-5357:
---
Attachment: D1851.3.patch
mbautin updated the revision [jira] [HBASE-5357] Refactoring: use the builder
pattern for HColumnDescriptor.
Reviewers: JIRA, todd, stack, tedyu, Kannan, Karthik, Liyin
Rebasing on trunk changes.
REVISION DETAIL
https://reviews.facebook.net/D1851
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
src/main/java/org/apache/hadoop/hbase/client/UnmodifyableHColumnDescriptor.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
src/test/java/org/apache/hadoop/hbase/TestSerialization.java
src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
src/test/java/org/apache/hadoop/hbase/io/encoding/TestEncodedSeekers.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingTTL.java
src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java
src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestColumnSeeking.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestSeekOptimizations.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestWideScanner.java
src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
Use builder pattern in HColumnDescriptor
Key: HBASE-5357
URL: https://issues.apache.org/jira/browse/HBASE-5357
Project: HBase
Issue Type: Improvement
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Attachments: D1851.1.patch, D1851.2.patch, D1851.3.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-21_19_13_35.patch
We have five ways to create an HFile writer, two ways to create a StoreFile
writer, and the sets of parameters keep changing, creating a lot of
confusion, especially when porting patches across branches. The same thing is
happening to HColumnDescriptor. I think we should move to a builder pattern
solution, e.g.
{code:java}
HFileWriter w = HFile.getWriterBuilder(conf, some common args)
.setParameter1(value1)
.setParameter2(value2)
...
.build();
{code}
Each parameter setter being on its own line will make merges/cherry-pick work
properly, we will not have to even mention default parameters again, and we
can eliminate a dozen impossible-to-remember constructors.
This particular JIRA addresses the HColumnDescriptor refactoring. For
StoreFile/HFile refactoring see HBASE-5442.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5357) Use builder pattern in HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HBASE-5357:
---
Attachment: D1851.4.patch
mbautin updated the revision [jira] [HBASE-5357] Refactoring: use the builder
pattern for HColumnDescriptor.
Reviewers: JIRA, todd, stack, tedyu, Kannan, Karthik, Liyin
Fix TestWideScanner failure.
REVISION DETAIL
https://reviews.facebook.net/D1851
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
src/main/java/org/apache/hadoop/hbase/client/UnmodifyableHColumnDescriptor.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
src/test/java/org/apache/hadoop/hbase/TestSerialization.java
src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
src/test/java/org/apache/hadoop/hbase/io/encoding/TestEncodedSeekers.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingTTL.java
src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java
src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestColumnSeeking.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestSeekOptimizations.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestWideScanner.java
src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
Use builder pattern in HColumnDescriptor
Key: HBASE-5357
URL: https://issues.apache.org/jira/browse/HBASE-5357
Project: HBase
Issue Type: Improvement
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Attachments: D1851.1.patch, D1851.2.patch, D1851.3.patch,
D1851.4.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-21_19_13_35.patch
We have five ways to create an HFile writer, two ways to create a StoreFile
writer, and the sets of parameters keep changing, creating a lot of
confusion, especially when porting patches across branches. The same thing is
happening to HColumnDescriptor. I think we should move to a builder pattern
solution, e.g.
{code:java}
HFileWriter w = HFile.getWriterBuilder(conf, some common args)
.setParameter1(value1)
.setParameter2(value2)
...
.build();
{code}
Each parameter setter being on its own line will make merges/cherry-pick work
properly, we will not have to even mention default parameters again, and we
can eliminate a dozen impossible-to-remember constructors.
This particular JIRA addresses the HColumnDescriptor refactoring. For
StoreFile/HFile refactoring see HBASE-5442.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5357) Use builder pattern in HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Bautin updated HBASE-5357:
--
Attachment:
Use-builder-pattern-for-HColumnDescriptor-20120223113155-e387d251.patch
Use builder pattern in HColumnDescriptor
Key: HBASE-5357
URL: https://issues.apache.org/jira/browse/HBASE-5357
Project: HBase
Issue Type: Improvement
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Attachments: D1851.1.patch, D1851.2.patch, D1851.3.patch,
D1851.4.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-21_19_13_35.patch,
Use-builder-pattern-for-HColumnDescriptor-20120223113155-e387d251.patch
We have five ways to create an HFile writer, two ways to create a StoreFile
writer, and the sets of parameters keep changing, creating a lot of
confusion, especially when porting patches across branches. The same thing is
happening to HColumnDescriptor. I think we should move to a builder pattern
solution, e.g.
{code:java}
HFileWriter w = HFile.getWriterBuilder(conf, some common args)
.setParameter1(value1)
.setParameter2(value2)
...
.build();
{code}
Each parameter setter being on its own line will make merges/cherry-pick work
properly, we will not have to even mention default parameters again, and we
can eliminate a dozen impossible-to-remember constructors.
This particular JIRA addresses the HColumnDescriptor refactoring. For
StoreFile/HFile refactoring see HBASE-5442.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5357) Use builder pattern in HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Bautin updated HBASE-5357:
--
Attachment:
Use-builder-pattern-for-HColumnDescriptor-2012-02-23_12_42_25.patch
Use builder pattern in HColumnDescriptor
Key: HBASE-5357
URL: https://issues.apache.org/jira/browse/HBASE-5357
Project: HBase
Issue Type: Improvement
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Attachments: D1851.1.patch, D1851.2.patch, D1851.3.patch,
D1851.4.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-21_19_13_35.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-23_12_42_25.patch,
Use-builder-pattern-for-HColumnDescriptor-20120223113155-e387d251.patch
We have five ways to create an HFile writer, two ways to create a StoreFile
writer, and the sets of parameters keep changing, creating a lot of
confusion, especially when porting patches across branches. The same thing is
happening to HColumnDescriptor. I think we should move to a builder pattern
solution, e.g.
{code:java}
HFileWriter w = HFile.getWriterBuilder(conf, some common args)
.setParameter1(value1)
.setParameter2(value2)
...
.build();
{code}
Each parameter setter being on its own line will make merges/cherry-pick work
properly, we will not have to even mention default parameters again, and we
can eliminate a dozen impossible-to-remember constructors.
This particular JIRA addresses the HColumnDescriptor refactoring. For
StoreFile/HFile refactoring see HBASE-5442.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5357) Use builder pattern in HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Bautin updated HBASE-5357:
--
Attachment: (was:
Use-builder-pattern-for-HColumnDescriptor-2012-02-23_12_42_25.patch)
Use builder pattern in HColumnDescriptor
Key: HBASE-5357
URL: https://issues.apache.org/jira/browse/HBASE-5357
Project: HBase
Issue Type: Improvement
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Attachments: D1851.1.patch, D1851.2.patch, D1851.3.patch,
D1851.4.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-21_19_13_35.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-23_12_42_49.patch,
Use-builder-pattern-for-HColumnDescriptor-20120223113155-e387d251.patch
We have five ways to create an HFile writer, two ways to create a StoreFile
writer, and the sets of parameters keep changing, creating a lot of
confusion, especially when porting patches across branches. The same thing is
happening to HColumnDescriptor. I think we should move to a builder pattern
solution, e.g.
{code:java}
HFileWriter w = HFile.getWriterBuilder(conf, some common args)
.setParameter1(value1)
.setParameter2(value2)
...
.build();
{code}
Each parameter setter being on its own line will make merges/cherry-pick work
properly, we will not have to even mention default parameters again, and we
can eliminate a dozen impossible-to-remember constructors.
This particular JIRA addresses the HColumnDescriptor refactoring. For
StoreFile/HFile refactoring see HBASE-5442.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5357) Use builder pattern in HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Bautin updated HBASE-5357:
--
Attachment:
Use-builder-pattern-for-HColumnDescriptor-2012-02-23_12_42_49.patch
Use builder pattern in HColumnDescriptor
Key: HBASE-5357
URL: https://issues.apache.org/jira/browse/HBASE-5357
Project: HBase
Issue Type: Improvement
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Attachments: D1851.1.patch, D1851.2.patch, D1851.3.patch,
D1851.4.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-21_19_13_35.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-23_12_42_49.patch,
Use-builder-pattern-for-HColumnDescriptor-20120223113155-e387d251.patch
We have five ways to create an HFile writer, two ways to create a StoreFile
writer, and the sets of parameters keep changing, creating a lot of
confusion, especially when porting patches across branches. The same thing is
happening to HColumnDescriptor. I think we should move to a builder pattern
solution, e.g.
{code:java}
HFileWriter w = HFile.getWriterBuilder(conf, some common args)
.setParameter1(value1)
.setParameter2(value2)
...
.build();
{code}
Each parameter setter being on its own line will make merges/cherry-pick work
properly, we will not have to even mention default parameters again, and we
can eliminate a dozen impossible-to-remember constructors.
This particular JIRA addresses the HColumnDescriptor refactoring. For
StoreFile/HFile refactoring see HBASE-5442.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5357) Use builder pattern in HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HBASE-5357:
---
Attachment: D1929.1.patch
mbautin requested code review of [jira] [HBASE-5357] [89-fb] Refactoring: use
the builder pattern for HColumnDescriptor.
Reviewers: Kannan, Liyin, Karthik, JIRA
Deprecate three ugly HColumnDescriptor constructors and use a builder
pattern instead, e.g. new
HColumnDescriptor(cfName).setMaxVersions(5).setBlockSize(8192), etc. Setters
have now become builder methods.
This is the 89-fb version of D1851.
TEST PLAN
Run unit tests
REVISION DETAIL
https://reviews.facebook.net/D1929
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
src/main/java/org/apache/hadoop/hbase/client/UnmodifyableHColumnDescriptor.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
src/test/java/org/apache/hadoop/hbase/TestSerialization.java
src/test/java/org/apache/hadoop/hbase/io/encoding/TestEncodedSeekers.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingTTL.java
src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestColumnSeeking.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestSeekOptimizations.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestWideScanner.java
Use builder pattern in HColumnDescriptor
Key: HBASE-5357
URL: https://issues.apache.org/jira/browse/HBASE-5357
Project: HBase
Issue Type: Improvement
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Attachments: D1851.1.patch, D1851.2.patch, D1851.3.patch,
D1851.4.patch, D1929.1.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-21_19_13_35.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-23_12_42_49.patch,
Use-builder-pattern-for-HColumnDescriptor-20120223113155-e387d251.patch
We have five ways to create an HFile writer, two ways to create a StoreFile
writer, and the sets of parameters keep changing, creating a lot of
confusion, especially when porting patches across branches. The same thing is
happening to HColumnDescriptor. I think we should move to a builder pattern
solution, e.g.
{code:java}
HFileWriter w = HFile.getWriterBuilder(conf, some common args)
.setParameter1(value1)
.setParameter2(value2)
...
.build();
{code}
Each parameter setter being on its own line will make merges/cherry-pick work
properly, we will not have to even mention default parameters again, and we
can eliminate a dozen impossible-to-remember constructors.
This particular JIRA addresses the HColumnDescriptor refactoring. For
StoreFile/HFile refactoring see HBASE-5442.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5357) Use builder pattern in HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HBASE-5357:
---
Attachment: D1851.2.patch
mbautin updated the revision [jira] [HBASE-5357] Refactoring: use the builder
pattern for HColumnDescriptor.
Reviewers: JIRA, todd, stack, tedyu, Kannan, Karthik, Liyin
Addressing Stack's comment.
REVISION DETAIL
https://reviews.facebook.net/D1851
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
src/main/java/org/apache/hadoop/hbase/client/UnmodifyableHColumnDescriptor.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
src/test/java/org/apache/hadoop/hbase/TestSerialization.java
src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
src/test/java/org/apache/hadoop/hbase/io/encoding/TestEncodedSeekers.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingTTL.java
src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java
src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestColumnSeeking.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestSeekOptimizations.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestWideScanner.java
src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
Use builder pattern in HColumnDescriptor
Key: HBASE-5357
URL: https://issues.apache.org/jira/browse/HBASE-5357
Project: HBase
Issue Type: Improvement
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Attachments: D1851.1.patch, D1851.2.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-21_19_13_35.patch
We have five ways to create an HFile writer, two ways to create a StoreFile
writer, and the sets of parameters keep changing, creating a lot of
confusion, especially when porting patches across branches. The same thing is
happening to HColumnDescriptor. I think we should move to a builder pattern
solution, e.g.
{code:java}
HFileWriter w = HFile.getWriterBuilder(conf, some common args)
.setParameter1(value1)
.setParameter2(value2)
...
.build();
{code}
Each parameter setter being on its own line will make merges/cherry-pick work
properly, we will not have to even mention default parameters again, and we
can eliminate a dozen impossible-to-remember constructors.
This particular JIRA addresses the HColumnDescriptor refactoring. For
StoreFile/HFile refactoring see HBASE-5442.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5357) Use builder pattern in HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Bautin updated HBASE-5357:
--
Description:
We have five ways to create an HFile writer, two ways to create a StoreFile
writer, and the sets of parameters keep changing, creating a lot of confusion,
especially when porting patches across branches. The same thing is happening to
HColumnDescriptor. I think we should move to a builder pattern solution, e.g.
{code:java}
HFileWriter w = HFile.getWriterBuilder(conf, some common args)
.setParameter1(value1)
.setParameter2(value2)
...
.build();
{code}
Each parameter setter being on its own line will make merges/cherry-pick work
properly, we will not have to even mention default parameters again, and we can
eliminate a dozen impossible-to-remember constructors.
This particular JIRA addresses the HColumnDescriptor refactoring. For
StoreFile/HFile refactoring see HBASE-5442.
was:
We have five ways to create an HFile writer, two ways to create a StoreFile
writer, and the sets of parameters keep changing, creating a lot of confusion,
especially when porting patches across branches. The same thing is happening to
HColumnDescriptor. I think we should move to a builder pattern solution, e.g.
{code:java}
HFileWriter w = HFile.getWriterBuilder(conf, some common args)
.setParameter1(value1)
.setParameter2(value2)
...
.build();
{code}
Each parameter setter being on its own line will make merges/cherry-pick work
properly, we will not have to even mention default parameters again, and we can
eliminate a dozen impossible-to-remember constructors.
Summary: Use builder pattern in HColumnDescriptor (was: Use builder
pattern in StoreFile, HFile, and HColumnDescriptor instantiation)
Use builder pattern in HColumnDescriptor
Key: HBASE-5357
URL: https://issues.apache.org/jira/browse/HBASE-5357
Project: HBase
Issue Type: Improvement
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Attachments: D1851.1.patch,
Use-builder-pattern-for-HColumnDescriptor-2012-02-21_19_13_35.patch
We have five ways to create an HFile writer, two ways to create a StoreFile
writer, and the sets of parameters keep changing, creating a lot of
confusion, especially when porting patches across branches. The same thing is
happening to HColumnDescriptor. I think we should move to a builder pattern
solution, e.g.
{code:java}
HFileWriter w = HFile.getWriterBuilder(conf, some common args)
.setParameter1(value1)
.setParameter2(value2)
...
.build();
{code}
Each parameter setter being on its own line will make merges/cherry-pick work
properly, we will not have to even mention default parameters again, and we
can eliminate a dozen impossible-to-remember constructors.
This particular JIRA addresses the HColumnDescriptor refactoring. For
StoreFile/HFile refactoring see HBASE-5442.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
