[jira] [Updated] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-25 Thread Jonathan Hsieh (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Hsieh updated HBASE-5652:
--

   Resolution: Fixed
Fix Version/s: 0.96.0
 Hadoop Flags: Reviewed
   Status: Resolved  (was: Patch Available)

Thanks Greg!  Committed to trunk with an updated bug count of 517.

 [findbugs] Fix lock release on all paths 
 -

 Key: HBASE-5652
 URL: https://issues.apache.org/jira/browse/HBASE-5652
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: Gregory Chanan
 Fix For: 0.96.0

 Attachments: HBASE-5652-v0.patch, HBASE-5652-v1.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_MT_CORRECTNESS
 Category UL

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-23 Thread Gregory Chanan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gregory Chanan updated HBASE-5652:
--

Attachment: HBASE-5652-v1.patch

* Attached HBASE-5652-v1.patch *

Fixed spacing as requested by Ted.
Haven't updated test-patch.properties, as I won't know what value to use until 
Hadoop QA runs.

 [findbugs] Fix lock release on all paths 
 -

 Key: HBASE-5652
 URL: https://issues.apache.org/jira/browse/HBASE-5652
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: Gregory Chanan
 Attachments: HBASE-5652-v0.patch, HBASE-5652-v1.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_MT_CORRECTNESS
 Category UL

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-20 Thread Gregory Chanan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gregory Chanan updated HBASE-5652:
--

Status: Patch Available  (was: Open)

 [findbugs] Fix lock release on all paths 
 -

 Key: HBASE-5652
 URL: https://issues.apache.org/jira/browse/HBASE-5652
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: Gregory Chanan
 Attachments: HBASE-5652-v0.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_MT_CORRECTNESS
 Category UL

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-20 Thread Gregory Chanan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gregory Chanan updated HBASE-5652:
--

Attachment: HBASE-5652-v0.patch

* Attacked HBASE-5652-v0.patch *

Attached patch that handles all the UL issues except two, which are on the 
exception list (I haven't tested the exception list yet, we'll see if it works 
in Hadoop QA).

Those two are startRegionOperation  and startBulkRegionOperation, which are 
correct (they release the lock and throw an exception if the region is closed, 
otherwise, hold the lock and continue processing.

 [findbugs] Fix lock release on all paths 
 -

 Key: HBASE-5652
 URL: https://issues.apache.org/jira/browse/HBASE-5652
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: Gregory Chanan
 Attachments: HBASE-5652-v0.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_MT_CORRECTNESS
 Category UL

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-03-27 Thread Jonathan Hsieh (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Hsieh updated HBASE-5652:
--

Description: 
See 
https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_MT_CORRECTNESS

Category UL
Summary: [findbugs] Fix lock release on all paths   (was: [find)

 [findbugs] Fix lock release on all paths 
 -

 Key: HBASE-5652
 URL: https://issues.apache.org/jira/browse/HBASE-5652
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh

 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_MT_CORRECTNESS
 Category UL

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira