[jira] [Updated] (HBASE-5813) Retry immediately after a NotServingRegionException in a multiput
[ https://issues.apache.org/jira/browse/HBASE-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-5813: -- Resolution: Incomplete Assignee: (was: Mikhail Bautin) Status: Resolved (was: Patch Available) Retry immediately after a NotServingRegionException in a multiput - Key: HBASE-5813 URL: https://issues.apache.org/jira/browse/HBASE-5813 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Attachments: ASF.LICENSE.NOT.GRANTED--D2847.1.patch, ASF.LICENSE.NOT.GRANTED--D2847.10.patch, ASF.LICENSE.NOT.GRANTED--D2847.11.patch, ASF.LICENSE.NOT.GRANTED--D2847.12.patch, ASF.LICENSE.NOT.GRANTED--D2847.2.patch, ASF.LICENSE.NOT.GRANTED--D2847.3.patch, ASF.LICENSE.NOT.GRANTED--D2847.4.patch, ASF.LICENSE.NOT.GRANTED--D2847.5.patch, ASF.LICENSE.NOT.GRANTED--D2847.6.patch, ASF.LICENSE.NOT.GRANTED--D2847.7.patch, ASF.LICENSE.NOT.GRANTED--D2847.8.patch, ASF.LICENSE.NOT.GRANTED--D2847.9.patch After we get some errors in a multiput we invalidate the region location cache and wait for the configured time interval according to the backoff policy. However, if all errors in multiput processing were NotServingRegionExceptions, we don't really need to wait. We can retry immediately. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-5813) Retry immediately after a NotServingRegionException in a multiput
[ https://issues.apache.org/jira/browse/HBASE-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davanum Srinivas updated HBASE-5813: Status: Patch Available (was: Open) Retry immediately after a NotServingRegionException in a multiput - Key: HBASE-5813 URL: https://issues.apache.org/jira/browse/HBASE-5813 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: ASF.LICENSE.NOT.GRANTED--D2847.1.patch, ASF.LICENSE.NOT.GRANTED--D2847.10.patch, ASF.LICENSE.NOT.GRANTED--D2847.11.patch, ASF.LICENSE.NOT.GRANTED--D2847.12.patch, ASF.LICENSE.NOT.GRANTED--D2847.2.patch, ASF.LICENSE.NOT.GRANTED--D2847.3.patch, ASF.LICENSE.NOT.GRANTED--D2847.4.patch, ASF.LICENSE.NOT.GRANTED--D2847.5.patch, ASF.LICENSE.NOT.GRANTED--D2847.6.patch, ASF.LICENSE.NOT.GRANTED--D2847.7.patch, ASF.LICENSE.NOT.GRANTED--D2847.8.patch, ASF.LICENSE.NOT.GRANTED--D2847.9.patch After we get some errors in a multiput we invalidate the region location cache and wait for the configured time interval according to the backoff policy. However, if all errors in multiput processing were NotServingRegionExceptions, we don't really need to wait. We can retry immediately. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HBASE-5813) Retry immediately after a NotServingRegionException in a multiput
[ https://issues.apache.org/jira/browse/HBASE-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5813: --- Attachment: D2847.6.patch mbautin updated the revision [jira] [HBASE-5813] [89-fb] Retry immediately after a NotServingRegionException in a multiput. Reviewers: Liyin, Kannan, khemani, todd, tedyu, stack, JIRA, aaiyer Fixing the bug Ted pointed out. Also, contrary to my previous comment, there is not transition between single-put and multi-put cases between retries, so there is no need to handle detection of the same region location consistently in these two cases. REVISION DETAIL https://reviews.facebook.net/D2847 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Retry immediately after a NotServingRegionException in a multiput - Key: HBASE-5813 URL: https://issues.apache.org/jira/browse/HBASE-5813 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D2847.1.patch, D2847.2.patch, D2847.3.patch, D2847.4.patch, D2847.5.patch, D2847.6.patch After we get some errors in a multiput we invalidate the region location cache and wait for the configured time interval according to the backoff policy. However, if all errors in multiput processing were NotServingRegionExceptions, we don't really need to wait. We can retry immediately. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5813) Retry immediately after a NotServingRegionException in a multiput
[ https://issues.apache.org/jira/browse/HBASE-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5813: --- Attachment: D2847.7.patch mbautin updated the revision [jira] [HBASE-5813] [89-fb] Retry immediately after a NotServingRegionException in a multiput. Reviewers: Liyin, Kannan, khemani, todd, tedyu, stack, JIRA, aaiyer Removing unused import. REVISION DETAIL https://reviews.facebook.net/D2847 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Retry immediately after a NotServingRegionException in a multiput - Key: HBASE-5813 URL: https://issues.apache.org/jira/browse/HBASE-5813 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D2847.1.patch, D2847.2.patch, D2847.3.patch, D2847.4.patch, D2847.5.patch, D2847.6.patch, D2847.7.patch After we get some errors in a multiput we invalidate the region location cache and wait for the configured time interval according to the backoff policy. However, if all errors in multiput processing were NotServingRegionExceptions, we don't really need to wait. We can retry immediately. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5813) Retry immediately after a NotServingRegionException in a multiput
[ https://issues.apache.org/jira/browse/HBASE-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5813: --- Attachment: D2847.8.patch mbautin updated the revision [jira] [HBASE-5813] [89-fb] Retry immediately after a NotServingRegionException in a multiput. Reviewers: Liyin, Kannan, khemani, todd, tedyu, stack, JIRA, aaiyer Replacing another occurrence of HashMapbyte[], ... with a TreeMap. It is incorrect to use byte arrays as keys in a HashMap (http://stackoverflow.com/questions/1058149/using-a-byte-array-as-hashmap-key-java). Also improving comments. REVISION DETAIL https://reviews.facebook.net/D2847 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Retry immediately after a NotServingRegionException in a multiput - Key: HBASE-5813 URL: https://issues.apache.org/jira/browse/HBASE-5813 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D2847.1.patch, D2847.2.patch, D2847.3.patch, D2847.4.patch, D2847.5.patch, D2847.6.patch, D2847.7.patch, D2847.8.patch After we get some errors in a multiput we invalidate the region location cache and wait for the configured time interval according to the backoff policy. However, if all errors in multiput processing were NotServingRegionExceptions, we don't really need to wait. We can retry immediately. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5813) Retry immediately after a NotServingRegionException in a multiput
[ https://issues.apache.org/jira/browse/HBASE-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5813: --- Attachment: D2847.9.patch mbautin updated the revision [jira] [HBASE-5813] [89-fb] Retry immediately after a NotServingRegionException in a multiput. Reviewers: Liyin, Kannan, khemani, todd, tedyu, stack, JIRA, aaiyer Not allocating a TreeMap in case of a singleton put. I apologize for spam. REVISION DETAIL https://reviews.facebook.net/D2847 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Retry immediately after a NotServingRegionException in a multiput - Key: HBASE-5813 URL: https://issues.apache.org/jira/browse/HBASE-5813 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D2847.1.patch, D2847.2.patch, D2847.3.patch, D2847.4.patch, D2847.5.patch, D2847.6.patch, D2847.7.patch, D2847.8.patch, D2847.9.patch After we get some errors in a multiput we invalidate the region location cache and wait for the configured time interval according to the backoff policy. However, if all errors in multiput processing were NotServingRegionExceptions, we don't really need to wait. We can retry immediately. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5813) Retry immediately after a NotServingRegionException in a multiput
[ https://issues.apache.org/jira/browse/HBASE-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5813: --- Attachment: D2847.10.patch mbautin updated the revision [jira] [HBASE-5813] [89-fb] Retry immediately after a NotServingRegionException in a multiput. Reviewers: Liyin, Kannan, khemani, todd, tedyu, stack, JIRA, aaiyer Addressing Prakash's comments. REVISION DETAIL https://reviews.facebook.net/D2847 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Retry immediately after a NotServingRegionException in a multiput - Key: HBASE-5813 URL: https://issues.apache.org/jira/browse/HBASE-5813 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D2847.1.patch, D2847.10.patch, D2847.2.patch, D2847.3.patch, D2847.4.patch, D2847.5.patch, D2847.6.patch, D2847.7.patch, D2847.8.patch, D2847.9.patch After we get some errors in a multiput we invalidate the region location cache and wait for the configured time interval according to the backoff policy. However, if all errors in multiput processing were NotServingRegionExceptions, we don't really need to wait. We can retry immediately. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5813) Retry immediately after a NotServingRegionException in a multiput
[ https://issues.apache.org/jira/browse/HBASE-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5813: --- Attachment: D2847.11.patch mbautin updated the revision [jira] [HBASE-5813] [89-fb] Retry immediately after a NotServingRegionException in a multiput. Reviewers: Liyin, Kannan, khemani, todd, tedyu, stack, JIRA, aaiyer Updating retry logic in getRegionServerWithRetries slightly after discussing offline with Liyin. REVISION DETAIL https://reviews.facebook.net/D2847 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Retry immediately after a NotServingRegionException in a multiput - Key: HBASE-5813 URL: https://issues.apache.org/jira/browse/HBASE-5813 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D2847.1.patch, D2847.10.patch, D2847.11.patch, D2847.2.patch, D2847.3.patch, D2847.4.patch, D2847.5.patch, D2847.6.patch, D2847.7.patch, D2847.8.patch, D2847.9.patch After we get some errors in a multiput we invalidate the region location cache and wait for the configured time interval according to the backoff policy. However, if all errors in multiput processing were NotServingRegionExceptions, we don't really need to wait. We can retry immediately. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5813) Retry immediately after a NotServingRegionException in a multiput
[ https://issues.apache.org/jira/browse/HBASE-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5813: --- Attachment: D2847.12.patch mbautin updated the revision [jira] [HBASE-5813] [89-fb] Retry immediately after a NotServingRegionException in a multiput. Reviewers: Liyin, Kannan, khemani, todd, tedyu, stack, JIRA, aaiyer Prakash: I think this implements your comments. I moved the logic that decides whether to wait if region locations are the same as before to the point when we already know the new region locations. Re-testing. REVISION DETAIL https://reviews.facebook.net/D2847 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java src/main/java/org/apache/hadoop/hbase/util/Threads.java Retry immediately after a NotServingRegionException in a multiput - Key: HBASE-5813 URL: https://issues.apache.org/jira/browse/HBASE-5813 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D2847.1.patch, D2847.10.patch, D2847.11.patch, D2847.12.patch, D2847.2.patch, D2847.3.patch, D2847.4.patch, D2847.5.patch, D2847.6.patch, D2847.7.patch, D2847.8.patch, D2847.9.patch After we get some errors in a multiput we invalidate the region location cache and wait for the configured time interval according to the backoff policy. However, if all errors in multiput processing were NotServingRegionExceptions, we don't really need to wait. We can retry immediately. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5813) Retry immediately after a NotServingRegionException in a multiput
[ https://issues.apache.org/jira/browse/HBASE-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5813: --- Attachment: D2847.1.patch mbautin requested code review of [jira] [HBASE-5813] [89-fb] Retry immediately after a NotServingRegionException in a multiput. Reviewers: Liyin, Kannan, khemani, todd, tedyu, stack, JIRA After we get some errors in a multiput we invalidate the region location cache and wait for the configured time interval according to the backoff policy. However, if all errors in multiput processing were NotServingRegionExceptions, we don't really need to wait. We can retry immediately. TEST PLAN Run unit tests REVISION DETAIL https://reviews.facebook.net/D2847 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/6453/ Tip: use the X-Herald-Rules header to filter Herald messages in your client. Retry immediately after a NotServingRegionException in a multiput - Key: HBASE-5813 URL: https://issues.apache.org/jira/browse/HBASE-5813 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D2847.1.patch After we get some errors in a multiput we invalidate the region location cache and wait for the configured time interval according to the backoff policy. However, if all errors in multiput processing were NotServingRegionExceptions, we don't really need to wait. We can retry immediately. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5813) Retry immediately after a NotServingRegionException in a multiput
[ https://issues.apache.org/jira/browse/HBASE-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5813: --- Attachment: D2847.2.patch mbautin updated the revision [jira] [HBASE-5813] [89-fb] Retry immediately after a NotServingRegionException in a multiput. Reviewers: Liyin, Kannan, khemani, todd, tedyu, stack, JIRA Addressing Liyin's offline feedback: not waiting at the last retry either. REVISION DETAIL https://reviews.facebook.net/D2847 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Retry immediately after a NotServingRegionException in a multiput - Key: HBASE-5813 URL: https://issues.apache.org/jira/browse/HBASE-5813 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D2847.1.patch, D2847.2.patch After we get some errors in a multiput we invalidate the region location cache and wait for the configured time interval according to the backoff policy. However, if all errors in multiput processing were NotServingRegionExceptions, we don't really need to wait. We can retry immediately. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5813) Retry immediately after a NotServingRegionException in a multiput
[ https://issues.apache.org/jira/browse/HBASE-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5813: --- Attachment: D2847.3.patch mbautin updated the revision [jira] [HBASE-5813] [89-fb] Retry immediately after a NotServingRegionException in a multiput. Reviewers: Liyin, Kannan, khemani, todd, tedyu, stack, JIRA Addressing Ted's comment. REVISION DETAIL https://reviews.facebook.net/D2847 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Retry immediately after a NotServingRegionException in a multiput - Key: HBASE-5813 URL: https://issues.apache.org/jira/browse/HBASE-5813 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D2847.1.patch, D2847.2.patch, D2847.3.patch After we get some errors in a multiput we invalidate the region location cache and wait for the configured time interval according to the backoff policy. However, if all errors in multiput processing were NotServingRegionExceptions, we don't really need to wait. We can retry immediately. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5813) Retry immediately after a NotServingRegionException in a multiput
[ https://issues.apache.org/jira/browse/HBASE-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5813: --- Attachment: D2847.4.patch mbautin updated the revision [jira] [HBASE-5813] [89-fb] Retry immediately after a NotServingRegionException in a multiput. Reviewers: Liyin, Kannan, khemani, todd, tedyu, stack, JIRA Using the previous logic (enabling the wait) in case of InterruptedException. REVISION DETAIL https://reviews.facebook.net/D2847 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Retry immediately after a NotServingRegionException in a multiput - Key: HBASE-5813 URL: https://issues.apache.org/jira/browse/HBASE-5813 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D2847.1.patch, D2847.2.patch, D2847.3.patch, D2847.4.patch After we get some errors in a multiput we invalidate the region location cache and wait for the configured time interval according to the backoff policy. However, if all errors in multiput processing were NotServingRegionExceptions, we don't really need to wait. We can retry immediately. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5813) Retry immediately after a NotServingRegionException in a multiput
[ https://issues.apache.org/jira/browse/HBASE-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5813: --- Attachment: D2847.5.patch mbautin updated the revision [jira] [HBASE-5813] [89-fb] Retry immediately after a NotServingRegionException in a multiput. Reviewers: Liyin, Kannan, khemani, todd, tedyu, stack, JIRA Adding more logic to handle the case when we get an NSRE but the region location is the same for one of the regions on a regionserver. It is possible that that region is being reassigned and the new location has not yet been written to META. In order to avoid exhausting retries too quickly in that case, we wait for the appropriate amount of time before the retry. This will need one more iteration—a request that started as a multi-put might become a single put during the course of retries, and previous region location needs to be correctly passed from multi-put to single put. REVISION DETAIL https://reviews.facebook.net/D2847 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Retry immediately after a NotServingRegionException in a multiput - Key: HBASE-5813 URL: https://issues.apache.org/jira/browse/HBASE-5813 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D2847.1.patch, D2847.2.patch, D2847.3.patch, D2847.4.patch, D2847.5.patch After we get some errors in a multiput we invalidate the region location cache and wait for the configured time interval according to the backoff policy. However, if all errors in multiput processing were NotServingRegionExceptions, we don't really need to wait. We can retry immediately. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
