[jira] [Updated] (HBASE-5867) Improve Compaction Throttle Default
[ https://issues.apache.org/jira/browse/HBASE-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Spiegelberg updated HBASE-5867: --- Resolution: Fixed Fix Version/s: 0.96.0 Status: Resolved (was: Patch Available) Improve Compaction Throttle Default --- Key: HBASE-5867 URL: https://issues.apache.org/jira/browse/HBASE-5867 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Priority: Minor Fix For: 0.96.0 Attachments: D2943.1.patch, HBASE-5867-trunk.patch We recently had a production issue where our compactions fell behind because our compaction throttle was improperly tuned and accidentally upgraded all compactions to the large pool. The default from HBASE-3877 makes 1 bad assumption: the default number of flushed files in a compaction. Currently the algorithm is: throttleSize ~= flushSize * 2 This assumes that the basic compaction utilizes 3 files and that all 3 files are compressed. In this case, hbase.hstore.compaction.min == 6 the values were not very compressible. Both conditions should be taken into consideration. As a default, it is less damaging for the large thread to be slightly higher than it needs to be versus having everything accidentally promoted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5867) Improve Compaction Throttle Default
[ https://issues.apache.org/jira/browse/HBASE-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Spiegelberg updated HBASE-5867: --- Status: Patch Available (was: Open) Improve Compaction Throttle Default --- Key: HBASE-5867 URL: https://issues.apache.org/jira/browse/HBASE-5867 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Priority: Minor Attachments: D2943.1.patch, HBASE-5867-trunk.patch We recently had a production issue where our compactions fell behind because our compaction throttle was improperly tuned and accidentally upgraded all compactions to the large pool. The default from HBASE-3877 makes 1 bad assumption: the default number of flushed files in a compaction. Currently the algorithm is: throttleSize ~= flushSize * 2 This assumes that the basic compaction utilizes 3 files and that all 3 files are compressed. In this case, hbase.hstore.compaction.min == 6 the values were not very compressible. Both conditions should be taken into consideration. As a default, it is less damaging for the large thread to be slightly higher than it needs to be versus having everything accidentally promoted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5867) Improve Compaction Throttle Default
[ https://issues.apache.org/jira/browse/HBASE-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Spiegelberg updated HBASE-5867: --- Attachment: HBASE-5867-trunk.patch straightforward port from 89fb Improve Compaction Throttle Default --- Key: HBASE-5867 URL: https://issues.apache.org/jira/browse/HBASE-5867 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Priority: Minor Attachments: D2943.1.patch, HBASE-5867-trunk.patch We recently had a production issue where our compactions fell behind because our compaction throttle was improperly tuned and accidentally upgraded all compactions to the large pool. The default from HBASE-3877 makes 1 bad assumption: the default number of flushed files in a compaction. Currently the algorithm is: throttleSize ~= flushSize * 2 This assumes that the basic compaction utilizes 3 files and that all 3 files are compressed. In this case, hbase.hstore.compaction.min == 6 the values were not very compressible. Both conditions should be taken into consideration. As a default, it is less damaging for the large thread to be slightly higher than it needs to be versus having everything accidentally promoted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5867) Improve Compaction Throttle Default
[ https://issues.apache.org/jira/browse/HBASE-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5867: --- Attachment: D2943.1.patch nspiegelberg requested code review of [jira] [HBASE-5867] [89-fb] Improve Compaction Throttle Default. Reviewers: JIRA, Kannan, Liyin We recently had a production issue where our compactions fell behind because our compaction throttle was improperly tuned and accidentally upgraded all compactions to the large pool. The default from HBASE-3877 makes 1 bad assumption: the default number of flushed files in a compaction. MinFilesToCompact should be taken into consideration. As a default, it is less damaging for the large thread to be slightly higher than it needs to be and only get timed-majors versus having everything accidentally promoted. TEST PLAN - mvn test REVISION DETAIL https://reviews.facebook.net/D2943 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java src/main/java/org/apache/hadoop/hbase/regionserver/Store.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/6717/ Tip: use the X-Herald-Rules header to filter Herald messages in your client. Improve Compaction Throttle Default --- Key: HBASE-5867 URL: https://issues.apache.org/jira/browse/HBASE-5867 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Priority: Minor Attachments: D2943.1.patch We recently had a production issue where our compactions fell behind because our compaction throttle was improperly tuned and accidentally upgraded all compactions to the large pool. The default from HBASE-3877 makes 1 bad assumption: the default number of flushed files in a compaction. Currently the algorithm is: throttleSize ~= flushSize * 2 This assumes that the basic compaction utilizes 3 files and that all 3 files are compressed. In this case, hbase.hstore.compaction.min == 6 the values were not very compressible. Both conditions should be taken into consideration. As a default, it is less damaging for the large thread to be slightly higher than it needs to be versus having everything accidentally promoted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
