[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-7215: - Attachment: 7215v5.txt Fixes a few more wrinkles. TestImportTsv still fails. Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7251-SKETCH.txt, MutableResult.java Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-7215: - Attachment: 7215v6.txt Fix for ImportTsv (needed to setup the Serialization, because it's not using TableMapReduceUtil in all cases) Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7251-SKETCH.txt, MutableResult.java Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-7215: - Attachment: 7215v7.txt Addressed Stacks comments. Will wait for test results, if that looks good I'll post to RB. Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-7215: - Status: Open (was: Patch Available) Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-7215: - Status: Patch Available (was: Open) Not sure why HadoopQA is not picking this up. Trying again. Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-7215: - Attachment: 7215v7.txt Maybe re-attaching will do it? Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-7215: - Attachment: (was: 7215v3.txt) Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-7215: - Status: Open (was: Patch Available) Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-7215: - Status: Patch Available (was: Open) Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-7215: - Attachment: 7215-v2.txt Patch that at least passes TestFromClientSide. Also removes Writable from Action, MultiAction, and MultiResponse. In general I am quite disappointed about the current state of protobuf'ing work. This looks unprofessional, where somebody just lost interest in finishing the cleanup work. We can do better than this. The Writable stuff is still *all over* the place, sometimes mixed together with the protobuf stuff (as in the case that I fixed where the Result was serialized as a Writable inside the protobuf response). Why is HBaseObjectWritable still around? I will only believe that we protobuf'ed everything when HBaseObjectWritable is gone for good. (Sorry for the rant) Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7215-v2.txt, 7251-SKETCH.txt Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-7215: - Attachment: 7215v3.txt Lars' patch w/ some null constructor's removed and some fixes in tests to deal better w/ Result that has no kvs. Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7215-v2.txt, 7215v3.txt, 7251-SKETCH.txt Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-7215: - Status: Patch Available (was: Open) Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7215-v2.txt, 7215v3.txt, 7251-SKETCH.txt Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-7215: - Attachment: 7215v3_mutableresult.txt Maybe we should keep Result immutable and have a MutableResult in the mapred package where its needed? Here is patch showing what it'd look like. Then we could keep Result immutable. Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7251-SKETCH.txt Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-7215: - Attachment: MutableResult.java Should have included this in the last patch posted. Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-7215: - Attachment: 7215v3.txt Retry (assume hadoopqa picked up my sketch patch) Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-7215: - Status: Open (was: Patch Available) Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-7215: - Status: Patch Available (was: Open) Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7251-SKETCH.txt, MutableResult.java Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-7215: - Attachment: 7215v4.txt Starting to feel a bit better about this now. (In nothing else this was a good exercise to dive into the depth of M/R serialization and protobufs) :) Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v3.txt, 7215v4.txt, 7251-SKETCH.txt, MutableResult.java Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-7215: - Attachment: 7251-SKETCH.txt Sketch of a patch. The only testing I have done is making sure it compiles. * adds Serialization for Mutation and Result * rejigger out M/R support to use that * remove all Writable stuff from Put, Delete, Increment, and Result. Please have a careful look, this is new'ish territory for me. Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Attachments: 7251-SKETCH.txt Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-7215: - Summary: Put, Delete, Increment, and Result still implement Writable (was: Put, Delete, and Increment still implement Writable) Put, Delete, Increment, and Result still implement Writable --- Key: HBASE-7215 URL: https://issues.apache.org/jira/browse/HBASE-7215 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Priority: Blocker Fix For: 0.96.0 Making blocker as suggested by Stack. At least the following still use Put/Delete as writables. * IdentityTableReduce.java * MultiPut.java * HRegionServer.checkAndMutate -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
