[jira] [Updated] (HBASE-7340) Master coprocessor notification for assignmentManager.balance() is inconsistent
[ https://issues.apache.org/jira/browse/HBASE-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-7340: -- Description: I found this issue when reading user discussion which is quoted below. In HMaster.moveRegion(), we have: {code} this.assignmentManager.balance(rp); if (this.cpHost != null) { this.cpHost.postMove(hri, rp.getSource(), rp.getDestination()); } {code} Meaning, user can register master coprocessor which would receive region movement notification. The assignmentManager.balance(plan) call in HMaster.balance() doesn't send out such notification. I think we should enhance the following hook (at line 1335) with list of regions moved so that notification from master is consistent: {code} this.cpHost.postBalance(); {code} Here is excerpt for user discussion: Sometimes user performs compaction after a region is moved (by balancer). We should provide 'hook' which lets user specify what follow-on actions to take after region movement. See discussion on user mailing list under the thread 'How to know it's time for a major compaction?' for background information: http://search-hadoop.com/m/BDx4S1jMjF92subj=How+to+know+it+s+time+for+a+major+compaction+ was: Sometimes user performs compaction after a region is moved (by balancer). We should provide 'hook' which lets user specify what follow-on actions to take after region movement. See discussion on user mailing list under the thread 'How to know it's time for a major compaction?' for background information: http://search-hadoop.com/m/BDx4S1jMjF92subj=How+to+know+it+s+time+for+a+major+compaction+ Issue Type: Bug (was: Task) Summary: Master coprocessor notification for assignmentManager.balance() is inconsistent (was: Allow user-specified actions following region movement) @Stack: As mentioned above, I have modified the subject of this JIRA to reflect latest progress. Master coprocessor notification for assignmentManager.balance() is inconsistent --- Key: HBASE-7340 URL: https://issues.apache.org/jira/browse/HBASE-7340 Project: HBase Issue Type: Bug Reporter: Ted Yu Assignee: Ted Yu Attachments: 7340-v1.txt I found this issue when reading user discussion which is quoted below. In HMaster.moveRegion(), we have: {code} this.assignmentManager.balance(rp); if (this.cpHost != null) { this.cpHost.postMove(hri, rp.getSource(), rp.getDestination()); } {code} Meaning, user can register master coprocessor which would receive region movement notification. The assignmentManager.balance(plan) call in HMaster.balance() doesn't send out such notification. I think we should enhance the following hook (at line 1335) with list of regions moved so that notification from master is consistent: {code} this.cpHost.postBalance(); {code} Here is excerpt for user discussion: Sometimes user performs compaction after a region is moved (by balancer). We should provide 'hook' which lets user specify what follow-on actions to take after region movement. See discussion on user mailing list under the thread 'How to know it's time for a major compaction?' for background information: http://search-hadoop.com/m/BDx4S1jMjF92subj=How+to+know+it+s+time+for+a+major+compaction+ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7340) Master coprocessor notification for assignmentManager.balance() is inconsistent
[ https://issues.apache.org/jira/browse/HBASE-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-7340: -- Priority: Trivial (was: Major) Issue Type: Improvement (was: Bug) Master coprocessor notification for assignmentManager.balance() is inconsistent --- Key: HBASE-7340 URL: https://issues.apache.org/jira/browse/HBASE-7340 Project: HBase Issue Type: Improvement Reporter: Ted Yu Assignee: Ted Yu Priority: Trivial Attachments: 7340-v1.txt I found this issue when reading user discussion which is quoted below. In HMaster.moveRegion(), we have: {code} this.assignmentManager.balance(rp); if (this.cpHost != null) { this.cpHost.postMove(hri, rp.getSource(), rp.getDestination()); } {code} Meaning, user can register master coprocessor which would receive region movement notification. The assignmentManager.balance(plan) call in HMaster.balance() doesn't send out such notification. I think we should enhance the following hook (at line 1335) with list of regions moved so that notification from master is consistent: {code} this.cpHost.postBalance(); {code} Here is excerpt for user discussion: Sometimes user performs compaction after a region is moved (by balancer). We should provide 'hook' which lets user specify what follow-on actions to take after region movement. See discussion on user mailing list under the thread 'How to know it's time for a major compaction?' for background information: http://search-hadoop.com/m/BDx4S1jMjF92subj=How+to+know+it+s+time+for+a+major+compaction+ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7340) Master coprocessor notification for assignmentManager.balance() is inconsistent
[ https://issues.apache.org/jira/browse/HBASE-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-7340: -- Attachment: 7340-v2.txt Patch v2 addresses Andy's comments. Master coprocessor notification for assignmentManager.balance() is inconsistent --- Key: HBASE-7340 URL: https://issues.apache.org/jira/browse/HBASE-7340 Project: HBase Issue Type: Improvement Reporter: Ted Yu Assignee: Ted Yu Priority: Trivial Attachments: 7340-v1.txt, 7340-v2.txt I found this issue when reading user discussion which is quoted below. In HMaster.moveRegion(), we have: {code} this.assignmentManager.balance(rp); if (this.cpHost != null) { this.cpHost.postMove(hri, rp.getSource(), rp.getDestination()); } {code} Meaning, user can register master coprocessor which would receive region movement notification. The assignmentManager.balance(plan) call in HMaster.balance() doesn't send out such notification. I think we should enhance the following hook (at line 1335) with list of regions moved so that notification from master is consistent: {code} this.cpHost.postBalance(); {code} Here is excerpt for user discussion: Sometimes user performs compaction after a region is moved (by balancer). We should provide 'hook' which lets user specify what follow-on actions to take after region movement. See discussion on user mailing list under the thread 'How to know it's time for a major compaction?' for background information: http://search-hadoop.com/m/BDx4S1jMjF92subj=How+to+know+it+s+time+for+a+major+compaction+ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7340) Master coprocessor notification for assignmentManager.balance() is inconsistent
[ https://issues.apache.org/jira/browse/HBASE-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-7340: -- Resolution: Fixed Fix Version/s: 0.96.0 Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Integrated to trunk. Thanks for the review, Andy. Master coprocessor notification for assignmentManager.balance() is inconsistent --- Key: HBASE-7340 URL: https://issues.apache.org/jira/browse/HBASE-7340 Project: HBase Issue Type: Improvement Reporter: Ted Yu Assignee: Ted Yu Priority: Trivial Fix For: 0.96.0 Attachments: 7340-v1.txt, 7340-v2.txt I found this issue when reading user discussion which is quoted below. In HMaster.moveRegion(), we have: {code} this.assignmentManager.balance(rp); if (this.cpHost != null) { this.cpHost.postMove(hri, rp.getSource(), rp.getDestination()); } {code} Meaning, user can register master coprocessor which would receive region movement notification. The assignmentManager.balance(plan) call in HMaster.balance() doesn't send out such notification. I think we should enhance the following hook (at line 1335) with list of regions moved so that notification from master is consistent: {code} this.cpHost.postBalance(); {code} Here is excerpt for user discussion: Sometimes user performs compaction after a region is moved (by balancer). We should provide 'hook' which lets user specify what follow-on actions to take after region movement. See discussion on user mailing list under the thread 'How to know it's time for a major compaction?' for background information: http://search-hadoop.com/m/BDx4S1jMjF92subj=How+to+know+it+s+time+for+a+major+compaction+ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira