[jira] [Updated] (HBASE-7437) Improve CompactSelection

2013-05-15 Thread Sergey Shelukhin (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Shelukhin updated HBASE-7437:


Resolution: Fixed
Status: Resolved  (was: Patch Available)

committed long ago

 Improve CompactSelection
 

 Key: HBASE-7437
 URL: https://issues.apache.org/jira/browse/HBASE-7437
 Project: HBase
  Issue Type: Improvement
  Components: Compaction
Reporter: Hiroshi Ikeda
Assignee: Hiroshi Ikeda
Priority: Minor
 Attachments: HBASE-7437.patch, HBASE-7437-V2.patch, 
 HBASE-7437-V3.patch, HBASE-7437-V4.patch


 1. Using AtomicLong makes CompactSelection simple and improve its performance.
 2. There are unused fields and methods.
 3. The fields should be private.
 4. Assertion in the method finishRequest seems wrong:
 {code}
   public void finishRequest() {
 if (isOffPeakCompaction) {
   long newValueToLog = -1;
   synchronized(compactionCountLock) {
 assert !isOffPeakCompaction : Double-counting off-peak count for 
 compaction;
 {code}
 The above assertion seems almost always false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7437) Improve CompactSelection

2013-04-11 Thread Hiroshi Ikeda (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hiroshi Ikeda updated HBASE-7437:
-

Attachment: HBASE-7437-V4.patch

Patch v4 from review board.

 Improve CompactSelection
 

 Key: HBASE-7437
 URL: https://issues.apache.org/jira/browse/HBASE-7437
 Project: HBase
  Issue Type: Improvement
  Components: Compaction
Reporter: Hiroshi Ikeda
Assignee: Hiroshi Ikeda
Priority: Minor
 Attachments: HBASE-7437.patch, HBASE-7437-V2.patch, 
 HBASE-7437-V3.patch, HBASE-7437-V4.patch


 1. Using AtomicLong makes CompactSelection simple and improve its performance.
 2. There are unused fields and methods.
 3. The fields should be private.
 4. Assertion in the method finishRequest seems wrong:
 {code}
   public void finishRequest() {
 if (isOffPeakCompaction) {
   long newValueToLog = -1;
   synchronized(compactionCountLock) {
 assert !isOffPeakCompaction : Double-counting off-peak count for 
 compaction;
 {code}
 The above assertion seems almost always false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7437) Improve CompactSelection

2013-04-04 Thread Hiroshi Ikeda (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hiroshi Ikeda updated HBASE-7437:
-

Attachment: HBASE-7437-V3.patch

Patch v3 from review board.

 Improve CompactSelection
 

 Key: HBASE-7437
 URL: https://issues.apache.org/jira/browse/HBASE-7437
 Project: HBase
  Issue Type: Improvement
  Components: Compaction
Reporter: Hiroshi Ikeda
Assignee: Hiroshi Ikeda
Priority: Minor
 Attachments: HBASE-7437.patch, HBASE-7437-V2.patch, 
 HBASE-7437-V3.patch


 1. Using AtomicLong makes CompactSelection simple and improve its performance.
 2. There are unused fields and methods.
 3. The fields should be private.
 4. Assertion in the method finishRequest seems wrong:
 {code}
   public void finishRequest() {
 if (isOffPeakCompaction) {
   long newValueToLog = -1;
   synchronized(compactionCountLock) {
 assert !isOffPeakCompaction : Double-counting off-peak count for 
 compaction;
 {code}
 The above assertion seems almost always false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7437) Improve CompactSelection

2013-01-03 Thread Hiroshi Ikeda (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hiroshi Ikeda updated HBASE-7437:
-

Attachment: HBASE-7437-V2.patch

Patch v2 from review board.

 Improve CompactSelection
 

 Key: HBASE-7437
 URL: https://issues.apache.org/jira/browse/HBASE-7437
 Project: HBase
  Issue Type: Improvement
  Components: Compaction
Reporter: Hiroshi Ikeda
Assignee: Hiroshi Ikeda
Priority: Minor
 Attachments: HBASE-7437.patch, HBASE-7437-V2.patch


 1. Using AtomicLong makes CompactSelection simple and improve its performance.
 2. There are unused fields and methods.
 3. The fields should be private.
 4. Assertion in the method finishRequest seems wrong:
 {code}
   public void finishRequest() {
 if (isOffPeakCompaction) {
   long newValueToLog = -1;
   synchronized(compactionCountLock) {
 assert !isOffPeakCompaction : Double-counting off-peak count for 
 compaction;
 {code}
 The above assertion seems almost always false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7437) Improve CompactSelection

2012-12-25 Thread Hiroshi Ikeda (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hiroshi Ikeda updated HBASE-7437:
-

Attachment: HBASE-7437.patch

 Improve CompactSelection
 

 Key: HBASE-7437
 URL: https://issues.apache.org/jira/browse/HBASE-7437
 Project: HBase
  Issue Type: Improvement
  Components: Compaction
Reporter: Hiroshi Ikeda
Priority: Minor
 Attachments: HBASE-7437.patch


 1. Using AtomicLong makes CompactSelection simple and improve its performance.
 2. There are unused fields and methods.
 3. The fields should be private.
 4. Assertion in the method finishRequest seems wrong:
 {code}
   public void finishRequest() {
 if (isOffPeakCompaction) {
   long newValueToLog = -1;
   synchronized(compactionCountLock) {
 assert !isOffPeakCompaction : Double-counting off-peak count for 
 compaction;
 {code}
 The above assertion seems almost always false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7437) Improve CompactSelection

2012-12-25 Thread Hiroshi Ikeda (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hiroshi Ikeda updated HBASE-7437:
-

Assignee: Hiroshi Ikeda

 Improve CompactSelection
 

 Key: HBASE-7437
 URL: https://issues.apache.org/jira/browse/HBASE-7437
 Project: HBase
  Issue Type: Improvement
  Components: Compaction
Reporter: Hiroshi Ikeda
Assignee: Hiroshi Ikeda
Priority: Minor
 Attachments: HBASE-7437.patch


 1. Using AtomicLong makes CompactSelection simple and improve its performance.
 2. There are unused fields and methods.
 3. The fields should be private.
 4. Assertion in the method finishRequest seems wrong:
 {code}
   public void finishRequest() {
 if (isOffPeakCompaction) {
   long newValueToLog = -1;
   synchronized(compactionCountLock) {
 assert !isOffPeakCompaction : Double-counting off-peak count for 
 compaction;
 {code}
 The above assertion seems almost always false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7437) Improve CompactSelection

2012-12-25 Thread Hiroshi Ikeda (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hiroshi Ikeda updated HBASE-7437:
-

Status: Patch Available  (was: Open)

 Improve CompactSelection
 

 Key: HBASE-7437
 URL: https://issues.apache.org/jira/browse/HBASE-7437
 Project: HBase
  Issue Type: Improvement
  Components: Compaction
Reporter: Hiroshi Ikeda
Priority: Minor
 Attachments: HBASE-7437.patch


 1. Using AtomicLong makes CompactSelection simple and improve its performance.
 2. There are unused fields and methods.
 3. The fields should be private.
 4. Assertion in the method finishRequest seems wrong:
 {code}
   public void finishRequest() {
 if (isOffPeakCompaction) {
   long newValueToLog = -1;
   synchronized(compactionCountLock) {
 assert !isOffPeakCompaction : Double-counting off-peak count for 
 compaction;
 {code}
 The above assertion seems almost always false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira