[jira] [Updated] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-7467: - Fix Version/s: (was: 0.94.5) 0.94.4 CleanerChore checkAndDeleteDirectory not deleting empty directories --- Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.95.0, 0.94.4 Attachments: 7465_7467-v5-0.94, 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7465_7467-v6-0.94.patch, HBASE-7465_7467-v7-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Marc Spaggiari updated HBASE-7467: --- Attachment: HBASE-7465_7467-v5-0.94.patch Patch for 0.94 attached. CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-7467: -- Status: Open (was: Patch Available) CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-7467: -- Attachment: 7465_7467-v5-0.94 The previous 0.94 patch was malformed. Attached is after some modification. However it still didn't apply cleanly: patching file src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java Reversed (or previously applied) patch detected! Assume -R? [n] ^C CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5-0.94, 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Marc Spaggiari updated HBASE-7467: --- Attachment: HBASE-7465_7467-v6-0.94.patch Another try ;) Still learning the right way to build the patch... CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5-0.94, 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7465_7467-v6-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Marc Spaggiari updated HBASE-7467: --- Attachment: HBASE-7465_7467-v7-0.94.patch Thanks to Ted for his help to build this patch correctly. Sorry for all those version. I hope this one is correct. CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5-0.94, 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7465_7467-v6-0.94.patch, HBASE-7465_7467-v7-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-7467: -- Summary: CleanerChore checkAndDeleteDirectory not deleting empty directories (was: CleanerChore checkAndDeleteDirectory not deleting empty directories.) CleanerChore checkAndDeleteDirectory not deleting empty directories --- Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5-0.94, 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7465_7467-v6-0.94.patch, HBASE-7465_7467-v7-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-7467: -- Hadoop Flags: Reviewed CleanerChore checkAndDeleteDirectory not deleting empty directories --- Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 7465_7467-v5-0.94, 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7465_7467-v6-0.94.patch, HBASE-7465_7467-v7-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-7467: -- Fix Version/s: (was: 0.94.5) 0.94.4 Integrated to 0.94 branch. Thanks for the patch, Jean-Marc. Thanks for the review, Lars. I will watch 0.94 build closely. CleanerChore checkAndDeleteDirectory not deleting empty directories --- Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 7465_7467-v5-0.94, 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7465_7467-v6-0.94.patch, HBASE-7465_7467-v7-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Marc Spaggiari updated HBASE-7467: --- Attachment: HBASE-7465_7467-v4.patch So. Another version is attached with the catch for IOException. FSUtils.listStatus(fs, toCheck); can still throw an IOException, so we are fine to keep the throws IOException declaration. Again, this is also including Jesse's fix for 7465. CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-7467: -- Attachment: 7465_7467-v5.txt Patch v5 fixed compilation error. Also corrected spelling. CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-7467: - Fix Version/s: 0.94.5 0.96.0 CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Marc Spaggiari updated HBASE-7467: --- Status: Patch Available (was: Open) CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Marc Spaggiari updated HBASE-7467: --- Attachment: HBASE-7467.patch Jesse, If an empty directory is created for any reason, which mine without any file into it, the current checkAndDeleteDirectory will not delete it. Current version of checkAndDeleteDirectory only delete directories where where is files which can be deleted too. But if the directory is empty, it's not deleted. The patch proposed here is to address that. Just let me know if I'm not clear. CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: HBASE-7467.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Marc Spaggiari updated HBASE-7467: --- Attachment: HBASE-7467-v2.patch Ok, got it! Here is a patch which add the emptydirectory test and also fix it. It's still throwing the IOException, which will most probably be fixed when I will apply you patch from 7465. CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[
https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jean-Marc Spaggiari updated HBASE-7467:
---
Attachment: HBASE-7465_7467-v3.patch
Attached is Jesse's patch + mine both in a single file. But they can still noth
be applied separatly. I'm not sure what's the best way to go, so I will let you
pickup the recommanded one.
Also, I'm wondering if I should replace
if (children == null) return fs.delete(toCheck, false);
by
if (children == null) {
try {
return fs.delete(toCheck, false);
} catch (IOException e) {
if (LOG.isTraceEnabled()) {
LOG.trace(Couldn't delete directory: + toCheck, e);
}
}
// couldn't delete w/o exception, so we can't return success.
return false;
}
Like Jesse did too...
CleanerChore checkAndDeleteDirectory not deleting empty directories.
Key: HBASE-7467
URL: https://issues.apache.org/jira/browse/HBASE-7467
Project: HBase
Issue Type: Bug
Reporter: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0, 0.94.5
Attachments: HBASE-7465_7467-v3.patch, HBASE-7467.patch,
HBASE-7467-v2.patch
CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a
result, some directories are kept in the FS but should have been removed.
To reproduce, simply create an empty directory under
/hbase/.archive/table_name/. If you place a file into this directory, it's
not more empty and therefore it's correctly removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
