[jira] [Updated] (HBASE-7588) Fix two findbugs warning in MemStoreFlusher
[ https://issues.apache.org/jira/browse/HBASE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-7588: - Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Thanks JM. Committed to trunk. Fix two findbugs warning in MemStoreFlusher --- Key: HBASE-7588 URL: https://issues.apache.org/jira/browse/HBASE-7588 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7588-v0-trunk.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7588) Fix two findbugs warning in MemStoreFlusher
[
https://issues.apache.org/jira/browse/HBASE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jean-Marc Spaggiari updated HBASE-7588:
---
Status: Patch Available (was: Reopened)
{quote}Is any sort of compare really used on WakeupFlushThread? {quote}
I did not find anywhere where this is used...
{quote}Go ahead with second style.{quote}
Perfect, it's done.
{quote}The imports added,{quote}
Removed...
{quote}and the blank line w/spaces before toString, seem unnecessary.{quote}
Removed too. Also removed some which was already there.
Updated patch attached.
Fix two findbugs warning in MemStoreFlusher
---
Key: HBASE-7588
URL: https://issues.apache.org/jira/browse/HBASE-7588
Project: HBase
Issue Type: Bug
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-7588-v0-trunk.patch, HBASE-7588-v1-trunk.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7588) Fix two findbugs warning in MemStoreFlusher
[ https://issues.apache.org/jira/browse/HBASE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Marc Spaggiari updated HBASE-7588: --- Attachment: HBASE-7588-v1-trunk.patch Fix two findbugs warning in MemStoreFlusher --- Key: HBASE-7588 URL: https://issues.apache.org/jira/browse/HBASE-7588 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7588-v0-trunk.patch, HBASE-7588-v1-trunk.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7588) Fix two findbugs warning in MemStoreFlusher
[ https://issues.apache.org/jira/browse/HBASE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Marc Spaggiari updated HBASE-7588: --- Status: Open (was: Patch Available) Misses one thing :( Fix two findbugs warning in MemStoreFlusher --- Key: HBASE-7588 URL: https://issues.apache.org/jira/browse/HBASE-7588 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7588-v0-trunk.patch, HBASE-7588-v1-trunk.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7588) Fix two findbugs warning in MemStoreFlusher
[ https://issues.apache.org/jira/browse/HBASE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Marc Spaggiari updated HBASE-7588: --- Attachment: HBASE-7588-v2-trunk.patch Fix two findbugs warning in MemStoreFlusher --- Key: HBASE-7588 URL: https://issues.apache.org/jira/browse/HBASE-7588 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7588-v0-trunk.patch, HBASE-7588-v1-trunk.patch, HBASE-7588-v2-trunk.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7588) Fix two findbugs warning in MemStoreFlusher
[ https://issues.apache.org/jira/browse/HBASE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Marc Spaggiari updated HBASE-7588: --- Status: Patch Available (was: Open) Fix two findbugs warning in MemStoreFlusher --- Key: HBASE-7588 URL: https://issues.apache.org/jira/browse/HBASE-7588 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7588-v0-trunk.patch, HBASE-7588-v1-trunk.patch, HBASE-7588-v2-trunk.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7588) Fix two findbugs warning in MemStoreFlusher
[ https://issues.apache.org/jira/browse/HBASE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-7588: - Resolution: Fixed Status: Resolved (was: Patch Available) Resolved. Thanks for the patch v2 JM (and lads for the reviews) Fix two findbugs warning in MemStoreFlusher --- Key: HBASE-7588 URL: https://issues.apache.org/jira/browse/HBASE-7588 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7588-v0-trunk.patch, HBASE-7588-v1-trunk.patch, HBASE-7588-v2-trunk.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7588) Fix two findbugs warning in MemStoreFlusher
[ https://issues.apache.org/jira/browse/HBASE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Marc Spaggiari updated HBASE-7588: --- Fix Version/s: 0.96.0 Status: Patch Available (was: Open) Added the 2 missing equals method to remove the findbugs warnings. Eq org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushRegionEntry defines compareTo(Object) and uses Object.equals() Bug type EQ_COMPARETO_USE_OBJECT_EQUALS (click for details) In class org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushRegionEntry In method org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushRegionEntry.compareTo(Object) At MemStoreFlusher.java:[line 543] Eq org.apache.hadoop.hbase.regionserver.MemStoreFlusher$WakeupFlushThread defines compareTo(Object) and uses Object.equals() Bug type EQ_COMPARETO_USE_OBJECT_EQUALS (click for details) In class org.apache.hadoop.hbase.regionserver.MemStoreFlusher$WakeupFlushThread In method org.apache.hadoop.hbase.regionserver.MemStoreFlusher$WakeupFlushThread.compareTo(Object) At MemStoreFlusher.java:[line 523] Fix two findbugs warning in MemStoreFlusher --- Key: HBASE-7588 URL: https://issues.apache.org/jira/browse/HBASE-7588 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7588-v0-trunk.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7588) Fix two findbugs warning in MemStoreFlusher
[ https://issues.apache.org/jira/browse/HBASE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Marc Spaggiari updated HBASE-7588: --- Attachment: HBASE-7588-v0-trunk.patch Fix two findbugs warning in MemStoreFlusher --- Key: HBASE-7588 URL: https://issues.apache.org/jira/browse/HBASE-7588 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Attachments: HBASE-7588-v0-trunk.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
