[jira] [Updated] (HBASE-7788) [snapshot 130201 merge] Fix flakey TestRestore*SnapshotFromClient#testCloneSnapshot
[ https://issues.apache.org/jira/browse/HBASE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-7788: -- Attachment: hbase-7788.patch Nice and simple patch. [snapshot 130201 merge] Fix flakey TestRestore*SnapshotFromClient#testCloneSnapshot --- Key: HBASE-7788 URL: https://issues.apache.org/jira/browse/HBASE-7788 Project: HBase Issue Type: Sub-task Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Attachments: hbase-7788.patch In the current implementation the clone call waits until after the newly created table isTableEnabled. However there is another state (apparently orthogonal) that a newly created table is assumed to be – isTableAvailable (all regions assigned). The logic for checking after table creation and after clone creation are slightly different – creation does the equivalent of isTableAvailable but clone does not check this availability condition. This causes flaky failures in tests that quickly try to use/delete a newly cloned table. TestRestoreSnapshotFromClient#testCloneSnapshot TestRestoreFlushSnapshotFromCleitn#testCloneSnapshot I believe there also are race conditions because of the postTableCreateHandler corpco and postTableDeleteHandler coproc hooks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7788) [snapshot 130201 merge] Fix flakey TestRestore*SnapshotFromClient#testCloneSnapshot
[ https://issues.apache.org/jira/browse/HBASE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-7788: -- Status: Patch Available (was: Open) [snapshot 130201 merge] Fix flakey TestRestore*SnapshotFromClient#testCloneSnapshot --- Key: HBASE-7788 URL: https://issues.apache.org/jira/browse/HBASE-7788 Project: HBase Issue Type: Sub-task Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Attachments: hbase-7788.patch In the current implementation the clone call waits until after the newly created table isTableEnabled. However there is another state (apparently orthogonal) that a newly created table is assumed to be – isTableAvailable (all regions assigned). The logic for checking after table creation and after clone creation are slightly different – creation does the equivalent of isTableAvailable but clone does not check this availability condition. This causes flaky failures in tests that quickly try to use/delete a newly cloned table. TestRestoreSnapshotFromClient#testCloneSnapshot TestRestoreFlushSnapshotFromCleitn#testCloneSnapshot I believe there also are race conditions because of the postTableCreateHandler corpco and postTableDeleteHandler coproc hooks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7788) [snapshot 130201 merge] Fix flakey TestRestore*SnapshotFromClient#testCloneSnapshot
[ https://issues.apache.org/jira/browse/HBASE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-7788: -- Attachment: hbase-7788.debug.patch the hbase-7788.debug.patch file adds some debugging information that is not intended for commit, but was useful for diagnosing the problem. [snapshot 130201 merge] Fix flakey TestRestore*SnapshotFromClient#testCloneSnapshot --- Key: HBASE-7788 URL: https://issues.apache.org/jira/browse/HBASE-7788 Project: HBase Issue Type: Sub-task Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Attachments: hbase-7788.debug.patch, hbase-7788.patch In the current implementation the clone call waits until after the newly created table isTableEnabled. However there is another state (apparently orthogonal) that a newly created table is assumed to be – isTableAvailable (all regions assigned). The logic for checking after table creation and after clone creation are slightly different – creation does the equivalent of isTableAvailable but clone does not check this availability condition. This causes flaky failures in tests that quickly try to use/delete a newly cloned table. TestRestoreSnapshotFromClient#testCloneSnapshot TestRestoreFlushSnapshotFromCleitn#testCloneSnapshot I believe there also are race conditions because of the postTableCreateHandler corpco and postTableDeleteHandler coproc hooks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7788) [snapshot 130201 merge] Fix flakey TestRestore*SnapshotFromClient#testCloneSnapshot
[ https://issues.apache.org/jira/browse/HBASE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-7788: -- Attachment: hbase-7788.v2.patch version I committed (added extra comments) [snapshot 130201 merge] Fix flakey TestRestore*SnapshotFromClient#testCloneSnapshot --- Key: HBASE-7788 URL: https://issues.apache.org/jira/browse/HBASE-7788 Project: HBase Issue Type: Sub-task Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Attachments: hbase-7788.debug.patch, hbase-7788.patch, hbase-7788.v2.patch In the current implementation the clone call waits until after the newly created table isTableEnabled. However there is another state (apparently orthogonal) that a newly created table is assumed to be – isTableAvailable (all regions assigned). The logic for checking after table creation and after clone creation are slightly different – creation does the equivalent of isTableAvailable but clone does not check this availability condition. This causes flaky failures in tests that quickly try to use/delete a newly cloned table. TestRestoreSnapshotFromClient#testCloneSnapshot TestRestoreFlushSnapshotFromCleitn#testCloneSnapshot I believe there also are race conditions because of the postTableCreateHandler corpco and postTableDeleteHandler coproc hooks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7788) [snapshot 130201 merge] Fix flakey TestRestore*SnapshotFromClient#testCloneSnapshot
[ https://issues.apache.org/jira/browse/HBASE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-7788: -- Resolution: Fixed Fix Version/s: hbase-7290 Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) committed to snapshots branch. Thanks for the review matteo. [snapshot 130201 merge] Fix flakey TestRestore*SnapshotFromClient#testCloneSnapshot --- Key: HBASE-7788 URL: https://issues.apache.org/jira/browse/HBASE-7788 Project: HBase Issue Type: Sub-task Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Fix For: hbase-7290 Attachments: hbase-7788.debug.patch, hbase-7788.patch, hbase-7788.v2.patch In the current implementation the clone call waits until after the newly created table isTableEnabled. However there is another state (apparently orthogonal) that a newly created table is assumed to be – isTableAvailable (all regions assigned). The logic for checking after table creation and after clone creation are slightly different – creation does the equivalent of isTableAvailable but clone does not check this availability condition. This causes flaky failures in tests that quickly try to use/delete a newly cloned table. TestRestoreSnapshotFromClient#testCloneSnapshot TestRestoreFlushSnapshotFromCleitn#testCloneSnapshot I believe there also are race conditions because of the postTableCreateHandler corpco and postTableDeleteHandler coproc hooks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
