[jira] [Updated] (HBASE-9355) HBaseTestingUtility#cleanupDataTestDirOnTestFS() doesn't close the FileSystem

[Andrew Kyle Purtell (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-9355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell updated HBASE-9355:
---
  Assignee: (was: Rekha Joshi)
Resolution: Abandoned
Status: Resolved  (was: Patch Available)

> HBaseTestingUtility#cleanupDataTestDirOnTestFS() doesn't close the FileSystem
> -
>
> Key: HBASE-9355
> URL: https://issues.apache.org/jira/browse/HBASE-9355
> Project: HBase
>  Issue Type: Test
>Affects Versions: 0.92.2
>Reporter: Ted Yu
>Priority: Minor
> Attachments: HBASE-9355.1.patch
>
>
> Here is related code:
> {code}
>   public boolean cleanupDataTestDirOnTestFS() throws IOException {
> boolean ret = getTestFileSystem().delete(dataTestDirOnTestFS, true);
> if (ret)
>   dataTestDirOnTestFS = null;
> return ret;
>   }
> {code}
> The FileSystem returned by getTestFileSystem() is not closed.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Updated] (HBASE-9355) HBaseTestingUtility#cleanupDataTestDirOnTestFS() doesn't close the FileSystem

[Rekha Joshi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-9355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rekha Joshi updated HBASE-9355:
---

Attachment: HBASE-9355.1.patch

Attached patch.
Think the configuration parameter - fs.automatic.close set to true seems 
better, rather than the boilerplate.What do you think?

> HBaseTestingUtility#cleanupDataTestDirOnTestFS() doesn't close the FileSystem
> -
>
> Key: HBASE-9355
> URL: https://issues.apache.org/jira/browse/HBASE-9355
> Project: HBase
>  Issue Type: Test
>Affects Versions: 0.92.2
>Reporter: Ted Yu
>Priority: Minor
> Attachments: HBASE-9355.1.patch
>
>
> Here is related code:
> {code}
>   public boolean cleanupDataTestDirOnTestFS() throws IOException {
> boolean ret = getTestFileSystem().delete(dataTestDirOnTestFS, true);
> if (ret)
>   dataTestDirOnTestFS = null;
> return ret;
>   }
> {code}
> The FileSystem returned by getTestFileSystem() is not closed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (HBASE-9355) HBaseTestingUtility#cleanupDataTestDirOnTestFS() doesn't close the FileSystem

[Rekha Joshi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-9355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rekha Joshi updated HBASE-9355:
---

Affects Version/s: 0.92.2
   Status: Patch Available  (was: Open)

Attached patch.
Think the configuration parameter - fs.automatic.close set to true seems 
better, rather than the boilerplate.What do you think?

> HBaseTestingUtility#cleanupDataTestDirOnTestFS() doesn't close the FileSystem
> -
>
> Key: HBASE-9355
> URL: https://issues.apache.org/jira/browse/HBASE-9355
> Project: HBase
>  Issue Type: Test
>Affects Versions: 0.92.2
>Reporter: Ted Yu
>Priority: Minor
> Attachments: HBASE-9355.1.patch
>
>
> Here is related code:
> {code}
>   public boolean cleanupDataTestDirOnTestFS() throws IOException {
> boolean ret = getTestFileSystem().delete(dataTestDirOnTestFS, true);
> if (ret)
>   dataTestDirOnTestFS = null;
> return ret;
>   }
> {code}
> The FileSystem returned by getTestFileSystem() is not closed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)