Re: [PR] HBASE-28290 Addendum also change title for test javadoc [hbase]
Apache9 merged PR #5601: URL: https://github.com/apache/hbase/pull/5601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28287 Fix the inaccurate expired time of MOB HFiles [hbase]
Apache9 commented on code in PR #5599:
URL: https://github.com/apache/hbase/pull/5599#discussion_r1440572185
##
hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestExpiredMobFileCleaner.java:
##
@@ -140,7 +140,8 @@ public void testCleaner() throws Exception {
assertEquals("Before cleanup without delay 1", 1, firstFiles.length);
String firstFile = firstFiles[0].getPath().getName();
-ts = EnvironmentEdgeManager.currentTime() - 1 * secondsOfDay() * 1000; //
1 day before
+ts = (long) (EnvironmentEdgeManager.currentTime() - 1.5 * secondsOfDay() *
1000); // 1.5 day
Review Comment:
Why we need to change the ts here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (HBASE-28249) Bump jruby to 9.3.13.0 and related joni and jcodings to 2.2.1 and 1.0.58 respectively
[ https://issues.apache.org/jira/browse/HBASE-28249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28249: --- Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to branch-2.6+ Thanks for the review [~chrajeshbab...@gmail.com] > Bump jruby to 9.3.13.0 and related joni and jcodings to 2.2.1 and 1.0.58 > respectively > - > > Key: HBASE-28249 > URL: https://issues.apache.org/jira/browse/HBASE-28249 > Project: HBase > Issue Type: Task > Components: jruby, security, shell >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 2.6.0, 3.0.0-beta-2 > > > Given branch-2 including branch-2.6 is already on 9.3.9.0, we should bump to > at least 9.3.13.0. This will fix the bundled *org.bouncycastle : > bcprov-jdk18on : 1.71* having > [CVE-2023-33201|https://nvd.nist.gov/vuln/detail/CVE-2023-33201] from our > classpath for the least. > As a follow up can try to bump to latest 9.4.x line. Otherwise I can try to > work directly on HBASE-28250 as well, although this may not be straight > forward and would require some good testing. > Please let me know what others think. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28249) Bump jruby to 9.3.13.0 and related joni and jcodings to 2.2.1 and 1.0.58 respectively
[ https://issues.apache.org/jira/browse/HBASE-28249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28249: --- Component/s: security shell > Bump jruby to 9.3.13.0 and related joni and jcodings to 2.2.1 and 1.0.58 > respectively > - > > Key: HBASE-28249 > URL: https://issues.apache.org/jira/browse/HBASE-28249 > Project: HBase > Issue Type: Task > Components: jruby, security, shell >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 2.6.0, 3.0.0-beta-2 > > > Given branch-2 including branch-2.6 is already on 9.3.9.0, we should bump to > at least 9.3.13.0. This will fix the bundled *org.bouncycastle : > bcprov-jdk18on : 1.71* having > [CVE-2023-33201|https://nvd.nist.gov/vuln/detail/CVE-2023-33201] from our > classpath for the least. > As a follow up can try to bump to latest 9.4.x line. Otherwise I can try to > work directly on HBASE-28250 as well, although this may not be straight > forward and would require some good testing. > Please let me know what others think. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28249) Bump jruby to 9.3.13.0 and related joni and jcodings to 2.2.1 and 1.0.58 respectively
[ https://issues.apache.org/jira/browse/HBASE-28249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28249: --- Fix Version/s: 2.6.0 > Bump jruby to 9.3.13.0 and related joni and jcodings to 2.2.1 and 1.0.58 > respectively > - > > Key: HBASE-28249 > URL: https://issues.apache.org/jira/browse/HBASE-28249 > Project: HBase > Issue Type: Task > Components: jruby >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 2.6.0, 3.0.0-beta-2 > > > Given branch-2 including branch-2.6 is already on 9.3.9.0, we should bump to > at least 9.3.13.0. This will fix the bundled *org.bouncycastle : > bcprov-jdk18on : 1.71* having > [CVE-2023-33201|https://nvd.nist.gov/vuln/detail/CVE-2023-33201] from our > classpath for the least. > As a follow up can try to bump to latest 9.4.x line. Otherwise I can try to > work directly on HBASE-28250 as well, although this may not be straight > forward and would require some good testing. > Please let me know what others think. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28290 Addendum use 'Test API' for test javadoc [hbase]
Apache-HBase commented on PR #5602: URL: https://github.com/apache/hbase/pull/5602#issuecomment-1875599017 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 46s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 55s | master passed | | +1 :green_heart: | compile | 5m 1s | master passed | | +1 :green_heart: | spotless | 0m 43s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 35s | the patch passed | | +1 :green_heart: | compile | 4m 50s | the patch passed | | +1 :green_heart: | javac | 4m 50s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 9m 13s | Patch does not cause any errors with Hadoop 3.2.4 3.3.6. | | +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 35m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5602/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5602 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile | | uname | Linux 9c1f289354b0 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4a545581ca | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5602/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28249) Bump jruby to 9.3.13.0 and related joni and jcodings to 2.2.1 and 1.0.58 respectively
[ https://issues.apache.org/jira/browse/HBASE-28249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28249: --- Fix Version/s: 3.0.0-beta-2 > Bump jruby to 9.3.13.0 and related joni and jcodings to 2.2.1 and 1.0.58 > respectively > - > > Key: HBASE-28249 > URL: https://issues.apache.org/jira/browse/HBASE-28249 > Project: HBase > Issue Type: Task > Components: jruby >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 3.0.0-beta-2 > > > Given branch-2 including branch-2.6 is already on 9.3.9.0, we should bump to > at least 9.3.13.0. This will fix the bundled *org.bouncycastle : > bcprov-jdk18on : 1.71* having > [CVE-2023-33201|https://nvd.nist.gov/vuln/detail/CVE-2023-33201] from our > classpath for the least. > As a follow up can try to bump to latest 9.4.x line. Otherwise I can try to > work directly on HBASE-28250 as well, although this may not be straight > forward and would require some good testing. > Please let me know what others think. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28290) Add 'TM' superscript to the index page title when generating javadoc
[ https://issues.apache.org/jira/browse/HBASE-28290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802198#comment-17802198 ] Duo Zhang commented on HBASE-28290: --- Strange, the test doc title is still not change on our website... Let me check locally again. > Add 'TM' superscript to the index page title when generating javadoc > > > Key: HBASE-28290 > URL: https://issues.apache.org/jira/browse/HBASE-28290 > Project: HBase > Issue Type: Sub-task > Components: build, documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28290 Addendum use 'Test API' for test javadoc [hbase]
NihalJain commented on code in PR #5602: URL: https://github.com/apache/hbase/pull/5602#discussion_r1440569684 ## pom.xml: ## @@ -3162,7 +3162,7 @@ testapidocs Test User API The HBase Application Programmer's API Review Comment: You may also want to change description: "API" -> "Test API" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28249 Bump jruby to 9.3.13.0 and related joni and jcodings to 2… [hbase]
NihalJain merged PR #5568: URL: https://github.com/apache/hbase/pull/5568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28290) Add 'TM' superscript to the index page title when generating javadoc
[ https://issues.apache.org/jira/browse/HBASE-28290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802209#comment-17802209 ] Duo Zhang commented on HBASE-28290: --- OK, it is just because my browser's cache... Anyway, we should use Test API instead of API for test page... Let me open another PR, sorry for the back and forth... > Add 'TM' superscript to the index page title when generating javadoc > > > Key: HBASE-28290 > URL: https://issues.apache.org/jira/browse/HBASE-28290 > Project: HBase > Issue Type: Sub-task > Components: build, documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28290 Addendum use 'Test API' for test javadoc [hbase]
NihalJain commented on code in PR #5602: URL: https://github.com/apache/hbase/pull/5602#discussion_r1440569684 ## pom.xml: ## @@ -3162,7 +3162,7 @@ testapidocs Test User API The HBase Application Programmer's API Review Comment: You may also want to change description to "Test API" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28290 Addendum use 'Test API' for test javadoc [hbase]
NihalJain commented on code in PR #5602: URL: https://github.com/apache/hbase/pull/5602#discussion_r1440569684 ## pom.xml: ## @@ -3162,7 +3162,7 @@ testapidocs Test User API The HBase Application Programmer's API Review Comment: You may also want to change this to Test API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28290) Add 'TM' superscript to the index page title when generating javadoc
[
https://issues.apache.org/jira/browse/HBASE-28290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802299#comment-17802299
]
Hudson commented on HBASE-28290:
Results for branch master
[build #975 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/975/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/975/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/975/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/975/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add 'TM' superscript to the index page title when generating javadoc
>
>
> Key: HBASE-28290
> URL: https://issues.apache.org/jira/browse/HBASE-28290
> Project: HBase
> Issue Type: Sub-task
> Components: build, documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28290 Addendum use 'Test API' for test javadoc [hbase]
Apache-HBase commented on PR #5602: URL: https://github.com/apache/hbase/pull/5602#issuecomment-1875945258 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 35s | master passed | | +1 :green_heart: | compile | 1m 57s | master passed | | +1 :green_heart: | shadedjars | 4m 55s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 56s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 41s | the patch passed | | +1 :green_heart: | compile | 1m 59s | the patch passed | | +1 :green_heart: | javac | 1m 59s | the patch passed | | +1 :green_heart: | shadedjars | 4m 49s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 55s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 285m 56s | root in the patch passed. | | | | 316m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5602/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5602 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a139043ea703 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4a545581ca | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5602/1/testReport/ | | Max. process+thread count | 8418 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5602/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28249) Bump jruby to 9.3.13.0 and related joni and jcodings to 2.2.1 and 1.0.58 respectively
[
https://issues.apache.org/jira/browse/HBASE-28249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802393#comment-17802393
]
Hudson commented on HBASE-28249:
Results for branch branch-2.6
[build #20 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/20/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/20/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/20/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/20/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/20/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/20//console].
> Bump jruby to 9.3.13.0 and related joni and jcodings to 2.2.1 and 1.0.58
> respectively
> -
>
> Key: HBASE-28249
> URL: https://issues.apache.org/jira/browse/HBASE-28249
> Project: HBase
> Issue Type: Task
> Components: jruby, security, shell
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 2.6.0, 3.0.0-beta-2
>
>
> Given branch-2 including branch-2.6 is already on 9.3.9.0, we should bump to
> at least 9.3.13.0. This will fix the bundled *org.bouncycastle :
> bcprov-jdk18on : 1.71* having
> [CVE-2023-33201|https://nvd.nist.gov/vuln/detail/CVE-2023-33201] from our
> classpath for the least.
> As a follow up can try to bump to latest 9.4.x line. Otherwise I can try to
> work directly on HBASE-28250 as well, although this may not be straight
> forward and would require some good testing.
> Please let me know what others think.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28271 Infinite waiting on lock acquisition by snapshot can result in unresponsive master [hbase]
Apache-HBase commented on PR #5603: URL: https://github.com/apache/hbase/pull/5603#issuecomment-1876257790 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 3s | master passed | | +1 :green_heart: | compile | 0m 46s | master passed | | +1 :green_heart: | shadedjars | 5m 15s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 42s | the patch passed | | +1 :green_heart: | compile | 0m 45s | the patch passed | | +1 :green_heart: | javac | 0m 45s | the patch passed | | +1 :green_heart: | shadedjars | 5m 16s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 216m 41s | hbase-server in the patch passed. | | | | 240m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5603 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4d59273184e1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4a545581ca | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/1/testReport/ | | Max. process+thread count | 4727 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28290 Addendum use 'Test API' for test javadoc [hbase]
Apache-HBase commented on PR #5602: URL: https://github.com/apache/hbase/pull/5602#issuecomment-1876066982 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 39s | master passed | | +1 :green_heart: | compile | 1m 34s | master passed | | +1 :green_heart: | shadedjars | 5m 11s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 23s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 18s | the patch passed | | +1 :green_heart: | compile | 1m 34s | the patch passed | | +1 :green_heart: | javac | 1m 34s | the patch passed | | +1 :green_heart: | shadedjars | 5m 7s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 20s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 404m 37s | root in the patch failed. | | | | 433m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5602/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5602 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fe508d5cb5e2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4a545581ca | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5602/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5602/1/testReport/ | | Max. process+thread count | 8517 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5602/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28271) Infinite waiting on lock acquisition by snapshot can result in unresponsive master
[ https://issues.apache.org/jira/browse/HBASE-28271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802345#comment-17802345 ] Viraj Jasani commented on HBASE-28271: -- Thanks for pointing that out [~dmanning], yes it is actually worse than what i thought earlier. > Infinite waiting on lock acquisition by snapshot can result in unresponsive > master > -- > > Key: HBASE-28271 > URL: https://issues.apache.org/jira/browse/HBASE-28271 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0-alpha-4, 2.4.17, 2.5.7 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Attachments: image.png > > > When a region is stuck in transition for significant time, any attempt to > take snapshot on the table would keep master handler thread in forever > waiting state. As part of the creating snapshot on enabled or disabled table, > in order to get the table level lock, LockProcedure is executed but if any > region of the table is in transition, LockProcedure could not be executed by > the snapshot handler, resulting in forever waiting until the region > transition is completed, allowing the table level lock to be acquired by the > snapshot handler. > In cases where a region stays in RIT for considerable time, if enough > attempts are made by the client to create snapshots on the table, it can > easily exhaust all handler threads, leading to potentially unresponsive > master. Attached a sample thread dump. > Proposal: The snapshot handler should not stay stuck forever if it cannot > take table level lock, it should fail-fast. > !image.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28271) Infinite waiting on lock acquisition by snapshot can result in unresponsive master
[ https://issues.apache.org/jira/browse/HBASE-28271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-28271: - Fix Version/s: 2.6.0 2.4.18 2.5.8 3.0.0-beta-2 Status: Patch Available (was: In Progress) > Infinite waiting on lock acquisition by snapshot can result in unresponsive > master > -- > > Key: HBASE-28271 > URL: https://issues.apache.org/jira/browse/HBASE-28271 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.5.7, 2.4.17, 3.0.0-alpha-4 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 2.6.0, 2.4.18, 2.5.8, 3.0.0-beta-2 > > Attachments: image.png > > > When a region is stuck in transition for significant time, any attempt to > take snapshot on the table would keep master handler thread in forever > waiting state. As part of the creating snapshot on enabled or disabled table, > in order to get the table level lock, LockProcedure is executed but if any > region of the table is in transition, LockProcedure could not be executed by > the snapshot handler, resulting in forever waiting until the region > transition is completed, allowing the table level lock to be acquired by the > snapshot handler. > In cases where a region stays in RIT for considerable time, if enough > attempts are made by the client to create snapshots on the table, it can > easily exhaust all handler threads, leading to potentially unresponsive > master. Attached a sample thread dump. > Proposal: The snapshot handler should not stay stuck forever if it cannot > take table level lock, it should fail-fast. > !image.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (HBASE-28271) Infinite waiting on lock acquisition by snapshot can result in unresponsive master
[ https://issues.apache.org/jira/browse/HBASE-28271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-28271 started by Viraj Jasani. > Infinite waiting on lock acquisition by snapshot can result in unresponsive > master > -- > > Key: HBASE-28271 > URL: https://issues.apache.org/jira/browse/HBASE-28271 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0-alpha-4, 2.4.17, 2.5.7 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Attachments: image.png > > > When a region is stuck in transition for significant time, any attempt to > take snapshot on the table would keep master handler thread in forever > waiting state. As part of the creating snapshot on enabled or disabled table, > in order to get the table level lock, LockProcedure is executed but if any > region of the table is in transition, LockProcedure could not be executed by > the snapshot handler, resulting in forever waiting until the region > transition is completed, allowing the table level lock to be acquired by the > snapshot handler. > In cases where a region stays in RIT for considerable time, if enough > attempts are made by the client to create snapshots on the table, it can > easily exhaust all handler threads, leading to potentially unresponsive > master. Attached a sample thread dump. > Proposal: The snapshot handler should not stay stuck forever if it cannot > take table level lock, it should fail-fast. > !image.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28271 Infinite waiting on lock acquisition by snapshot can result in unresponsive master [hbase]
Apache-HBase commented on PR #5603: URL: https://github.com/apache/hbase/pull/5603#issuecomment-1876129373 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 9s | master passed | | +1 :green_heart: | compile | 2m 36s | master passed | | +1 :green_heart: | checkstyle | 0m 36s | master passed | | +1 :green_heart: | spotless | 0m 44s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 36s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 51s | the patch passed | | +1 :green_heart: | compile | 2m 32s | the patch passed | | +1 :green_heart: | javac | 2m 32s | the patch passed | | -0 :warning: | checkstyle | 0m 36s | hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 10m 51s | Patch does not cause any errors with Hadoop 3.2.4 3.3.6. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 35m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5603 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 35b0e6acd567 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4a545581ca | | Default Java | Eclipse Adoptium-11.0.17+8 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28271 Infinite waiting on lock acquisition by snapshot can result in unresponsive master [hbase]
Apache-HBase commented on PR #5603: URL: https://github.com/apache/hbase/pull/5603#issuecomment-1876263089 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 18s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 35s | master passed | | +1 :green_heart: | compile | 0m 35s | master passed | | +1 :green_heart: | shadedjars | 5m 9s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 14s | the patch passed | | +1 :green_heart: | compile | 0m 36s | the patch passed | | +1 :green_heart: | javac | 0m 36s | the patch passed | | +1 :green_heart: | shadedjars | 5m 1s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 225m 27s | hbase-server in the patch passed. | | | | 248m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5603 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 34f43e68bc60 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4a545581ca | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/1/testReport/ | | Max. process+thread count | 4873 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28249) Bump jruby to 9.3.13.0 and related joni and jcodings to 2.2.1 and 1.0.58 respectively
[
https://issues.apache.org/jira/browse/HBASE-28249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802438#comment-17802438
]
Hudson commented on HBASE-28249:
Results for branch branch-2
[build #953 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/953/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/953/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/953/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/953/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/953/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Bump jruby to 9.3.13.0 and related joni and jcodings to 2.2.1 and 1.0.58
> respectively
> -
>
> Key: HBASE-28249
> URL: https://issues.apache.org/jira/browse/HBASE-28249
> Project: HBase
> Issue Type: Task
> Components: jruby, security, shell
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 2.6.0, 3.0.0-beta-2
>
>
> Given branch-2 including branch-2.6 is already on 9.3.9.0, we should bump to
> at least 9.3.13.0. This will fix the bundled *org.bouncycastle :
> bcprov-jdk18on : 1.71* having
> [CVE-2023-33201|https://nvd.nist.gov/vuln/detail/CVE-2023-33201] from our
> classpath for the least.
> As a follow up can try to bump to latest 9.4.x line. Otherwise I can try to
> work directly on HBASE-28250 as well, although this may not be straight
> forward and would require some good testing.
> Please let me know what others think.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
