[jira] [Commented] (HIVE-22583) LLAP cache always misses with non-vectorized serde readers such as OpenCSV

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990385#comment-16990385
 ] 

Hive QA commented on HIVE-22583:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987578/HIVE-22583.0.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19788/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19788/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19788/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Tests exited with: Exception: Patch URL 
https://issues.apache.org/jira/secure/attachment/12987578/HIVE-22583.0.patch 
was found in seen patch url's cache and a test was probably run already on it. 
Aborting...
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12987578 - PreCommit-HIVE-Build

> LLAP cache always misses with non-vectorized serde readers such as OpenCSV
> --
>
> Key: HIVE-22583
> URL: https://issues.apache.org/jira/browse/HIVE-22583
> Project: Hive
>  Issue Type: Bug
>  Components: llap
>Reporter: Ádám Szita
>Assignee: Ádám Szita
>Priority: Major
> Attachments: HIVE-22583.0.patch
>
>
> Although after the first read LLAP cache stores data of tables that are not 
> using the LazySimple serde, the stored data is then never used in the future 
> subsequent queries, causing a full cache miss and re-read each time.
> Problem is rooted in SerdeEncodedDataReader#cacheFileData is not taking care 
> of creating an entry for the root/struct column of the table. The only cases 
> this is taken care of are when a vectorized reader is used _(e.g. 
> LazySimpleSerde's LazySimpleDeserializeRead)_, where 
> SerdeEncodedDataReader#processAsyncCacheData takes care of this.
> This can be reproduced by either using a custom serde, like OpenCSV or using 
> LazySimpleSerde, but turning off _hive.llap.io.encode.vector.serde.enabled_.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22553) Expose locks and transactions in sys db

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990384#comment-16990384
 ] 

Hive QA commented on HIVE-22553:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987736/HIVE-22553.5.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17760 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query19]
 (batchId=301)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19787/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19787/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19787/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12987736 - PreCommit-HIVE-Build

> Expose locks and transactions in sys db
> ---
>
> Key: HIVE-22553
> URL: https://issues.apache.org/jira/browse/HIVE-22553
> Project: Hive
>  Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Zoltan Chovan
>Assignee: Zoltan Chovan
>Priority: Major
> Attachments: HIVE-22553.2.patch, HIVE-22553.3.patch, 
> HIVE-22553.3.patch, HIVE-22553.4.patch, HIVE-22553.5.patch, HIVE-22553.patch
>
>
> Create new sysdb tables/views to access lock and transaction data.
> This allows to provide admins with live data about ongoing locks and 
> transacions. Due to this being in the sys db access to this information can 
> be restricted to select privileged users.
> Information about locks and compactions can be joined and accessed at the 
> same time.
> Compaction related transactions would also be visible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22553) Expose locks and transactions in sys db

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990368#comment-16990368
 ] 

Hive QA commented on HIVE-22553:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
44s{color} | {color:blue} Maven dependency ordering for branch {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
26s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
11s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  2m 55s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19787/dev-support/hive-personality.sh
 |
| git revision | master / e6ef282 |
| modules | C: metastore ql U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19787/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Expose locks and transactions in sys db
> ---
>
> Key: HIVE-22553
> URL: https://issues.apache.org/jira/browse/HIVE-22553
> Project: Hive
>  Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Zoltan Chovan
>Assignee: Zoltan Chovan
>Priority: Major
> Attachments: HIVE-22553.2.patch, HIVE-22553.3.patch, 
> HIVE-22553.3.patch, HIVE-22553.4.patch, HIVE-22553.5.patch, HIVE-22553.patch
>
>
> Create new sysdb tables/views to access lock and transaction data.
> This allows to provide admins with live data about ongoing locks and 
> transacions. Due to this being in the sys db access to this information can 
> be restricted to select privileged users.
> Information about locks and compactions can be joined and accessed at the 
> same time.
> Compaction related transactions would also be visible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-20972) Enable TestMiniLlapLocalCliDriver cbo_limit and cbo_rp_limit

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-20972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990360#comment-16990360
 ] 

Hive QA commented on HIVE-20972:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987689/HIVE-20972.03.patch

{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17762 tests 
executed
*Failed tests:*
{noformat}
org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=285)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19786/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19786/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19786/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12987689 - PreCommit-HIVE-Build

> Enable TestMiniLlapLocalCliDriver cbo_limit and cbo_rp_limit
> 
>
> Key: HIVE-20972
> URL: https://issues.apache.org/jira/browse/HIVE-20972
> Project: Hive
>  Issue Type: Test
>Reporter: Vihang Karajgaonkar
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-20972.01.patch, HIVE-20972.02.patch, 
> HIVE-20972.02.patch, HIVE-20972.03.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-20972) Enable TestMiniLlapLocalCliDriver cbo_limit and cbo_rp_limit

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-20972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990339#comment-16990339
 ] 

Hive QA commented on HIVE-20972:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
59s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
52s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 
11s{color} | {color:blue} ql in master has 1532 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
48s{color} | {color:blue} itests/util in master has 53 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
26s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
 0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m  
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 31m  8s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19786/dev-support/hive-personality.sh
 |
| git revision | master / e6ef282 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql itests/util U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19786/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Enable TestMiniLlapLocalCliDriver cbo_limit and cbo_rp_limit
> 
>
> Key: HIVE-20972
> URL: https://issues.apache.org/jira/browse/HIVE-20972
> Project: Hive
>  Issue Type: Test
>Reporter: Vihang Karajgaonkar
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-20972.01.patch, HIVE-20972.02.patch, 
> HIVE-20972.02.patch, HIVE-20972.03.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22578) CBO genOPTree is not failsafe for CTAS and VIEW statements

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990321#comment-16990321
 ] 

Hive QA commented on HIVE-22578:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987684/HIVE-22578.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17760 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19785/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19785/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19785/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12987684 - PreCommit-HIVE-Build

> CBO genOPTree is not failsafe for CTAS and VIEW statements
> --
>
> Key: HIVE-22578
> URL: https://issues.apache.org/jira/browse/HIVE-22578
> Project: Hive
>  Issue Type: Bug
>  Components: CBO
>Affects Versions: 3.0.0, 3.1.2
>Reporter: Aron Hamvas
>Assignee: Aron Hamvas
>Priority: Major
> Fix For: 3.0.1, 3.1.3
>
> Attachments: HIVE-22578.2.patch, HIVE-22578.patch
>
>
> If CBO fails during OT generation, it is supposed to skip CBO and fall back 
> to SemanticAnalyzer generating the OT for the original AST. However, for CTAS 
> and VIEW statements, the original AST is discarded and replaced with the new 
> AST. 
> If OT generation for the new AST fails with a SemanticException, the 
> compilation is destined to fail completely since we cannot fall back to the 
> original and possibly valid AST.
> Also, the SemanticException sometimes gets hidden and misjudged as a missing 
> column statistics issue due to bad error handling.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22578) CBO genOPTree is not failsafe for CTAS and VIEW statements

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990306#comment-16990306
 ] 

Hive QA commented on HIVE-22578:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
 0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
45s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 
14s{color} | {color:blue} ql in master has 1532 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
4s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 
22s{color} | {color:red} ql generated 1 new + 1531 unchanged - 1 fixed = 1532 
total (was 1532) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 41s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.hive.ql.parse.CalcitePlanner.genOPTree(SemanticAnalyzer$PlannerContext)
  At CalcitePlanner.java:is not thrown in 
org.apache.hadoop.hive.ql.parse.CalcitePlanner.genOPTree(SemanticAnalyzer$PlannerContext)
  At CalcitePlanner.java:[line 565] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19785/dev-support/hive-personality.sh
 |
| git revision | master / e6ef282 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19785/yetus/new-findbugs-ql.html
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19785/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> CBO genOPTree is not failsafe for CTAS and VIEW statements
> --
>
> Key: HIVE-22578
> URL: https://issues.apache.org/jira/browse/HIVE-22578
> Project: Hive
>  Issue Type: Bug
>  Components: CBO
>Affects Versions: 3.0.0, 3.1.2
>Reporter: Aron Hamvas
>Assignee: Aron Hamvas
>Priority: Major
> Fix For: 3.0.1, 3.1.3
>
> Attachments: HIVE-22578.2.patch, HIVE-22578.patch
>
>
> If CBO fails during OT generation, it is supposed to skip CBO and fall back 
> to SemanticAnalyzer generating the OT for the original AST. However, for CTAS 
> and VIEW statements, the original AST is discarded and replaced with the new 
> AST. 
> If OT generation for the new AST fails with a SemanticException, the 
> compilation is destined to fail completely since we cannot fall back to the 
> original and possibly valid AST.
> Also, the SemanticException sometimes gets hidden and misjudged as a missing 
> column statistics issue due to bad error handling.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22547) Review txn compactor Package

2019-12-06 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-22547:
--
Attachment: (was: HIVE-22547.2.patch)

> Review txn compactor Package
> 
>
> Key: HIVE-22547
> URL: https://issues.apache.org/jira/browse/HIVE-22547
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-22547.1.patch, HIVE-22547.2.patch, 
> HIVE-22547.3.patch
>
>
> * Remove log-and-throw anti-pattern
> * Use parameterized logging
> * Add a CompactionException class to improve debug-ability
> * Introduce Java Optional utility
> * Other clean up



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22547) Review txn compactor Package

2019-12-06 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-22547:
--
Attachment: HIVE-22547.3.patch

> Review txn compactor Package
> 
>
> Key: HIVE-22547
> URL: https://issues.apache.org/jira/browse/HIVE-22547
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-22547.1.patch, HIVE-22547.2.patch, 
> HIVE-22547.3.patch
>
>
> * Remove log-and-throw anti-pattern
> * Use parameterized logging
> * Add a CompactionException class to improve debug-ability
> * Introduce Java Optional utility
> * Other clean up



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22547) Review txn compactor Package

2019-12-06 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-22547:
--
Attachment: HIVE-22547.3.patch

> Review txn compactor Package
> 
>
> Key: HIVE-22547
> URL: https://issues.apache.org/jira/browse/HIVE-22547
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-22547.1.patch, HIVE-22547.2.patch, 
> HIVE-22547.3.patch
>
>
> * Remove log-and-throw anti-pattern
> * Use parameterized logging
> * Add a CompactionException class to improve debug-ability
> * Introduce Java Optional utility
> * Other clean up



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22547) Review txn compactor Package

2019-12-06 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-22547:
--
Attachment: (was: HIVE-22547.3.patch)

> Review txn compactor Package
> 
>
> Key: HIVE-22547
> URL: https://issues.apache.org/jira/browse/HIVE-22547
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-22547.1.patch, HIVE-22547.2.patch, 
> HIVE-22547.3.patch
>
>
> * Remove log-and-throw anti-pattern
> * Use parameterized logging
> * Add a CompactionException class to improve debug-ability
> * Introduce Java Optional utility
> * Other clean up



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22491) Use Collections emptyList

2019-12-06 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-22491:
--
Attachment: HIVE-22491.4.patch

> Use Collections emptyList
> -
>
> Key: HIVE-22491
> URL: https://issues.apache.org/jira/browse/HIVE-22491
> Project: Hive
>  Issue Type: Improvement
>Affects Versions: 3.2.0
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-22491.1.patch, HIVE-22491.2.patch, 
> HIVE-22491.3.patch, HIVE-22491.4.patch
>
>
> [https://docs.oracle.com/javase/8/docs/api/?java/util/Collections.html]
> Use Collections#emptyList instead of instantiating empty ArrayLists



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22569) PartitionPruner use Collections Class

2019-12-06 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-22569:
--
Attachment: HIVE-22569.2.patch

> PartitionPruner use Collections Class
> -
>
> Key: HIVE-22569
> URL: https://issues.apache.org/jira/browse/HIVE-22569
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-22569.2.patch, HIVE-22569.2.patch, 
> HIVE.22569.1.patch
>
>
> Make class {{PrunedPartitionList.java}} more immutable.  It kinda is already. 
>  Immutable classes are easier to reason about.
> Use {{Collections.emptyXXX}} in {{PartitionPruner}} to save an object 
> instantiation at runtime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22569) PartitionPruner use Collections Class

2019-12-06 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-22569:
--
Attachment: (was: HIVE-22569.2.patch)

> PartitionPruner use Collections Class
> -
>
> Key: HIVE-22569
> URL: https://issues.apache.org/jira/browse/HIVE-22569
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-22569.2.patch, HIVE.22569.1.patch
>
>
> Make class {{PrunedPartitionList.java}} more immutable.  It kinda is already. 
>  Immutable classes are easier to reason about.
> Use {{Collections.emptyXXX}} in {{PartitionPruner}} to save an object 
> instantiation at runtime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22570) Review of ExprNodeDesc.java

2019-12-06 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-22570:
--
Attachment: (was: HIVE-22570.1.patch)

> Review of ExprNodeDesc.java
> ---
>
> Key: HIVE-22570
> URL: https://issues.apache.org/jira/browse/HIVE-22570
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-22570.1.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22588) Flush the remaining rows for the rest of the grouping sets when switching the vector groupby mode

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990298#comment-16990298
 ] 

Hive QA commented on HIVE-22588:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987796/HIVE-22588.4.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17762 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19783/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19783/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19783/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12987796 - PreCommit-HIVE-Build

> Flush the remaining rows for the rest of the grouping sets when switching the 
> vector groupby mode
> -
>
> Key: HIVE-22588
> URL: https://issues.apache.org/jira/browse/HIVE-22588
> Project: Hive
>  Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Attachments: HIVE-22588.1.patch, HIVE-22588.2.patch, 
> HIVE-22588.3.patch, HIVE-22588.4.patch
>
>
> Flush the remaining rows for the rest of the grouping sets when switching the 
> vector groupby mode



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22588) Flush the remaining rows for the rest of the grouping sets when switching the vector groupby mode

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990299#comment-16990299
 ] 

Hive QA commented on HIVE-22588:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987796/HIVE-22588.4.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19784/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19784/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19784/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Tests exited with: Exception: Patch URL 
https://issues.apache.org/jira/secure/attachment/12987796/HIVE-22588.4.patch 
was found in seen patch url's cache and a test was probably run already on it. 
Aborting...
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12987796 - PreCommit-HIVE-Build

> Flush the remaining rows for the rest of the grouping sets when switching the 
> vector groupby mode
> -
>
> Key: HIVE-22588
> URL: https://issues.apache.org/jira/browse/HIVE-22588
> Project: Hive
>  Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Attachments: HIVE-22588.1.patch, HIVE-22588.2.patch, 
> HIVE-22588.3.patch, HIVE-22588.4.patch
>
>
> Flush the remaining rows for the rest of the grouping sets when switching the 
> vector groupby mode



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22588) Flush the remaining rows for the rest of the grouping sets when switching the vector groupby mode

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990295#comment-16990295
 ] 

Hive QA commented on HIVE-22588:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
54s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  9m  
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m 
 7s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 
49s{color} | {color:blue} ql in master has 1532 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  8m 
13s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
26s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  8m  
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  8m  
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  8m  
0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 69m 26s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19783/dev-support/hive-personality.sh
 |
| git revision | master / e6ef282 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql . itests U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19783/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Flush the remaining rows for the rest of the grouping sets when switching the 
> vector groupby mode
> -
>
> Key: HIVE-22588
> URL: https://issues.apache.org/jira/browse/HIVE-22588
> Project: Hive
>  Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Attachments: HIVE-22588.1.patch, HIVE-22588.2.patch, 
> HIVE-22588.3.patch, HIVE-22588.4.patch
>
>
> Flush the remaining rows for the rest of the grouping sets when switching the 
> vector groupby mode



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22595) Dynamic partition inserts fail on Avro table table with external schema

2019-12-06 Thread Jason Dere (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990284#comment-16990284
 ] 

Jason Dere commented on HIVE-22595:
---

I think this was introduced by HIVE-11972, but I guess we never ran into this 
one until now.
In the case of an external schema we cannot rely on the column list from the 
TableDesc properties to give the correct number of columns.

> Dynamic partition inserts fail on Avro table table with external schema
> ---
>
> Key: HIVE-22595
> URL: https://issues.apache.org/jira/browse/HIVE-22595
> Project: Hive
>  Issue Type: Bug
>  Components: Avro, Serializers/Deserializers
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
>
> Example qfile test:
> {noformat}
> create external table avro_extschema_insert1 (name string) partitioned by (p1 
> string)
>   stored as avro tblproperties 
> ('avro.schema.url'='${system:test.tmp.dir}/table1.avsc');
> create external table avro_extschema_insert2 like avro_extschema_insert1;
> insert overwrite table avro_extschema_insert1 partition (p1='part1') values 
> ('col1_value', 1, 'col3_value');
> insert overwrite table avro_extschema_insert2 partition (p1) select * from 
> avro_extschema_insert1;
> {noformat}
> The last statement fails with the following error:
> {noformat}
> ], TaskAttempt 3 failed, info=[Error: Error while running task ( failure ) : 
> attempt_1575484789169_0003_4_00_00_3:java.lang.RuntimeException: 
> java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: 
> Hive Runtime Error while processing row
>   at 
> org.apache.hadoop.hive.ql.exec.tez.TezProcessor.initializeAndRunProcessor(TezProcessor.java:296)
>   at 
> org.apache.hadoop.hive.ql.exec.tez.TezProcessor.run(TezProcessor.java:250)
>   at 
> org.apache.tez.runtime.LogicalIOProcessorRuntimeTask.run(LogicalIOProcessorRuntimeTask.java:374)
>   at 
> org.apache.tez.runtime.task.TaskRunner2Callable$1.run(TaskRunner2Callable.java:73)
>   at 
> org.apache.tez.runtime.task.TaskRunner2Callable$1.run(TaskRunner2Callable.java:61)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:422)
>   at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730)
>   at 
> org.apache.tez.runtime.task.TaskRunner2Callable.callInternal(TaskRunner2Callable.java:61)
>   at 
> org.apache.tez.runtime.task.TaskRunner2Callable.callInternal(TaskRunner2Callable.java:37)
>   at org.apache.tez.common.CallableWithNdc.call(CallableWithNdc.java:36)
>   at 
> com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
>   at 
> com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:69)
>   at 
> com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.RuntimeException: 
> org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while 
> processing row
>   at 
> org.apache.hadoop.hive.ql.exec.tez.MapRecordSource.processRow(MapRecordSource.java:101)
>   at 
> org.apache.hadoop.hive.ql.exec.tez.MapRecordSource.pushRecord(MapRecordSource.java:76)
>   at 
> org.apache.hadoop.hive.ql.exec.tez.MapRecordProcessor.run(MapRecordProcessor.java:426)
>   at 
> org.apache.hadoop.hive.ql.exec.tez.TezProcessor.initializeAndRunProcessor(TezProcessor.java:267)
>   ... 16 more
> Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime 
> Error while processing row
>   at 
> org.apache.hadoop.hive.ql.exec.MapOperator.process(MapOperator.java:576)
>   at 
> org.apache.hadoop.hive.ql.exec.tez.MapRecordSource.processRow(MapRecordSource.java:92)
>   ... 19 more
> Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: 
> org.apache.hadoop.hive.serde2.avro.AvroSerdeException: Number of input 
> columns was different than output columns (in = 2 vs out = 1
>   at 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator.process(FileSinkOperator.java:1047)
>   at 
> org.apache.hadoop.hive.ql.exec.Operator.baseForward(Operator.java:994)
>   at org.apache.hadoop.hive.ql.exec.Operator.forward(Operator.java:940)
>   at org.apache.hadoop.hive.ql.exec.Operator.forward(Operator.java:927)
>   at 
> org.apache.hadoop.hive.ql.exec.SelectOperator.process(SelectOperator.java:95)
>   at 
> 

[jira] [Assigned] (HIVE-22595) Dynamic partition inserts fail on Avro table table with external schema

2019-12-06 Thread Jason Dere (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Dere reassigned HIVE-22595:
-


> Dynamic partition inserts fail on Avro table table with external schema
> ---
>
> Key: HIVE-22595
> URL: https://issues.apache.org/jira/browse/HIVE-22595
> Project: Hive
>  Issue Type: Bug
>  Components: Avro, Serializers/Deserializers
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
>
> Example qfile test:
> {noformat}
> create external table avro_extschema_insert1 (name string) partitioned by (p1 
> string)
>   stored as avro tblproperties 
> ('avro.schema.url'='${system:test.tmp.dir}/table1.avsc');
> create external table avro_extschema_insert2 like avro_extschema_insert1;
> insert overwrite table avro_extschema_insert1 partition (p1='part1') values 
> ('col1_value', 1, 'col3_value');
> insert overwrite table avro_extschema_insert2 partition (p1) select * from 
> avro_extschema_insert1;
> {noformat}
> The last statement fails with the following error:
> {noformat}
> ], TaskAttempt 3 failed, info=[Error: Error while running task ( failure ) : 
> attempt_1575484789169_0003_4_00_00_3:java.lang.RuntimeException: 
> java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: 
> Hive Runtime Error while processing row
>   at 
> org.apache.hadoop.hive.ql.exec.tez.TezProcessor.initializeAndRunProcessor(TezProcessor.java:296)
>   at 
> org.apache.hadoop.hive.ql.exec.tez.TezProcessor.run(TezProcessor.java:250)
>   at 
> org.apache.tez.runtime.LogicalIOProcessorRuntimeTask.run(LogicalIOProcessorRuntimeTask.java:374)
>   at 
> org.apache.tez.runtime.task.TaskRunner2Callable$1.run(TaskRunner2Callable.java:73)
>   at 
> org.apache.tez.runtime.task.TaskRunner2Callable$1.run(TaskRunner2Callable.java:61)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:422)
>   at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730)
>   at 
> org.apache.tez.runtime.task.TaskRunner2Callable.callInternal(TaskRunner2Callable.java:61)
>   at 
> org.apache.tez.runtime.task.TaskRunner2Callable.callInternal(TaskRunner2Callable.java:37)
>   at org.apache.tez.common.CallableWithNdc.call(CallableWithNdc.java:36)
>   at 
> com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
>   at 
> com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:69)
>   at 
> com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.RuntimeException: 
> org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while 
> processing row
>   at 
> org.apache.hadoop.hive.ql.exec.tez.MapRecordSource.processRow(MapRecordSource.java:101)
>   at 
> org.apache.hadoop.hive.ql.exec.tez.MapRecordSource.pushRecord(MapRecordSource.java:76)
>   at 
> org.apache.hadoop.hive.ql.exec.tez.MapRecordProcessor.run(MapRecordProcessor.java:426)
>   at 
> org.apache.hadoop.hive.ql.exec.tez.TezProcessor.initializeAndRunProcessor(TezProcessor.java:267)
>   ... 16 more
> Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime 
> Error while processing row
>   at 
> org.apache.hadoop.hive.ql.exec.MapOperator.process(MapOperator.java:576)
>   at 
> org.apache.hadoop.hive.ql.exec.tez.MapRecordSource.processRow(MapRecordSource.java:92)
>   ... 19 more
> Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: 
> org.apache.hadoop.hive.serde2.avro.AvroSerdeException: Number of input 
> columns was different than output columns (in = 2 vs out = 1
>   at 
> org.apache.hadoop.hive.ql.exec.FileSinkOperator.process(FileSinkOperator.java:1047)
>   at 
> org.apache.hadoop.hive.ql.exec.Operator.baseForward(Operator.java:994)
>   at org.apache.hadoop.hive.ql.exec.Operator.forward(Operator.java:940)
>   at org.apache.hadoop.hive.ql.exec.Operator.forward(Operator.java:927)
>   at 
> org.apache.hadoop.hive.ql.exec.SelectOperator.process(SelectOperator.java:95)
>   at 
> org.apache.hadoop.hive.ql.exec.Operator.baseForward(Operator.java:994)
>   at org.apache.hadoop.hive.ql.exec.Operator.forward(Operator.java:940)
>   at 
> org.apache.hadoop.hive.ql.exec.TableScanOperator.process(TableScanOperator.java:125)
>   at 
> 

[jira] [Commented] (HIVE-22491) Use Collections emptyList

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990274#comment-16990274
 ] 

Hive QA commented on HIVE-22491:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987645/HIVE-22491.3.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17756 tests 
executed
*Failed tests:*
{noformat}
TestStatsReplicationScenariosACIDNoAutogather - did not produce a TEST-*.xml 
file (likely timed out) (batchId=257)
org.apache.hive.jdbc.TestSSL.testSSLFetch (batchId=285)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19782/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19782/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19782/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12987645 - PreCommit-HIVE-Build

> Use Collections emptyList
> -
>
> Key: HIVE-22491
> URL: https://issues.apache.org/jira/browse/HIVE-22491
> Project: Hive
>  Issue Type: Improvement
>Affects Versions: 3.2.0
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-22491.1.patch, HIVE-22491.2.patch, 
> HIVE-22491.3.patch
>
>
> [https://docs.oracle.com/javase/8/docs/api/?java/util/Collections.html]
> Use Collections#emptyList instead of instantiating empty ArrayLists



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22491) Use Collections emptyList

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990268#comment-16990268
 ] 

Hive QA commented on HIVE-22491:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  2m  
7s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
37s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  2m 
46s{color} | {color:blue} standalone-metastore/metastore-common in master has 
37 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
35s{color} | {color:blue} common in master has 65 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
43s{color} | {color:blue} serde in master has 198 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m 
15s{color} | {color:blue} standalone-metastore/metastore-server in master has 
179 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 
10s{color} | {color:blue} ql in master has 1532 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
31s{color} | {color:blue} hcatalog/webhcat/java-client in master has 3 extant 
Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
40s{color} | {color:blue} hcatalog/webhcat/svr in master has 96 extant Findbugs 
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
25s{color} | {color:blue} kudu-handler in master has 1 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  3m 
38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
29s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  3m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} The patch metastore-common passed checkstyle {color} 
|
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} The patch common passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
15s{color} | {color:green} The patch serde passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
33s{color} | {color:green} standalone-metastore/metastore-server: The patch 
generated 0 new + 1201 unchanged - 1 fixed = 1201 total (was 1202) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
47s{color} | {color:red} ql: The patch generated 1 new + 547 unchanged - 1 
fixed = 548 total (was 548) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} The patch java-client passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} The patch svr passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} The patch kudu-handler passed checkstyle {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 
29s{color} | {color:red} ql generated 3 new + 1532 unchanged - 0 fixed = 1535 
total (was 1532) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | 

[jira] [Assigned] (HIVE-12876) OpenCSV Serde treats everything as strings.

2019-12-06 Thread qingzhongli (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-12876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

qingzhongli reassigned HIVE-12876:
--

Assignee: (was: qingzhongli)

> OpenCSV Serde treats everything as strings.
> ---
>
> Key: HIVE-12876
> URL: https://issues.apache.org/jira/browse/HIVE-12876
> Project: Hive
>  Issue Type: Bug
>  Components: Hive, Serializers/Deserializers
>Affects Versions: 1.2.1
>Reporter: Carter Shanklin
>Priority: Major
> Attachments: HIVE-12876.patch
>
>
> This one caught me by surprise after some wrong results. I'm filing this as 
> Brock suggested in HIVE-. Back to Ctrl-A for me it seems.
> To repro:
> {code}
> drop table int_table;
> create table int_table(
> x int
> )
> ROW FORMAT SERDE 'org.apache.hadoop.hive.serde2.OpenCSVSerde';
> show create table int_table;
> {code}
> And note that x is a string.
> Applicable to Hive 1.2.1.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22486) Send only accessed columns for masking policies request

2019-12-06 Thread Jesus Camacho Rodriguez (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesus Camacho Rodriguez updated HIVE-22486:
---
Attachment: (was: HIVE-22486.addendum.01.patch)

> Send only accessed columns for masking policies request
> ---
>
> Key: HIVE-22486
> URL: https://issues.apache.org/jira/browse/HIVE-22486
> Project: Hive
>  Issue Type: Improvement
>  Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22486.01.patch, HIVE-22486.02.patch, 
> HIVE-22486.03.patch, HIVE-22486.05.patch, HIVE-22486.06.patch, 
> HIVE-22486.addendum.01.patch, HIVE-22486.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently, we send all columns for masking request, even if they are not 
> accessed by the given query. We could send only those columns for which the 
> masking policy will be necessary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22486) Send only accessed columns for masking policies request

2019-12-06 Thread Jesus Camacho Rodriguez (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesus Camacho Rodriguez updated HIVE-22486:
---
Attachment: HIVE-22486.addendum.01.patch

> Send only accessed columns for masking policies request
> ---
>
> Key: HIVE-22486
> URL: https://issues.apache.org/jira/browse/HIVE-22486
> Project: Hive
>  Issue Type: Improvement
>  Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22486.01.patch, HIVE-22486.02.patch, 
> HIVE-22486.03.patch, HIVE-22486.05.patch, HIVE-22486.06.patch, 
> HIVE-22486.addendum.01.patch, HIVE-22486.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently, we send all columns for masking request, even if they are not 
> accessed by the given query. We could send only those columns for which the 
> masking policy will be necessary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HIVE-22556) Unset the credential provider config in the tez jobs configurations

2019-12-06 Thread Ramesh Kumar Thangarajan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ramesh Kumar Thangarajan resolved HIVE-22556.
-
Resolution: Won't Fix

> Unset the credential provider config in the tez jobs configurations
> ---
>
> Key: HIVE-22556
> URL: https://issues.apache.org/jira/browse/HIVE-22556
> Project: Hive
>  Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Attachments: HIVE-22556.1.patch
>
>
> Unset the credential provider config in the tez jobs configurations



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22556) Unset the credential provider config in the tez jobs configurations

2019-12-06 Thread Ramesh Kumar Thangarajan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ramesh Kumar Thangarajan updated HIVE-22556:

Status: Open  (was: Patch Available)

> Unset the credential provider config in the tez jobs configurations
> ---
>
> Key: HIVE-22556
> URL: https://issues.apache.org/jira/browse/HIVE-22556
> Project: Hive
>  Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Attachments: HIVE-22556.1.patch
>
>
> Unset the credential provider config in the tez jobs configurations



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22486) Send only accessed columns for masking policies request

2019-12-06 Thread Jesus Camacho Rodriguez (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesus Camacho Rodriguez updated HIVE-22486:
---
Attachment: HIVE-22486.addendum.01.patch

> Send only accessed columns for masking policies request
> ---
>
> Key: HIVE-22486
> URL: https://issues.apache.org/jira/browse/HIVE-22486
> Project: Hive
>  Issue Type: Improvement
>  Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22486.01.patch, HIVE-22486.02.patch, 
> HIVE-22486.03.patch, HIVE-22486.05.patch, HIVE-22486.06.patch, 
> HIVE-22486.addendum.01.patch, HIVE-22486.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently, we send all columns for masking request, even if they are not 
> accessed by the given query. We could send only those columns for which the 
> masking policy will be necessary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22486) Send only accessed columns for masking policies request

2019-12-06 Thread Jesus Camacho Rodriguez (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesus Camacho Rodriguez updated HIVE-22486:
---
Status: Patch Available  (was: In Progress)

> Send only accessed columns for masking policies request
> ---
>
> Key: HIVE-22486
> URL: https://issues.apache.org/jira/browse/HIVE-22486
> Project: Hive
>  Issue Type: Improvement
>  Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22486.01.patch, HIVE-22486.02.patch, 
> HIVE-22486.03.patch, HIVE-22486.05.patch, HIVE-22486.06.patch, 
> HIVE-22486.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently, we send all columns for masking request, even if they are not 
> accessed by the given query. We could send only those columns for which the 
> masking policy will be necessary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work started] (HIVE-22486) Send only accessed columns for masking policies request

2019-12-06 Thread Jesus Camacho Rodriguez (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HIVE-22486 started by Jesus Camacho Rodriguez.
--
> Send only accessed columns for masking policies request
> ---
>
> Key: HIVE-22486
> URL: https://issues.apache.org/jira/browse/HIVE-22486
> Project: Hive
>  Issue Type: Improvement
>  Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22486.01.patch, HIVE-22486.02.patch, 
> HIVE-22486.03.patch, HIVE-22486.05.patch, HIVE-22486.06.patch, 
> HIVE-22486.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently, we send all columns for masking request, even if they are not 
> accessed by the given query. We could send only those columns for which the 
> masking policy will be necessary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (HIVE-22486) Send only accessed columns for masking policies request

2019-12-06 Thread Jesus Camacho Rodriguez (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesus Camacho Rodriguez reopened HIVE-22486:


> Send only accessed columns for masking policies request
> ---
>
> Key: HIVE-22486
> URL: https://issues.apache.org/jira/browse/HIVE-22486
> Project: Hive
>  Issue Type: Improvement
>  Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22486.01.patch, HIVE-22486.02.patch, 
> HIVE-22486.03.patch, HIVE-22486.05.patch, HIVE-22486.06.patch, 
> HIVE-22486.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently, we send all columns for masking request, even if they are not 
> accessed by the given query. We could send only those columns for which the 
> masking policy will be necessary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22594) Reorder metastore thrift structures

2019-12-06 Thread John Sherman (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Sherman updated HIVE-22594:

Status: Patch Available  (was: Open)

> Reorder metastore thrift structures
> ---
>
> Key: HIVE-22594
> URL: https://issues.apache.org/jira/browse/HIVE-22594
> Project: Hive
>  Issue Type: Improvement
>  Components: Standalone Metastore, Thrift API
>Affects Versions: 4.0.0
>Reporter: John Sherman
>Assignee: John Sherman
>Priority: Major
> Attachments: HIVE-22594.1.patch
>
>
> Currently hive_metastore.thrift C++ output does not compile due to structures 
> like ScheduledQueryKey and ColumnStatistics being referenced before being 
> defined later in the file. We should reorder the structures in the file so 
> the C++ output is usable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22573) HMS filter metadata using Ranger plugin

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990242#comment-16990242
 ] 

Hive QA commented on HIVE-22573:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987644/HIVE-22573.4.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17764 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19781/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19781/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19781/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12987644 - PreCommit-HIVE-Build

> HMS filter metadata using Ranger plugin
> ---
>
> Key: HIVE-22573
> URL: https://issues.apache.org/jira/browse/HIVE-22573
> Project: Hive
>  Issue Type: New Feature
>  Components: Standalone Metastore
>Affects Versions: 4.0.0
>Reporter: Sam An
>Assignee: Ramesh Mani
>Priority: Major
> Attachments: HIVE-22573.2.patch, HIVE-22573.3.patch, 
> HIVE-22573.4.patch, HIVE-22573.5.patch, HIVE-22573.patch
>
>
> HMS needs to filter out rows based on Ranger plugin. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22588) Flush the remaining rows for the rest of the grouping sets when switching the vector groupby mode

2019-12-06 Thread Ramesh Kumar Thangarajan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ramesh Kumar Thangarajan updated HIVE-22588:

Attachment: HIVE-22588.4.patch
Status: Patch Available  (was: Open)

> Flush the remaining rows for the rest of the grouping sets when switching the 
> vector groupby mode
> -
>
> Key: HIVE-22588
> URL: https://issues.apache.org/jira/browse/HIVE-22588
> Project: Hive
>  Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Attachments: HIVE-22588.1.patch, HIVE-22588.2.patch, 
> HIVE-22588.3.patch, HIVE-22588.4.patch
>
>
> Flush the remaining rows for the rest of the grouping sets when switching the 
> vector groupby mode



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22588) Flush the remaining rows for the rest of the grouping sets when switching the vector groupby mode

2019-12-06 Thread Ramesh Kumar Thangarajan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ramesh Kumar Thangarajan updated HIVE-22588:

Status: Open  (was: Patch Available)

> Flush the remaining rows for the rest of the grouping sets when switching the 
> vector groupby mode
> -
>
> Key: HIVE-22588
> URL: https://issues.apache.org/jira/browse/HIVE-22588
> Project: Hive
>  Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Attachments: HIVE-22588.1.patch, HIVE-22588.2.patch, 
> HIVE-22588.3.patch
>
>
> Flush the remaining rows for the rest of the grouping sets when switching the 
> vector groupby mode



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22573) HMS filter metadata using Ranger plugin

2019-12-06 Thread Ramesh Mani (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ramesh Mani updated HIVE-22573:
---
Attachment: HIVE-22573.5.patch

> HMS filter metadata using Ranger plugin
> ---
>
> Key: HIVE-22573
> URL: https://issues.apache.org/jira/browse/HIVE-22573
> Project: Hive
>  Issue Type: New Feature
>  Components: Standalone Metastore
>Affects Versions: 4.0.0
>Reporter: Sam An
>Assignee: Ramesh Mani
>Priority: Major
> Attachments: HIVE-22573.2.patch, HIVE-22573.3.patch, 
> HIVE-22573.4.patch, HIVE-22573.5.patch, HIVE-22573.patch
>
>
> HMS needs to filter out rows based on Ranger plugin. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22573) HMS filter metadata using Ranger plugin

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990222#comment-16990222
 ] 

Hive QA commented on HIVE-22573:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
45s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 
16s{color} | {color:blue} ql in master has 1532 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
9s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
41s{color} | {color:red} ql: The patch generated 223 new + 185 unchanged - 3 
fixed = 408 total (was 188) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
7s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 16s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19781/dev-support/hive-personality.sh
 |
| git revision | master / e6ef282 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19781/yetus/diff-checkstyle-ql.txt
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19781/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> HMS filter metadata using Ranger plugin
> ---
>
> Key: HIVE-22573
> URL: https://issues.apache.org/jira/browse/HIVE-22573
> Project: Hive
>  Issue Type: New Feature
>  Components: Standalone Metastore
>Affects Versions: 4.0.0
>Reporter: Sam An
>Assignee: Ramesh Mani
>Priority: Major
> Attachments: HIVE-22573.2.patch, HIVE-22573.3.patch, 
> HIVE-22573.4.patch, HIVE-22573.patch
>
>
> HMS needs to filter out rows based on Ranger plugin. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22594) Reorder metastore thrift structures

2019-12-06 Thread John Sherman (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Sherman updated HIVE-22594:

Attachment: HIVE-22594.1.patch

> Reorder metastore thrift structures
> ---
>
> Key: HIVE-22594
> URL: https://issues.apache.org/jira/browse/HIVE-22594
> Project: Hive
>  Issue Type: Improvement
>  Components: Standalone Metastore, Thrift API
>Affects Versions: 4.0.0
>Reporter: John Sherman
>Assignee: John Sherman
>Priority: Major
> Attachments: HIVE-22594.1.patch
>
>
> Currently hive_metastore.thrift C++ output does not compile due to structures 
> like ScheduledQueryKey and ColumnStatistics being referenced before being 
> defined later in the file. We should reorder the structures in the file so 
> the C++ output is usable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (HIVE-22594) Reorder metastore thrift structures

2019-12-06 Thread John Sherman (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Sherman reassigned HIVE-22594:
---


> Reorder metastore thrift structures
> ---
>
> Key: HIVE-22594
> URL: https://issues.apache.org/jira/browse/HIVE-22594
> Project: Hive
>  Issue Type: Improvement
>  Components: Standalone Metastore, Thrift API
>Affects Versions: 4.0.0
>Reporter: John Sherman
>Assignee: John Sherman
>Priority: Major
>
> Currently hive_metastore.thrift C++ output does not compile due to structures 
> like ScheduledQueryKey and ColumnStatistics being referenced before being 
> defined later in the file. We should reorder the structures in the file so 
> the C++ output is usable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22588) Flush the remaining rows for the rest of the grouping sets when switching the vector groupby mode

2019-12-06 Thread Ramesh Kumar Thangarajan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ramesh Kumar Thangarajan updated HIVE-22588:

Status: Open  (was: Patch Available)

> Flush the remaining rows for the rest of the grouping sets when switching the 
> vector groupby mode
> -
>
> Key: HIVE-22588
> URL: https://issues.apache.org/jira/browse/HIVE-22588
> Project: Hive
>  Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Attachments: HIVE-22588.1.patch, HIVE-22588.2.patch, 
> HIVE-22588.3.patch
>
>
> Flush the remaining rows for the rest of the grouping sets when switching the 
> vector groupby mode



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22588) Flush the remaining rows for the rest of the grouping sets when switching the vector groupby mode

2019-12-06 Thread Ramesh Kumar Thangarajan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ramesh Kumar Thangarajan updated HIVE-22588:

Attachment: HIVE-22588.3.patch
Status: Patch Available  (was: Open)

> Flush the remaining rows for the rest of the grouping sets when switching the 
> vector groupby mode
> -
>
> Key: HIVE-22588
> URL: https://issues.apache.org/jira/browse/HIVE-22588
> Project: Hive
>  Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Attachments: HIVE-22588.1.patch, HIVE-22588.2.patch, 
> HIVE-22588.3.patch
>
>
> Flush the remaining rows for the rest of the grouping sets when switching the 
> vector groupby mode



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22587) hive.stats.ndv.error parameter documentation issue in HiveConf.java

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990205#comment-16990205
 ] 

Hive QA commented on HIVE-22587:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987643/HIVE-22587.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17760 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19780/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19780/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19780/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12987643 - PreCommit-HIVE-Build

> hive.stats.ndv.error parameter documentation issue in HiveConf.java
> ---
>
> Key: HIVE-22587
> URL: https://issues.apache.org/jira/browse/HIVE-22587
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Pablo Junge
>Assignee: Pablo Junge
>Priority: Minor
> Attachments: HIVE-22587.patch
>
>
> hive.stats.ndv.error parameter documentation should specify that it only 
> affects the FM-Sketch algorithm



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22572) NullPointerException when using dynamic semijoin reduction

2019-12-06 Thread Oliver Draese (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Draese updated HIVE-22572:
-
Attachment: HIVE-22572.3.patch

> NullPointerException when using dynamic semijoin reduction
> --
>
> Key: HIVE-22572
> URL: https://issues.apache.org/jira/browse/HIVE-22572
> Project: Hive
>  Issue Type: Bug
>  Components: Query Planning
>Reporter: Oliver Draese
>Assignee: Oliver Draese
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22572.1.patch, HIVE-22572.2.patch, 
> HIVE-22572.3.patch, HIVE-22572.patch
>
>
> From HS2 logs
> Caused by: java.lang.NullPointerException
>  at 
> org.apache.hadoop.hive.ql.parse.TezCompiler.removeSemijoinOptimizationByBenefit(TezCompiler.java:1541)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.TezCompiler.semijoinRemovalBasedTransformations(TezCompiler.java:471)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.TezCompiler.optimizeOperatorPlan(TezCompiler.java:182)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.TaskCompiler.compile(TaskCompiler.java:148) 
> ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:12487)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.CalcitePlanner.analyzeInternal(CalcitePlanner.java:360)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:289)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:664) 
> ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1869) 
> ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22572) NullPointerException when using dynamic semijoin reduction

2019-12-06 Thread Oliver Draese (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990193#comment-16990193
 ] 

Oliver Draese commented on HIVE-22572:
--

Test failures are not related to patch. Re-attached patch to trigger new test 
run.

> NullPointerException when using dynamic semijoin reduction
> --
>
> Key: HIVE-22572
> URL: https://issues.apache.org/jira/browse/HIVE-22572
> Project: Hive
>  Issue Type: Bug
>  Components: Query Planning
>Reporter: Oliver Draese
>Assignee: Oliver Draese
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22572.1.patch, HIVE-22572.2.patch, 
> HIVE-22572.3.patch, HIVE-22572.patch
>
>
> From HS2 logs
> Caused by: java.lang.NullPointerException
>  at 
> org.apache.hadoop.hive.ql.parse.TezCompiler.removeSemijoinOptimizationByBenefit(TezCompiler.java:1541)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.TezCompiler.semijoinRemovalBasedTransformations(TezCompiler.java:471)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.TezCompiler.optimizeOperatorPlan(TezCompiler.java:182)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.TaskCompiler.compile(TaskCompiler.java:148) 
> ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:12487)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.CalcitePlanner.analyzeInternal(CalcitePlanner.java:360)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:289)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:664) 
> ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1869) 
> ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22587) hive.stats.ndv.error parameter documentation issue in HiveConf.java

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990183#comment-16990183
 ] 

Hive QA commented on HIVE-22587:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
 1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
18s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
38s{color} | {color:blue} common in master has 65 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
18s{color} | {color:red} common: The patch generated 2 new + 368 unchanged - 0 
fixed = 370 total (was 368) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m  1s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19780/dev-support/hive-personality.sh
 |
| git revision | master / e6ef282 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19780/yetus/diff-checkstyle-common.txt
 |
| modules | C: common U: common |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19780/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> hive.stats.ndv.error parameter documentation issue in HiveConf.java
> ---
>
> Key: HIVE-22587
> URL: https://issues.apache.org/jira/browse/HIVE-22587
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Pablo Junge
>Assignee: Pablo Junge
>Priority: Minor
> Attachments: HIVE-22587.patch
>
>
> hive.stats.ndv.error parameter documentation should specify that it only 
> affects the FM-Sketch algorithm



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22572) NullPointerException when using dynamic semijoin reduction

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990171#comment-16990171
 ] 

Hive QA commented on HIVE-22572:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987641/HIVE-22572.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17761 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.TestWarehouseExternalDir.org.apache.hadoop.hive.ql.TestWarehouseExternalDir
 (batchId=277)
org.apache.hadoop.hive.ql.TestWarehouseExternalDir.testExternalDefaultPaths 
(batchId=277)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19779/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19779/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19779/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12987641 - PreCommit-HIVE-Build

> NullPointerException when using dynamic semijoin reduction
> --
>
> Key: HIVE-22572
> URL: https://issues.apache.org/jira/browse/HIVE-22572
> Project: Hive
>  Issue Type: Bug
>  Components: Query Planning
>Reporter: Oliver Draese
>Assignee: Oliver Draese
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22572.1.patch, HIVE-22572.2.patch, HIVE-22572.patch
>
>
> From HS2 logs
> Caused by: java.lang.NullPointerException
>  at 
> org.apache.hadoop.hive.ql.parse.TezCompiler.removeSemijoinOptimizationByBenefit(TezCompiler.java:1541)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.TezCompiler.semijoinRemovalBasedTransformations(TezCompiler.java:471)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.TezCompiler.optimizeOperatorPlan(TezCompiler.java:182)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.TaskCompiler.compile(TaskCompiler.java:148) 
> ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:12487)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.CalcitePlanner.analyzeInternal(CalcitePlanner.java:360)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:289)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:664) 
> ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1869) 
> ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22572) NullPointerException when using dynamic semijoin reduction

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990143#comment-16990143
 ] 

Hive QA commented on HIVE-22572:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
40s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 
32s{color} | {color:blue} ql in master has 1532 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
6s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
16s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 29s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19779/dev-support/hive-personality.sh
 |
| git revision | master / e6ef282 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19779/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> NullPointerException when using dynamic semijoin reduction
> --
>
> Key: HIVE-22572
> URL: https://issues.apache.org/jira/browse/HIVE-22572
> Project: Hive
>  Issue Type: Bug
>  Components: Query Planning
>Reporter: Oliver Draese
>Assignee: Oliver Draese
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22572.1.patch, HIVE-22572.2.patch, HIVE-22572.patch
>
>
> From HS2 logs
> Caused by: java.lang.NullPointerException
>  at 
> org.apache.hadoop.hive.ql.parse.TezCompiler.removeSemijoinOptimizationByBenefit(TezCompiler.java:1541)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.TezCompiler.semijoinRemovalBasedTransformations(TezCompiler.java:471)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.TezCompiler.optimizeOperatorPlan(TezCompiler.java:182)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.TaskCompiler.compile(TaskCompiler.java:148) 
> ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:12487)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.CalcitePlanner.analyzeInternal(CalcitePlanner.java:360)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 
> org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:289)
>  ~[hive-exec-3.1.0.3.1.0.142-1.jar:3.1.0.3.1.0.142-1]
>  at 

[jira] [Commented] (HIVE-22577) StringIndexOutOfBoundsException when getting sessionId from worker node name

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990122#comment-16990122
 ] 

Hive QA commented on HIVE-22577:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987631/HIVE-22577.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17760 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.TestMTQueries.testMTQueries1 (batchId=276)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19778/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19778/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19778/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12987631 - PreCommit-HIVE-Build

> StringIndexOutOfBoundsException when getting sessionId from worker node name
> 
>
> Key: HIVE-22577
> URL: https://issues.apache.org/jira/browse/HIVE-22577
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Attila Magyar
>Assignee: Attila Magyar
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22577.1.patch, HIVE-22577.2.patch
>
>
> When the node name is "worker-" the following exception is thrown
>  
> {code:java}
> Caused by: java.lang.StringIndexOutOfBoundsException: String index out of 
> range: -1Caused by: java.lang.StringIndexOutOfBoundsException: String index 
> out of range: -1 at java.lang.String.substring(String.java:1931) at 
> org.apache.hadoop.hive.registry.impl.ZkRegistryBase.extractSeqNum(ZkRegistryBase.java:781)
>  at 
> org.apache.hadoop.hive.registry.impl.ZkRegistryBase.populateCache(ZkRegistryBase.java:507)
>  at 
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.access$000(LlapZookeeperRegistryImpl.java:65)
>  at 
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl$DynamicServiceInstanceSet.(LlapZookeeperRegistryImpl.java:313)
>  at 
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.getInstances(LlapZookeeperRegistryImpl.java:462)
>  at 
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.getApplicationId(LlapZookeeperRegistryImpl.java:469)
>  at 
> org.apache.hadoop.hive.llap.registry.impl.LlapRegistryService.getApplicationId(LlapRegistryService.java:212)
>  at 
> org.apache.hadoop.hive.ql.exec.tez.Utils.getCustomSplitLocationProvider(Utils.java:77)
>  at 
> org.apache.hadoop.hive.ql.exec.tez.Utils.getSplitLocationProvider(Utils.java:53)
>  at 
> org.apache.hadoop.hive.ql.exec.tez.HiveSplitGenerator.(HiveSplitGenerator.java:140)
>   {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22577) StringIndexOutOfBoundsException when getting sessionId from worker node name

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990070#comment-16990070
 ] 

Hive QA commented on HIVE-22577:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
10s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
25s{color} | {color:blue} llap-client in master has 27 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
11s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
10s{color} | {color:red} llap-client: The patch generated 3 new + 40 unchanged 
- 3 fixed = 43 total (was 43) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 52s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19778/dev-support/hive-personality.sh
 |
| git revision | master / e6ef282 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19778/yetus/diff-checkstyle-llap-client.txt
 |
| modules | C: llap-client U: llap-client |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19778/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> StringIndexOutOfBoundsException when getting sessionId from worker node name
> 
>
> Key: HIVE-22577
> URL: https://issues.apache.org/jira/browse/HIVE-22577
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Attila Magyar
>Assignee: Attila Magyar
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22577.1.patch, HIVE-22577.2.patch
>
>
> When the node name is "worker-" the following exception is thrown
>  
> {code:java}
> Caused by: java.lang.StringIndexOutOfBoundsException: String index out of 
> range: -1Caused by: java.lang.StringIndexOutOfBoundsException: String index 
> out of range: -1 at java.lang.String.substring(String.java:1931) at 
> org.apache.hadoop.hive.registry.impl.ZkRegistryBase.extractSeqNum(ZkRegistryBase.java:781)
>  at 
> org.apache.hadoop.hive.registry.impl.ZkRegistryBase.populateCache(ZkRegistryBase.java:507)
>  at 
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.access$000(LlapZookeeperRegistryImpl.java:65)
>  at 
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl$DynamicServiceInstanceSet.(LlapZookeeperRegistryImpl.java:313)
>  at 
> org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.getInstances(LlapZookeeperRegistryImpl.java:462)
>  at 
> 

[jira] [Commented] (HIVE-22569) PartitionPruner use Collections Class

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990052#comment-16990052
 ] 

Hive QA commented on HIVE-22569:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987624/HIVE-22569.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17760 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.metadata.TestHiveRemote.testDropPartitionsWithPurge 
(batchId=336)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19777/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19777/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19777/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12987624 - PreCommit-HIVE-Build

> PartitionPruner use Collections Class
> -
>
> Key: HIVE-22569
> URL: https://issues.apache.org/jira/browse/HIVE-22569
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-22569.2.patch, HIVE-22569.2.patch, 
> HIVE.22569.1.patch
>
>
> Make class {{PrunedPartitionList.java}} more immutable.  It kinda is already. 
>  Immutable classes are easier to reason about.
> Use {{Collections.emptyXXX}} in {{PartitionPruner}} to save an object 
> instantiation at runtime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-21737) Upgrade Avro to version 1.9.1

2019-12-06 Thread David Lavati (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-21737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990031#comment-16990031
 ] 

David Lavati commented on HIVE-21737:
-

[~iemejia] I'm not an expert on the topic, but can give you some more or less 
correct background: Spark already depends on hive, so we can't include it 
simply as a dependency. This is why a specific build of spark is needed for 
integration tests, where hive is left out of the build.

The last spark upgrade was done in HIVE-18436

> Upgrade Avro to version 1.9.1
> -
>
> Key: HIVE-21737
> URL: https://issues.apache.org/jira/browse/HIVE-21737
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Ismaël Mejía
>Assignee: Fokko Driesprong
>Priority: Major
>  Labels: pull-request-available
> Attachments: 0001-HIVE-21737-Bump-Apache-Avro-to-1.9.1.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Avro 1.9.0 was released recently. It brings a lot of fixes including a leaner 
> version of Avro without Jackson in the public API. Worth the update.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (HIVE-21569) Bump guava version to 28.1-jre

2019-12-06 Thread David Lavati (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-21569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Lavati reassigned HIVE-21569:
---

Assignee: (was: David Lavati)

> Bump guava version to 28.1-jre
> --
>
> Key: HIVE-21569
> URL: https://issues.apache.org/jira/browse/HIVE-21569
> Project: Hive
>  Issue Type: Task
>  Components: Hive
>Reporter: Laszlo Pinter
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-21569.01.patch, HIVE-21569.02.patch, 
> HIVE-21569.03.patch, HIVE-21569.04.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Changes required to bump guava to 28.1-jre



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work stopped] (HIVE-21569) Bump guava version to 28.1-jre

2019-12-06 Thread David Lavati (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-21569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HIVE-21569 stopped by David Lavati.
---
> Bump guava version to 28.1-jre
> --
>
> Key: HIVE-21569
> URL: https://issues.apache.org/jira/browse/HIVE-21569
> Project: Hive
>  Issue Type: Task
>  Components: Hive
>Reporter: Laszlo Pinter
>Assignee: David Lavati
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-21569.01.patch, HIVE-21569.02.patch, 
> HIVE-21569.03.patch, HIVE-21569.04.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Changes required to bump guava to 28.1-jre



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-21569) Bump guava version to 28.1-jre

2019-12-06 Thread David Lavati (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-21569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990016#comment-16990016
 ] 

David Lavati commented on HIVE-21569:
-

I've yet to find a good enough way around the fact that anything from guava 16 
has breaking changes compared to spark 2.3's guava 14.

At this point spark itests will always fail. I see the following options (in no 
particular order):
 * wait for a spark version with a newer guava (see SPARK-23897)
 * as mentioned in the above ticket, an option would be to have a spark version 
that shades all dependencies
 * try the same approach with hive itself

> Bump guava version to 28.1-jre
> --
>
> Key: HIVE-21569
> URL: https://issues.apache.org/jira/browse/HIVE-21569
> Project: Hive
>  Issue Type: Task
>  Components: Hive
>Reporter: Laszlo Pinter
>Assignee: David Lavati
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-21569.01.patch, HIVE-21569.02.patch, 
> HIVE-21569.03.patch, HIVE-21569.04.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Changes required to bump guava to 28.1-jre



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22571) Review of ExprNodeFieldDesc Class

2019-12-06 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-22571:
--
Attachment: (was: HIVE-22571.1.patch)

> Review of ExprNodeFieldDesc Class
> -
>
> Key: HIVE-22571
> URL: https://issues.apache.org/jira/browse/HIVE-22571
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-22571.1.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22571) Review of ExprNodeFieldDesc Class

2019-12-06 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-22571:
--
Attachment: (was: HIVE-22571.1.patch)

> Review of ExprNodeFieldDesc Class
> -
>
> Key: HIVE-22571
> URL: https://issues.apache.org/jira/browse/HIVE-22571
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-22571.1.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22571) Review of ExprNodeFieldDesc Class

2019-12-06 Thread David Mollitor (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990008#comment-16990008
 ] 

David Mollitor commented on HIVE-22571:
---

I will fix minor checkstyle on commit

> Review of ExprNodeFieldDesc Class
> -
>
> Key: HIVE-22571
> URL: https://issues.apache.org/jira/browse/HIVE-22571
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-22571.1.patch, HIVE-22571.1.patch, 
> HIVE-22571.1.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22498) Schema tool enhancements to merge catalogs

2019-12-06 Thread Naveen Gangam (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Naveen Gangam updated HIVE-22498:
-
Status: Patch Available  (was: Open)

MySQL does not allow update on a table with a select on the same table. Updated 
the query to use a nested subquery.

> Schema tool enhancements to merge catalogs
> --
>
> Key: HIVE-22498
> URL: https://issues.apache.org/jira/browse/HIVE-22498
> Project: Hive
>  Issue Type: Sub-task
>Affects Versions: 4.0.0
>Reporter: Naveen Gangam
>Assignee: Naveen Gangam
>Priority: Major
> Attachments: HIVE-22498.2.patch, HIVE-22498.patch
>
>
> Schema tool currently supports relocation of database from one catalog to 
> another, one at a time. While having to do this one at a time is painful, it 
> also lacks support for converting them to external tables during migration, 
> in lieu of the changes to the translation layer where a MANAGED table is 
> strictly ACID-only table.
> Hence we also need to convert them to external tables during relocation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22498) Schema tool enhancements to merge catalogs

2019-12-06 Thread Naveen Gangam (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Naveen Gangam updated HIVE-22498:
-
Attachment: HIVE-22498.2.patch

> Schema tool enhancements to merge catalogs
> --
>
> Key: HIVE-22498
> URL: https://issues.apache.org/jira/browse/HIVE-22498
> Project: Hive
>  Issue Type: Sub-task
>Affects Versions: 4.0.0
>Reporter: Naveen Gangam
>Assignee: Naveen Gangam
>Priority: Major
> Attachments: HIVE-22498.2.patch, HIVE-22498.patch
>
>
> Schema tool currently supports relocation of database from one catalog to 
> another, one at a time. While having to do this one at a time is painful, it 
> also lacks support for converting them to external tables during migration, 
> in lieu of the changes to the translation layer where a MANAGED table is 
> strictly ACID-only table.
> Hence we also need to convert them to external tables during relocation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22498) Schema tool enhancements to merge catalogs

2019-12-06 Thread Naveen Gangam (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Naveen Gangam updated HIVE-22498:
-
Status: Open  (was: Patch Available)

> Schema tool enhancements to merge catalogs
> --
>
> Key: HIVE-22498
> URL: https://issues.apache.org/jira/browse/HIVE-22498
> Project: Hive
>  Issue Type: Sub-task
>Affects Versions: 4.0.0
>Reporter: Naveen Gangam
>Assignee: Naveen Gangam
>Priority: Major
> Attachments: HIVE-22498.patch
>
>
> Schema tool currently supports relocation of database from one catalog to 
> another, one at a time. While having to do this one at a time is painful, it 
> also lacks support for converting them to external tables during migration, 
> in lieu of the changes to the translation layer where a MANAGED table is 
> strictly ACID-only table.
> Hence we also need to convert them to external tables during relocation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22569) PartitionPruner use Collections Class

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990002#comment-16990002
 ] 

Hive QA commented on HIVE-22569:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
39s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  
8s{color} | {color:blue} ql in master has 1532 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
2s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 22s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19777/dev-support/hive-personality.sh
 |
| git revision | master / e6ef282 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19777/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> PartitionPruner use Collections Class
> -
>
> Key: HIVE-22569
> URL: https://issues.apache.org/jira/browse/HIVE-22569
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-22569.2.patch, HIVE-22569.2.patch, 
> HIVE.22569.1.patch
>
>
> Make class {{PrunedPartitionList.java}} more immutable.  It kinda is already. 
>  Immutable classes are easier to reason about.
> Use {{Collections.emptyXXX}} in {{PartitionPruner}} to save an object 
> instantiation at runtime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22571) Review of ExprNodeFieldDesc Class

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989965#comment-16989965
 ] 

Hive QA commented on HIVE-22571:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987625/HIVE-22571.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17760 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19776/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19776/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19776/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12987625 - PreCommit-HIVE-Build

> Review of ExprNodeFieldDesc Class
> -
>
> Key: HIVE-22571
> URL: https://issues.apache.org/jira/browse/HIVE-22571
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-22571.1.patch, HIVE-22571.1.patch, 
> HIVE-22571.1.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22593) Dynamically partitioned MM (insert-only ACID) tables don't compact automatically

2019-12-06 Thread Karen Coppage (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Coppage updated HIVE-22593:
-
Summary: Dynamically partitioned MM (insert-only ACID) tables don't compact 
automatically  (was: Dynamically partitioned MM (insert-only ACID) table isn't 
compacting automatically)

> Dynamically partitioned MM (insert-only ACID) tables don't compact 
> automatically
> 
>
> Key: HIVE-22593
> URL: https://issues.apache.org/jira/browse/HIVE-22593
> Project: Hive
>  Issue Type: Bug
>Reporter: Karen Coppage
>Assignee: Karen Coppage
>Priority: Major
>
> Dynamic partitions of MM tables aren't entered into the HMS table 
> TXN_COMPONENTS. On inserting into such tables we see this line in the HMS log:
> {code:java}
> Expected to move at least one record from txn_components to 
> completed_txn_components when committing txn!{code}
> (This is not the case for non-partitioned MM tables.)
> Since the partitions aren't entered into COMPLETED_TXN_COMPONENTS, they 
> aren't considered for automatic compaction.
> Probably the culprit is 
> org.apache.hadoop.hive.ql.metadata.Hive#loadDynamicPartitions which has an 
> isAcid parameter that is always false regarding MM tables, and also because 
> MM tables' "write type" is AcidUtils.Operation.NOT_ACID and not INSERT.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (HIVE-22593) Dynamically partitioned MM (insert-only ACID) table isn't compacting automatically

2019-12-06 Thread Karen Coppage (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Coppage reassigned HIVE-22593:



> Dynamically partitioned MM (insert-only ACID) table isn't compacting 
> automatically
> --
>
> Key: HIVE-22593
> URL: https://issues.apache.org/jira/browse/HIVE-22593
> Project: Hive
>  Issue Type: Bug
>Reporter: Karen Coppage
>Assignee: Karen Coppage
>Priority: Major
>
> Dynamic partitions of MM tables aren't entered into the HMS table 
> TXN_COMPONENTS. On inserting into such tables we see this line in the HMS log:
> {code:java}
> Expected to move at least one record from txn_components to 
> completed_txn_components when committing txn!{code}
> (This is not the case for non-partitioned MM tables.)
> Since the partitions aren't entered into COMPLETED_TXN_COMPONENTS, they 
> aren't considered for automatic compaction.
> Probably the culprit is 
> org.apache.hadoop.hive.ql.metadata.Hive#loadDynamicPartitions which has an 
> isAcid parameter that is always false regarding MM tables, and also because 
> MM tables' "write type" is AcidUtils.Operation.NOT_ACID and not INSERT.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22587) hive.stats.ndv.error parameter documentation issue in HiveConf.java

2019-12-06 Thread Ashutosh Chauhan (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989916#comment-16989916
 ] 

Ashutosh Chauhan commented on HIVE-22587:
-

+1

> hive.stats.ndv.error parameter documentation issue in HiveConf.java
> ---
>
> Key: HIVE-22587
> URL: https://issues.apache.org/jira/browse/HIVE-22587
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Pablo Junge
>Assignee: Pablo Junge
>Priority: Minor
> Attachments: HIVE-22587.patch
>
>
> hive.stats.ndv.error parameter documentation should specify that it only 
> affects the FM-Sketch algorithm



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22355) Beeline should not prompt for hive user and password when authentication is NONE

2019-12-06 Thread Mate Juhasz (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989913#comment-16989913
 ] 

Mate Juhasz commented on HIVE-22355:


Hi [~thejas] and [~ngangam]! Thanks for your thoughts!

I like the idea of picking the current unix username and I guess something 
similar would do the trick:
{noformat}
if ("NONE".equals(auth)) {
  if (username == null) {
username = System.getProperty("user.name");
  }
  props.setProperty(JdbcConnectionParams.AUTH_USER, username);
} else...
{noformat}

The main idea would be to skip prompting, even if we dont specify 
username/password in the url/cli options when we are in an "unsecure" 
environment (without kerberos). Basically when we hit beeline without any 
additional args and its reading the jdbc url from beeline-site.xml

This usually happens during a Sqoop hive-import, where it is a real problem in 
unsecure envs, since they migrated to beeline from hive cli. While there is a 
workaround SQOOP-3423, its uncomfortable for users/requires changes in their 
scripts etc... 

By adding auth=NONE to beeline-site.xml the connection could be smooth but 
unchanged in this case. Please correct me if I am missing something.

Thanks


> Beeline should not prompt for hive user and password when authentication is 
> NONE
> 
>
> Key: HIVE-22355
> URL: https://issues.apache.org/jira/browse/HIVE-22355
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Mate Juhasz
>Assignee: Mate Juhasz
>Priority: Major
> Attachments: HIVE-22355.1.patch, HIVE-22355.2.patch, 
> HIVE-22355.3.patch
>
>
> Beeline - without adding the jdbc url - prompts for username and password in 
> case hive.server2.authentication=NONE, which is possibly pointless and can be 
> misleading for users as any input is accepted.
> In addition, Sqoop has dropped hive cli recently in favor of beeline and if 
> there is no authentication set in Hive, Sqoop fails to connect as the process 
> stops waiting for the user/password input. 
> I think it would be nice to check the auth type "NONE" before reading unused 
> inputs from the console before this point:
> https://github.com/apache/hive/blob/master/beeline/src/java/org/apache/hive/beeline/Commands.java#L1641



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22592) Remove redundant calls to AcidUtils#getAcidState in Worker and CompactorMR

2019-12-06 Thread Karen Coppage (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Coppage updated HIVE-22592:
-
Attachment: HIVE-22592.01.patch
Status: Patch Available  (was: Open)

> Remove redundant calls to AcidUtils#getAcidState in Worker and CompactorMR
> --
>
> Key: HIVE-22592
> URL: https://issues.apache.org/jira/browse/HIVE-22592
> Project: Hive
>  Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Karen Coppage
>Assignee: Karen Coppage
>Priority: Major
> Attachments: HIVE-22592.01.patch
>
>
> AcidUtils#getAcidState is called in the Worker before CompactorMR#run and 
> again inside CompactorMR#run. Since it's costly to call, we can pass the 
> value as an argument to CompactorMR#run.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22571) Review of ExprNodeFieldDesc Class

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989902#comment-16989902
 ] 

Hive QA commented on HIVE-22571:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
41s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 
13s{color} | {color:blue} ql in master has 1532 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
9s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
40s{color} | {color:red} ql: The patch generated 1 new + 0 unchanged - 0 fixed 
= 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 54s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19776/dev-support/hive-personality.sh
 |
| git revision | master / e6ef282 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19776/yetus/diff-checkstyle-ql.txt
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19776/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Review of ExprNodeFieldDesc Class
> -
>
> Key: HIVE-22571
> URL: https://issues.apache.org/jira/browse/HIVE-22571
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-22571.1.patch, HIVE-22571.1.patch, 
> HIVE-22571.1.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (HIVE-22592) Remove redundant calls to AcidUtils#getAcidState in Worker and CompactorMR

2019-12-06 Thread Karen Coppage (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Coppage reassigned HIVE-22592:



> Remove redundant calls to AcidUtils#getAcidState in Worker and CompactorMR
> --
>
> Key: HIVE-22592
> URL: https://issues.apache.org/jira/browse/HIVE-22592
> Project: Hive
>  Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Karen Coppage
>Assignee: Karen Coppage
>Priority: Major
>
> AcidUtils#getAcidState is called in the Worker before CompactorMR#run and 
> again inside CompactorMR#run. Since it's costly to call, we can pass the 
> value as an argument to CompactorMR#run.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22568) Process compaction candidates in parallel by the Initiator

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989864#comment-16989864
 ] 

Hive QA commented on HIVE-22568:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987723/HIVE-22568.2.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17761 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19775/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19775/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19775/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12987723 - PreCommit-HIVE-Build

> Process compaction candidates in parallel by the Initiator
> --
>
> Key: HIVE-22568
> URL: https://issues.apache.org/jira/browse/HIVE-22568
> Project: Hive
>  Issue Type: Improvement
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22568.1.patch, HIVE-22568.2.patch
>
>
> `checkForCompaction` includes many file metadata checks and may be expensive. 
> Therefore, make sense using a thread pool here and running 
> `checkForCompactions` in parallel.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22553) Expose locks and transactions in sys db

2019-12-06 Thread Zoltan Chovan (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989819#comment-16989819
 ] 

Zoltan Chovan commented on HIVE-22553:
--

[~pvary] sure, it always sneaks in :)

> Expose locks and transactions in sys db
> ---
>
> Key: HIVE-22553
> URL: https://issues.apache.org/jira/browse/HIVE-22553
> Project: Hive
>  Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Zoltan Chovan
>Assignee: Zoltan Chovan
>Priority: Major
> Attachments: HIVE-22553.2.patch, HIVE-22553.3.patch, 
> HIVE-22553.3.patch, HIVE-22553.4.patch, HIVE-22553.5.patch, HIVE-22553.patch
>
>
> Create new sysdb tables/views to access lock and transaction data.
> This allows to provide admins with live data about ongoing locks and 
> transacions. Due to this being in the sys db access to this information can 
> be restricted to select privileged users.
> Information about locks and compactions can be joined and accessed at the 
> same time.
> Compaction related transactions would also be visible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22553) Expose locks and transactions in sys db

2019-12-06 Thread Zoltan Chovan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zoltan Chovan updated HIVE-22553:
-
Attachment: HIVE-22553.5.patch

> Expose locks and transactions in sys db
> ---
>
> Key: HIVE-22553
> URL: https://issues.apache.org/jira/browse/HIVE-22553
> Project: Hive
>  Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Zoltan Chovan
>Assignee: Zoltan Chovan
>Priority: Major
> Attachments: HIVE-22553.2.patch, HIVE-22553.3.patch, 
> HIVE-22553.3.patch, HIVE-22553.4.patch, HIVE-22553.5.patch, HIVE-22553.patch
>
>
> Create new sysdb tables/views to access lock and transaction data.
> This allows to provide admins with live data about ongoing locks and 
> transacions. Due to this being in the sys db access to this information can 
> be restricted to select privileged users.
> Information about locks and compactions can be joined and accessed at the 
> same time.
> Compaction related transactions would also be visible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22568) Process compaction candidates in parallel by the Initiator

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989805#comment-16989805
 ] 

Hive QA commented on HIVE-22568:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
43s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
 7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
59s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
36s{color} | {color:blue} common in master has 65 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 
19s{color} | {color:blue} ql in master has 1532 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
29s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
26s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
43s{color} | {color:red} ql: The patch generated 1 new + 17 unchanged - 5 fixed 
= 18 total (was 22) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 30m 58s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19775/dev-support/hive-personality.sh
 |
| git revision | master / e6ef282 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19775/yetus/diff-checkstyle-ql.txt
 |
| modules | C: common ql U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19775/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Process compaction candidates in parallel by the Initiator
> --
>
> Key: HIVE-22568
> URL: https://issues.apache.org/jira/browse/HIVE-22568
> Project: Hive
>  Issue Type: Improvement
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22568.1.patch, HIVE-22568.2.patch
>
>
> `checkForCompaction` includes many file metadata checks and may be expensive. 
> Therefore, make sense using a thread pool here and running 
> `checkForCompactions` in parallel.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (HIVE-22553) Expose locks and transactions in sys db

2019-12-06 Thread Peter Vary (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989783#comment-16989783
 ] 

Peter Vary edited comment on HIVE-22553 at 12/6/19 1:56 PM:


[~zchovan]: Could you please remove hive-site.xml changes from the patch? :)
Otherwise looks good to me +1


was (Author: pvary):
[~zchovan]: Could you please remove hive-site.xml changes from the commit? :)
Otherwise looks good to me +1

> Expose locks and transactions in sys db
> ---
>
> Key: HIVE-22553
> URL: https://issues.apache.org/jira/browse/HIVE-22553
> Project: Hive
>  Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Zoltan Chovan
>Assignee: Zoltan Chovan
>Priority: Major
> Attachments: HIVE-22553.2.patch, HIVE-22553.3.patch, 
> HIVE-22553.3.patch, HIVE-22553.4.patch, HIVE-22553.patch
>
>
> Create new sysdb tables/views to access lock and transaction data.
> This allows to provide admins with live data about ongoing locks and 
> transacions. Due to this being in the sys db access to this information can 
> be restricted to select privileged users.
> Information about locks and compactions can be joined and accessed at the 
> same time.
> Compaction related transactions would also be visible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22553) Expose locks and transactions in sys db

2019-12-06 Thread Peter Vary (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989783#comment-16989783
 ] 

Peter Vary commented on HIVE-22553:
---

[~zchovan]: Could you please remove hive-site.xml changes from the commit? :)
Otherwise looks good to me +1

> Expose locks and transactions in sys db
> ---
>
> Key: HIVE-22553
> URL: https://issues.apache.org/jira/browse/HIVE-22553
> Project: Hive
>  Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Zoltan Chovan
>Assignee: Zoltan Chovan
>Priority: Major
> Attachments: HIVE-22553.2.patch, HIVE-22553.3.patch, 
> HIVE-22553.3.patch, HIVE-22553.4.patch, HIVE-22553.patch
>
>
> Create new sysdb tables/views to access lock and transaction data.
> This allows to provide admins with live data about ongoing locks and 
> transacions. Due to this being in the sys db access to this information can 
> be restricted to select privileged users.
> Information about locks and compactions can be joined and accessed at the 
> same time.
> Compaction related transactions would also be visible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-16690) Configure Tez cartesian product edge based on LLAP cluster size

2019-12-06 Thread Jira


 [ 
https://issues.apache.org/jira/browse/HIVE-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

László Bodor updated HIVE-16690:

Attachment: HIVE-16690.2.patch

> Configure Tez cartesian product edge based on LLAP cluster size
> ---
>
> Key: HIVE-16690
> URL: https://issues.apache.org/jira/browse/HIVE-16690
> Project: Hive
>  Issue Type: Bug
>Reporter: Zhiyuan Yang
>Assignee: László Bodor
>Priority: Major
> Attachments: HIVE-16690.1.patch, HIVE-16690.2.patch, 
> HIVE-16690.2.patch, HIVE-16690.2.patch, HIVE-16690.2.patch, 
> HIVE-16690.2.patch, HIVE-16690.2.patch, HIVE-16690.2.patch, 
> HIVE-16690.2.patch, HIVE-16690.addendum.patch
>
>
> In HIVE-14731 we are using default value for target parallelism of fair 
> cartesian product edge. Ideally this should be set according to cluster size. 
> In case of LLAP it's pretty easy to get cluster size, i.e., number of 
> executors.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22553) Expose locks and transactions in sys db

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989769#comment-16989769
 ] 

Hive QA commented on HIVE-22553:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987691/HIVE-22553.4.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17760 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19774/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19774/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19774/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12987691 - PreCommit-HIVE-Build

> Expose locks and transactions in sys db
> ---
>
> Key: HIVE-22553
> URL: https://issues.apache.org/jira/browse/HIVE-22553
> Project: Hive
>  Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Zoltan Chovan
>Assignee: Zoltan Chovan
>Priority: Major
> Attachments: HIVE-22553.2.patch, HIVE-22553.3.patch, 
> HIVE-22553.3.patch, HIVE-22553.4.patch, HIVE-22553.patch
>
>
> Create new sysdb tables/views to access lock and transaction data.
> This allows to provide admins with live data about ongoing locks and 
> transacions. Due to this being in the sys db access to this information can 
> be restricted to select privileged users.
> Information about locks and compactions can be joined and accessed at the 
> same time.
> Compaction related transactions would also be visible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22327) Repl: Ignore read-only transactions in notification log

2019-12-06 Thread Denys Kuzmenko (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989763#comment-16989763
 ] 

Denys Kuzmenko commented on HIVE-22327:
---

[~pvary], submitted new patch with added query logging under debug

> Repl: Ignore read-only transactions in notification log
> ---
>
> Key: HIVE-22327
> URL: https://issues.apache.org/jira/browse/HIVE-22327
> Project: Hive
>  Issue Type: Improvement
>  Components: repl
>Reporter: Gopal Vijayaraghavan
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22327.1.patch, HIVE-22327.10.patch, 
> HIVE-22327.11.patch, HIVE-22327.12.patch, HIVE-22327.13.patch, 
> HIVE-22327.14.patch, HIVE-22327.15.patch, HIVE-22327.16.patch, 
> HIVE-22327.2.patch, HIVE-22327.3.patch, HIVE-22327.4.patch, 
> HIVE-22327.5.patch, HIVE-22327.6.patch, HIVE-22327.7.patch, 
> HIVE-22327.8.patch, HIVE-22327.9.patch
>
>
> Read txns need not be replicated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22327) Repl: Ignore read-only transactions in notification log

2019-12-06 Thread Denys Kuzmenko (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Denys Kuzmenko updated HIVE-22327:
--
Attachment: HIVE-22327.16.patch

> Repl: Ignore read-only transactions in notification log
> ---
>
> Key: HIVE-22327
> URL: https://issues.apache.org/jira/browse/HIVE-22327
> Project: Hive
>  Issue Type: Improvement
>  Components: repl
>Reporter: Gopal Vijayaraghavan
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22327.1.patch, HIVE-22327.10.patch, 
> HIVE-22327.11.patch, HIVE-22327.12.patch, HIVE-22327.13.patch, 
> HIVE-22327.14.patch, HIVE-22327.15.patch, HIVE-22327.16.patch, 
> HIVE-22327.2.patch, HIVE-22327.3.patch, HIVE-22327.4.patch, 
> HIVE-22327.5.patch, HIVE-22327.6.patch, HIVE-22327.7.patch, 
> HIVE-22327.8.patch, HIVE-22327.9.patch
>
>
> Read txns need not be replicated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22568) Process compaction candidates in parallel by the Initiator

2019-12-06 Thread Denys Kuzmenko (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Denys Kuzmenko updated HIVE-22568:
--
Attachment: HIVE-22568.2.patch

> Process compaction candidates in parallel by the Initiator
> --
>
> Key: HIVE-22568
> URL: https://issues.apache.org/jira/browse/HIVE-22568
> Project: Hive
>  Issue Type: Improvement
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22568.1.patch, HIVE-22568.2.patch
>
>
> `checkForCompaction` includes many file metadata checks and may be expensive. 
> Therefore, make sense using a thread pool here and running 
> `checkForCompactions` in parallel.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22548) Optimise Utilities.removeTempOrDuplicateFiles when moving files to final location

2019-12-06 Thread Steve Loughran (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989710#comment-16989710
 ] 

Steve Loughran commented on HIVE-22548:
---

OK.

 BTW, if you call toString on the S3A connector you get a dump of its metrics; 
you can just do a LOG.debug("FS {}", fs) to get this @ debug level

> Optimise Utilities.removeTempOrDuplicateFiles when moving files to final 
> location
> -
>
> Key: HIVE-22548
> URL: https://issues.apache.org/jira/browse/HIVE-22548
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Affects Versions: 3.1.2
>Reporter: Rajesh Balamohan
>Assignee: mahesh kumar behera
>Priority: Major
> Attachments: HIVE-22548.01.patch, HIVE-22548.02.patch
>
>
> {{Utilities.removeTempOrDuplicateFiles}}
> is very slow with cloud storage, as it executes {{listStatus}} twice and also 
> runs in single threaded mode.
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java#L1629



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22582) Avoid reading table as ACID when table name is starting with "delta" , but table is not transactional and BI Split Strategy is used

2019-12-06 Thread Peter Vary (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Vary updated HIVE-22582:
--
Fix Version/s: 4.0.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

Pushed to master.
Thanks for the patch [~aditya-shah] and [~lpinter] for the review!

> Avoid reading table as ACID when table name is starting with "delta" , but 
> table is not transactional and BI Split Strategy is used
> ---
>
> Key: HIVE-22582
> URL: https://issues.apache.org/jira/browse/HIVE-22582
> Project: Hive
>  Issue Type: Bug
>Reporter: Aditya Shah
>Assignee: Aditya Shah
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22582.patch
>
>
> The issue is fixed in HIVE-22473 but missed a check for BI Split Strategy.
> Steps to reproduce: 
> {code:java}
> set hive.exec.orc.split.strategy=BI;
> create table delta_result (a int) stored as orc 
> tblproperties('transactional'='false');
> insert into delta_result select 1;
> select * from delta_result;
> {code}
> Exception Stack Trace:
> {code:java}
> Caused by: java.lang.RuntimeException: ORC split generation failed with 
> exception: String index out of range: -1
> at 
> org.apache.hadoop.hive.ql.io.orc.OrcInputFormat.generateSplitsInfo(OrcInputFormat.java:1929)
> at 
> org.apache.hadoop.hive.ql.io.orc.OrcInputFormat.getSplits(OrcInputFormat.java:2016)
> at 
> org.apache.hadoop.hive.ql.exec.FetchOperator.generateWrappedSplits(FetchOperator.java:461)
> at 
> org.apache.hadoop.hive.ql.exec.FetchOperator.getNextSplits(FetchOperator.java:430)
> at 
> org.apache.hadoop.hive.ql.exec.FetchOperator.getRecordReader(FetchOperator.java:336)
> at 
> org.apache.hadoop.hive.ql.exec.FetchOperator.getNextRow(FetchOperator.java:576)
> ... 50 more
> Caused by: java.lang.StringIndexOutOfBoundsException: String index out of 
> range: -1
> at java.lang.String.substring(String.java:1967)
> at 
> org.apache.hadoop.hive.ql.io.AcidUtils.parsedDelta(AcidUtils.java:1128)
> at 
> org.apache.hadoop.hive.ql.io.AcidUtils$ParsedDeltaLight.parse(AcidUtils.java:921)
> at 
> org.apache.hadoop.hive.ql.io.AcidUtils.getLogicalLength(AcidUtils.java:2084)
> at 
> org.apache.hadoop.hive.ql.io.orc.OrcInputFormat$BISplitStrategy.getSplits(OrcInputFormat.java:1115)
> at 
> org.apache.hadoop.hive.ql.io.orc.OrcInputFormat.generateSplitsInfo(OrcInputFormat.java:1905)
> ... 55 more
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22578) CBO genOPTree is not failsafe for CTAS and VIEW statements

2019-12-06 Thread Vineet Garg (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989693#comment-16989693
 ] 

Vineet Garg commented on HIVE-22578:


[~hamvas.aron] That makes sense, thanks for the clarification.

> CBO genOPTree is not failsafe for CTAS and VIEW statements
> --
>
> Key: HIVE-22578
> URL: https://issues.apache.org/jira/browse/HIVE-22578
> Project: Hive
>  Issue Type: Bug
>  Components: CBO
>Affects Versions: 3.0.0, 3.1.2
>Reporter: Aron Hamvas
>Assignee: Aron Hamvas
>Priority: Major
> Fix For: 3.0.1, 3.1.3
>
> Attachments: HIVE-22578.2.patch, HIVE-22578.patch
>
>
> If CBO fails during OT generation, it is supposed to skip CBO and fall back 
> to SemanticAnalyzer generating the OT for the original AST. However, for CTAS 
> and VIEW statements, the original AST is discarded and replaced with the new 
> AST. 
> If OT generation for the new AST fails with a SemanticException, the 
> compilation is destined to fail completely since we cannot fall back to the 
> original and possibly valid AST.
> Also, the SemanticException sometimes gets hidden and misjudged as a missing 
> column statistics issue due to bad error handling.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22553) Expose locks and transactions in sys db

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989690#comment-16989690
 ] 

Hive QA commented on HIVE-22553:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
50s{color} | {color:blue} Maven dependency ordering for branch {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
27s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
10s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  3m  9s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  xml  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19774/dev-support/hive-personality.sh
 |
| git revision | master / 0c78dcb |
| modules | C: metastore ql . U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19774/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Expose locks and transactions in sys db
> ---
>
> Key: HIVE-22553
> URL: https://issues.apache.org/jira/browse/HIVE-22553
> Project: Hive
>  Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Zoltan Chovan
>Assignee: Zoltan Chovan
>Priority: Major
> Attachments: HIVE-22553.2.patch, HIVE-22553.3.patch, 
> HIVE-22553.3.patch, HIVE-22553.4.patch, HIVE-22553.patch
>
>
> Create new sysdb tables/views to access lock and transaction data.
> This allows to provide admins with live data about ongoing locks and 
> transacions. Due to this being in the sys db access to this information can 
> be restricted to select privileged users.
> Information about locks and compactions can be joined and accessed at the 
> same time.
> Compaction related transactions would also be visible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22584) Flakyness in TestTaskExecutorService.testSetCapacity

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989677#comment-16989677
 ] 

Hive QA commented on HIVE-22584:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987595/HIVE-22584.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17760 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19773/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19773/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19773/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12987595 - PreCommit-HIVE-Build

> Flakyness in TestTaskExecutorService.testSetCapacity
> 
>
> Key: HIVE-22584
> URL: https://issues.apache.org/jira/browse/HIVE-22584
> Project: Hive
>  Issue Type: Test
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-22584.patch
>
>
> Very rarely the test fails:
> {code}
> java.lang.AssertionError: expected:<0> but was:<1>
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:743)
>   at org.junit.Assert.assertEquals(Assert.java:118)
>   at org.junit.Assert.assertEquals(Assert.java:555)
>   at org.junit.Assert.assertEquals(Assert.java:542)
>   at 
> org.apache.hadoop.hive.llap.daemon.impl.TestTaskExecutorService.testSetCapacity(TestTaskExecutorService.java:515)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
> {code}
> See: 
> https://builds.apache.org/job/PreCommit-HIVE-Build/19739/testReport/org.apache.hadoop.hive.llap.daemon.impl/TestTaskExecutorService/testSetCapacity/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22529) Make Debugging Stacktrace More Explicit

2019-12-06 Thread Ashutosh Bapat (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989670#comment-16989670
 ] 

Ashutosh Bapat commented on HIVE-22529:
---

Sorry for the delay. The patch looks good to me. I see that it's already 
committed. Thanks for working on it, [~belugabehr] and [~vgarg].

> Make Debugging Stacktrace More Explicit
> ---
>
> Key: HIVE-22529
> URL: https://issues.apache.org/jira/browse/HIVE-22529
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-22529.1.patch, HIVE-22529.1.patch
>
>
> In some places, the following DEBUG logging was introduced:
> {code:java}
> LOG.debug("Message", new Exception());
> {code}
> The purpose of this is to log the stack trace of the Thread calling this 
> debug logging method.  However, the resulting log message includes the 
> following:
> {code:none}
> 2019-11-19T08:13:31,392 DEBUG [Thread] Logger: Message
> java.lang.Exception: null
>  at 
> {code}
> To the observer, it appears that there was perhaps some sort of NPE.  Add a 
> message to the Exception being generated to make it more clear that this 
> "Exception" is for debugging purposes and not an actual error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22582) Avoid reading table as ACID when table name is starting with "delta" , but table is not transactional and BI Split Strategy is used

2019-12-06 Thread Aditya Shah (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989656#comment-16989656
 ] 

Aditya Shah commented on HIVE-22582:


[~pvary] no failures, can you please merge? Thanks!

> Avoid reading table as ACID when table name is starting with "delta" , but 
> table is not transactional and BI Split Strategy is used
> ---
>
> Key: HIVE-22582
> URL: https://issues.apache.org/jira/browse/HIVE-22582
> Project: Hive
>  Issue Type: Bug
>Reporter: Aditya Shah
>Assignee: Aditya Shah
>Priority: Major
> Attachments: HIVE-22582.patch
>
>
> The issue is fixed in HIVE-22473 but missed a check for BI Split Strategy.
> Steps to reproduce: 
> {code:java}
> set hive.exec.orc.split.strategy=BI;
> create table delta_result (a int) stored as orc 
> tblproperties('transactional'='false');
> insert into delta_result select 1;
> select * from delta_result;
> {code}
> Exception Stack Trace:
> {code:java}
> Caused by: java.lang.RuntimeException: ORC split generation failed with 
> exception: String index out of range: -1
> at 
> org.apache.hadoop.hive.ql.io.orc.OrcInputFormat.generateSplitsInfo(OrcInputFormat.java:1929)
> at 
> org.apache.hadoop.hive.ql.io.orc.OrcInputFormat.getSplits(OrcInputFormat.java:2016)
> at 
> org.apache.hadoop.hive.ql.exec.FetchOperator.generateWrappedSplits(FetchOperator.java:461)
> at 
> org.apache.hadoop.hive.ql.exec.FetchOperator.getNextSplits(FetchOperator.java:430)
> at 
> org.apache.hadoop.hive.ql.exec.FetchOperator.getRecordReader(FetchOperator.java:336)
> at 
> org.apache.hadoop.hive.ql.exec.FetchOperator.getNextRow(FetchOperator.java:576)
> ... 50 more
> Caused by: java.lang.StringIndexOutOfBoundsException: String index out of 
> range: -1
> at java.lang.String.substring(String.java:1967)
> at 
> org.apache.hadoop.hive.ql.io.AcidUtils.parsedDelta(AcidUtils.java:1128)
> at 
> org.apache.hadoop.hive.ql.io.AcidUtils$ParsedDeltaLight.parse(AcidUtils.java:921)
> at 
> org.apache.hadoop.hive.ql.io.AcidUtils.getLogicalLength(AcidUtils.java:2084)
> at 
> org.apache.hadoop.hive.ql.io.orc.OrcInputFormat$BISplitStrategy.getSplits(OrcInputFormat.java:1115)
> at 
> org.apache.hadoop.hive.ql.io.orc.OrcInputFormat.generateSplitsInfo(OrcInputFormat.java:1905)
> ... 55 more
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (HIVE-22584) Flakyness in TestTaskExecutorService.testSetCapacity

2019-12-06 Thread Peter Vary (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988775#comment-16988775
 ] 

Peter Vary edited comment on HIVE-22584 at 12/6/19 11:10 AM:
-

Submitted the patch.
Thanks [~odraese] for pointing out.


was (Author: pvary):
Submitted the patch.
Thansk [~odraese] for pointing out.

> Flakyness in TestTaskExecutorService.testSetCapacity
> 
>
> Key: HIVE-22584
> URL: https://issues.apache.org/jira/browse/HIVE-22584
> Project: Hive
>  Issue Type: Test
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-22584.patch
>
>
> Very rarely the test fails:
> {code}
> java.lang.AssertionError: expected:<0> but was:<1>
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:743)
>   at org.junit.Assert.assertEquals(Assert.java:118)
>   at org.junit.Assert.assertEquals(Assert.java:555)
>   at org.junit.Assert.assertEquals(Assert.java:542)
>   at 
> org.apache.hadoop.hive.llap.daemon.impl.TestTaskExecutorService.testSetCapacity(TestTaskExecutorService.java:515)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
> {code}
> See: 
> https://builds.apache.org/job/PreCommit-HIVE-Build/19739/testReport/org.apache.hadoop.hive.llap.daemon.impl/TestTaskExecutorService/testSetCapacity/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22364) RelFieldTrimmer is being done twice during compilation

2019-12-06 Thread Vineet Garg (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vineet Garg updated HIVE-22364:
---
Status: Open  (was: Patch Available)

> RelFieldTrimmer is being done twice during compilation
> --
>
> Key: HIVE-22364
> URL: https://issues.apache.org/jira/browse/HIVE-22364
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Planning
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Attachments: HIVE-22364.1.patch, HIVE-22364.2.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22364) RelFieldTrimmer is being done twice during compilation

2019-12-06 Thread Vineet Garg (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vineet Garg updated HIVE-22364:
---
Status: Patch Available  (was: Open)

> RelFieldTrimmer is being done twice during compilation
> --
>
> Key: HIVE-22364
> URL: https://issues.apache.org/jira/browse/HIVE-22364
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Planning
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Attachments: HIVE-22364.1.patch, HIVE-22364.2.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22364) RelFieldTrimmer is being done twice during compilation

2019-12-06 Thread Vineet Garg (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vineet Garg updated HIVE-22364:
---
Attachment: HIVE-22364.2.patch

> RelFieldTrimmer is being done twice during compilation
> --
>
> Key: HIVE-22364
> URL: https://issues.apache.org/jira/browse/HIVE-22364
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Planning
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Attachments: HIVE-22364.1.patch, HIVE-22364.2.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22584) Flakyness in TestTaskExecutorService.testSetCapacity

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989635#comment-16989635
 ] 

Hive QA commented on HIVE-22584:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
14s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
43s{color} | {color:blue} llap-server in master has 90 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
14s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 31s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19773/dev-support/hive-personality.sh
 |
| git revision | master / 0c78dcb |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: llap-server U: llap-server |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19773/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Flakyness in TestTaskExecutorService.testSetCapacity
> 
>
> Key: HIVE-22584
> URL: https://issues.apache.org/jira/browse/HIVE-22584
> Project: Hive
>  Issue Type: Test
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-22584.patch
>
>
> Very rarely the test fails:
> {code}
> java.lang.AssertionError: expected:<0> but was:<1>
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:743)
>   at org.junit.Assert.assertEquals(Assert.java:118)
>   at org.junit.Assert.assertEquals(Assert.java:555)
>   at org.junit.Assert.assertEquals(Assert.java:542)
>   at 
> org.apache.hadoop.hive.llap.daemon.impl.TestTaskExecutorService.testSetCapacity(TestTaskExecutorService.java:515)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> 

[jira] [Updated] (HIVE-22546) Postgres schema not using quoted identifiers for certain tables

2019-12-06 Thread Zoltan Chovan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zoltan Chovan updated HIVE-22546:
-
Attachment: HIVE-22546.5.patch

> Postgres schema not using quoted identifiers for certain tables
> ---
>
> Key: HIVE-22546
> URL: https://issues.apache.org/jira/browse/HIVE-22546
> Project: Hive
>  Issue Type: Bug
>  Components: Database/Schema
>Affects Versions: 4.0.0
>Reporter: Zoltan Chovan
>Assignee: Zoltan Chovan
>Priority: Major
> Attachments: HIVE-22546.2.patch, HIVE-22546.3.patch, 
> HIVE-22546.3.patch, HIVE-22546.4.patch, HIVE-22546.5.patch, HIVE-22546.patch
>
>
> In the latest postgresql schema 
> (standalone-metastore/metastore-server/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql)
>  the following tables have lowercase table and column names:
> {code:java}
> aux_table 
> compaction_queue 
> completed_compactions 
> completed_txn_components 
> hive_locks 
> materialization_rebuild_locks 
> min_history_level 
> next_compaction_queue_id 
> next_lock_id 
> next_txn_id 
> next_write_id 
> repl_txn_map 
> runtime_stats 
> txn_components 
> txn_to_write_id 
> txns 
> write_set{code}
> As these tables are referenced from the Hive sys database, the queries to 
> these tables will fail with a "Table not found" error.
> The problem is that the table and column names are not enclosed in quotes, so 
> postgres will turn these identifiers into lowercase.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (HIVE-22586) Temporary table delete fails with "SemanticException No valid privileges"

2019-12-06 Thread Laszlo Kovari (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Laszlo Kovari reassigned HIVE-22586:


Assignee: Laszlo Pinter

> Temporary table delete fails with "SemanticException No valid privileges"
> -
>
> Key: HIVE-22586
> URL: https://issues.apache.org/jira/browse/HIVE-22586
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
>
> When using Hive with Sentry, at the moment is not possible to delete a 
> temporary tables without granting ALL privileges on database/table level.
> Temporary tables are strongly bound to the session, and it is only 
> visible/accessible to the user who owns the session, and the table exists 
> until the session is not closed. 
> Since temporary tables only exists on session level, and they are not 
> connected to any database, checking the privileges with Sentry is 
> unnecessary. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22408) The fix for CALCITE-2991 creates wrong results on edge case

2019-12-06 Thread Vineet Garg (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989626#comment-16989626
 ] 

Vineet Garg commented on HIVE-22408:


[~kgyrtkirk] Would you mind taking a look at this?

> The fix for CALCITE-2991 creates wrong results on edge case
> ---
>
> Key: HIVE-22408
> URL: https://issues.apache.org/jira/browse/HIVE-22408
> Project: Hive
>  Issue Type: Bug
>  Components: CBO
>Affects Versions: 3.1.2
>Reporter: Steve Carlin
>Assignee: Vineet Garg
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22408.1.patch, HIVE-22408.2.patch, 
> HIVE-22408.3.patch, HIVE-22408.4.patch, HIVE-22408.5.patch, HIVE-22408.6.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The Calcite upgrade from 1.19 to 1.21 includes a fix for CALCITE-2991.  This 
> patch causes a failure in subquery_ALL.q
> In order to proceed with the upgrade, the patch was bypassed by creating the 
> HiveRelMdMaxRowCount class which overrides the behavior in Calcite.  
> In order to recreate the regression, remove this file and the references to 
> the class in HiveDefaultRelMetadataProvider.
> This Jira is being created before the HIVE-22274 PR has been pushed, so 
> please wait until that is pushed before working on this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22591) Make single metastore call to fetch all column stats instead of separate call for each column

2019-12-06 Thread Vineet Garg (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vineet Garg updated HIVE-22591:
---
Status: Patch Available  (was: Open)

> Make single metastore call to fetch all column stats instead of separate call 
> for each column
> -
>
> Key: HIVE-22591
> URL: https://issues.apache.org/jira/browse/HIVE-22591
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Planning
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Attachments: HIVE-22591.1.patch
>
>
> Currently HiveRelFieldTrimmer has the ability to fetch (and trigger cache) 
> column stats in single call. 
> HiveReduceExpressionsWithStatsRule on the other hand has to use column stats 
> on demand, as a result it makes single call for each column.
> This should be moved after RelFieldTrimmer so that RelFieldTrimmer has all 
> the column stats cached.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22591) Make single metastore call to fetch all column stats instead of separate call for each column

2019-12-06 Thread Vineet Garg (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vineet Garg updated HIVE-22591:
---
Attachment: HIVE-22591.1.patch

> Make single metastore call to fetch all column stats instead of separate call 
> for each column
> -
>
> Key: HIVE-22591
> URL: https://issues.apache.org/jira/browse/HIVE-22591
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Planning
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Attachments: HIVE-22591.1.patch
>
>
> Currently HiveRelFieldTrimmer has the ability to fetch (and trigger cache) 
> column stats in single call. 
> HiveReduceExpressionsWithStatsRule on the other hand has to use column stats 
> on demand, as a result it makes single call for each column.
> This should be moved after RelFieldTrimmer so that RelFieldTrimmer has all 
> the column stats cached.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (HIVE-22591) Make single metastore call to fetch all column stats instead of separate call for each column

2019-12-06 Thread Vineet Garg (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vineet Garg reassigned HIVE-22591:
--


> Make single metastore call to fetch all column stats instead of separate call 
> for each column
> -
>
> Key: HIVE-22591
> URL: https://issues.apache.org/jira/browse/HIVE-22591
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Planning
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
>
> Currently HiveRelFieldTrimmer has the ability to fetch (and trigger cache) 
> column stats in single call. 
> HiveReduceExpressionsWithStatsRule on the other hand has to use column stats 
> on demand, as a result it makes single call for each column.
> This should be moved after RelFieldTrimmer so that RelFieldTrimmer has all 
> the column stats cached.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22590) Revert HIVE-17218 Canonical-ize hostnames for Hive metastore, and HS2 servers as it causes issues with SSL and LB

2019-12-06 Thread Peter Vary (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989625#comment-16989625
 ] 

Peter Vary commented on HIVE-22590:
---

Just found HIVE-21899. That patch might solve this issue too

> Revert HIVE-17218 Canonical-ize hostnames for Hive metastore, and HS2 servers 
> as it causes issues with SSL and LB
> -
>
> Key: HIVE-22590
> URL: https://issues.apache.org/jira/browse/HIVE-22590
> Project: Hive
>  Issue Type: Bug
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Major
>
> HIVE-17218 causes issues with Load balanced + SSL environments, like this:
> {code}
> java.net.SocketException: Socket is closed 
> at sun.security.ssl.SSLSocketImpl.checkEOF(SSLSocketImpl.java:1532) 
> at sun.security.ssl.SSLSocketImpl.checkWrite(SSLSocketImpl.java:1553) 
> at sun.security.ssl.AppOutputStream.write(AppOutputStream.java:71) 
> at java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:82) 
> at java.io.BufferedOutputStream.flush(BufferedOutputStream.java:140) 
> at java.io.FilterOutputStream.close(FilterOutputStream.java:158) 
> at 
> org.apache.thrift.transport.TIOStreamTransport.close(TIOStreamTransport.java:110)
>  
> at org.apache.thrift.transport.TSocket.close(TSocket.java:235) 
> at org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:318) 
> at 
> org.apache.thrift.transport.TSaslClientTransport.open(TSaslClientTransport.java:37)
>  
> at 
> org.apache.hadoop.hive.thrift.client.TUGIAssumingTransport$1.run(TUGIAssumingTransport.java:52)
>  
> at 
> org.apache.hadoop.hive.thrift.client.TUGIAssumingTransport$1.run(TUGIAssumingTransport.java:49)
>  
> at java.security.AccessController.doPrivileged(Native Method) 
> at javax.security.auth.Subject.doAs(Subject.java:422) 
> at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1917)
>  
> at 
> org.apache.hadoop.hive.thrift.client.TUGIAssumingTransport.open(TUGIAssumingTransport.java:49)
>  
> at org.apache.hive.jdbc.HiveConnection.openTransport(HiveConnection.java:204) 
> at org.apache.hive.jdbc.HiveConnection.(HiveConnection.java:169) 
> at org.apache.hive.jdbc.HiveDriver.connect(HiveDriver.java:105) 
> at java.sql.DriverManager.getConnection(DriverManager.java:664) 
> at java.sql.DriverManager.getConnection(DriverManager.java:208) 
> at 
> org.apache.hive.beeline.DatabaseConnection.connect(DatabaseConnection.java:146)
>  
> at 
> org.apache.hive.beeline.DatabaseConnection.getConnection(DatabaseConnection.java:211)
>  
> at org.apache.hive.beeline.Commands.connect(Commands.java:1496) 
> at org.apache.hive.beeline.Commands.connect(Commands.java:1391) 
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  
> at java.lang.reflect.Method.invoke(Method.java:498) 
> at 
> org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:52)
>  
> at org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1135) 
> at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1174) 
> at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1010) 
> at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:922) 
> at org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:518) 
> at org.apache.hive.beeline.BeeLine.main(BeeLine.java:501) 
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  
> at java.lang.reflect.Method.invoke(Method.java:498) 
> at org.apache.hadoop.util.RunJar.run(RunJar.java:221) 
> at org.apache.hadoop.util.RunJar.main(RunJar.java:136) 
> Unknown HS2 problem when communicating with Thrift server. 
> Error: Could not open client transport with JDBC Uri: jdbc:hive2:// For privacy> GSS initiate failed 
> Also, could not send response: 
> org.apache.thrift.transport.TTransportException: 
> javax.net.ssl.SSLHandshakeException: java.security.cert.CertificateException: 
> No subject alternative names matching IP address 52 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-20972) Enable TestMiniLlapLocalCliDriver cbo_limit and cbo_rp_limit

2019-12-06 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-20972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989621#comment-16989621
 ] 

Hive QA commented on HIVE-20972:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987594/HIVE-20972.02.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17730 tests 
executed
*Failed tests:*
{noformat}
TestMiniLlapLocalCliDriver - did not produce a TEST-*.xml file (likely timed 
out) (batchId=187)

[vector_case_when_1.q,tez_nway_join.q,bucket_map_join_tez1.q,insert_update_delete.q,schema_evol_orc_nonvec_part_all_primitive_llap_io.q,external_jdbc_table_partition.q,cte_1.q,autoColumnStats_2.q,schema_evol_orc_acid_part_llap_io.q,semijoin6.q,reopt_semijoin.q,vector_decimal64_div_decimal64column.q,vectorization_0.q,orc_merge8.q,orc_merge_incompat2.q,vector_outer_join4.q,materialized_view_partitioned.q,orc_merge7.q,bucketpruning1.q,schema_evol_orc_acidvec_table.q,vector_grouping_sets.q,vector_outer_join5.q,schema_evol_orc_acidvec_part_update_llap_io.q,groupby_groupingset_bug.q,bucketmapjoin1.q,load_dyn_part1.q,results_cache_temptable.q,groupby_rollup_empty2.q,external_jdbc_table_perf.q,orc_merge_incompat_writer_version.q]
org.apache.hadoop.hive.ql.metadata.TestHiveRemote.testDropPartitionsWithPurge 
(batchId=336)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19772/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19772/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19772/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12987594 - PreCommit-HIVE-Build

> Enable TestMiniLlapLocalCliDriver cbo_limit and cbo_rp_limit
> 
>
> Key: HIVE-20972
> URL: https://issues.apache.org/jira/browse/HIVE-20972
> Project: Hive
>  Issue Type: Test
>Reporter: Vihang Karajgaonkar
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-20972.01.patch, HIVE-20972.02.patch, 
> HIVE-20972.02.patch, HIVE-20972.03.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   >