[jira] [Commented] (HIVE-23236) Remove the global lock from acquireLock

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089309#comment-17089309
 ] 

Hive QA commented on HIVE-23236:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
25s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m 
22s{color} | {color:blue} standalone-metastore/metastore-server in master has 
190 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
23s{color} | {color:red} standalone-metastore/metastore-server: The patch 
generated 6 new + 518 unchanged - 4 fixed = 524 total (was 522) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch 4 line(s) with tabs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 
27s{color} | {color:red} standalone-metastore/metastore-server generated 2 new 
+ 190 unchanged - 0 fixed = 192 total (was 190) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
15s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m 17s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore/metastore-server |
|  |  
org.apache.hadoop.hive.metastore.txn.TxnHandler.lockComponentsForUpdate(Connection,
 long) may fail to clean up java.sql.ResultSet  Obligation to clean up resource 
created at TxnHandler.java:clean up java.sql.ResultSet  Obligation to clean up 
resource created at TxnHandler.java:[line 4443] is not discharged |
|  |  
org.apache.hadoop.hive.metastore.txn.TxnHandler.lockComponentsForUpdate(Connection,
 long) passes a nonconstant String to an execute or addBatch method on an SQL 
statement  At TxnHandler.java:String to an execute or addBatch method on an SQL 
statement  At TxnHandler.java:[line 4443] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21842/dev-support/hive-personality.sh
 |
| git revision | master / 8b9fadb |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21842/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt
 |
| whitespace | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21842/yetus/whitespace-tabs.txt
 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21842/yetus/new-findbugs-standalone-metastore_metastore-server.html
 |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21842/yetus/patch-asflicense-problems.txt
 |
| modules | C: standalone-metastore/metastore-server U: 
standalone-metastore/metastore-server |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21842/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Remove the global lock from acquireLock
> ---
>
> Key: HIVE-23236
> URL: https://issues.apache.org/jira/browse/HIVE-23236
> Project: Hive
>  Issue Type: Improvement
>Reporter: Marton Bod
>

[jira] [Commented] (HIVE-23048) Use sequences for TXN_ID generation

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089298#comment-17089298
 ] 

Hive QA commented on HIVE-23048:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000703/HIVE-23048.10.patch

{color:green}SUCCESS:{color} +1 due to 11 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 17142 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.TestTxnCommandsForOrcMmTable.testOperationsOnCompletedTxnComponentsForMmTable
 (batchId=268)
org.apache.hadoop.hive.ql.txn.compactor.TestMmCompactorOnTez.testMmMinorCompactionWithSchemaEvolutionAndBuckets
 (batchId=181)
org.apache.hive.minikdc.TestJdbcWithMiniKdcCookie.testCookie[0: 
tranportMode=all] (batchId=236)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21841/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21841/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21841/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13000703 - PreCommit-HIVE-Build

> Use sequences for TXN_ID generation
> ---
>
> Key: HIVE-23048
> URL: https://issues.apache.org/jira/browse/HIVE-23048
> Project: Hive
>  Issue Type: Bug
>Reporter: Peter Vary
>Assignee: Peter Varga
>Priority: Major
> Attachments: HIVE-23048.1.patch, HIVE-23048.10.patch, 
> HIVE-23048.2.patch, HIVE-23048.3.patch, HIVE-23048.4.patch, 
> HIVE-23048.5.patch, HIVE-23048.6.patch, HIVE-23048.7.patch, 
> HIVE-23048.8.patch, HIVE-23048.9.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-19064) Add mode to support delimited identifiers enclosed within double quotation

2020-04-21 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-19064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-19064:
--
Status: Open  (was: Patch Available)

> Add mode to support delimited identifiers enclosed within double quotation
> --
>
> Key: HIVE-19064
> URL: https://issues.apache.org/jira/browse/HIVE-19064
> Project: Hive
>  Issue Type: Improvement
>  Components: Parser, SQL
>Affects Versions: 3.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-19064.01.patch, HIVE-19064.02.patch, 
> HIVE-19064.03.patch, HIVE-19064.4.patch, HIVE-19064.5.patch, 
> HIVE-19064.6.patch
>
>
> As per SQL standard. Hive currently uses `` (backticks). Default will 
> continue being backticks, but we will support identifiers within double 
> quotation via configuration parameter.
> This issue will also extends support for arbitrary char sequences, e.g., 
> containing {{~ ! @ # $ % ^ & * () , < >}}, in database and table names. 
> Currently, special characters are only supported for column names.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-19064) Add mode to support delimited identifiers enclosed within double quotation

2020-04-21 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-19064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-19064:
--
Attachment: HIVE-19064.6.patch

> Add mode to support delimited identifiers enclosed within double quotation
> --
>
> Key: HIVE-19064
> URL: https://issues.apache.org/jira/browse/HIVE-19064
> Project: Hive
>  Issue Type: Improvement
>  Components: Parser, SQL
>Affects Versions: 3.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-19064.01.patch, HIVE-19064.02.patch, 
> HIVE-19064.03.patch, HIVE-19064.4.patch, HIVE-19064.5.patch, 
> HIVE-19064.6.patch
>
>
> As per SQL standard. Hive currently uses `` (backticks). Default will 
> continue being backticks, but we will support identifiers within double 
> quotation via configuration parameter.
> This issue will also extends support for arbitrary char sequences, e.g., 
> containing {{~ ! @ # $ % ^ & * () , < >}}, in database and table names. 
> Currently, special characters are only supported for column names.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-19064) Add mode to support delimited identifiers enclosed within double quotation

2020-04-21 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-19064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-19064:
--
Status: Patch Available  (was: Open)

> Add mode to support delimited identifiers enclosed within double quotation
> --
>
> Key: HIVE-19064
> URL: https://issues.apache.org/jira/browse/HIVE-19064
> Project: Hive
>  Issue Type: Improvement
>  Components: Parser, SQL
>Affects Versions: 3.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-19064.01.patch, HIVE-19064.02.patch, 
> HIVE-19064.03.patch, HIVE-19064.4.patch, HIVE-19064.5.patch, 
> HIVE-19064.6.patch
>
>
> As per SQL standard. Hive currently uses `` (backticks). Default will 
> continue being backticks, but we will support identifiers within double 
> quotation via configuration parameter.
> This issue will also extends support for arbitrary char sequences, e.g., 
> containing {{~ ! @ # $ % ^ & * () , < >}}, in database and table names. 
> Currently, special characters are only supported for column names.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23048) Use sequences for TXN_ID generation

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089290#comment-17089290
 ] 

Hive QA commented on HIVE-23048:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  2m 
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
26s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  2m 
44s{color} | {color:blue} standalone-metastore/metastore-common in master has 
35 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m 
18s{color} | {color:blue} standalone-metastore/metastore-server in master has 
190 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  
1s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
18s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
31s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m  
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m  
4s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
25s{color} | {color:red} standalone-metastore/metastore-server: The patch 
generated 2 new + 593 unchanged - 26 fixed = 595 total (was 619) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
49s{color} | {color:red} ql: The patch generated 11 new + 886 unchanged - 4 
fixed = 897 total (was 890) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 
30s{color} | {color:red} standalone-metastore/metastore-server generated 1 new 
+ 189 unchanged - 1 fixed = 190 total (was 190) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 
22s{color} | {color:red} standalone-metastore_metastore-server generated 1 new 
+ 24 unchanged - 0 fixed = 25 total (was 24) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
16s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 43m 55s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore/metastore-server |
|  |  Write to static field 
org.apache.hadoop.hive.metastore.txn.TxnHandler.openTxnTimeOutMillis from 
instance method 
org.apache.hadoop.hive.metastore.txn.TxnHandler.setOpenTxnTimeOutMillis(long)  
At TxnHandler.java:from instance method 
org.apache.hadoop.hive.metastore.txn.TxnHandler.setOpenTxnTimeOutMillis(long)  
At TxnHandler.java:[line 875] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21841/dev-support/hive-personality.sh
 |
| git revision | master / 8b9fadb |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21841/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt
 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21841/yetus/diff-checkstyle-ql.txt
 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21841/yetus/new-findbugs-standalone-metastore_metastore-server.html
 |
| javadoc | 

[jira] [Comment Edited] (HIVE-23164) server is not properly terminated because of non-daemon threads

2020-04-21 Thread Eugene Chung (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088804#comment-17088804
 ] 

Eugene Chung edited comment on HIVE-23164 at 4/22/20, 4:56 AM:
---

Shutdown of ScheduledExecutorService made by PerPoolTriggerValidatorRunnable 
makes 4 tests fail. It seems setting its threads as daemon is just enough right 
now.


was (Author: euigeun_chung):
Shutdown of ScheduledExecutorService made by PerPoolTriggerValidatorRunnable 
makes 4 tests fail. It seems setting its threads as daemon right now.

> server is not properly terminated because of non-daemon threads
> ---
>
> Key: HIVE-23164
> URL: https://issues.apache.org/jira/browse/HIVE-23164
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2
>Reporter: Eugene Chung
>Assignee: Eugene Chung
>Priority: Major
> Attachments: HIVE-23164.01.patch, HIVE-23164.02.patch, 
> HIVE-23164.03.patch, thread_dump_hiveserver2_is_not_terminated.txt
>
>
> HiveServer2 which receives the deregister command is at first preparing 
> shutdown. If there's no remaining session, HiveServer2.stop() is called to 
> shut down. But I found the case that the HiveServer2 JVM is not terminated 
> even if HiveServer2.stop() has been called and processed. The case is always 
> occurred when the local(embedded) metastore is used.
> I've attached the full thread dump describing the situation.
> [^thread_dump_hiveserver2_is_not_terminated.txt]
> In this thread dump, you can see some bunch of 'daemon' threads, NO main 
> thread, and some 'non-daemon' thread(or user thread)s. As specified by 
> [https://www.baeldung.com/java-daemon-thread], if there is at least one user 
> thread exists, JVM does not terminate. (Note that DestroyJavaVM thread is 
> non-daemon but it's special.)
>  
> {code:java}
> "pool-8-thread-1" #24 prio=5 os_prio=0 tid=0x7f52ad1fc000 nid=0x821c 
> waiting on condition [0x7f525c50]
>  java.lang.Thread.State: TIMED_WAITING (parking)
>  at sun.misc.Unsafe.park(Native Method)
>  - parking to wait for <0x0003cfa057c0> (a 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
>  at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
>  at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2078)
>  at 
> java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:1093)
>  at 
> java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:809)
>  at 
> java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1067)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1127)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  at java.lang.Thread.run(Thread.java:748)
> Locked ownable synchronizers:
>  - None
> {code}
> The thread above is created by ScheduledThreadPoolExecutor(int coreSize) with 
> default ThreadFactory which always creates non-daemon thread. If such thread 
> pool is not destroyed with ScheduledThreadPoolExecutor.shutdown() method, JVM 
> cannot terminate! The only way to kill is TERM signal. If JVM receives TERM 
> signal, it ignores non-daemon threads and terminates.
> So I have been digging modules which create ScheduledThreadPoolExecutor with 
> non-daemon threads and I got it. As you may guess, it's the local(embedded) 
> metastore. ScheduledThreadPoolExecutor is created by 
> org.apache.hadoop.hive.metastore.HiveMetaStore.HMSHandler#startAlwaysTaskThreads()
>  and ScheduledThreadPoolExecutor.shutdown() is never called.
> Plus, I found another usage of creating such ScheduledThreadPoolExecutor and 
> not calling its shutdown. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-19369) Locks: Add new lock implementations for always zero-wait readers

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-19369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089271#comment-17089271
 ] 

Hive QA commented on HIVE-19369:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000698/HIVE-19369.7.patch

{color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 20 failed/errored test(s), 17146 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[timestamptz_2] 
(batchId=37)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testCompletedTxnComponents 
(batchId=300)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testDynamicPartitionInsert 
(batchId=300)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testDynamicPartitionInsertSharedWrite
 (batchId=300)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMerge3Way (batchId=300)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMerge3WayConflict 
(batchId=300)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMerge3WayConflictSharedWrite
 (batchId=300)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMergePartitioned 
(batchId=300)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMergePartitionedConflict
 (batchId=300)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMergePartitionedConflictSharedWrite
 (batchId=300)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMergeUnpartitioned 
(batchId=300)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMergeUnpartitionedConflict
 (batchId=300)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMergeUnpartitionedConflictSharedWrite
 (batchId=300)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMultiInsert 
(batchId=300)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMultiInsertOnDynamicallyPartitionedMmTable
 (batchId=300)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testWriteSetTracking10 
(batchId=300)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testWriteSetTracking11 
(batchId=300)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testWriteSetTracking7 
(batchId=300)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testWriteSetTracking8 
(batchId=300)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testWriteSetTracking9 
(batchId=300)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21840/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21840/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21840/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 20 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13000698 - PreCommit-HIVE-Build

> Locks: Add new lock implementations for always zero-wait readers
> 
>
> Key: HIVE-19369
> URL: https://issues.apache.org/jira/browse/HIVE-19369
> Project: Hive
>  Issue Type: Improvement
>  Components: Transactions
>Reporter: Gopal Vijayaraghavan
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-19369.1.patch, HIVE-19369.2.patch, 
> HIVE-19369.3.patch, HIVE-19369.4.patch, HIVE-19369.5.patch, 
> HIVE-19369.6.patch, HIVE-19369.7.patch
>
>
> Hive Locking with Micro-managed and full-ACID tables needs a better locking 
> implementation which allows for no-wait readers always.
> EXCL_DROP
> EXCL_WRITE
> SHARED_WRITE
> SHARED_READ
> Short write-up
> EXCL_DROP is a "drop partition" or "drop table" and waits for all others to 
> exit
> EXCL_WRITE excludes all writes and will wait for all existing SHARED_WRITE to 
> exit.
> SHARED_WRITE allows all SHARED_WRITES to go through, but will wait for an 
> EXCL_WRITE & EXCL_DROP (waiting so that you can do drop + insert in different 
> threads).
> SHARED_READ does not wait for any lock - it fails fast for a pending 
> EXCL_DROP, because even if there is an EXCL_WRITE or SHARED_WRITE pending, 
> there's no semantic reason to wait for them to succeed before going ahead 
> with a SHARED_WRITE.
> a select * => SHARED_READ
> an insert into => SHARED_WRITE
> an insert overwrite or MERGE => EXCL_WRITE
> a drop table => EXCL_DROP
> TODO:
> The fate of the compactor needs to be added to this before it is a complete 
> description.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-19369) Locks: Add new lock implementations for always zero-wait readers

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-19369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089267#comment-17089267
 ] 

Hive QA commented on HIVE-19369:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  2m 
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
39s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  2m 
46s{color} | {color:blue} standalone-metastore/metastore-common in master has 
35 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
36s{color} | {color:blue} common in master has 63 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m 
21s{color} | {color:blue} standalone-metastore/metastore-server in master has 
190 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
59s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
42s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
30s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
 3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} standalone-metastore/metastore-common: The patch 
generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
17s{color} | {color:green} The patch common passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
24s{color} | {color:red} standalone-metastore/metastore-server: The patch 
generated 5 new + 504 unchanged - 33 fixed = 509 total (was 537) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
48s{color} | {color:red} ql: The patch generated 23 new + 231 unchanged - 122 
fixed = 254 total (was 353) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
55s{color} | {color:green} metastore-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
43s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
28s{color} | {color:green} standalone-metastore/metastore-server generated 0 
new + 189 unchanged - 1 fixed = 189 total (was 190) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m  
6s{color} | {color:green} ql in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
16s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 47m 42s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21840/dev-support/hive-personality.sh
 |
| git 

[jira] [Commented] (HIVE-23263) Add fix order to cbo_rp_limit.q queries + improve readability

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089253#comment-17089253
 ] 

Hive QA commented on HIVE-23263:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000688/HIVE-23263.01.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17134 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.TestWarehouseExternalDir.org.apache.hadoop.hive.ql.TestWarehouseExternalDir
 (batchId=181)
org.apache.hadoop.hive.ql.TestWarehouseExternalDir.testExternalDefaultPaths 
(batchId=181)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21839/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21839/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21839/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13000688 - PreCommit-HIVE-Build

> Add fix order to cbo_rp_limit.q queries + improve readability
> -
>
> Key: HIVE-23263
> URL: https://issues.apache.org/jira/browse/HIVE-23263
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-23263.01.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23207) Create integration tests for TxnManager for different rdbms metastores

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089240#comment-17089240
 ] 

Hive QA commented on HIVE-23207:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  2m 
17s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m 
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  4m 
46s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m 
23s{color} | {color:blue} standalone-metastore/metastore-server in master has 
190 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  
0s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
25s{color} | {color:blue} contrib in master has 11 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
23s{color} | {color:blue} itests/qtest-druid in master has 7 extant Findbugs 
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
51s{color} | {color:blue} itests/util in master has 53 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 10m 
41s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
28s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 15m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
25s{color} | {color:green} standalone-metastore/metastore-server: The patch 
generated 0 new + 512 unchanged - 12 fixed = 512 total (was 524) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
45s{color} | {color:green} ql: The patch generated 0 new + 139 unchanged - 80 
fixed = 139 total (was 219) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
10s{color} | {color:green} The patch contrib passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
22s{color} | {color:green} root: The patch generated 0 new + 678 unchanged - 92 
fixed = 678 total (was 770) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
15s{color} | {color:green} The patch hive-blobstore passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
14s{color} | {color:green} The patch qtest-accumulo passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} The patch qtest-druid passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} The patch qtest-kudu passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
15s{color} | {color:green} The patch util passed checkstyle {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
7s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 
16s{color} | {color:red} patch/standalone-metastore/metastore-server cannot run 
setBugDatabaseInfo from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  3m 
51s{color} | {color:red} patch/ql cannot run setBugDatabaseInfo from findbugs 
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | 

[jira] [Commented] (HIVE-23263) Add fix order to cbo_rp_limit.q queries + improve readability

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089216#comment-17089216
 ] 

Hive QA commented on HIVE-23263:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  1m  
2s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}  2m 15s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21839/dev-support/hive-personality.sh
 |
| git revision | master / 8b9fadb |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21839/yetus/patch-asflicense-problems.txt
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21839/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Add fix order to cbo_rp_limit.q queries + improve readability
> -
>
> Key: HIVE-23263
> URL: https://issues.apache.org/jira/browse/HIVE-23263
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-23263.01.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23207) Create integration tests for TxnManager for different rdbms metastores

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089212#comment-17089212
 ] 

Hive QA commented on HIVE-23207:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000684/HIVE-23207.8.patch

{color:green}SUCCESS:{color} +1 due to 9 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17133 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[timestamptz_2] 
(batchId=37)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21838/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21838/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21838/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13000684 - PreCommit-HIVE-Build

> Create integration tests for TxnManager for different rdbms metastores
> --
>
> Key: HIVE-23207
> URL: https://issues.apache.org/jira/browse/HIVE-23207
> Project: Hive
>  Issue Type: Improvement
>Reporter: Peter Varga
>Assignee: Peter Varga
>Priority: Minor
> Attachments: HIVE-23207.1.patch, HIVE-23207.2.patch, 
> HIVE-23207.3.patch, HIVE-23207.4.patch, HIVE-23207.5.patch, 
> HIVE-23207.6.patch, HIVE-23207.7.patch, HIVE-23207.8.patch
>
>
> Create an integration test suite that runs tests for TxnManager with the 
> metastore configured to use different kind of RDBMS-s. Use the different 
> DatabaseRule-s defined in the standalone-metastore for docker environments, 
> and use the real init schema for every database type instead of the hardwired 
> TxnDbUtil.prepDb.
> This test will be useful for easy manual validation of schema changes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-22458) Add more constraints on showing partitions

2020-04-21 Thread Zhihua Deng (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhihua Deng updated HIVE-22458:
---
Fix Version/s: 4.0.0

> Add more constraints on showing partitions
> --
>
> Key: HIVE-22458
> URL: https://issues.apache.org/jira/browse/HIVE-22458
> Project: Hive
>  Issue Type: Improvement
>Reporter: Zhihua Deng
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22458.2.patch, HIVE-22458.3.patch, 
> HIVE-22458.4.patch, HIVE-22458.5.patch, HIVE-22458.branch-1.02.patch, 
> HIVE-22458.branch-1.patch, HIVE-22458.patch
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> When we showing partitions of a table with thousands of partitions,  all the 
> partitions will be returned and it's not easy to catch the specified one from 
> them, this make showing partitions hard to use. We can add where/limit/order 
> by constraints to show partitions like:
>  show partitions table_name [partition_specs] where partition_key >= value 
> order by partition_key desc limit n;
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22934) Hive server interactive log counters to error stream

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089191#comment-17089191
 ] 

Hive QA commented on HIVE-22934:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000685/HIVE-22934.01.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 943 failed/errored test(s), 17133 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBlobstoreNegativeCliDriver.testCliDriver[select_dropped_table]
 (batchId=237)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join25] (batchId=34)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join_without_localtask]
 (batchId=1)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[avrotblsjoin] 
(batchId=15)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[correlationoptimizer8] 
(batchId=7)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[infer_bucket_sort_convert_join]
 (batchId=26)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[infer_bucket_sort_map_operators]
 (batchId=31)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[infer_const_type] 
(batchId=32)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_hook] (batchId=6)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_0] 
(batchId=8)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_3] 
(batchId=36)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_limit]
 (batchId=12)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_offset_limit]
 (batchId=16)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_pushdown]
 (batchId=16)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[subquery_multiinsert] 
(batchId=39)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_offset_limit]
 (batchId=22)
org.apache.hadoop.hive.cli.TestCliDriverMethods.testProcessSelectDatabase 
(batchId=133)
org.apache.hadoop.hive.cli.TestCliDriverMethods.testRun (batchId=133)
org.apache.hadoop.hive.cli.TestCliDriverMethods.testprocessInitFiles 
(batchId=133)
org.apache.hadoop.hive.cli.TestContribNegativeCliDriver.testCliDriver[case_with_row_sequence]
 (batchId=232)
org.apache.hadoop.hive.cli.TestContribNegativeCliDriver.testCliDriver[invalid_row_sequence]
 (batchId=232)
org.apache.hadoop.hive.cli.TestContribNegativeCliDriver.testCliDriver[serde_regex]
 (batchId=232)
org.apache.hadoop.hive.cli.TestContribNegativeCliDriver.testCliDriver[udtf_explode2]
 (batchId=232)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_drop_table]
 (batchId=124)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_move_tbl]
 (batchId=123)
org.apache.hadoop.hive.cli.TestHBaseNegativeCliDriver.testCliDriver[cascade_dbdrop]
 (batchId=233)
org.apache.hadoop.hive.cli.TestHBaseNegativeCliDriver.testCliDriver[generatehfiles_require_family_path]
 (batchId=233)
org.apache.hadoop.hive.cli.TestHBaseNegativeCliDriver.testCliDriver[hbase_ddl] 
(batchId=233)
org.apache.hadoop.hive.cli.TestKuduNegativeCliDriver.testCliDriver[kudu_config] 
(batchId=222)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_merge10] 
(batchId=58)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[acid_bloom_filter_orc_file_dump]
 (batchId=117)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[authorization_wm]
 (batchId=105)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[column_access_stats]
 (batchId=98)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[compare_double_bigint_2]
 (batchId=78)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[filter_join_breaktask2]
 (batchId=111)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[hook_order] 
(batchId=63)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[join_literals]
 (batchId=119)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[lineage2] 
(batchId=97)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[lineage3] 
(batchId=90)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[multiMapJoin1]
 (batchId=91)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[multiMapJoin2]
 (batchId=110)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[multi_sahooks]
 (batchId=89)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[orc_file_dump]
 (batchId=98)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[orc_merge11]
 (batchId=87)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[overridden_confs]
 (batchId=92)

[jira] [Commented] (HIVE-22934) Hive server interactive log counters to error stream

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089178#comment-17089178
 ] 

Hive QA commented on HIVE-22934:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  2m 
27s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 0s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
37s{color} | {color:blue} common in master has 63 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  
2s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
34s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
11s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
17s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 31m 46s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21837/dev-support/hive-personality.sh
 |
| git revision | master / 8b9fadb |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21837/yetus/patch-asflicense-problems.txt
 |
| modules | C: common ql U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21837/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Hive server interactive log counters to error stream
> 
>
> Key: HIVE-22934
> URL: https://issues.apache.org/jira/browse/HIVE-22934
> Project: Hive
>  Issue Type: Bug
>Reporter: Slim Bouguerra
>Assignee: Antal Sinkovits
>Priority: Major
> Attachments: HIVE-22934.01.patch, HIVE-22934.patch
>
>
> Hive server is logging the console output to system error stream.
> This need to be fixed because 
> First we do not roll the file.
> Second writing to such file is done sequential and can lead to throttle/poor 
> perf.
> {code}
> -rw-r--r--  1 hive hadoop 9.5G Feb 26 17:22 hive-server2-interactive.err
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23249) Prevent infinite loop in TestJdbcWithMiniLlapArrow

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089154#comment-17089154
 ] 

Hive QA commented on HIVE-23249:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000679/HIVE-23249.02.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17133 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21836/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21836/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21836/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13000679 - PreCommit-HIVE-Build

> Prevent infinite loop in TestJdbcWithMiniLlapArrow
> --
>
> Key: HIVE-23249
> URL: https://issues.apache.org/jira/browse/HIVE-23249
> Project: Hive
>  Issue Type: Sub-task
>  Components: Test
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-23249.01.patch, HIVE-23249.02.patch
>
>
> if we always hit continue 
> [here|https://github.com/apache/hive/blob/e65715c6ab12816ba6a79b21e8e9fcbfc6fe41cd/itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniLlapArrow.java#L372];
>  the loop may never-ever end...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23215) Make FilterContext and MutableFilterContext interfaces

2020-04-21 Thread Ashutosh Chauhan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Chauhan updated HIVE-23215:

Status: Open  (was: Patch Available)

> Make FilterContext and MutableFilterContext interfaces
> --
>
> Key: HIVE-23215
> URL: https://issues.apache.org/jira/browse/HIVE-23215
> Project: Hive
>  Issue Type: Bug
>  Components: storage-api
>Reporter: Owen O'Malley
>Assignee: Owen O'Malley
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-23215.patch
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> HIVE-22959 introduced FilterContext to support ORC-577. The duplication of 
> fields between the FilterContext and VectorizedRowBatch seems likely to cause 
> user confusion. This patch makes them interfaces that VectorizedRowBatch 
> implements.
> Thus, there is a single copy of the data and no need to copy them back and 
> forth. LLAP can make its own implementation of the interfaces if it doesn't 
> want to use VectorizedRowBatch.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23169) Probe runtime support for LLAP

2020-04-21 Thread Ashutosh Chauhan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Chauhan updated HIVE-23169:

Fix Version/s: 4.0.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

Pushed to master. Thanks, Panos!

> Probe runtime support for LLAP
> --
>
> Key: HIVE-23169
> URL: https://issues.apache.org/jira/browse/HIVE-23169
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Panagiotis Garefalakis
>Assignee: Panagiotis Garefalakis
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-23169.01.patch, HIVE-23169.02.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23169) Probe runtime support for LLAP

2020-04-21 Thread Ashutosh Chauhan (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089152#comment-17089152
 ] 

Ashutosh Chauhan commented on HIVE-23169:
-

+1

> Probe runtime support for LLAP
> --
>
> Key: HIVE-23169
> URL: https://issues.apache.org/jira/browse/HIVE-23169
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Panagiotis Garefalakis
>Assignee: Panagiotis Garefalakis
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-23169.01.patch, HIVE-23169.02.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-23175) Skip serializing hadoop and tez config on HS side

2020-04-21 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23175?focusedWorklogId=425942=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425942
 ]

ASF GitHub Bot logged work on HIVE-23175:
-

Author: ASF GitHub Bot
Created on: 21/Apr/20 23:50
Start Date: 21/Apr/20 23:50
Worklog Time Spent: 10m 
  Work Description: mustafaiman opened a new pull request #989:
URL: https://github.com/apache/hive/pull/989


   Change-Id: I4dde8e25631fbb7243afa17d139f93b785206a46



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 425942)
Remaining Estimate: 0h
Time Spent: 10m

> Skip serializing hadoop and tez config on HS side
> -
>
> Key: HIVE-23175
> URL: https://issues.apache.org/jira/browse/HIVE-23175
> Project: Hive
>  Issue Type: Improvement
>  Components: Tez
>Reporter: Mustafa Iman
>Assignee: Mustafa Iman
>Priority: Major
> Attachments: HIVE-23175.1.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> HiveServer spends a lot of time serializing configuration objects. We can 
> skip putting hadoop and tez config xml files in payload assuming that the 
> configs are the same on both HS and AM side. This depends on Tez to load 
> local xml configs when creating config objects 
> https://issues.apache.org/jira/browse/TEZ-4137 
> Ideally we should be able to skip hive-site.xml too. However, if we skip 
> hive-site.xml at that stage, then we make wrong choices at tez dag build 
> stage due to missing configs.
> In the ideal version of this, we should not be both looking up configs and 
> putting new configs from and to the same config object at DAG and Vertex 
> build phases. Instead we should be looking up from a HS2's HiveConf object 
> and writing to a brand new JobConf for each vertex. That way we would not 
> have any unnecessary item in the jobconf for any vertex. However Dag and 
> Vertex build stages (TezTask#build) and a lot of other components called from 
> there treat a single config object both the source of HS2 side config and the 
> target JobConf that they are putting vertex level options into. It is very 
> hard to separate these concerns now.
> With this patch, we are reducing the size of JobConf (per vertex) by ~65%. It 
> should improve the transmit latency. However, most significant gains are at 
> CPU time while compressing job configs as the config objects are much smaller 
> now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23175) Skip serializing hadoop and tez config on HS side

2020-04-21 Thread Mustafa Iman (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089149#comment-17089149
 ] 

Mustafa Iman commented on HIVE-23175:
-

[~ashutoshc] [~gopalv] what do you think about this?

 

> Skip serializing hadoop and tez config on HS side
> -
>
> Key: HIVE-23175
> URL: https://issues.apache.org/jira/browse/HIVE-23175
> Project: Hive
>  Issue Type: Improvement
>  Components: Tez
>Reporter: Mustafa Iman
>Assignee: Mustafa Iman
>Priority: Major
> Attachments: HIVE-23175.1.patch
>
>
> HiveServer spends a lot of time serializing configuration objects. We can 
> skip putting hadoop and tez config xml files in payload assuming that the 
> configs are the same on both HS and AM side. This depends on Tez to load 
> local xml configs when creating config objects 
> https://issues.apache.org/jira/browse/TEZ-4137 
> Ideally we should be able to skip hive-site.xml too. However, if we skip 
> hive-site.xml at that stage, then we make wrong choices at tez dag build 
> stage due to missing configs.
> In the ideal version of this, we should not be both looking up configs and 
> putting new configs from and to the same config object at DAG and Vertex 
> build phases. Instead we should be looking up from a HS2's HiveConf object 
> and writing to a brand new JobConf for each vertex. That way we would not 
> have any unnecessary item in the jobconf for any vertex. However Dag and 
> Vertex build stages (TezTask#build) and a lot of other components called from 
> there treat a single config object both the source of HS2 side config and the 
> target JobConf that they are putting vertex level options into. It is very 
> hard to separate these concerns now.
> With this patch, we are reducing the size of JobConf (per vertex) by ~65%. It 
> should improve the transmit latency. However, most significant gains are at 
> CPU time while compressing job configs as the config objects are much smaller 
> now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23175) Skip serializing hadoop and tez config on HS side

2020-04-21 Thread Mustafa Iman (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mustafa Iman updated HIVE-23175:

Description: 
HiveServer spends a lot of time serializing configuration objects. We can skip 
putting hadoop and tez config xml files in payload assuming that the configs 
are the same on both HS and AM side. This depends on Tez to load local xml 
configs when creating config objects 
https://issues.apache.org/jira/browse/TEZ-4137 

Ideally we should be able to skip hive-site.xml too. However, if we skip 
hive-site.xml at that stage, then we make wrong choices at tez dag build stage 
due to missing configs.

In the ideal version of this, we should not be both looking up configs and 
putting new configs from and to the same config object at DAG and Vertex build 
phases. Instead we should be looking up from a HS2's HiveConf object and 
writing to a brand new JobConf for each vertex. That way we would not have any 
unnecessary item in the jobconf for any vertex. However Dag and Vertex build 
stages (TezTask#build) and a lot of other components called from there treat a 
single config object both the source of HS2 side config and the target JobConf 
that they are putting vertex level options into. It is very hard to separate 
these concerns now.

With this patch, we are reducing the size of JobConf (per vertex) by ~65%. It 
should improve the transmit latency. However, most significant gains are at CPU 
time while compressing job configs as the config objects are much smaller now.

  was:HiveServer spends a lot of time serializing configuration objects. We can 
skip putting hadoop and tez config xml files in payload assuming that the 
configs are the same on both HS and AM side. This depends on Tez to load local 
xml configs when creating config objects 
https://issues.apache.org/jira/browse/TEZ-4137 


> Skip serializing hadoop and tez config on HS side
> -
>
> Key: HIVE-23175
> URL: https://issues.apache.org/jira/browse/HIVE-23175
> Project: Hive
>  Issue Type: Improvement
>  Components: Tez
>Reporter: Mustafa Iman
>Assignee: Mustafa Iman
>Priority: Major
> Attachments: HIVE-23175.1.patch
>
>
> HiveServer spends a lot of time serializing configuration objects. We can 
> skip putting hadoop and tez config xml files in payload assuming that the 
> configs are the same on both HS and AM side. This depends on Tez to load 
> local xml configs when creating config objects 
> https://issues.apache.org/jira/browse/TEZ-4137 
> Ideally we should be able to skip hive-site.xml too. However, if we skip 
> hive-site.xml at that stage, then we make wrong choices at tez dag build 
> stage due to missing configs.
> In the ideal version of this, we should not be both looking up configs and 
> putting new configs from and to the same config object at DAG and Vertex 
> build phases. Instead we should be looking up from a HS2's HiveConf object 
> and writing to a brand new JobConf for each vertex. That way we would not 
> have any unnecessary item in the jobconf for any vertex. However Dag and 
> Vertex build stages (TezTask#build) and a lot of other components called from 
> there treat a single config object both the source of HS2 side config and the 
> target JobConf that they are putting vertex level options into. It is very 
> hard to separate these concerns now.
> With this patch, we are reducing the size of JobConf (per vertex) by ~65%. It 
> should improve the transmit latency. However, most significant gains are at 
> CPU time while compressing job configs as the config objects are much smaller 
> now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23175) Skip serializing hadoop and tez config on HS side

2020-04-21 Thread Mustafa Iman (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mustafa Iman updated HIVE-23175:

Description: HiveServer spends a lot of time serializing configuration 
objects. We can skip putting hadoop and tez config xml files in payload 
assuming that the configs are the same on both HS and AM side. This depends on 
Tez to load local xml configs when creating config objects 
https://issues.apache.org/jira/browse/TEZ-4137   (was: HiveServer spends a lot 
of time serializing configuration objects. We can skip putting hadoop and tez 
config xml files in payload assuming that the configs are the same on both HS 
and AM side. This depends on Tez to load local xml configs when creating config 
objects https://issues.apache.org/jira/browse/TEZ-4141)

> Skip serializing hadoop and tez config on HS side
> -
>
> Key: HIVE-23175
> URL: https://issues.apache.org/jira/browse/HIVE-23175
> Project: Hive
>  Issue Type: Improvement
>  Components: Tez
>Reporter: Mustafa Iman
>Assignee: Mustafa Iman
>Priority: Major
> Attachments: HIVE-23175.1.patch
>
>
> HiveServer spends a lot of time serializing configuration objects. We can 
> skip putting hadoop and tez config xml files in payload assuming that the 
> configs are the same on both HS and AM side. This depends on Tez to load 
> local xml configs when creating config objects 
> https://issues.apache.org/jira/browse/TEZ-4137 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23249) Prevent infinite loop in TestJdbcWithMiniLlapArrow

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089131#comment-17089131
 ] 

Hive QA commented on HIVE-23249:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
19s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
44s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
28s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
15s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m  3s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21836/dev-support/hive-personality.sh
 |
| git revision | master / 51b810e |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21836/yetus/patch-asflicense-problems.txt
 |
| modules | C: itests/hive-unit U: itests/hive-unit |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21836/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Prevent infinite loop in TestJdbcWithMiniLlapArrow
> --
>
> Key: HIVE-23249
> URL: https://issues.apache.org/jira/browse/HIVE-23249
> Project: Hive
>  Issue Type: Sub-task
>  Components: Test
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-23249.01.patch, HIVE-23249.02.patch
>
>
> if we always hit continue 
> [here|https://github.com/apache/hive/blob/e65715c6ab12816ba6a79b21e8e9fcbfc6fe41cd/itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniLlapArrow.java#L372];
>  the loop may never-ever end...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23252) Change spark related tests to be optional

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089121#comment-17089121
 ] 

Hive QA commented on HIVE-23252:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000682/HIVE-23252.01.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 17133 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.exec.spark.TestSmallTableCacheEviction.testSmallTableEvictionIfNewQueryIsExecuted
 (batchId=206)
org.apache.hadoop.hive.ql.exec.spark.TestSparkSessionTimeout.testMultiSessionSparkSessionTimeout
 (batchId=208)
org.apache.hadoop.hive.ql.exec.spark.TestSparkSessionTimeout.testSparkSessionMultipleTimeout
 (batchId=208)
org.apache.hadoop.hive.ql.exec.spark.TestSparkSessionTimeout.testSparkSessionTimeout
 (batchId=208)
org.apache.hadoop.hive.ql.exec.spark.TestSparkStatistics.testSparkStatistics 
(batchId=208)
org.apache.hive.jdbc.TestJdbcWithMiniHS2ErasureCoding.testDescribeErasureCoding 
(batchId=218)
org.apache.hive.jdbc.TestJdbcWithMiniHS2ErasureCoding.testExplainErasureCoding 
(batchId=218)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21835/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21835/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21835/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 7 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13000682 - PreCommit-HIVE-Build

> Change spark related tests to be optional
> -
>
> Key: HIVE-23252
> URL: https://issues.apache.org/jira/browse/HIVE-23252
> Project: Hive
>  Issue Type: Sub-task
>  Components: Test
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-23252.01.patch, HIVE-23252.01.patch
>
>
> HIVE-23137 have disabled the execution of some spark related tests; but they 
> would be still considered by a plain maven command - and the spark artifacts 
> are (unneccessarily)  still downloaded



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23252) Change spark related tests to be optional

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089119#comment-17089119
 ] 

Hive QA commented on HIVE-23252:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  3m  
1s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  8m 
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  8m 
16s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
29s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
 6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  8m  
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  8m  
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
4s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  7m 
45s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
14s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 55m 31s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  xml  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21835/dev-support/hive-personality.sh
 |
| git revision | master / 51b810e |
| Default Java | 1.8.0_111 |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21835/yetus/patch-asflicense-problems.txt
 |
| modules | C: . itests itests/hive-unit U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21835/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Change spark related tests to be optional
> -
>
> Key: HIVE-23252
> URL: https://issues.apache.org/jira/browse/HIVE-23252
> Project: Hive
>  Issue Type: Sub-task
>  Components: Test
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-23252.01.patch, HIVE-23252.01.patch
>
>
> HIVE-23137 have disabled the execution of some spark related tests; but they 
> would be still considered by a plain maven command - and the spark artifacts 
> are (unneccessarily)  still downloaded



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23243) Accept SQL type like pattern for Show Databases

2020-04-21 Thread Miklos Gergely (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miklos Gergely updated HIVE-23243:
--
Attachment: HIVE-23243.01.patch

> Accept SQL type like pattern for Show Databases
> ---
>
> Key: HIVE-23243
> URL: https://issues.apache.org/jira/browse/HIVE-23243
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Minor
> Attachments: HIVE-23243.01.patch
>
>
> Show Databases pattern accepts java like pattern with * and ., use SQL like 
> instead with % and _.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23243) Accept SQL type like pattern for Show Databases

2020-04-21 Thread Miklos Gergely (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miklos Gergely updated HIVE-23243:
--
Attachment: (was: HIVE-23243.01.patch)

> Accept SQL type like pattern for Show Databases
> ---
>
> Key: HIVE-23243
> URL: https://issues.apache.org/jira/browse/HIVE-23243
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Minor
> Attachments: HIVE-23243.01.patch
>
>
> Show Databases pattern accepts java like pattern with * and ., use SQL like 
> instead with % and _.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23243) Accept SQL type like pattern for Show Databases

2020-04-21 Thread Miklos Gergely (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miklos Gergely updated HIVE-23243:
--
Attachment: HIVE-23243.01.patch

> Accept SQL type like pattern for Show Databases
> ---
>
> Key: HIVE-23243
> URL: https://issues.apache.org/jira/browse/HIVE-23243
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Minor
> Attachments: HIVE-23243.01.patch
>
>
> Show Databases pattern accepts java like pattern with * and ., use SQL like 
> instead with % and _.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23243) Accept SQL type like pattern for Show Databases

2020-04-21 Thread Miklos Gergely (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miklos Gergely updated HIVE-23243:
--
Attachment: (was: HIVE-23243.01.patch)

> Accept SQL type like pattern for Show Databases
> ---
>
> Key: HIVE-23243
> URL: https://issues.apache.org/jira/browse/HIVE-23243
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Minor
> Attachments: HIVE-23243.01.patch
>
>
> Show Databases pattern accepts java like pattern with * and ., use SQL like 
> instead with % and _.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23220) PostExecOrcFileDump listing order may depend on the underlying filesystem

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089102#comment-17089102
 ] 

Hive QA commented on HIVE-23220:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  2m 
15s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  8m 
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
53s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  
1s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  8m 
38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
29s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  8m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  8m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m 
 0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  7m 
11s{color} | {color:red} patch/ql cannot run setBugDatabaseInfo from findbugs 
{color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  8m 
41s{color} | {color:red} root in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
27s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 75m 58s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21834/dev-support/hive-personality.sh
 |
| git revision | master / 51b810e |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21834/yetus/patch-findbugs-ql.txt
 |
| javadoc | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21834/yetus/patch-javadoc-root.txt
 |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21834/yetus/patch-asflicense-problems.txt
 |
| modules | C: ql . U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21834/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> PostExecOrcFileDump listing order may depend on the underlying filesystem
> -
>
> Key: HIVE-23220
> URL: https://issues.apache.org/jira/browse/HIVE-23220
> Project: Hive
>  Issue Type: Sub-task
>  Components: Testing Infrastructure
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-23220.01.patch, HIVE-23220.02.patch, 
> HIVE-23220.02.patch
>
>
> in case there are multiple files; the order might not be stable - and may 
> cause unstable q.outs
> https://github.com/apache/hive/blob/83f917c787d60543f171b23d28ceda44d69c235d/ql/src/java/org/apache/hadoop/hive/ql/hooks/PostExecOrcFileDump.java#L104



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23220) PostExecOrcFileDump listing order may depend on the underlying filesystem

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089092#comment-17089092
 ] 

Hive QA commented on HIVE-23220:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000678/HIVE-23220.02.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17133 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21834/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21834/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21834/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13000678 - PreCommit-HIVE-Build

> PostExecOrcFileDump listing order may depend on the underlying filesystem
> -
>
> Key: HIVE-23220
> URL: https://issues.apache.org/jira/browse/HIVE-23220
> Project: Hive
>  Issue Type: Sub-task
>  Components: Testing Infrastructure
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-23220.01.patch, HIVE-23220.02.patch, 
> HIVE-23220.02.patch
>
>
> in case there are multiple files; the order might not be stable - and may 
> cause unstable q.outs
> https://github.com/apache/hive/blob/83f917c787d60543f171b23d28ceda44d69c235d/ql/src/java/org/apache/hadoop/hive/ql/hooks/PostExecOrcFileDump.java#L104



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23201) Improve logging in locking

2020-04-21 Thread Marton Bod (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marton Bod updated HIVE-23201:
--
Attachment: HIVE-23201.5.patch

> Improve logging in locking
> --
>
> Key: HIVE-23201
> URL: https://issues.apache.org/jira/browse/HIVE-23201
> Project: Hive
>  Issue Type: Improvement
>Reporter: Marton Bod
>Assignee: Marton Bod
>Priority: Major
> Attachments: HIVE-23201.1.patch, HIVE-23201.1.patch, 
> HIVE-23201.2.patch, HIVE-23201.2.patch, HIVE-23201.3.patch, 
> HIVE-23201.4.patch, HIVE-23201.5.patch, HIVE-23201.5.patch, 
> HIVE-23201.5.patch, HIVE-23201.5.patch
>
>
> Currently it can be quite difficult to troubleshoot issues related to 
> locking. To understand why a particular txn gave up after a while on 
> acquiring a lock, you have to connect directly to the backend DB, since we 
> are not logging right now which exact locks the txn is waiting for.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23117) Review of HiveStatement Class

2020-04-21 Thread David Mollitor (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089084#comment-17089084
 ] 

David Mollitor commented on HIVE-23117:
---

Fixed the typo and had to rebase.

> Review of HiveStatement Class
> -
>
> Key: HIVE-23117
> URL: https://issues.apache.org/jira/browse/HIVE-23117
> Project: Hive
>  Issue Type: Improvement
>  Components: JDBC
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23117.1.patch, HIVE-23117.2.patch
>
>
> * Remove unused instance variable(s)
>  * Remove non-JavaDoc comments
>  * Make inPlaceUpdateStream Optional (and remove NO-OP class) (inconsistent 
> behavior with 'null' values)
>  * {{getQueryTimeout()}} returns incorrect value
>  * Unify and improve Exception messages
>  * Checkstyle fixes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23117) Review of HiveStatement Class

2020-04-21 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23117:
--
Attachment: HIVE-23117.2.patch

> Review of HiveStatement Class
> -
>
> Key: HIVE-23117
> URL: https://issues.apache.org/jira/browse/HIVE-23117
> Project: Hive
>  Issue Type: Improvement
>  Components: JDBC
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23117.1.patch, HIVE-23117.2.patch
>
>
> * Remove unused instance variable(s)
>  * Remove non-JavaDoc comments
>  * Make inPlaceUpdateStream Optional (and remove NO-OP class) (inconsistent 
> behavior with 'null' values)
>  * {{getQueryTimeout()}} returns incorrect value
>  * Unify and improve Exception messages
>  * Checkstyle fixes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23267) Reduce dependency on groovy

2020-04-21 Thread Ashutosh Chauhan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Chauhan updated HIVE-23267:

Status: Patch Available  (was: Open)

> Reduce dependency on groovy
> ---
>
> Key: HIVE-23267
> URL: https://issues.apache.org/jira/browse/HIVE-23267
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Planning
>Reporter: Ashutosh Chauhan
>Assignee: Ashutosh Chauhan
>Priority: Major
> Attachments: HIVE-23267.patch
>
>
> Transitively pulled where its unneeded.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23267) Reduce dependency on groovy

2020-04-21 Thread Ashutosh Chauhan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Chauhan updated HIVE-23267:

Attachment: HIVE-23267.patch

> Reduce dependency on groovy
> ---
>
> Key: HIVE-23267
> URL: https://issues.apache.org/jira/browse/HIVE-23267
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Planning
>Reporter: Ashutosh Chauhan
>Assignee: Ashutosh Chauhan
>Priority: Major
> Attachments: HIVE-23267.patch
>
>
> Transitively pulled where its unneeded.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (HIVE-23267) Reduce dependency on groovy

2020-04-21 Thread Ashutosh Chauhan (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Chauhan reassigned HIVE-23267:
---


> Reduce dependency on groovy
> ---
>
> Key: HIVE-23267
> URL: https://issues.apache.org/jira/browse/HIVE-23267
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Planning
>Reporter: Ashutosh Chauhan
>Assignee: Ashutosh Chauhan
>Priority: Major
>
> Transitively pulled where its unneeded.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23243) Accept SQL type like pattern for Show Databases

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089048#comment-17089048
 ] 

Hive QA commented on HIVE-23243:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000677/HIVE-23243.01.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21833/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21833/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21833/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit 
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2020-04-21 20:35:40.598
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-21833/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2020-04-21 20:35:40.601
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 51b810e HIVE-23232: Fix flaky 
TestJdbcWithServiceDiscovery.testKillQueryWithDifferentServerZKTurnedOff (Peter 
Varga, reviewed by Adam Szita)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 51b810e HIVE-23232: Fix flaky 
TestJdbcWithServiceDiscovery.testKillQueryWithDifferentServerZKTurnedOff (Peter 
Varga, reviewed by Adam Szita)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2020-04-21 20:35:41.365
+ rm -rf ../yetus_PreCommit-HIVE-Build-21833
+ mkdir ../yetus_PreCommit-HIVE-Build-21833
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-21833
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-21833/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh 
/data/hiveptest/working/scratch/build.patch
Trying to apply the patch with -p0
Going to apply patch with: git apply -p0
+ [[ maven == \m\a\v\e\n ]]
+ rm -rf /data/hiveptest/working/maven/org/apache/hive
+ mvn -B clean install -DskipTests -T 4 -q 
-Dmaven.repo.local=/data/hiveptest/working/maven
protoc-jar: executing: [/tmp/protoc1035763506454859344.exe, --version]
libprotoc 2.6.1
protoc-jar: executing: [/tmp/protoc1035763506454859344.exe, 
-I/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore,
 
--java_out=/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/target/generated-sources,
 
/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore/metastore.proto]
ANTLR Parser Generator  Version 3.5.2
protoc-jar: executing: [/tmp/protoc7721676232691029186.exe, --version]
libprotoc 2.6.1
ANTLR Parser Generator  Version 3.5.2
Output file 
/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-server/target/generated-sources/org/apache/hadoop/hive/metastore/parser/FilterParser.java
 does not exist: must build 
/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/Filter.g
org/apache/hadoop/hive/metastore/parser/Filter.g
ANTLR Parser Generator  Version 3.5.2
Output file 
/data/hiveptest/working/apache-github-source-source/parser/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HiveLexer.java
 does not exist: must build 
/data/hiveptest/working/apache-github-source-source/parser/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g
org/apache/hadoop/hive/ql/parse/HiveLexer.g
Output file 

[jira] [Commented] (HIVE-23246) Reduce MiniDruidCluster memory requeirements

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089047#comment-17089047
 ] 

Hive QA commented on HIVE-23246:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000675/HIVE-23246.01.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17133 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21832/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21832/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21832/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13000675 - PreCommit-HIVE-Build

> Reduce MiniDruidCluster memory requeirements
> 
>
> Key: HIVE-23246
> URL: https://issues.apache.org/jira/browse/HIVE-23246
> Project: Hive
>  Issue Type: Sub-task
>  Components: Test
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-23246.01.patch, HIVE-23246.01.patch
>
>
> this is needed to enable the druid and kafka related cli tests to be run 
> reliably with at most 8G of memory
> * reduce processing buffer size to 10M  (from 200M)
> * set Xmx512m for spawned peon processes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23259) Fix Apache Rat validation

2020-04-21 Thread Jira


 [ 
https://issues.apache.org/jira/browse/HIVE-23259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ismaël Mejía updated HIVE-23259:

Resolution: Won't Fix
Status: Resolved  (was: Patch Available)

> Fix Apache Rat validation 
> --
>
> Key: HIVE-23259
> URL: https://issues.apache.org/jira/browse/HIVE-23259
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore, Standalone Metastore
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>Priority: Trivial
> Attachments: HIVE-23259.patch
>
>
> The headers for two files merged as part of HIVE-22750 did not include the 
> Apache headers, this issue is to add it and unlock the validation to pass.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23259) Fix Apache Rat validation

2020-04-21 Thread Jira


[ 
https://issues.apache.org/jira/browse/HIVE-23259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089042#comment-17089042
 ] 

Ismaël Mejía commented on HIVE-23259:
-

Ok I will close this issue then.

> Fix Apache Rat validation 
> --
>
> Key: HIVE-23259
> URL: https://issues.apache.org/jira/browse/HIVE-23259
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore, Standalone Metastore
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>Priority: Trivial
> Attachments: HIVE-23259.patch
>
>
> The headers for two files merged as part of HIVE-22750 did not include the 
> Apache headers, this issue is to add it and unlock the validation to pass.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (HIVE-23259) Fix Apache Rat validation

2020-04-21 Thread Jira


[ 
https://issues.apache.org/jira/browse/HIVE-23259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089042#comment-17089042
 ] 

Ismaël Mejía edited comment on HIVE-23259 at 4/21/20, 8:30 PM:
---

Ok I will close this issue then. Thanks for telling me [~abstractdog]


was (Author: iemejia):
Ok I will close this issue then.

> Fix Apache Rat validation 
> --
>
> Key: HIVE-23259
> URL: https://issues.apache.org/jira/browse/HIVE-23259
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore, Standalone Metastore
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>Priority: Trivial
> Attachments: HIVE-23259.patch
>
>
> The headers for two files merged as part of HIVE-22750 did not include the 
> Apache headers, this issue is to add it and unlock the validation to pass.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23246) Reduce MiniDruidCluster memory requeirements

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089017#comment-17089017
 ] 

Hive QA commented on HIVE-23246:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
22s{color} | {color:blue} itests/qtest-druid in master has 7 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
15s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
10s{color} | {color:red} itests/qtest-druid: The patch generated 1 new + 5 
unchanged - 0 fixed = 6 total (was 5) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
15s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 24s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21832/dev-support/hive-personality.sh
 |
| git revision | master / 51b810e |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21832/yetus/diff-checkstyle-itests_qtest-druid.txt
 |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21832/yetus/patch-asflicense-problems.txt
 |
| modules | C: itests/qtest-druid U: itests/qtest-druid |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21832/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Reduce MiniDruidCluster memory requeirements
> 
>
> Key: HIVE-23246
> URL: https://issues.apache.org/jira/browse/HIVE-23246
> Project: Hive
>  Issue Type: Sub-task
>  Components: Test
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-23246.01.patch, HIVE-23246.01.patch
>
>
> this is needed to enable the druid and kafka related cli tests to be run 
> reliably with at most 8G of memory
> * reduce processing buffer size to 10M  (from 200M)
> * set Xmx512m for spawned peon processes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23230) "get_splits" udf ignores limit constraint while creating splits

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089003#comment-17089003
 ] 

Hive QA commented on HIVE-23230:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000674/HIVE-23230.2.patch

{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 15 failed/errored test(s), 17135 tests 
executed
*Failed tests:*
{noformat}
org.apache.hive.jdbc.TestJdbcWithMiniLlapArrow.testComplexQuery (batchId=215)
org.apache.hive.jdbc.TestJdbcWithMiniLlapArrow.testMultipleBatchesOfComplexTypes
 (batchId=215)
org.apache.hive.jdbc.TestJdbcWithMiniLlapRow.testComplexQuery (batchId=216)
org.apache.hive.jdbc.TestJdbcWithMiniLlapRow.testMultipleBatchesOfComplexTypes 
(batchId=216)
org.apache.hive.jdbc.TestJdbcWithMiniLlapVectorArrow.testComplexQuery 
(batchId=218)
org.apache.hive.jdbc.TestJdbcWithMiniLlapVectorArrow.testLlapInputFormatEndToEnd
 (batchId=218)
org.apache.hive.jdbc.TestJdbcWithMiniLlapVectorArrow.testMultipleBatchesOfComplexTypes
 (batchId=218)
org.apache.hive.jdbc.TestJdbcWithMiniLlapVectorArrow.testTypesNestedInListWithLimitAndFilters
 (batchId=218)
org.apache.hive.jdbc.TestJdbcWithMiniLlapVectorArrow.testTypesNestedInMapWithLimitAndFilters
 (batchId=218)
org.apache.hive.jdbc.TestJdbcWithMiniLlapVectorArrowBatch.testLlapInputFormatEndToEndWithMultipleBatches
 (batchId=216)
org.apache.hive.jdbc.TestJdbcWithMiniLlapVectorArrowBatch.testMultipleBatchesOfComplexTypes
 (batchId=216)
org.apache.hive.jdbc.TestNewGetSplitsFormat.testComplexQuery (batchId=216)
org.apache.hive.jdbc.TestNewGetSplitsFormat.testMultipleBatchesOfComplexTypes 
(batchId=216)
org.apache.hive.jdbc.TestNewGetSplitsFormatReturnPath.testComplexQuery 
(batchId=218)
org.apache.hive.jdbc.TestNewGetSplitsFormatReturnPath.testMultipleBatchesOfComplexTypes
 (batchId=218)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21831/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21831/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21831/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 15 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13000674 - PreCommit-HIVE-Build

> "get_splits" udf ignores limit constraint while creating splits
> ---
>
> Key: HIVE-23230
> URL: https://issues.apache.org/jira/browse/HIVE-23230
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2
>Affects Versions: 3.1.0
>Reporter: Adesh Kumar Rao
>Assignee: Adesh Kumar Rao
>Priority: Major
> Attachments: HIVE-23230.1.patch, HIVE-23230.2.patch, HIVE-23230.patch
>
>
> Issue: Running the query {noformat}select * from  limit n{noformat} 
> from spark via hive warehouse connector may return more rows than "n".
> This happens because "get_splits" udf creates splits ignoring the limit 
> constraint. These splits when submitted to multiple llap daemons will return 
> "n" rows each.
> How to reproduce: Needs spark-shell, hive-warehouse-connector and hive on 
> llap with more that 1 llap daemons running.
> run below commands via beeline to create and populate the table
>  
> {noformat}
> create table test (id int);
> insert into table test values (1);
> insert into table test values (2);
> insert into table test values (3);
> insert into table test values (4);
> insert into table test values (5);
> insert into table test values (6);
> insert into table test values (7);
> delete from test where id = 7;{noformat}
> now running below query via spark-shell
> {noformat}
> import com.hortonworks.hwc.HiveWarehouseSession 
> val hive = HiveWarehouseSession.session(spark).build() 
> hive.executeQuery("select * from test limit 1").show()
> {noformat}
> will return more than 1 rows.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23040) Checkpointing for repl dump incremental phase

2020-04-21 Thread PRAVIN KUMAR SINHA (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

PRAVIN KUMAR SINHA updated HIVE-23040:
--
Attachment: (was: HIVE-23040.03.patch)

> Checkpointing for repl dump incremental phase
> -
>
> Key: HIVE-23040
> URL: https://issues.apache.org/jira/browse/HIVE-23040
> Project: Hive
>  Issue Type: Improvement
>Reporter: Aasha Medhi
>Assignee: PRAVIN KUMAR SINHA
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-23040.01.patch, HIVE-23040.02.patch, 
> HIVE-23040.03.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23040) Checkpointing for repl dump incremental phase

2020-04-21 Thread PRAVIN KUMAR SINHA (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

PRAVIN KUMAR SINHA updated HIVE-23040:
--
Attachment: HIVE-23040.03.patch

> Checkpointing for repl dump incremental phase
> -
>
> Key: HIVE-23040
> URL: https://issues.apache.org/jira/browse/HIVE-23040
> Project: Hive
>  Issue Type: Improvement
>Reporter: Aasha Medhi
>Assignee: PRAVIN KUMAR SINHA
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-23040.01.patch, HIVE-23040.02.patch, 
> HIVE-23040.03.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23266) Remove QueryWrapper from ObjectStore

2020-04-21 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23266:
--
Attachment: HIVE-23266.1.patch

> Remove QueryWrapper from ObjectStore
> 
>
> Key: HIVE-23266
> URL: https://issues.apache.org/jira/browse/HIVE-23266
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-23266.1.patch
>
>
> There is currently a utility called {{QueryWrapper}} that makes a normal 
> {{Query}} auto-closable.  However, {{Query}} is now in fact already 
> auto-closing, so there is no need for this class.  In trying to remove it, I 
> realized that this wrapper was being passed around in pretty convoluted ways 
> and also it was sometimes being created in a {{try-with-resources}} block but 
> then never actually used in any way.
> Remove the {{QueryWrapper}} from the class and simplify some of the DB 
> interactions.
> https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L178



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23230) "get_splits" udf ignores limit constraint while creating splits

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088984#comment-17088984
 ] 

Hive QA commented on HIVE-23230:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  2m 
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 4s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
58s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
44s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
29s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
30s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
53s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
21s{color} | {color:red} itests/hive-unit: The patch generated 1 new + 3 
unchanged - 0 fixed = 4 total (was 3) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
26s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
16s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m  9s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21831/dev-support/hive-personality.sh
 |
| git revision | master / 51b810e |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21831/yetus/diff-checkstyle-itests_hive-unit.txt
 |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21831/yetus/patch-asflicense-problems.txt
 |
| modules | C: ql itests/hive-unit U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21831/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> "get_splits" udf ignores limit constraint while creating splits
> ---
>
> Key: HIVE-23230
> URL: https://issues.apache.org/jira/browse/HIVE-23230
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2
>Affects Versions: 3.1.0
>Reporter: Adesh Kumar Rao
>Assignee: Adesh Kumar Rao
>Priority: Major
> Attachments: HIVE-23230.1.patch, HIVE-23230.2.patch, HIVE-23230.patch
>
>
> Issue: Running the query {noformat}select * from  limit n{noformat} 
> from spark via hive warehouse connector may return more rows than "n".
> This happens because "get_splits" udf creates splits ignoring the limit 
> constraint. These splits when submitted to multiple llap daemons will return 
> "n" rows each.
> How to reproduce: Needs spark-shell, hive-warehouse-connector and hive on 
> llap with more that 1 llap 

[jira] [Updated] (HIVE-23266) Remove QueryWrapper from ObjectStore

2020-04-21 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23266:
--
Status: Patch Available  (was: Open)

> Remove QueryWrapper from ObjectStore
> 
>
> Key: HIVE-23266
> URL: https://issues.apache.org/jira/browse/HIVE-23266
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-23266.1.patch
>
>
> There is currently a utility called {{QueryWrapper}} that makes a normal 
> {{Query}} auto-closable.  However, {{Query}} is now in fact already 
> auto-closing, so there is no need for this class.  In trying to remove it, I 
> realized that this wrapper was being passed around in pretty convoluted ways 
> and also it was sometimes being created in a {{try-with-resources}} block but 
> then never actually used in any way.
> Remove the {{QueryWrapper}} from the class and simplify some of the DB 
> interactions.
> https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L178



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23266) Remove QueryWrapper from ObjectStore

2020-04-21 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23266:
--
Description: 
There is currently a utility called {{QueryWrapper}} that makes a normal 
{{Query}} auto-closable.  However, {{Query}} is now in fact already 
auto-closing, so there is no need for this class.  In trying to remove it, I 
realized that this wrapper was being passed around in pretty convoluted ways 
and also it was sometimes being created in a {{try-with-resources}} block but 
then never actually used in any way.

Remove the {{QueryWrapper}} from the class and simplify some of the DB 
interactions.

https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L178

  was:
There is currently a utility called {{QueryWrapper}} that makes a normal 
{{Query}} auto-closable.  However, {{Query}} is now in fact already 
auto-closing, so there is no need for this class.  In trying to remove it, I 
realized that this wrapper was being passed around in pretty convoluted ways 
and also it was sometimes being created in a {{try-with-resources}} block but 
then never actually used in anyway.

Remove the {{QueryWrapper}} from the class and simplify some of the DB 
interactions.

https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L178


> Remove QueryWrapper from ObjectStore
> 
>
> Key: HIVE-23266
> URL: https://issues.apache.org/jira/browse/HIVE-23266
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
>
> There is currently a utility called {{QueryWrapper}} that makes a normal 
> {{Query}} auto-closable.  However, {{Query}} is now in fact already 
> auto-closing, so there is no need for this class.  In trying to remove it, I 
> realized that this wrapper was being passed around in pretty convoluted ways 
> and also it was sometimes being created in a {{try-with-resources}} block but 
> then never actually used in any way.
> Remove the {{QueryWrapper}} from the class and simplify some of the DB 
> interactions.
> https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L178



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (HIVE-23266) Remove QueryWrapper from ObjectStore

2020-04-21 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor reassigned HIVE-23266:
-


> Remove QueryWrapper from ObjectStore
> 
>
> Key: HIVE-23266
> URL: https://issues.apache.org/jira/browse/HIVE-23266
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
>
> There is currently a utility called {{QueryWrapper}} that makes a normal 
> {{Query}} auto-closable.  However, {{Query}} is now in fact already 
> auto-closing, so there is no need for this class.  In trying to remove it, I 
> realized that this wrapper was being passed around in pretty convoluted ways 
> and also it was sometimes being created in a {{try-with-resources}} block but 
> then never actually used in anyway.
> Remove the {{QueryWrapper}} from the class and simplify some of the DB 
> interactions.
> https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L178



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23260) Add support for unmodified_metadata capability

2020-04-21 Thread Naveen Gangam (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Naveen Gangam updated HIVE-23260:
-
Status: Patch Available  (was: Open)

> Add support for unmodified_metadata capability
> --
>
> Key: HIVE-23260
> URL: https://issues.apache.org/jira/browse/HIVE-23260
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Affects Versions: 4.0.0
>Reporter: Naveen Gangam
>Assignee: Naveen Gangam
>Priority: Major
> Attachments: HIVE-23260.patch
>
>
> Currently, the translator removes bucketing info for tables for clients that 
> do not possess the HIVEBUCKET2 capability. While this is desirable, some 
> clients that have write access to these tables can turn around overwrite the 
> metadata thus corrupting original bucketing info.
> So adding support for a capability for client that are capable of 
> interpreting the original metadata would prevent such corruption.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23260) Add support for unmodified_metadata capability

2020-04-21 Thread Naveen Gangam (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Naveen Gangam updated HIVE-23260:
-
Attachment: HIVE-23260.patch

> Add support for unmodified_metadata capability
> --
>
> Key: HIVE-23260
> URL: https://issues.apache.org/jira/browse/HIVE-23260
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Affects Versions: 4.0.0
>Reporter: Naveen Gangam
>Assignee: Naveen Gangam
>Priority: Major
> Attachments: HIVE-23260.patch
>
>
> Currently, the translator removes bucketing info for tables for clients that 
> do not possess the HIVEBUCKET2 capability. While this is desirable, some 
> clients that have write access to these tables can turn around overwrite the 
> metadata thus corrupting original bucketing info.
> So adding support for a capability for client that are capable of 
> interpreting the original metadata would prevent such corruption.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-21304) Show Bucketing version for ReduceSinkOp in explain extended plan

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-21304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088945#comment-17088945
 ] 

Hive QA commented on HIVE-21304:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000672/HIVE-21304.29.patch

{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 17134 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[insert_overwrite_directory]
 (batchId=237)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[timestamptz_2] 
(batchId=37)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[murmur_hash_migration]
 (batchId=100)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut 
(batchId=171)
org.apache.hadoop.hive.ql.exec.TestUtilities.testRemoveTempOrDuplicateFilesOnMrNoDp
 (batchId=292)
org.apache.hadoop.hive.ql.exec.TestUtilities.testRemoveTempOrDuplicateFilesOnMrWithDp
 (batchId=292)
org.apache.hadoop.hive.ql.exec.TestUtilities.testRemoveTempOrDuplicateFilesOnTezNoDp
 (batchId=292)
org.apache.hadoop.hive.ql.exec.TestUtilities.testRemoveTempOrDuplicateFilesOnTezWithDp
 (batchId=292)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21830/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21830/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21830/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 8 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13000672 - PreCommit-HIVE-Build

> Show Bucketing version for ReduceSinkOp in explain extended plan
> 
>
> Key: HIVE-21304
> URL: https://issues.apache.org/jira/browse/HIVE-21304
> Project: Hive
>  Issue Type: Bug
>Reporter: Deepak Jaiswal
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-21304.01.patch, HIVE-21304.02.patch, 
> HIVE-21304.03.patch, HIVE-21304.04.patch, HIVE-21304.05.patch, 
> HIVE-21304.06.patch, HIVE-21304.07.patch, HIVE-21304.08.patch, 
> HIVE-21304.09.patch, HIVE-21304.10.patch, HIVE-21304.11.patch, 
> HIVE-21304.12.patch, HIVE-21304.13.patch, HIVE-21304.14.patch, 
> HIVE-21304.15.patch, HIVE-21304.16.patch, HIVE-21304.17.patch, 
> HIVE-21304.18.patch, HIVE-21304.19.patch, HIVE-21304.20.patch, 
> HIVE-21304.21.patch, HIVE-21304.22.patch, HIVE-21304.23.patch, 
> HIVE-21304.24.patch, HIVE-21304.25.patch, HIVE-21304.26.patch, 
> HIVE-21304.27.patch, HIVE-21304.28.patch, HIVE-21304.29.patch
>
>
> Show Bucketing version for ReduceSinkOp in explain extended plan.
> This helps identify what hashing algorithm is being used by by ReduceSinkOp.
>  
> cc [~vgarg]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23088) Using Strings from log4j breaks non-log4j users

2020-04-21 Thread David Lavati (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088927#comment-17088927
 ] 

David Lavati commented on HIVE-23088:
-

Thank you [~pgaref], I'm not familiar with the state of branch-3, but if my new 
reupload has similar results, I guess it's business as usual. The change is 
probably simple enough to merge it there as well though.

> Using Strings from log4j breaks non-log4j users
> ---
>
> Key: HIVE-23088
> URL: https://issues.apache.org/jira/browse/HIVE-23088
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 3.1.2
>Reporter: Vova Vysotskyi
>Assignee: David Lavati
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0, 3.2.0, 3.1.3
>
> Attachments: HIVE-23088.01.branch-3.patch, 
> HIVE-23088.01.branch-3.patch, HIVE-23088.01.branch-3.patch, 
> HIVE-23088.01.patch, HIVE-23088.01.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> {{HookUtils}} uses explicitly {{org.apache.logging.log4j.util.Strings}} class 
> from log4j, but it may break clients who use other loggers and should exclude 
> log4j from the classpath.
> {{commons-lang}} has class {{StringUtils}} which may be used as a replacement 
> for this one:
>  {{Strings.isBlank}} -> {{StringUtils.isBlank}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23088) Using Strings from log4j breaks non-log4j users

2020-04-21 Thread David Lavati (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Lavati updated HIVE-23088:

Attachment: HIVE-23088.01.branch-3.patch

> Using Strings from log4j breaks non-log4j users
> ---
>
> Key: HIVE-23088
> URL: https://issues.apache.org/jira/browse/HIVE-23088
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 3.1.2
>Reporter: Vova Vysotskyi
>Assignee: David Lavati
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0, 3.2.0, 3.1.3
>
> Attachments: HIVE-23088.01.branch-3.patch, 
> HIVE-23088.01.branch-3.patch, HIVE-23088.01.branch-3.patch, 
> HIVE-23088.01.patch, HIVE-23088.01.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> {{HookUtils}} uses explicitly {{org.apache.logging.log4j.util.Strings}} class 
> from log4j, but it may break clients who use other loggers and should exclude 
> log4j from the classpath.
> {{commons-lang}} has class {{StringUtils}} which may be used as a replacement 
> for this one:
>  {{Strings.isBlank}} -> {{StringUtils.isBlank}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-21304) Show Bucketing version for ReduceSinkOp in explain extended plan

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-21304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088921#comment-17088921
 ] 

Hive QA commented on HIVE-21304:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
55s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
12s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
56s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
31s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
44s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
59s{color} | {color:red} ql: The patch generated 9 new + 1295 unchanged - 10 
fixed = 1304 total (was 1305) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 
17s{color} | {color:red} ql generated 3 new + 1530 unchanged - 0 fixed = 1533 
total (was 1530) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
22s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
16s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m  3s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Suspicious comparison of Integer references in 
org.apache.hadoop.hive.ql.optimizer.BucketVersionPopulator$BucketingVersionResult.merge(BucketVersionPopulator$BucketingVersionResult)
  At BucketVersionPopulator.java:in 
org.apache.hadoop.hive.ql.optimizer.BucketVersionPopulator$BucketingVersionResult.merge(BucketVersionPopulator$BucketingVersionResult)
  At BucketVersionPopulator.java:[line 65] |
|  |  Suspicious comparison of Integer references in 
org.apache.hadoop.hive.ql.optimizer.BucketVersionPopulator$BucketingVersionResult.merge2(BucketVersionPopulator$BucketingVersionResult)
  At BucketVersionPopulator.java:in 
org.apache.hadoop.hive.ql.optimizer.BucketVersionPopulator$BucketingVersionResult.merge2(BucketVersionPopulator$BucketingVersionResult)
  At BucketVersionPopulator.java:[line 75] |
|  |  Nullcheck of table_desc at line 8232 of value previously dereferenced in 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.createFileSinkDesc(String, 
TableDesc, Partition, Path, int, boolean, boolean, boolean, Path, 
SemanticAnalyzer$SortBucketRSCtx, DynamicPartitionCtx, ListBucketingCtx, 
RowSchema, boolean, Table, Long, boolean, Integer, QB, boolean)  At 
SemanticAnalyzer.java:8232 of value previously dereferenced in 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.createFileSinkDesc(String, 
TableDesc, Partition, Path, int, boolean, boolean, boolean, Path, 
SemanticAnalyzer$SortBucketRSCtx, DynamicPartitionCtx, ListBucketingCtx, 
RowSchema, boolean, Table, Long, boolean, Integer, QB, boolean)  At 
SemanticAnalyzer.java:[line 8225] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21830/dev-support/hive-personality.sh
 |
| git revision | master / 

[jira] [Commented] (HIVE-23192) "default" database locationUri should be external warehouse root.

2020-04-21 Thread Naveen Gangam (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088919#comment-17088919
 ] 

Naveen Gangam commented on HIVE-23192:
--

[~samuelan] Could you please review this? Thank you

> "default" database locationUri should be external warehouse root.
> -
>
> Key: HIVE-23192
> URL: https://issues.apache.org/jira/browse/HIVE-23192
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Affects Versions: 4.0.0
>Reporter: Naveen Gangam
>Assignee: Naveen Gangam
>Priority: Major
> Attachments: HIVE-23192.patch, HIVE-23192.patch, HIVE-23192.patch
>
>
> When creating the default database, the database locationUri should be set to 
> external warehouse.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23250) Scheduled query related qtests may not finish before it's expected

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1707#comment-1707
 ] 

Hive QA commented on HIVE-23250:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000669/HIVE-23250.03.patch

{color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17133 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21829/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21829/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21829/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13000669 - PreCommit-HIVE-Build

> Scheduled query related qtests may not finish before it's expected
> --
>
> Key: HIVE-23250
> URL: https://issues.apache.org/jira/browse/HIVE-23250
> Project: Hive
>  Issue Type: Sub-task
>  Components: Test
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-23250.01.patch, HIVE-23250.02.patch, 
> HIVE-23250.03.patch
>
>
> schq_ingest fails intermittently...showing that the query is still executing



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23040) Checkpointing for repl dump incremental phase

2020-04-21 Thread PRAVIN KUMAR SINHA (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

PRAVIN KUMAR SINHA updated HIVE-23040:
--
Attachment: (was: HIVE-23040.03.patch)

> Checkpointing for repl dump incremental phase
> -
>
> Key: HIVE-23040
> URL: https://issues.apache.org/jira/browse/HIVE-23040
> Project: Hive
>  Issue Type: Improvement
>Reporter: Aasha Medhi
>Assignee: PRAVIN KUMAR SINHA
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-23040.01.patch, HIVE-23040.02.patch, 
> HIVE-23040.03.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23040) Checkpointing for repl dump incremental phase

2020-04-21 Thread PRAVIN KUMAR SINHA (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

PRAVIN KUMAR SINHA updated HIVE-23040:
--
Attachment: HIVE-23040.03.patch

> Checkpointing for repl dump incremental phase
> -
>
> Key: HIVE-23040
> URL: https://issues.apache.org/jira/browse/HIVE-23040
> Project: Hive
>  Issue Type: Improvement
>Reporter: Aasha Medhi
>Assignee: PRAVIN KUMAR SINHA
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-23040.01.patch, HIVE-23040.02.patch, 
> HIVE-23040.03.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23265) Duplicate rowsets are returned with Limit and Offset ste

2020-04-21 Thread Chiran Ravani (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chiran Ravani updated HIVE-23265:
-
Description: 
We have a query which produces duplicate results even when there is no 
duplicate records in underlying tables.

Sample Query
{code:java}
select * from orderdatatest_ext order by col1 limit 1000,50
{code}

The problem appears when order by clause is used with col1 having non-unique 
rows. Apparently the duplicates are being produced during reducer phase of the 
query.
set hive.vectorized.execution.reduce.enabled=false does not cause the problem.

Data in table is as follows.
{code:java}
1,1
1,2
1,3
.
.
1,1500
{code}

Results with hive.vectorized.execution.reduce.enabled=true

{code:java}
+-+-+
| orderdatatest_ext.col1  | orderdatatest_ext.col2  |
+-+-+
| 1   | 1001|
| 1   | 1002|
| 1   | 1003|
| 1   | 1004|
| 1   | 1005|
| 1   | 1006|
| 1   | 1007|
| 1   | 1008|
| 1   | 1009|
| 1   | 1010|
| 1   | 1011|
| 1   | 1012|
| 1   | 1013|
| 1   | 1014|
| 1   | 1015|
| 1   | 1016|
| 1   | 1017|
| 1   | 1018|
| 1   | 1019|
| 1   | 1020|
| 1   | 1021|
| 1   | 1022|
| 1   | 1023|
| 1   | 1024|
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
| 1   | 1   |
+-+-+
{code}

Results with hive.vectorized.execution.reduce.enabled=false

{code:java}
+-+-+
| orderdatatest_ext.col1  | orderdatatest_ext.col2  |
+-+-+
| 1   | 1001|
| 1   | 1002|
| 1   | 1003|
| 1   | 1004|
| 1   | 1005|
| 1   | 1006|
| 1   | 1007|
| 1   | 1008|
| 1   | 1009|
| 1   | 1010|
| 1   | 1011|
| 1   | 1012|
| 1   | 1013|
| 1   | 1014|
| 1   | 1015|
| 1   | 1016|
| 1   | 1017|
| 1   | 1018|
| 1   | 1019|
| 1 

[jira] [Work logged] (HIVE-23031) Add option to enable transparent rewrite of count(distinct) into sketch functions

2020-04-21 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23031?focusedWorklogId=425756=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425756
 ]

ASF GitHub Bot logged work on HIVE-23031:
-

Author: ASF GitHub Bot
Created on: 21/Apr/20 16:46
Start Date: 21/Apr/20 16:46
Worklog Time Spent: 10m 
  Work Description: kgyrtkirk opened a new pull request #988:
URL: https://github.com/apache/hive/pull/988


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 425756)
Remaining Estimate: 0h
Time Spent: 10m

> Add option to enable transparent rewrite of count(distinct) into sketch 
> functions
> -
>
> Key: HIVE-23031
> URL: https://issues.apache.org/jira/browse/HIVE-23031
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-23031.01.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23031) Add option to enable transparent rewrite of count(distinct) into sketch functions

2020-04-21 Thread Zoltan Haindrich (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zoltan Haindrich updated HIVE-23031:

Attachment: HIVE-23031.01.patch

> Add option to enable transparent rewrite of count(distinct) into sketch 
> functions
> -
>
> Key: HIVE-23031
> URL: https://issues.apache.org/jira/browse/HIVE-23031
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-23031.01.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23261) Check whether encryption is enabled in the cluster before moving files

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088824#comment-17088824
 ] 

Hive QA commented on HIVE-23261:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000642/HIVE-23261.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17133 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_load_data_to_encrypted_tables]
 (batchId=123)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schq_materialized]
 (batchId=99)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21824/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21824/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21824/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13000642 - PreCommit-HIVE-Build

> Check whether encryption is enabled in the cluster before moving files
> --
>
> Key: HIVE-23261
> URL: https://issues.apache.org/jira/browse/HIVE-23261
> Project: Hive
>  Issue Type: Improvement
>Reporter: Rajesh Balamohan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Minor
> Attachments: HIVE-23261.1.patch
>
>
> Similar to HIVE-23212, there is an unwanted check of encryption paths during 
> file move operation.
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L4546]
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23235) Checkpointing in repl dump failing for orc format

2020-04-21 Thread Aasha Medhi (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aasha Medhi updated HIVE-23235:
---
Status: In Progress  (was: Patch Available)

> Checkpointing in repl dump failing for orc format
> -
>
> Key: HIVE-23235
> URL: https://issues.apache.org/jira/browse/HIVE-23235
> Project: Hive
>  Issue Type: Bug
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
> Attachments: HIVE-23235.01.patch, HIVE-23235.02.patch, 
> HIVE-23235.03.patch, HIVE-23235.04.patch, HIVE-23235.05.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23235) Checkpointing in repl dump failing for orc format

2020-04-21 Thread Aasha Medhi (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aasha Medhi updated HIVE-23235:
---
Attachment: HIVE-23235.05.patch
Status: Patch Available  (was: In Progress)

> Checkpointing in repl dump failing for orc format
> -
>
> Key: HIVE-23235
> URL: https://issues.apache.org/jira/browse/HIVE-23235
> Project: Hive
>  Issue Type: Bug
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
> Attachments: HIVE-23235.01.patch, HIVE-23235.02.patch, 
> HIVE-23235.03.patch, HIVE-23235.04.patch, HIVE-23235.05.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23164) server is not properly terminated because of non-daemon threads

2020-04-21 Thread Eugene Chung (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eugene Chung updated HIVE-23164:

Attachment: HIVE-23164.03.patch
Status: Patch Available  (was: Open)

Shutdown of ScheduledExecutorService made by PerPoolTriggerValidatorRunnable 
makes 4 tests fail. It seems setting its threads as daemon right now.

> server is not properly terminated because of non-daemon threads
> ---
>
> Key: HIVE-23164
> URL: https://issues.apache.org/jira/browse/HIVE-23164
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2
>Reporter: Eugene Chung
>Assignee: Eugene Chung
>Priority: Major
> Attachments: HIVE-23164.01.patch, HIVE-23164.02.patch, 
> HIVE-23164.03.patch, thread_dump_hiveserver2_is_not_terminated.txt
>
>
> HiveServer2 which receives the deregister command is at first preparing 
> shutdown. If there's no remaining session, HiveServer2.stop() is called to 
> shut down. But I found the case that the HiveServer2 JVM is not terminated 
> even if HiveServer2.stop() has been called and processed. The case is always 
> occurred when the local(embedded) metastore is used.
> I've attached the full thread dump describing the situation.
> [^thread_dump_hiveserver2_is_not_terminated.txt]
> In this thread dump, you can see some bunch of 'daemon' threads, NO main 
> thread, and some 'non-daemon' thread(or user thread)s. As specified by 
> [https://www.baeldung.com/java-daemon-thread], if there is at least one user 
> thread exists, JVM does not terminate. (Note that DestroyJavaVM thread is 
> non-daemon but it's special.)
>  
> {code:java}
> "pool-8-thread-1" #24 prio=5 os_prio=0 tid=0x7f52ad1fc000 nid=0x821c 
> waiting on condition [0x7f525c50]
>  java.lang.Thread.State: TIMED_WAITING (parking)
>  at sun.misc.Unsafe.park(Native Method)
>  - parking to wait for <0x0003cfa057c0> (a 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
>  at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
>  at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2078)
>  at 
> java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:1093)
>  at 
> java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:809)
>  at 
> java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1067)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1127)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  at java.lang.Thread.run(Thread.java:748)
> Locked ownable synchronizers:
>  - None
> {code}
> The thread above is created by ScheduledThreadPoolExecutor(int coreSize) with 
> default ThreadFactory which always creates non-daemon thread. If such thread 
> pool is not destroyed with ScheduledThreadPoolExecutor.shutdown() method, JVM 
> cannot terminate! The only way to kill is TERM signal. If JVM receives TERM 
> signal, it ignores non-daemon threads and terminates.
> So I have been digging modules which create ScheduledThreadPoolExecutor with 
> non-daemon threads and I got it. As you may guess, it's the local(embedded) 
> metastore. ScheduledThreadPoolExecutor is created by 
> org.apache.hadoop.hive.metastore.HiveMetaStore.HMSHandler#startAlwaysTaskThreads()
>  and ScheduledThreadPoolExecutor.shutdown() is never called.
> Plus, I found another usage of creating such ScheduledThreadPoolExecutor and 
> not calling its shutdown. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23164) server is not properly terminated because of non-daemon threads

2020-04-21 Thread Eugene Chung (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eugene Chung updated HIVE-23164:

Status: Open  (was: Patch Available)

> server is not properly terminated because of non-daemon threads
> ---
>
> Key: HIVE-23164
> URL: https://issues.apache.org/jira/browse/HIVE-23164
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2
>Reporter: Eugene Chung
>Assignee: Eugene Chung
>Priority: Major
> Attachments: HIVE-23164.01.patch, HIVE-23164.02.patch, 
> thread_dump_hiveserver2_is_not_terminated.txt
>
>
> HiveServer2 which receives the deregister command is at first preparing 
> shutdown. If there's no remaining session, HiveServer2.stop() is called to 
> shut down. But I found the case that the HiveServer2 JVM is not terminated 
> even if HiveServer2.stop() has been called and processed. The case is always 
> occurred when the local(embedded) metastore is used.
> I've attached the full thread dump describing the situation.
> [^thread_dump_hiveserver2_is_not_terminated.txt]
> In this thread dump, you can see some bunch of 'daemon' threads, NO main 
> thread, and some 'non-daemon' thread(or user thread)s. As specified by 
> [https://www.baeldung.com/java-daemon-thread], if there is at least one user 
> thread exists, JVM does not terminate. (Note that DestroyJavaVM thread is 
> non-daemon but it's special.)
>  
> {code:java}
> "pool-8-thread-1" #24 prio=5 os_prio=0 tid=0x7f52ad1fc000 nid=0x821c 
> waiting on condition [0x7f525c50]
>  java.lang.Thread.State: TIMED_WAITING (parking)
>  at sun.misc.Unsafe.park(Native Method)
>  - parking to wait for <0x0003cfa057c0> (a 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
>  at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
>  at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2078)
>  at 
> java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:1093)
>  at 
> java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:809)
>  at 
> java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1067)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1127)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  at java.lang.Thread.run(Thread.java:748)
> Locked ownable synchronizers:
>  - None
> {code}
> The thread above is created by ScheduledThreadPoolExecutor(int coreSize) with 
> default ThreadFactory which always creates non-daemon thread. If such thread 
> pool is not destroyed with ScheduledThreadPoolExecutor.shutdown() method, JVM 
> cannot terminate! The only way to kill is TERM signal. If JVM receives TERM 
> signal, it ignores non-daemon threads and terminates.
> So I have been digging modules which create ScheduledThreadPoolExecutor with 
> non-daemon threads and I got it. As you may guess, it's the local(embedded) 
> metastore. ScheduledThreadPoolExecutor is created by 
> org.apache.hadoop.hive.metastore.HiveMetaStore.HMSHandler#startAlwaysTaskThreads()
>  and ScheduledThreadPoolExecutor.shutdown() is never called.
> Plus, I found another usage of creating such ScheduledThreadPoolExecutor and 
> not calling its shutdown. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-8123) Support parquet ACID

2020-04-21 Thread Abhishek Somani (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088800#comment-17088800
 ] 

Abhishek Somani commented on HIVE-8123:
---

[~gopalv] [~pvary] [~omalley] Can you please take a look at the above design 
doc. We have made some progress and will upload a patch soon as well, working 
on test cases right now.

> Support parquet ACID
> 
>
> Key: HIVE-8123
> URL: https://issues.apache.org/jira/browse/HIVE-8123
> Project: Hive
>  Issue Type: Task
>Reporter: Brock Noland
>Assignee: Ferdinand Xu
>Priority: Major
>
> Hive "ACID" work currently only works with ORC. It should work with Parquet 
> as well. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23261) Check whether encryption is enabled in the cluster before moving files

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088791#comment-17088791
 ] 

Hive QA commented on HIVE-23261:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
46s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
56s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
57s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
6s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
43s{color} | {color:red} ql: The patch generated 1 new + 193 unchanged - 1 
fixed = 194 total (was 194) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
15s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 28s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21824/dev-support/hive-personality.sh
 |
| git revision | master / 51b810e |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21824/yetus/diff-checkstyle-ql.txt
 |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21824/yetus/patch-asflicense-problems.txt
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21824/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Check whether encryption is enabled in the cluster before moving files
> --
>
> Key: HIVE-23261
> URL: https://issues.apache.org/jira/browse/HIVE-23261
> Project: Hive
>  Issue Type: Improvement
>Reporter: Rajesh Balamohan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Minor
> Attachments: HIVE-23261.1.patch
>
>
> Similar to HIVE-23212, there is an unwanted check of encryption paths during 
> file move operation.
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L4546]
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23216) Add new api as replacement of get_partitions_by_expr to return PartitionSpec instead of Partitions

2020-04-21 Thread Vineet Garg (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vineet Garg updated HIVE-23216:
---
Status: Patch Available  (was: Open)

> Add new api as replacement of get_partitions_by_expr to return PartitionSpec 
> instead of Partitions
> --
>
> Key: HIVE-23216
> URL: https://issues.apache.org/jira/browse/HIVE-23216
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Affects Versions: 4.0.0
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Attachments: HIVE-23216.1.patch, HIVE-23216.2.patch, 
> HIVE-23216.3.patch, HIVE-23216.4.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23216) Add new api as replacement of get_partitions_by_expr to return PartitionSpec instead of Partitions

2020-04-21 Thread Vineet Garg (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vineet Garg updated HIVE-23216:
---
Attachment: HIVE-23216.4.patch

> Add new api as replacement of get_partitions_by_expr to return PartitionSpec 
> instead of Partitions
> --
>
> Key: HIVE-23216
> URL: https://issues.apache.org/jira/browse/HIVE-23216
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Affects Versions: 4.0.0
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Attachments: HIVE-23216.1.patch, HIVE-23216.2.patch, 
> HIVE-23216.3.patch, HIVE-23216.4.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23216) Add new api as replacement of get_partitions_by_expr to return PartitionSpec instead of Partitions

2020-04-21 Thread Vineet Garg (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vineet Garg updated HIVE-23216:
---
Status: Open  (was: Patch Available)

> Add new api as replacement of get_partitions_by_expr to return PartitionSpec 
> instead of Partitions
> --
>
> Key: HIVE-23216
> URL: https://issues.apache.org/jira/browse/HIVE-23216
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Affects Versions: 4.0.0
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Attachments: HIVE-23216.1.patch, HIVE-23216.2.patch, 
> HIVE-23216.3.patch, HIVE-23216.4.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23040) Checkpointing for repl dump incremental phase

2020-04-21 Thread PRAVIN KUMAR SINHA (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

PRAVIN KUMAR SINHA updated HIVE-23040:
--
Attachment: HIVE-23040.03.patch

> Checkpointing for repl dump incremental phase
> -
>
> Key: HIVE-23040
> URL: https://issues.apache.org/jira/browse/HIVE-23040
> Project: Hive
>  Issue Type: Improvement
>Reporter: Aasha Medhi
>Assignee: PRAVIN KUMAR SINHA
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-23040.01.patch, HIVE-23040.02.patch, 
> HIVE-23040.03.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-19064) Add mode to support delimited identifiers enclosed within double quotation

2020-04-21 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-19064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-19064:
--
Status: Patch Available  (was: Open)

> Add mode to support delimited identifiers enclosed within double quotation
> --
>
> Key: HIVE-19064
> URL: https://issues.apache.org/jira/browse/HIVE-19064
> Project: Hive
>  Issue Type: Improvement
>  Components: Parser, SQL
>Affects Versions: 3.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-19064.01.patch, HIVE-19064.02.patch, 
> HIVE-19064.03.patch, HIVE-19064.4.patch, HIVE-19064.5.patch
>
>
> As per SQL standard. Hive currently uses `` (backticks). Default will 
> continue being backticks, but we will support identifiers within double 
> quotation via configuration parameter.
> This issue will also extends support for arbitrary char sequences, e.g., 
> containing {{~ ! @ # $ % ^ & * () , < >}}, in database and table names. 
> Currently, special characters are only supported for column names.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-19064) Add mode to support delimited identifiers enclosed within double quotation

2020-04-21 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-19064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-19064:
--
Attachment: HIVE-19064.5.patch

> Add mode to support delimited identifiers enclosed within double quotation
> --
>
> Key: HIVE-19064
> URL: https://issues.apache.org/jira/browse/HIVE-19064
> Project: Hive
>  Issue Type: Improvement
>  Components: Parser, SQL
>Affects Versions: 3.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-19064.01.patch, HIVE-19064.02.patch, 
> HIVE-19064.03.patch, HIVE-19064.4.patch, HIVE-19064.5.patch
>
>
> As per SQL standard. Hive currently uses `` (backticks). Default will 
> continue being backticks, but we will support identifiers within double 
> quotation via configuration parameter.
> This issue will also extends support for arbitrary char sequences, e.g., 
> containing {{~ ! @ # $ % ^ & * () , < >}}, in database and table names. 
> Currently, special characters are only supported for column names.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-19064) Add mode to support delimited identifiers enclosed within double quotation

2020-04-21 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-19064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-19064:
--
Status: Open  (was: Patch Available)

> Add mode to support delimited identifiers enclosed within double quotation
> --
>
> Key: HIVE-19064
> URL: https://issues.apache.org/jira/browse/HIVE-19064
> Project: Hive
>  Issue Type: Improvement
>  Components: Parser, SQL
>Affects Versions: 3.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-19064.01.patch, HIVE-19064.02.patch, 
> HIVE-19064.03.patch, HIVE-19064.4.patch, HIVE-19064.5.patch
>
>
> As per SQL standard. Hive currently uses `` (backticks). Default will 
> continue being backticks, but we will support identifiers within double 
> quotation via configuration parameter.
> This issue will also extends support for arbitrary char sequences, e.g., 
> containing {{~ ! @ # $ % ^ & * () , < >}}, in database and table names. 
> Currently, special characters are only supported for column names.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-19064) Add mode to support delimited identifiers enclosed within double quotation

2020-04-21 Thread Krisztian Kasa (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-19064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krisztian Kasa updated HIVE-19064:
--
Target Version/s: 4.0.0  (was: 3.0.0)

> Add mode to support delimited identifiers enclosed within double quotation
> --
>
> Key: HIVE-19064
> URL: https://issues.apache.org/jira/browse/HIVE-19064
> Project: Hive
>  Issue Type: Improvement
>  Components: Parser, SQL
>Affects Versions: 3.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Krisztian Kasa
>Priority: Major
> Attachments: HIVE-19064.01.patch, HIVE-19064.02.patch, 
> HIVE-19064.03.patch, HIVE-19064.4.patch, HIVE-19064.5.patch
>
>
> As per SQL standard. Hive currently uses `` (backticks). Default will 
> continue being backticks, but we will support identifiers within double 
> quotation via configuration parameter.
> This issue will also extends support for arbitrary char sequences, e.g., 
> containing {{~ ! @ # $ % ^ & * () , < >}}, in database and table names. 
> Currently, special characters are only supported for column names.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23236) Remove the global lock from acquireLock

2020-04-21 Thread Marton Bod (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marton Bod updated HIVE-23236:
--
Attachment: HIVE-23236.2.patch

> Remove the global lock from acquireLock
> ---
>
> Key: HIVE-23236
> URL: https://issues.apache.org/jira/browse/HIVE-23236
> Project: Hive
>  Issue Type: Improvement
>Reporter: Marton Bod
>Assignee: Marton Bod
>Priority: Major
> Attachments: HIVE-23236.1.patch, HIVE-23236.2.patch
>
>
> Currently we have a global lock (NEXT_LOCK_ID) when running enqueueLock, 
> because the algorithm in checkLock requires the locks to have a well defined 
> order, and also requires that every lock component is already stored in the 
> RDBMS before checking the locks.
> Proposed approach:
>  * Enqueue locks without a global S4U lock, using an auto-incremented value 
> instead to get the next lock ID (modify next_lock_id table)
>  * Before checking for lock conflicts, issue a S4U for all lock components we 
> are requesting (db/table/partition level) in order to prevent other clients 
> for doing interleaving conflict check (especially late-coming clients holding 
> a lower lockID)
>  * Conflict check algorithm to check not just for lower lockIDs, but also 
> higher lockIDs which are already in 'acquired' state



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23235) Checkpointing in repl dump failing for orc format

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088765#comment-17088765
 ] 

Hive QA commented on HIVE-23235:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000687/HIVE-23235.04.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 165 failed/errored test(s), 17137 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[exim_11_managed_external]
 (batchId=107)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[exim_15_external_part]
 (batchId=86)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[exim_18_part_external]
 (batchId=108)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[mm_conversions]
 (batchId=110)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[mm_exim] 
(batchId=120)
org.apache.hadoop.hive.ql.TestTxnAddPartition.addPartitionBucketed (batchId=296)
org.apache.hadoop.hive.ql.TestTxnAddPartition.addPartitionMM (batchId=296)
org.apache.hadoop.hive.ql.TestTxnAddPartition.addPartitionRename (batchId=296)
org.apache.hadoop.hive.ql.TestTxnCommands.testMmExim (batchId=299)
org.apache.hadoop.hive.ql.TestTxnCommandsWithSplitUpdateAndVectorization.testMmExim
 (batchId=275)
org.apache.hadoop.hive.ql.TestTxnExIm.testExportBucketed (batchId=277)
org.apache.hadoop.hive.ql.TestTxnExIm.testImport (batchId=277)
org.apache.hadoop.hive.ql.TestTxnExIm.testImportNoTarget (batchId=277)
org.apache.hadoop.hive.ql.TestTxnExIm.testImportPartitioned (batchId=277)
org.apache.hadoop.hive.ql.TestTxnExIm.testImportPartitionedCreate (batchId=277)
org.apache.hadoop.hive.ql.TestTxnExIm.testImportPartitionedCreate2 (batchId=277)
org.apache.hadoop.hive.ql.TestTxnExIm.testImportPartitionedOrc (batchId=277)
org.apache.hadoop.hive.ql.TestTxnExIm.testImportVectorized (batchId=277)
org.apache.hadoop.hive.ql.TestTxnExIm.testMM (batchId=277)
org.apache.hadoop.hive.ql.TestTxnExIm.testMMCreate (batchId=277)
org.apache.hadoop.hive.ql.TestTxnExIm.testMMFlatSource (batchId=277)
org.apache.hadoop.hive.ql.TestTxnLoadData.loadDataNonAcid2AcidConversion 
(batchId=246)
org.apache.hadoop.hive.ql.TestTxnLoadData.loadDataNonAcid2AcidConversionVectorized
 (batchId=246)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testAddPartitionLocks 
(batchId=300)
org.apache.hadoop.hive.ql.parse.TestCopyUtils.testPrivilegedDistCpWithSameUserAsCurrentDoesNotTryToImpersonate
 (batchId=206)
org.apache.hadoop.hive.ql.parse.TestMetaStoreEventListenerInRepl.testReplEvents 
(batchId=181)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesBootstrapWithJsonMessage.retryIncBootstrapAcidFromDifferentDumpWithoutCleanTablesConfig
 (batchId=183)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesBootstrapWithJsonMessage.testAcidTablesBootstrapDuringIncremental
 (batchId=183)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesBootstrapWithJsonMessage.testAcidTablesBootstrapDuringIncrementalWithOpenTxnsTimeout
 (batchId=183)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesBootstrapWithJsonMessage.testBootstrapAcidTablesDuringIncrementalWithConcurrentWrites
 (batchId=183)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesBootstrapWithJsonMessage.testRetryAcidTablesBootstrapFromDifferentDump
 (batchId=183)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidBootstrapReplLoadRetryAfterFailure
 (batchId=200)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesBootstrap
 (batchId=200)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesBootstrapWithConcurrentDropTable
 (batchId=200)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesBootstrapWithConcurrentWrites
 (batchId=200)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesBootstrapWithOpenTxnsTimeout
 (batchId=200)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesMoveOptimizationBootStrap
 (batchId=200)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testAcidTablesMoveOptimizationIncremental
 (batchId=200)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testCheckPointingDataDumpFailure
 (batchId=200)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testCheckPointingDataDumpFailureORCTableDistcpCopy
 (batchId=200)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testCheckPointingDataDumpFailureORCTableRegularCopy
 (batchId=200)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testCheckPointingDataDumpFailureRegularCopy
 (batchId=200)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesWithJsonMessage.testCheckPointingMetadataDumpFailure
 (batchId=200)

[jira] [Commented] (HIVE-23124) Review of SQLOperation Class

2020-04-21 Thread David Mollitor (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088759#comment-17088759
 ] 

David Mollitor commented on HIVE-23124:
---

[~pvary] I put up a new patch to remove {{Callable}}.  Thanks.

We cannot use {{computeIfAbsent}} here, instead just using {{compute}}.  
{{computeIfAbsent}} is good in situations where multiple threads are building 
up a Map for display or further processing, however, since in this scenario, 
there are threads adding and removing from the {{Map}}, the {{Map}} needs to be 
locked down more tightly, otherwise, there are subtle race conditions, because 
one thread is computing an (absent) value, and then modifying that value, while 
another thread may sweep in between the compute and the increment and remove 
the value first, in which case, the first thread is increment a dead value.

> Review of SQLOperation Class
> 
>
> Key: HIVE-23124
> URL: https://issues.apache.org/jira/browse/HIVE-23124
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-23124.1.patch, HIVE-23124.2.patch
>
>
> * Use ConcurrentHashMap instead of synchronized methods to improve 
> multi-threaded access
>  * Use JDK 8 facilities where applicable
>  * General cleanup
>  * Better log messages and Exception messages
>  * Use {{switch}} statement instead of if/else blocks
>  * Checkstyle fixes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23124) Review of SQLOperation Class

2020-04-21 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23124:
--
Attachment: HIVE-23124.2.patch

> Review of SQLOperation Class
> 
>
> Key: HIVE-23124
> URL: https://issues.apache.org/jira/browse/HIVE-23124
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-23124.1.patch, HIVE-23124.2.patch
>
>
> * Use ConcurrentHashMap instead of synchronized methods to improve 
> multi-threaded access
>  * Use JDK 8 facilities where applicable
>  * General cleanup
>  * Better log messages and Exception messages
>  * Use {{switch}} statement instead of if/else blocks
>  * Checkstyle fixes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23124) Review of SQLOperation Class

2020-04-21 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23124:
--
Attachment: (was: HIVE-23124.2.patch)

> Review of SQLOperation Class
> 
>
> Key: HIVE-23124
> URL: https://issues.apache.org/jira/browse/HIVE-23124
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-23124.1.patch
>
>
> * Use ConcurrentHashMap instead of synchronized methods to improve 
> multi-threaded access
>  * Use JDK 8 facilities where applicable
>  * General cleanup
>  * Better log messages and Exception messages
>  * Use {{switch}} statement instead of if/else blocks
>  * Checkstyle fixes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23124) Review of SQLOperation Class

2020-04-21 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23124:
--
Attachment: HIVE-23124.2.patch

> Review of SQLOperation Class
> 
>
> Key: HIVE-23124
> URL: https://issues.apache.org/jira/browse/HIVE-23124
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-23124.1.patch, HIVE-23124.2.patch
>
>
> * Use ConcurrentHashMap instead of synchronized methods to improve 
> multi-threaded access
>  * Use JDK 8 facilities where applicable
>  * General cleanup
>  * Better log messages and Exception messages
>  * Use {{switch}} statement instead of if/else blocks
>  * Checkstyle fixes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23235) Checkpointing in repl dump failing for orc format

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088753#comment-17088753
 ] 

Hive QA commented on HIVE-23235:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
54s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 3s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
52s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
43s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
26s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
31s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
25s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
15s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 32m 24s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21823/dev-support/hive-personality.sh
 |
| git revision | master / 51b810e |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21823/yetus/patch-asflicense-problems.txt
 |
| modules | C: ql itests/hive-unit U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21823/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Checkpointing in repl dump failing for orc format
> -
>
> Key: HIVE-23235
> URL: https://issues.apache.org/jira/browse/HIVE-23235
> Project: Hive
>  Issue Type: Bug
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
> Attachments: HIVE-23235.01.patch, HIVE-23235.02.patch, 
> HIVE-23235.03.patch, HIVE-23235.04.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23176) Remove SELECT REGEX Column Feature

2020-04-21 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23176:
--
Labels: backwards-incompatible  (was: )

> Remove SELECT REGEX Column Feature
> --
>
> Key: HIVE-23176
> URL: https://issues.apache.org/jira/browse/HIVE-23176
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
>  Labels: backwards-incompatible
> Attachments: HIVE-23176.1.patch, HIVE-23176.2.patch, 
> HIVE-23176.3.patch, HIVE-23176.4.patch, HIVE-23176.4.patch, HIVE-23176.4.patch
>
>
> Remove the Hive feature: REGEX Column.
>  
> Hive has this interesting feature for doing REGEX to SELECT multiple columns. 
>  This needs to go.  It is not SQL standard and as currently implemented, it 
> is impossible to determine if a column identifier is a REGEX or the actual 
> name of the column.  If a column name is enclosed in back ticks then any 
> UTF-8 character is a valid table name.
>  
> [https://dev.mysql.com/doc/refman/8.0/en/identifiers.html]
> [https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Select]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23264) Make partition_wise_fileformat12.q deterministic with order by clauses

2020-04-21 Thread Jira


[ 
https://issues.apache.org/jira/browse/HIVE-23264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088732#comment-17088732
 ] 

László Bodor commented on HIVE-23264:
-

+1

> Make partition_wise_fileformat12.q deterministic with order by clauses
> --
>
> Key: HIVE-23264
> URL: https://issues.apache.org/jira/browse/HIVE-23264
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Attachments: HIVE-23264.01.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23264) Make partition_wise_fileformat12.q deterministic with order by clauses

2020-04-21 Thread Miklos Gergely (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miklos Gergely updated HIVE-23264:
--
Status: Patch Available  (was: Open)

> Make partition_wise_fileformat12.q deterministic with order by clauses
> --
>
> Key: HIVE-23264
> URL: https://issues.apache.org/jira/browse/HIVE-23264
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Attachments: HIVE-23264.01.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23264) Make partition_wise_fileformat12.q deterministic with order by clauses

2020-04-21 Thread Miklos Gergely (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miklos Gergely updated HIVE-23264:
--
Attachment: HIVE-23264.01.patch

> Make partition_wise_fileformat12.q deterministic with order by clauses
> --
>
> Key: HIVE-23264
> URL: https://issues.apache.org/jira/browse/HIVE-23264
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Attachments: HIVE-23264.01.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (HIVE-23264) Make partition_wise_fileformat12.q deterministic with order by clauses

2020-04-21 Thread Miklos Gergely (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miklos Gergely reassigned HIVE-23264:
-


> Make partition_wise_fileformat12.q deterministic with order by clauses
> --
>
> Key: HIVE-23264
> URL: https://issues.apache.org/jira/browse/HIVE-23264
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23236) Remove the global lock from acquireLock

2020-04-21 Thread Marton Bod (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marton Bod updated HIVE-23236:
--
Attachment: HIVE-23236.1.patch

> Remove the global lock from acquireLock
> ---
>
> Key: HIVE-23236
> URL: https://issues.apache.org/jira/browse/HIVE-23236
> Project: Hive
>  Issue Type: Improvement
>Reporter: Marton Bod
>Assignee: Marton Bod
>Priority: Major
> Attachments: HIVE-23236.1.patch
>
>
> Currently we have a global lock (NEXT_LOCK_ID) when running enqueueLock, 
> because the algorithm in checkLock requires the locks to have a well defined 
> order, and also requires that every lock component is already stored in the 
> RDBMS before checking the locks.
> Proposed approach:
>  * Enqueue locks without a global S4U lock, using an auto-incremented value 
> instead to get the next lock ID (modify next_lock_id table)
>  * Before checking for lock conflicts, issue a S4U for all lock components we 
> are requesting (db/table/partition level) in order to prevent other clients 
> for doing interleaving conflict check (especially late-coming clients holding 
> a lower lockID)
>  * Conflict check algorithm to check not just for lower lockIDs, but also 
> higher lockIDs which are already in 'acquired' state



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23236) Remove the global lock from acquireLock

2020-04-21 Thread Marton Bod (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marton Bod updated HIVE-23236:
--
Attachment: (was: HIVE-23236.1.patch)

> Remove the global lock from acquireLock
> ---
>
> Key: HIVE-23236
> URL: https://issues.apache.org/jira/browse/HIVE-23236
> Project: Hive
>  Issue Type: Improvement
>Reporter: Marton Bod
>Assignee: Marton Bod
>Priority: Major
> Attachments: HIVE-23236.1.patch
>
>
> Currently we have a global lock (NEXT_LOCK_ID) when running enqueueLock, 
> because the algorithm in checkLock requires the locks to have a well defined 
> order, and also requires that every lock component is already stored in the 
> RDBMS before checking the locks.
> Proposed approach:
>  * Enqueue locks without a global S4U lock, using an auto-incremented value 
> instead to get the next lock ID (modify next_lock_id table)
>  * Before checking for lock conflicts, issue a S4U for all lock components we 
> are requesting (db/table/partition level) in order to prevent other clients 
> for doing interleaving conflict check (especially late-coming clients holding 
> a lower lockID)
>  * Conflict check algorithm to check not just for lower lockIDs, but also 
> higher lockIDs which are already in 'acquired' state



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23192) "default" database locationUri should be external warehouse root.

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088717#comment-17088717
 ] 

Hive QA commented on HIVE-23192:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000627/HIVE-23192.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17133 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21822/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21822/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21822/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13000627 - PreCommit-HIVE-Build

> "default" database locationUri should be external warehouse root.
> -
>
> Key: HIVE-23192
> URL: https://issues.apache.org/jira/browse/HIVE-23192
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Affects Versions: 4.0.0
>Reporter: Naveen Gangam
>Assignee: Naveen Gangam
>Priority: Major
> Attachments: HIVE-23192.patch, HIVE-23192.patch, HIVE-23192.patch
>
>
> When creating the default database, the database locationUri should be set to 
> external warehouse.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23258) Remove BoneCP Connection Pool

2020-04-21 Thread David Mollitor (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088679#comment-17088679
 ] 

David Mollitor commented on HIVE-23258:
---

[~szita] Yes.  I have added the label.  Like I said, the default in Hive 3 is 
already HikariCP, so we are talking about a very small pool of people that 
bothered to explicitly configure this.

> Remove BoneCP Connection Pool
> -
>
> Key: HIVE-23258
> URL: https://issues.apache.org/jira/browse/HIVE-23258
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
>  Labels: backwards-incompatible
> Fix For: 4.0.0
>
> Attachments: HIVE-23258.1.patch
>
>
> {quote}
> BoneCP is a Java JDBC connection pool implementation that is tuned for high 
> performance by minimizing lock contention to give greater throughput for your 
> application ... but SHOULD NOW BE CONSIDERED DEPRECATED in favour of HikariCP.
> {quote}
> https://github.com/wwadge/bonecp
> The default in Hive 3.x is already HikariCP, so just remove BoneCP in 4.x
> https://github.com/apache/hive/blob/branch-3.1/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java#L392



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23192) "default" database locationUri should be external warehouse root.

2020-04-21 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-23192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088676#comment-17088676
 ] 

Hive QA commented on HIVE-23192:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
23s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m 
19s{color} | {color:blue} standalone-metastore/metastore-server in master has 
190 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
21s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
15s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m 13s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21822/dev-support/hive-personality.sh
 |
| git revision | master / 51b810e |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21822/yetus/patch-asflicense-problems.txt
 |
| modules | C: standalone-metastore/metastore-server U: 
standalone-metastore/metastore-server |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21822/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> "default" database locationUri should be external warehouse root.
> -
>
> Key: HIVE-23192
> URL: https://issues.apache.org/jira/browse/HIVE-23192
> Project: Hive
>  Issue Type: Sub-task
>  Components: Hive
>Affects Versions: 4.0.0
>Reporter: Naveen Gangam
>Assignee: Naveen Gangam
>Priority: Major
> Attachments: HIVE-23192.patch, HIVE-23192.patch, HIVE-23192.patch
>
>
> When creating the default database, the database locationUri should be set to 
> external warehouse.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HIVE-23258) Remove BoneCP Connection Pool

2020-04-21 Thread David Mollitor (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-23258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23258:
--
Labels: backwards-incompatible  (was: )

> Remove BoneCP Connection Pool
> -
>
> Key: HIVE-23258
> URL: https://issues.apache.org/jira/browse/HIVE-23258
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
>  Labels: backwards-incompatible
> Fix For: 4.0.0
>
> Attachments: HIVE-23258.1.patch
>
>
> {quote}
> BoneCP is a Java JDBC connection pool implementation that is tuned for high 
> performance by minimizing lock contention to give greater throughput for your 
> application ... but SHOULD NOW BE CONSIDERED DEPRECATED in favour of HikariCP.
> {quote}
> https://github.com/wwadge/bonecp
> The default in Hive 3.x is already HikariCP, so just remove BoneCP in 4.x
> https://github.com/apache/hive/blob/branch-3.1/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java#L392



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-23263) Add fix order to cbo_rp_limit.q queries + improve readability

2020-04-21 Thread Jira


[ 
https://issues.apache.org/jira/browse/HIVE-23263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088663#comment-17088663
 ] 

László Bodor commented on HIVE-23263:
-

+1

> Add fix order to cbo_rp_limit.q queries + improve readability
> -
>
> Key: HIVE-23263
> URL: https://issues.apache.org/jira/browse/HIVE-23263
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-23263.01.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   >