[jira] [Updated] (HIVE-24197) Check for write transactions for the db under replication at a frequent interval

2020-10-11 Thread Anishek Agarwal (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-24197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anishek Agarwal updated HIVE-24197:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

Committed to master. Thanks for the patch [~aasha] and review [~pkumarsinha]

> Check for write transactions for the db under replication at a frequent 
> interval
> 
>
> Key: HIVE-24197
> URL: https://issues.apache.org/jira/browse/HIVE-24197
> Project: Hive
>  Issue Type: Task
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-24197.01.patch, HIVE-24197.02.patch, 
> HIVE-24197.03.patch, HIVE-24197.04.patch, HIVE-24197.05.patch, 
> HIVE-24197.06.patch, HIVE-24197.07.patch, HIVE-24197.08.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-24254) Remove setOwner call in ReplChangeManager

2020-10-11 Thread Anishek Agarwal (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-24254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anishek Agarwal updated HIVE-24254:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

Thanks for the patch [~aasha] and review [~pkumarsinha]. Patch committed to 
master.

> Remove setOwner call in ReplChangeManager
> -
>
> Key: HIVE-24254
> URL: https://issues.apache.org/jira/browse/HIVE-24254
> Project: Hive
>  Issue Type: Task
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-24254.01.patch, HIVE-24254.02.patch, 
> HIVE-24254.03.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-23989) Read isMetastoreRemote flag from system var in StartMiniHS2Cluster

2020-10-11 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23989?focusedWorklogId=499127=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-499127
 ]

ASF GitHub Bot logged work on HIVE-23989:
-

Author: ASF GitHub Bot
Created on: 12/Oct/20 00:55
Start Date: 12/Oct/20 00:55
Worklog Time Spent: 10m 
  Work Description: github-actions[bot] closed pull request #1360:
URL: https://github.com/apache/hive/pull/1360


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 499127)
Time Spent: 40m  (was: 0.5h)

> Read isMetastoreRemote flag from system var in StartMiniHS2Cluster
> --
>
> Key: HIVE-23989
> URL: https://issues.apache.org/jira/browse/HIVE-23989
> Project: Hive
>  Issue Type: Improvement
>  Components: HiveServer2
>Reporter: Sumeet
>Assignee: Sumeet
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 4.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> *Problem:*
> In order to access ACID tables created using MiniHS2, spark-acid requires to 
> access the same HMS which MiniHS2 uses. 
> In StartMiniHS2Cluster, while initializing MiniHS2, isMetastoreRemote is set 
> to false. 
> Hence the metastore cannot be accessed from Spark or any other application 
> per se. 
> Due to this limitation, spark-acid cannot be tested on ACID tables created 
> using MiniHS2.
> *Proposed Solution:*
> Read miniHS2.isMetastoreRemote from env variable with default value of false.
> *Benefit:*
> This will enable testing spark-acid locally with MiniHS2 and may help in 
> reducing the test-dev cycle for spark-acid.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-23993) Handle irrecoverable errors

2020-10-11 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23993?focusedWorklogId=499130=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-499130
 ]

ASF GitHub Bot logged work on HIVE-23993:
-

Author: ASF GitHub Bot
Created on: 12/Oct/20 00:55
Start Date: 12/Oct/20 00:55
Worklog Time Spent: 10m 
  Work Description: github-actions[bot] commented on pull request #1367:
URL: https://github.com/apache/hive/pull/1367#issuecomment-706799956


   This pull request has been automatically marked as stale because it has not 
had recent activity. It will be closed if no further activity occurs.
   Feel free to reach out on the d...@hive.apache.org list if the patch is in 
need of reviews.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 499130)
Time Spent: 2h 20m  (was: 2h 10m)

> Handle irrecoverable errors
> ---
>
> Key: HIVE-23993
> URL: https://issues.apache.org/jira/browse/HIVE-23993
> Project: Hive
>  Issue Type: Task
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-23993.01.patch, HIVE-23993.02.patch, 
> HIVE-23993.03.patch, HIVE-23993.04.patch, HIVE-23993.05.patch, 
> HIVE-23993.06.patch, HIVE-23993.07.patch, HIVE-23993.08.patch, Retry Logic 
> for Replication.pdf
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-23916) Fix Atlas client dependency version

2020-10-11 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23916?focusedWorklogId=499129=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-499129
 ]

ASF GitHub Bot logged work on HIVE-23916:
-

Author: ASF GitHub Bot
Created on: 12/Oct/20 00:55
Start Date: 12/Oct/20 00:55
Worklog Time Spent: 10m 
  Work Description: github-actions[bot] closed pull request #1318:
URL: https://github.com/apache/hive/pull/1318


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 499129)
Time Spent: 1h  (was: 50m)

> Fix Atlas client dependency version
> ---
>
> Key: HIVE-23916
> URL: https://issues.apache.org/jira/browse/HIVE-23916
> Project: Hive
>  Issue Type: Task
>Reporter: Pravin Sinha
>Assignee: Pravin Sinha
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-23916.01.patch, HIVE-23916.02.patch, 
> HIVE-23916.03.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-23962) Make bin/hive pick user defined jdbc url

2020-10-11 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23962?focusedWorklogId=499126=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-499126
 ]

ASF GitHub Bot logged work on HIVE-23962:
-

Author: ASF GitHub Bot
Created on: 12/Oct/20 00:55
Start Date: 12/Oct/20 00:55
Worklog Time Spent: 10m 
  Work Description: github-actions[bot] commented on pull request #1344:
URL: https://github.com/apache/hive/pull/1344#issuecomment-706799967


   This pull request has been automatically marked as stale because it has not 
had recent activity. It will be closed if no further activity occurs.
   Feel free to reach out on the d...@hive.apache.org list if the patch is in 
need of reviews.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 499126)
Time Spent: 0.5h  (was: 20m)

> Make bin/hive pick user defined jdbc url 
> -
>
> Key: HIVE-23962
> URL: https://issues.apache.org/jira/browse/HIVE-23962
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2
>Affects Versions: 4.0.0
>Reporter: Xiaomeng Zhang
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently hive command will trigger bin/hive which run "beeline" by default.
> We want to pass a env variable so that user can define which url beeline use.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-22415) Upgrade to Java 11

2020-10-11 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-22415?focusedWorklogId=499131=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-499131
 ]

ASF GitHub Bot logged work on HIVE-22415:
-

Author: ASF GitHub Bot
Created on: 12/Oct/20 00:55
Start Date: 12/Oct/20 00:55
Worklog Time Spent: 10m 
  Work Description: github-actions[bot] closed pull request #1241:
URL: https://github.com/apache/hive/pull/1241


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 499131)
Time Spent: 3h  (was: 2h 50m)

> Upgrade to Java 11
> --
>
> Key: HIVE-22415
> URL: https://issues.apache.org/jira/browse/HIVE-22415
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Critical
>  Labels: pull-request-available
>  Time Spent: 3h
>  Remaining Estimate: 0h
>
> Upgrade Hive to Java JDK 11



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-23998) Upgrave Guava to 27 for Hive 2.3

2020-10-11 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23998?focusedWorklogId=499128=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-499128
 ]

ASF GitHub Bot logged work on HIVE-23998:
-

Author: ASF GitHub Bot
Created on: 12/Oct/20 00:55
Start Date: 12/Oct/20 00:55
Worklog Time Spent: 10m 
  Work Description: github-actions[bot] commented on pull request #1394:
URL: https://github.com/apache/hive/pull/1394#issuecomment-706799941


   This pull request has been automatically marked as stale because it has not 
had recent activity. It will be closed if no further activity occurs.
   Feel free to reach out on the d...@hive.apache.org list if the patch is in 
need of reviews.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 499128)
Time Spent: 7.5h  (was: 7h 20m)

> Upgrave Guava to 27 for Hive 2.3
> 
>
> Key: HIVE-23998
> URL: https://issues.apache.org/jira/browse/HIVE-23998
> Project: Hive
>  Issue Type: Improvement
>Affects Versions: 2.3.7
>Reporter: L. C. Hsieh
>Assignee: L. C. Hsieh
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-23998.01.branch-2.3.patch
>
>  Time Spent: 7.5h
>  Remaining Estimate: 0h
>
> Try to upgrade Guava to 27.0-jre for Hive 2.3 branch.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-24231) Enhance shared work optimizer to merge scans with filters on both sides

2020-10-11 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-24231?focusedWorklogId=499095=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-499095
 ]

ASF GitHub Bot logged work on HIVE-24231:
-

Author: ASF GitHub Bot
Created on: 11/Oct/20 19:01
Start Date: 11/Oct/20 19:01
Worklog Time Spent: 10m 
  Work Description: jcamachor commented on a change in pull request #1553:
URL: https://github.com/apache/hive/pull/1553#discussion_r502816547



##
File path: Jenkinsfile
##
@@ -174,6 +174,17 @@ def loadWS() {
 tar -xf archive.tar'''
 }
 
+def saveFile(name) {

Review comment:
   It seems this is unrelated to this patch? It may be better to split into 
multiple JIRAs/PRs.

##
File path: pom.xml
##
@@ -104,7 +104,7 @@
 2.17
 1.12
 2.10
-3.0.0-M4
+3.0.0-M5

Review comment:
   Same as above, not sure if it would belong exactly to same PR, but it 
would be better to have different JIRAs/PRs for this different issues.

##
File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java
##
@@ -386,125 +456,81 @@ public boolean sharedWorkOptimization(ParseContext pctx, 
SharedWorkOptimizerCach
   LOG.debug("Merging subtree starting at {} into subtree starting 
at {}",
   discardableTsOp, retainableTsOp);
 } else {
-  ExprNodeDesc newRetainableTsFilterExpr = null;
-  List semijoinExprNodes = new ArrayList<>();
-  if (retainableTsOp.getConf().getFilterExpr() != null) {
-// Gather SJ expressions and normal expressions
-List allExprNodesExceptSemijoin = new 
ArrayList<>();
-splitExpressions(retainableTsOp.getConf().getFilterExpr(),
-allExprNodesExceptSemijoin, semijoinExprNodes);
-// Create new expressions
-if (allExprNodesExceptSemijoin.size() > 1) {
-  newRetainableTsFilterExpr = 
ExprNodeGenericFuncDesc.newInstance(
-  new GenericUDFOPAnd(), allExprNodesExceptSemijoin);
-} else if (allExprNodesExceptSemijoin.size() > 0 &&
-allExprNodesExceptSemijoin.get(0) instanceof 
ExprNodeGenericFuncDesc) {
-  newRetainableTsFilterExpr = 
allExprNodesExceptSemijoin.get(0);
-}
-// Push filter on top of children for retainable
-pushFilterToTopOfTableScan(optimizerCache, retainableTsOp);
+
+  if (sr.discardableOps.size() > 1) {
+throw new RuntimeException("we can't discard more in this 
path");

Review comment:
   Can you leave a comment explaining how we could hit this error? What 
should have happened? Somehow we have something in retainable/discardable that 
should be equivalent but it is not?

##
File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java
##
@@ -338,8 +385,29 @@ public boolean sharedWorkOptimization(ParseContext pctx, 
SharedWorkOptimizerCach
   // about the part of the tree that can be merged. We need to 
regenerate the
   // cache because semijoin operators have been removed
   sr = extractSharedOptimizationInfoForRoot(
-  pctx, optimizerCache, retainableTsOp, discardableTsOp);
-} else {
+  pctx, optimizerCache, retainableTsOp, discardableTsOp, true);
+} else if (mode == Mode.DPPUnion) {
+  boolean mergeable = areMergeable(pctx, retainableTsOp, 
discardableTsOp);
+  if (!mergeable) {
+LOG.debug("{} and {} cannot be merged", retainableTsOp, 
discardableTsOp);
+continue;
+  }
+  boolean validMerge =
+  areMergeableDppUninon(pctx, optimizerCache, retainableTsOp, 
discardableTsOp);

Review comment:
   typo -> areMergeableDppUninon

##
File path: ql/src/test/results/clientpositive/llap/join_parse.q.out
##
@@ -499,34 +499,41 @@ STAGE PLANS:
 sort order: +
 Map-reduce partition columns: _col0 (type: string)
 Statistics: Num rows: 500 Data size: 43500 Basic 
stats: COMPLETE Column stats: COMPLETE
+  Filter Operator
+predicate: (value is not null and key is not null) (type: 
boolean)
+Statistics: Num rows: 500 Data size: 89000 Basic stats: 
COMPLETE Column stats: COMPLETE
+Select Operator
+  expressions: key (type: string), value (type: string)
+  outputColumnNames: _col0, _col1
+  Statistics: Num rows: 500 Data size: 89000 Basic stats: 
COMPLETE Column stats: COMPLETE
   Reduce Output Operator

[jira] [Work logged] (HIVE-23695) [CachedStore] Add check/default constraints in CachedStore

2020-10-11 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23695?focusedWorklogId=499072=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-499072
 ]

ASF GitHub Bot logged work on HIVE-23695:
-

Author: ASF GitHub Bot
Created on: 11/Oct/20 15:39
Start Date: 11/Oct/20 15:39
Worklog Time Spent: 10m 
  Work Description: ashish-kumar-sharma commented on a change in pull 
request #1527:
URL: https://github.com/apache/hive/pull/1527#discussion_r502931524



##
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/TableCacheObjects.java
##
@@ -3,6 +3,9 @@
 import org.apache.hadoop.hive.metastore.api.AggrStats;
 import org.apache.hadoop.hive.metastore.api.ColumnStatistics;
 import org.apache.hadoop.hive.metastore.api.Partition;
+import org.apache.hadoop.hive.metastore.api.SQLAllTableConstraints;
+import org.apache.hadoop.hive.metastore.api.SQLCheckConstraint;
+import org.apache.hadoop.hive.metastore.api.SQLDefaultConstraint;

Review comment:
   removed





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 499072)
Time Spent: 40m  (was: 0.5h)

> [CachedStore] Add check/default constraints in CachedStore
> --
>
> Key: HIVE-23695
> URL: https://issues.apache.org/jira/browse/HIVE-23695
> Project: Hive
>  Issue Type: Sub-task
>  Components: Standalone Metastore
>Reporter: Adesh Kumar Rao
>Assignee: Ashish Sharma
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> This is blocked by HIVE-23618 (notification events are not generated for 
> default/unique constraints, hence created a separate sub-task from 
> HIVE-22015).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-24257) Wrong check constraint naming in Hive metastore

2020-10-11 Thread Ashish Sharma (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-24257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Sharma updated HIVE-24257:
-
Component/s: Standalone Metastore

> Wrong check constraint naming in Hive metastore
> ---
>
> Key: HIVE-24257
> URL: https://issues.apache.org/jira/browse/HIVE-24257
> Project: Hive
>  Issue Type: Bug
>  Components: Standalone Metastore
>Reporter: Ashish Sharma
>Assignee: Ashish Sharma
>Priority: Trivial
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Current 
> struct SQLCheckConstraint {
>   1: string catName, // catalog name
>   2: string table_db,// table schema
>   3: string table_name,  // table name
>   4: string column_name, // column name
>   5: string check_expression,// check expression
>   6: string dc_name, // default name
>   7: bool enable_cstr,   // Enable/Disable
>   8: bool validate_cstr, // Validate/No validate
>   9: bool rely_cstr  // Rely/No Rely
> }
> Naming for CheckConstraint is wrong it should be cc_name instead of dc_name



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-23695) [CachedStore] Add check/default constraints in CachedStore

2020-10-11 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23695?focusedWorklogId=499067=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-499067
 ]

ASF GitHub Bot logged work on HIVE-23695:
-

Author: ASF GitHub Bot
Created on: 11/Oct/20 11:09
Start Date: 11/Oct/20 11:09
Worklog Time Spent: 10m 
  Work Description: adesh-rao commented on a change in pull request #1527:
URL: https://github.com/apache/hive/pull/1527#discussion_r502898228



##
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/TableCacheObjects.java
##
@@ -3,6 +3,9 @@
 import org.apache.hadoop.hive.metastore.api.AggrStats;
 import org.apache.hadoop.hive.metastore.api.ColumnStatistics;
 import org.apache.hadoop.hive.metastore.api.Partition;
+import org.apache.hadoop.hive.metastore.api.SQLAllTableConstraints;
+import org.apache.hadoop.hive.metastore.api.SQLCheckConstraint;
+import org.apache.hadoop.hive.metastore.api.SQLDefaultConstraint;

Review comment:
   not required?

##
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/TableCacheObjects.java
##
@@ -3,6 +3,9 @@
 import org.apache.hadoop.hive.metastore.api.AggrStats;
 import org.apache.hadoop.hive.metastore.api.ColumnStatistics;
 import org.apache.hadoop.hive.metastore.api.Partition;
+import org.apache.hadoop.hive.metastore.api.SQLAllTableConstraints;
+import org.apache.hadoop.hive.metastore.api.SQLCheckConstraint;

Review comment:
   not required?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 499067)
Time Spent: 0.5h  (was: 20m)

> [CachedStore] Add check/default constraints in CachedStore
> --
>
> Key: HIVE-23695
> URL: https://issues.apache.org/jira/browse/HIVE-23695
> Project: Hive
>  Issue Type: Sub-task
>  Components: Standalone Metastore
>Reporter: Adesh Kumar Rao
>Assignee: Ashish Sharma
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> This is blocked by HIVE-23618 (notification events are not generated for 
> default/unique constraints, hence created a separate sub-task from 
> HIVE-22015).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-24257) Wrong check constraint naming in Hive metastore

2020-10-11 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-24257?focusedWorklogId=499051=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-499051
 ]

ASF GitHub Bot logged work on HIVE-24257:
-

Author: ASF GitHub Bot
Created on: 11/Oct/20 08:17
Start Date: 11/Oct/20 08:17
Worklog Time Spent: 10m 
  Work Description: ashish-kumar-sharma opened a new pull request #1570:
URL: https://github.com/apache/hive/pull/1570


   
   
   ### What changes were proposed in this pull request?
   
   Check constraint name is "dc_name //default value" instread it should be 
"cc_name // check constraint name"
   
   ### Why are the changes needed?
   
   because default value doesn't exist in check constraint
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   No
   ### How was this patch tested?
   
   Already existing test case edited cause it is just the name change.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 499051)
Remaining Estimate: 0h
Time Spent: 10m

> Wrong check constraint naming in Hive metastore
> ---
>
> Key: HIVE-24257
> URL: https://issues.apache.org/jira/browse/HIVE-24257
> Project: Hive
>  Issue Type: Bug
>Reporter: Ashish Sharma
>Assignee: Ashish Sharma
>Priority: Trivial
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Current 
> struct SQLCheckConstraint {
>   1: string catName, // catalog name
>   2: string table_db,// table schema
>   3: string table_name,  // table name
>   4: string column_name, // column name
>   5: string check_expression,// check expression
>   6: string dc_name, // default name
>   7: bool enable_cstr,   // Enable/Disable
>   8: bool validate_cstr, // Validate/No validate
>   9: bool rely_cstr  // Rely/No Rely
> }
> Naming for CheckConstraint is wrong it should be cc_name instead of dc_name



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-24257) Wrong check constraint naming in Hive metastore

2020-10-11 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-24257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated HIVE-24257:
--
Labels: pull-request-available  (was: )

> Wrong check constraint naming in Hive metastore
> ---
>
> Key: HIVE-24257
> URL: https://issues.apache.org/jira/browse/HIVE-24257
> Project: Hive
>  Issue Type: Bug
>Reporter: Ashish Sharma
>Assignee: Ashish Sharma
>Priority: Trivial
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Current 
> struct SQLCheckConstraint {
>   1: string catName, // catalog name
>   2: string table_db,// table schema
>   3: string table_name,  // table name
>   4: string column_name, // column name
>   5: string check_expression,// check expression
>   6: string dc_name, // default name
>   7: bool enable_cstr,   // Enable/Disable
>   8: bool validate_cstr, // Validate/No validate
>   9: bool rely_cstr  // Rely/No Rely
> }
> Naming for CheckConstraint is wrong it should be cc_name instead of dc_name



--
This message was sent by Atlassian Jira
(v8.3.4#803005)